[Lldb-commits] [PATCH] D17750: arm ios doesn't have elf.h, sys/procfs.h, need to avoid including them on apple systems

jasonmolenda created this revision. jasonmolenda added reviewers: tberghammer, omjavaid. jasonmolenda added a subscriber: lldb-commits. jasonmolenda set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. I'm getting lldb to build for ios again and had build

Re: [Lldb-commits] [PATCH] D17597: [LLDB][MIPS] Fix TestDisassembleBreakpoint

jaydeep accepted this revision. jaydeep added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D17597 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

zturner updated this revision to Diff 49442. zturner added a comment. Note this should compile now on every platform. Look over the unit tests to see my assumptions about how the API should work. Hopefully this makes reviewing things easier (it definitely made getting things to work easier)

Re: [Lldb-commits] [PATCH] D17745: Fix bug with function resolution when using IR Interpreter

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. Aside from one minor object ownership issue this is good to go. Change the `IRExecutionUnitSP` to an `IRExecutionUnit&` and you have my blessing! Comment at:

[Lldb-commits] [PATCH] D17745: Fix bug with function resolution when using IR Interpreter

ted created this revision. ted added a reviewer: spyffe. ted added a subscriber: lldb-commits. Recent changes to the expression parser broke function name resolution when using the IR interpreter instead of JIT. This patch changes the IRMemoryMap ivar in InterpreterStackFrame to an

[Lldb-commits] [lldb] r262281 - Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target/Process.cpp; other minor fixes.

Author: eugenezelenko Date: Mon Feb 29 18:55:51 2016 New Revision: 262281 URL: http://llvm.org/viewvc/llvm-project?rev=262281=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target/Process.cpp; other minor fixes. Modified: lldb/trunk/source/Target/Process.cpp

[Lldb-commits] [lldb] r262271 - When 'help' cannot find a command, produce additional help text that also points the user to the apropos and type lookup commands

Author: enrico Date: Mon Feb 29 17:22:53 2016 New Revision: 262271 URL: http://llvm.org/viewvc/llvm-project?rev=262271=rev Log: When 'help' cannot find a command, produce additional help text that also points the user to the apropos and type lookup commands This is useful in cases such as, e.g.

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

I think I see the problem. Somewhere I was calling SymbolVendor::FindPlugin(module) instead of module->GetSymbolVendor() On Mon, Feb 29, 2016 at 2:48 PM Greg Clayton wrote: > You shouldn't have to do any of this. There should be a 1 to 1 mapping > between a Module and a

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

You shouldn't have to do any of this. There should be a 1 to 1 mapping between a Module and a SymbolVendor which has a single SymbolFile. My guess is that you should just return: kAllAbilities for SymbolFilePDB::CalculateAbilities (). Try that and let me know how this goes. These abilities

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

I guess I could make the CreateInstance() method of SymbolFilePDB do some "smarts" to cache instances of SymbolFilePDB already created, and either return those or create a new one depending on whether we've loaded an instance for the requested executable or not. On Mon, Feb 29, 2016 at 1:26 PM

[Lldb-commits] [lldb] r262260 - Fix a typo in my previous commit. This would cause mutable NSArrays to show up empty

Author: enrico Date: Mon Feb 29 15:41:19 2016 New Revision: 262260 URL: http://llvm.org/viewvc/llvm-project?rev=262260=rev Log: Fix a typo in my previous commit. This would cause mutable NSArrays to show up empty Modified: lldb/trunk/source/Plugins/Language/ObjC/NSArray.cpp Modified:

[Lldb-commits] [lldb] r262259 - Change the user-visible name for the argument type language to source-language

Author: enrico Date: Mon Feb 29 15:37:01 2016 New Revision: 262259 URL: http://llvm.org/viewvc/llvm-project?rev=262259=rev Log: Change the user-visible name for the argument type language to source-language This makes it so that help language provides help on the language command and help

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

I'm running into what I think is the final issue. My SymbolFilePDB plugin creates created many many times. Specifically, every single call to SymbolVendor::FindPlugin(module) will cause a brand new instance of SymbolFilePDB to get created. This effectively kills any caching I've got going on,

[Lldb-commits] [lldb] r262256 - NFC: Refactor ProcessWinMiniDump to use a more traditional pimpl idiom.

Author: amccarth Date: Mon Feb 29 15:15:23 2016 New Revision: 262256 URL: http://llvm.org/viewvc/llvm-project?rev=262256=rev Log: NFC: Refactor ProcessWinMiniDump to use a more traditional pimpl idiom. This is a mechanical refactor. There should be no functional changes in this commit.

Re: [Lldb-commits] [PATCH] D17650: Fix TestInlines.py on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL262255: Fix TestInlines.py on Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D17650?vs=49208=49409#toc Repository: rL LLVM http://reviews.llvm.org/D17650 Files:

[Lldb-commits] [lldb] r262255 - Fix TestInlines.py on Windows

Author: amccarth Date: Mon Feb 29 15:13:29 2016 New Revision: 262255 URL: http://llvm.org/viewvc/llvm-project?rev=262255=rev Log: Fix TestInlines.py on Windows The inlining semantics for C and C++ are different, which affects the test's expectation of the number of times the function should

[Lldb-commits] [lldb] r262254 - Add an LLDB data formatter for single-element NSArray and NSDictionary Cocoa containers

Author: enrico Date: Mon Feb 29 15:06:50 2016 New Revision: 262254 URL: http://llvm.org/viewvc/llvm-project?rev=262254=rev Log: Add an LLDB data formatter for single-element NSArray and NSDictionary Cocoa containers Fixes rdar://23715118 Modified:

[Lldb-commits] [lldb] r262246 - Fix Clang-tidy modernize-use-nullptr warnings in source/Plugins/Language; other minor fixes.

Author: eugenezelenko Date: Mon Feb 29 13:41:30 2016 New Revision: 262246 URL: http://llvm.org/viewvc/llvm-project?rev=262246=rev Log: Fix Clang-tidy modernize-use-nullptr warnings in source/Plugins/Language; other minor fixes. Modified:

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

The straightforward way to do specify a complex command line for debugging is: lldb —arch=x86_64 — /bin/ls -IAF everything after the — are arguments to the program. This also allows you to cut & paste whole command lines. It works by the trick that if you haven’t specified a file before the

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

clayborg added a comment. In http://reviews.llvm.org/D17724#364454, @zturner wrote: > long and short options are supported, but the one I'm not sure about is the > case where you use a short option with no space. Your example "-ax86_64" > might not work. It might, just that it should be

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

long and short options are supported, but the one I'm not sure about is the case where you use a short option with no space. Your example "-ax86_64" might not work. It might, just that it should be tested. I'm 99% confident the rest of them all work. Also not sure about this example: "% lldb

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

clayborg added a comment. As long as both long and short options are still supported? Can you still type any of: - --arch=x86_64 - --arch x86_64 - -arch=x86_64 - -arch x86_64 - -ax86_64 - -a x86_64 Are we able to track which options can be used with other options with the llvm solution? I

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

Thanks! I think I've got a handle on it. I'll upload another patch this week hopefully. On Mon, Feb 29, 2016 at 10:30 AM Greg Clayton wrote: > > > On Feb 26, 2016, at 3:33 PM, Zachary Turner wrote: > > > > Ok, so back to check_inlines. I realized

Re: [Lldb-commits] [PATCH] D17710: Simplify GetGlobalProperties functions of Thread/Process/Target

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good to me, commit when you know this will work with MSVC versions you need. All other platforms will be good to go. http://reviews.llvm.org/D17710

Re: [Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I will let Sean review this one as the expression parser is his area of expertise. http://reviews.llvm.org/D17719 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.

> On Feb 26, 2016, at 3:33 PM, Zachary Turner wrote: > > Ok, so back to check_inlines. I realized after I hit send that the > explanation I had written out is exactly what I thought I had to do for > check_inlines == true. > > I guess a concrete example would make it

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

I think the issue is that on OS X, GetScalarValue fails to return false when the value is *not* actually scalar. When it's not scalar, it should be using WriteMemory instead, right? Or is it possible for GetScalarValue to succeed but return something with a different byte size? On Mon, Feb 29,

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

labath added a comment. Yes, we are, and unfortunately we can't get rid of it that easily there, as llvm:cl does not really have interactive uses in mind (global variables everywhere, --help kills your program, etc.). It probably wouldn't be **too** hard to add a version which can do that, as

Re: [Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

Love this change in principle. I will look over it on the windows side to make sure nothing breaks. One question: we are using getopt still for parsing interactive command lines right? On Mon, Feb 29, 2016 at 9:26 AM Pavel Labath wrote: > labath created this revision. >

[Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver

labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. This replaces the hand-rolled getopt option parser in lldb driver with the one in llvm. This results in a lot less code, as the llvm's parser does much of the work (e.g., formatting

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

Sorry about the breakage, and thanks for working on a patch Chaoren. Hopefully Marianne will revise her merge request if this fix is still important for her. On 28/02/2016 00:06, Todd Fiala wrote: I brought the state of the lines changed there to what they were prior to the change. If you

Re: [Lldb-commits] [PATCH] D17710: Simplify GetGlobalProperties functions of Thread/Process/Target

labath added a comment. I suspected something like that might be up. Thanks. The VS2015 migration for us is taking longer than expected, but we are now nearing the end, hopefully. If there are no objections, I'll land this after we are done. http://reviews.llvm.org/D17710

[Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

ldrumm created this revision. ldrumm added reviewers: clayborg, spyffe. ldrumm added a subscriber: lldb-commits. The current expression language is currently tracked in a few places within the `ClangExpressionParser` constructor. This patch adds a private `lldb::LanguageType` attribute to the

[Lldb-commits] [lldb] r262223 - Revert a part of "Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI."

Author: labath Date: Mon Feb 29 08:26:45 2016 New Revision: 262223 URL: http://llvm.org/viewvc/llvm-project?rev=262223=rev Log: Revert a part of "Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI." This partially reverts commit r262218. The commit added

Re: [Lldb-commits] [PATCH] D17716: Add complex and aggregate with vector types return value test cases

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good but please verify that the new test is passes on other architectures and XFAIL the test accordingly. If you have to XFAIL something then I would prefer to split this test

[Lldb-commits] [PATCH] D17716: Add complex and aggregate with vector types return value test cases

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. This patch adds tests to test complex return types and aggregate return types with vector elements. http://reviews.llvm.org/D17716 Files:

Re: [Lldb-commits] [PATCH] D17708: Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262218: Add/Improve complex, vector, aggregate types handling for SysV ARM… (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D17708?vs=49353=49364#toc Repository: rL LLVM

[Lldb-commits] [lldb] r262218 - Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI.

Author: omjavaid Date: Mon Feb 29 07:39:20 2016 New Revision: 262218 URL: http://llvm.org/viewvc/llvm-project?rev=262218=rev Log: Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI. For details see: Differential revision: http://reviews.llvm.org/D17708

Re: [Lldb-commits] [PATCH] D17708: Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI.

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good (it would be nice if we can split GetReturnValueObjectImpl to multiple function as it starts to become pretty big and hard to read but I don't think we shouldn't do it as

[Lldb-commits] [lldb] r262214 - Fix compiler warnings in the java code

Author: labath Date: Mon Feb 29 05:44:15 2016 New Revision: 262214 URL: http://llvm.org/viewvc/llvm-project?rev=262214=rev Log: Fix compiler warnings in the java code Modified: lldb/trunk/source/Plugins/Language/Java/JavaLanguage.h lldb/trunk/source/Symbol/JavaASTContext.cpp Modified:

[Lldb-commits] [PATCH] D17710: Simplify GetGlobalProperties functions of Thread/Process/Target

labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. "Initialization of function-local statics is guaranteed to occur only once even when called from multiple threads, and may be more efficient than the equivalent code using

[Lldb-commits] [PATCH] D17708: Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI.

omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds code to SysV ARM ABI for handling complex and aggregates containing complex return types. It also improves support for