Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: labath, zturner, nitesh.jain.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This patch include two fixes:
* include CheckAtomic to set
Author: gclayton
Date: Wed Jul 13 17:38:54 2016
New Revision: 275336
URL: http://llvm.org/viewvc/llvm-project?rev=275336=rev
Log:
Added test for setting breakpoints by basename and fullname.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespace.py
clayborg added a comment.
In http://reviews.llvm.org/D22294#483311, @sas wrote:
> In http://reviews.llvm.org/D22294#483264, @clayborg wrote:
>
> > Note that during function lookup, we can find **both** "putchar" and
> > "__my_putchar" in the debug info, so you will be able to call both.
>
>
>
k8stone removed rL LLVM as the repository for this revision.
k8stone updated this revision to Diff 63867.
k8stone added a comment.
clang-format applied. Greg's recommendation to document the multi-line editing
behavior in help make sense, but should land after the major help rework in
jingham added a comment.
We always resolve duplicate symbols to the "closest" one to the current frame.
So if there are two versions of putchar and one is in the library containing
the current frame, we should find that one. If we aren't getting that right,
that's a bug. So the correct
We always resolve duplicate symbols to the "closest" one to the current frame.
So if there are two versions of putchar and one is in the library containing
the current frame, we should find that one. If we aren't getting that right,
that's a bug. So the correct symbol should get called in
sas added a comment.
In http://reviews.llvm.org/D22294#483264, @clayborg wrote:
> Note that during function lookup, we can find **both** "putchar" and
> "__my_putchar" in the debug info, so you will be able to call both.
Correct, unless as you pointed out both symbols are in libraries, and
clayborg added a comment.
Note that during function lookup, we can find **both** "putchar" and
"__my_putchar" in the debug info, so you will be able to call both.
http://reviews.llvm.org/D22294
___
lldb-commits mailing list
clayborg added a comment.
> I think some understanding of the rewrites from the debugger is still
> required because the user will still enter commands like `call putchar('a')`
> and expect the `putchar()` they wrote to be called. That `putchar()` they
> expect is now called `_my_putchar()`
sas added a comment.
In http://reviews.llvm.org/D22294#483250, @clayborg wrote:
> In http://reviews.llvm.org/D22294#483213, @sas wrote:
>
> > @jingham, @clayborg, this is indeed a bit fragile as having to specify your
> > rewrite maps manually when debugging is very error-prone. I have a patch
clayborg added a comment.
In http://reviews.llvm.org/D22294#483213, @sas wrote:
> @jingham, @clayborg, this is indeed a bit fragile as having to specify your
> rewrite maps manually when debugging is very error-prone. I have a patch that
> fetches the path to the rewrite map from the debug
fjricci added a comment.
@clayborg: As you saw when running the test with debug info enabled, we might
end up calling the non-rewritten `putchar()`, which is due to the compiler
emitting debug symbols with the non-rewritten name. The `-g0` option is just a
workaround until we can fix that.
I
granata.enrico added inline comments.
Comment at: source/Commands/CommandObjectCommands.cpp:2272
@@ -2271,3 +2271,3 @@
"command script",
-"A set of commands for managing or customizing
script commands.",
+
sas added a comment.
@jingham, @clayborg, this is indeed a bit fragile as having to specify your
rewrite maps manually when debugging is very error-prone. I have a patch that
fetches the path to the rewrite map from the debug info, I'm waiting for this
one to go in to upload that other diff
clayborg added a comment.
Adrian Prantl suggested that we modify clang to update the debug info for the
function. In the test case that was attached, the DWARF currently has a
"putchar" function which should get a linkage name attached to it with
"__my_putchar". Then the debug info can be
jingham added a subscriber: jingham.
jingham added a comment.
This approach seems fragile to me. I'm supposed to remember that some build
system set some rewriter file that I then have to supply manually to get the
view of symbols to match reality? We really try to avoid having to write notes
clayborg added a comment.
Adding a feature to the debugger that doesn't work with debug info seems like a
bad idea.
http://reviews.llvm.org/D22294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
If you can't get this right when debug info is present then I would rather not
have this patch. We enabled debug info on your test and it will call the
putchar() in the current
Author: sas
Date: Wed Jul 13 12:34:26 2016
New Revision: 275287
URL: http://llvm.org/viewvc/llvm-project?rev=275287=rev
Log:
Fix a check in the objc trampoline handler
Summary:
The function FunctionCaller::WriteFunctionArguments returns false on
errors, so they should check for the false return
Author: gclayton
Date: Wed Jul 13 12:25:55 2016
New Revision: 275285
URL: http://llvm.org/viewvc/llvm-project?rev=275285=rev
Log:
Remove comment that isn't needed anymore.
Modified:
lldb/trunk/include/lldb/Core/Module.h
Modified: lldb/trunk/include/lldb/Core/Module.h
URL:
Author: gclayton
Date: Wed Jul 13 12:12:24 2016
New Revision: 275281
URL: http://llvm.org/viewvc/llvm-project?rev=275281=rev
Log:
Centralize the way symbol and functions are looked up by making a
Module::LookupInfo class that does all of the heavy lifting.
Background: symbols and functions can
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D22286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
fjricci updated this revision to Diff 63816.
fjricci marked an inline comment as done.
fjricci added a comment.
Fix const SP and update unit test
Will now only run the unit test as a dwarf test (with -g0),
but since we don't want to test the debug data anyway,
this shouldn't be an issue, and
fjricci marked 3 inline comments as done.
Comment at:
packages/Python/lldbsuite/test/lang/c/symbol_rewriter/TestSymbolRewriter.py:28
@@ +27,3 @@
+# Clang does not rewrite dwarf debug info, so it must be stripped
+subprocess.check_call(['strip', '-g', exe])
+
ki.stfu added a comment.
Hi Chuck! Sorry for delay, didn't see this CL. I'll check it tomorrow, so pls
wait one more day.
Repository:
rL LLVM
http://reviews.llvm.org/D21757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath added a comment.
In http://reviews.llvm.org/D22266#482626, @jasonmolenda wrote:
> This is fine - is there a binary using this? I'd love to see the assembly
> code and a dump of the eh_frame CFI.
>
> I googled around and didn't find much about DW_CFA_GNU_args_size but in the
> libunwind
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275260: Add "support" for DW_CFA_GNU_args_size to the
unwinder (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D22266?vs=63678=63792#toc
Repository:
rL LLVM
Author: labath
Date: Wed Jul 13 05:55:24 2016
New Revision: 275260
URL: http://llvm.org/viewvc/llvm-project?rev=275260=rev
Log:
Add "support" for DW_CFA_GNU_args_size to the unwinder
Summary:
This adds the knowledge of the DW_CFA_GNU_args_size instruction to the eh_frame
parsing code.
Right now
labath added a subscriber: labath.
labath added a comment.
Mostly just comments about the test from me.
Comment at: include/lldb/Core/Module.h:240
@@ -239,2 +239,3 @@
FindFirstSymbolWithNameAndType (const ConstString ,
+const
labath added a comment.
looks good as far as I can tell
I second the idea of running clang-format over the patch.
Repository:
rL LLVM
http://reviews.llvm.org/D22284
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath added a comment.
lgtm
http://reviews.llvm.org/D22286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
This is fine - is there a binary using this? I'd love to see the assembly code
and a dump of the eh_frame CFI.
I googled around and didn't find much about DW_CFA_GNU_args_size
32 matches
Mail list logo
