Re: [Lldb-commits] [PATCH] D22284: [LLDB] Proposed change in multi-line edit behavior (Return = end/append, Meta+Return = line break)

2016-07-14 Thread Kate Stone via lldb-commits
k8stone added a comment. Fair enough! I was planning to close both out tomorrow after getting Jim to approve the other patch. https://reviews.llvm.org/D22284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D22284: [LLDB] Proposed change in multi-line edit behavior (Return = end/append, Meta+Return = line break)

2016-07-14 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko added a comment. Sorry, forgot to add "[revision] in commit summary". https://reviews.llvm.org/D22284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22284: [LLDB] Proposed change in multi-line edit behavior (Return = end/append, Meta+Return = line break)

2016-07-14 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r275482. Please mention URL of Differential revision to close it automatically after commit. https://reviews.llvm.org/D22284 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r275519 - Remember to add the testcase I wrote for r274822.

2016-07-14 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Jul 14 20:41:54 2016 New Revision: 275519 URL: http://llvm.org/viewvc/llvm-project?rev=275519=rev Log: Remember to add the testcase I wrote for r274822. Added: lldb/trunk/packages/Python/lldbsuite/test/expression_command/unwind_expression/

[Lldb-commits] [lldb] r275506 - adjust one of the NSLog output tests to only run on macOS 10.12+

2016-07-14 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Jul 14 19:51:26 2016 New Revision: 275506 URL: http://llvm.org/viewvc/llvm-project?rev=275506=rev Log: adjust one of the NSLog output tests to only run on macOS 10.12+ The LLDB NSLog handling when Xcode intends to suppress NSLog output only works on Fall 2016 OS

[Lldb-commits] [lldb] r275482 - Editing multi-line content in a terminal environment involves a lot of

2016-07-14 Thread Kate Stone via lldb-commits
Author: kate Date: Thu Jul 14 17:00:04 2016 New Revision: 275482 URL: http://llvm.org/viewvc/llvm-project?rev=275482=rev Log: Editing multi-line content in a terminal environment involves a lot of trade-offs. When LLDB's multi-line editing support was first introduced for expressions / REPL

[Lldb-commits] [lldb] r275472 - fix command-line LLDB so NSLog messages show up

2016-07-14 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Jul 14 16:02:45 2016 New Revision: 275472 URL: http://llvm.org/viewvc/llvm-project?rev=275472=rev Log: fix command-line LLDB so NSLog messages show up Changes to the underlying logging infrastructure in Fall 2016 Darwin OSes were no longer showing up NSLog messages in

[Lldb-commits] [lldb] r275459 - Add support for Objective-C class properties.

2016-07-14 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Thu Jul 14 14:31:18 2016 New Revision: 275459 URL: http://llvm.org/viewvc/llvm-project?rev=275459=rev Log: Add support for Objective-C class properties. Added test cases to exiting tests to cover the new functionality. Modified:

Re: [Lldb-commits] [PATCH] D22322: [LLDB] Fixes for standalone build

2016-07-14 Thread Eugene Zelenko via lldb-commits
Eugene.Zelenko updated this revision to Diff 64000. Eugene.Zelenko added a comment. Improved description, but in generic terms, since two files are needed. Repository: rL LLVM https://reviews.llvm.org/D22322 Files: cmake/modules/LLDBStandalone.cmake Index:

[Lldb-commits] [PATCH] D22369: DWARFDeclContext: Don't add '::' in front of symbol names

2016-07-14 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. I believe the symbol names more consistent. In case a symbol has DW_AT_linkage_name (e.g. clang puts it everywhere), we print the demangled linkage name, which does not contain the '::'. If

[Lldb-commits] [PATCH] D22357: [NPL] Simplify process launch code

2016-07-14 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: tberghammer. labath added a subscriber: lldb-commits. This removes one level of indirection, which was just packing and repacking launch args into different structures. NFC. https://reviews.llvm.org/D22357 Files:

Re: [Lldb-commits] [PATCH] D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes.

2016-07-14 Thread Howard Hellyer via lldb-commits
hhellyer added inline comments. Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338 @@ -315,4 +337,3 @@ // truncated. -error.SetErrorString("address is not in a known range"); return error; } Asking for an address outside

Re: [Lldb-commits] [PATCH] D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes.

2016-07-14 Thread Howard Hellyer via lldb-commits
hhellyer updated this revision to Diff 63975. hhellyer added a comment. .arcconfig has been updated. https://reviews.llvm.org/D22352 Files: source/Plugins/Process/Windows/Live/ProcessWindowsLive.cpp source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp Index:

Re: [Lldb-commits] [PATCH] D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes.

2016-07-14 Thread Adrian McCarthy via lldb-commits
amccarth added a subscriber: amccarth. Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338 @@ -315,4 +337,3 @@ // truncated. -error.SetErrorString("address is not in a known range"); return error; } I'm not clear why you

Re: [Lldb-commits] [PATCH] D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes.

2016-07-14 Thread Howard Hellyer via lldb-commits
hhellyer added a comment. Arcanist won't upload the patch without the change to .arcconfig yet because of http://lists.llvm.org/pipermail/llvm-dev/2016-July/102305.html but I think this will be patched officially shortly! It should disappear if I update the revision for any reason once that's

[Lldb-commits] [PATCH] D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes.

2016-07-14 Thread Howard Hellyer via lldb-commits
hhellyer created this revision. hhellyer added a reviewer: clayborg. hhellyer added a subscriber: lldb-commits. This patch fills in the implementation of GetMemoryRegions() on the Windows live process and minidump implementations of lldb_private::Process (ProcessWindowsLive::GetMemoryRegionInfo

[Lldb-commits] [lldb] r275409 - Upgrade all the .arcconfigs to https.

2016-07-14 Thread Benjamin Kramer via lldb-commits
Author: d0k Date: Thu Jul 14 08:15:37 2016 New Revision: 275409 URL: http://llvm.org/viewvc/llvm-project?rev=275409=rev Log: Upgrade all the .arcconfigs to https. Modified: lldb/trunk/.arcconfig Modified: lldb/trunk/.arcconfig URL:

Re: [Lldb-commits] [PATCH] D22322: [LLDB] Fixes for standalone build

2016-07-14 Thread Nitesh Jain via lldb-commits
nitesh.jain accepted this revision. nitesh.jain added a comment. LGTM. Thanks Repository: rL LLVM http://reviews.llvm.org/D22322 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D22322: [LLDB] Fixes for standalone build

2016-07-14 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm. Comment at: cmake/modules/LLDBStandalone.cmake:61 @@ -60,2 +60,3 @@ set(LLVM_MAIN_INCLUDE_DIR ${INCLUDE_DIR} CACHE PATH "Path to llvm/include") + set(LLVM_DIR

[Lldb-commits] [lldb] r275393 - [test] [linux] define PR_SET_PTRACER constants if the system does not provide them

2016-07-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jul 14 05:43:21 2016 New Revision: 275393 URL: http://llvm.org/viewvc/llvm-project?rev=275393=rev Log: [test] [linux] define PR_SET_PTRACER constants if the system does not provide them Android API <= 16 header do not have these symbols defined, but the kernel does

[Lldb-commits] [lldb] r275394 - mark newly failing tests as XFAIL

2016-07-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jul 14 05:43:24 2016 New Revision: 275394 URL: http://llvm.org/viewvc/llvm-project?rev=275394=rev Log: mark newly failing tests as XFAIL Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/step-avoids-no-debug/TestStepNoDebug.py

Re: [Lldb-commits] [PATCH] D21757: Fix lldb-mi disable/enable breakpoints commands

2016-07-14 Thread Ilia K via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL275381: Fix -break-enable/-break-disable commands (MI) (authored by ki.stfu). Changed prior to commit: http://reviews.llvm.org/D21757?vs=63928=63932#toc Repository: rL LLVM

[Lldb-commits] [lldb] r275381 - Fix -break-enable/-break-disable commands (MI)

2016-07-14 Thread Ilia K via lldb-commits
Author: ki.stfu Date: Thu Jul 14 02:43:14 2016 New Revision: 275381 URL: http://llvm.org/viewvc/llvm-project?rev=275381=rev Log: Fix -break-enable/-break-disable commands (MI) * Previously -break-enable mistakenly set BP's enabled flag to false. * These commands print fake =breakpoint-modified

Re: [Lldb-commits] [PATCH] D21757: Fix lldb-mi disable/enable breakpoints commands

2016-07-14 Thread Ilia K via lldb-commits
ki.stfu updated this revision to Diff 63928. ki.stfu added a comment. add checks for =breakpoint-modified http://reviews.llvm.org/D21757 Files: packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py tools/lldb-mi/MICmdCmdBreak.cpp Index: tools/lldb-mi/MICmdCmdBreak.cpp

Re: [Lldb-commits] [PATCH] D21757: Fix lldb-mi disable/enable breakpoints commands

2016-07-14 Thread Ilia K via lldb-commits
ki.stfu accepted this revision. ki.stfu added a comment. @faxue, thank you for your patch! The fixes look good, but if you don't mind I gonna improve your tests. After that I'll commit this patch. Repository: rL LLVM http://reviews.llvm.org/D21757