[Lldb-commits] [lldb] r281696 - add availability check to DarwinLog event tests

Author: tfiala Date: Thu Sep 15 22:07:14 2016 New Revision: 281696 URL: http://llvm.org/viewvc/llvm-project?rev=281696=rev Log: add availability check to DarwinLog event tests The pexpect-based tests properly checked for the stub reporting DarwinLog support. The event-based ones did not. This

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

One thing I wonder about. It seems like everyone is mostly on the same page about command line output . What about input? Would anyone have objections to a test which ran a few commands to get the debugger into a particular state before doing something to verify the output? Let's assume I'm

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

> On Sep 15, 2016, at 8:02 AM, Zachary Turner wrote: > > > It sounds like your goal is also "tests have to use the SB API and no other > API", which if so I think that's counterproductive. More productive, IMO, > would be being open to any alternative that addresses the

[Lldb-commits] [lldb] r281690 - First tests for serializing breakpoints.

Author: jingham Date: Thu Sep 15 20:41:27 2016 New Revision: 281690 URL: http://llvm.org/viewvc/llvm-project?rev=281690=rev Log: First tests for serializing breakpoints. Plus a few bug fixes I found along the way. Added:

[Lldb-commits] [lldb] r281661 - [cmake] Don't depend on lldb-server unless it's built.

Author: zturner Date: Thu Sep 15 16:32:51 2016 New Revision: 281661 URL: http://llvm.org/viewvc/llvm-project?rev=281661=rev Log: [cmake] Don't depend on lldb-server unless it's built. Modified: lldb/trunk/lit/CMakeLists.txt Modified: lldb/trunk/lit/CMakeLists.txt URL:

[Lldb-commits] [lldb] r281662 - Allow ArchSpec to take a StringRef.

Author: zturner Date: Thu Sep 15 16:32:57 2016 New Revision: 281662 URL: http://llvm.org/viewvc/llvm-project?rev=281662=rev Log: Allow ArchSpec to take a StringRef. Modified: lldb/trunk/include/lldb/Core/ArchSpec.h lldb/trunk/source/Core/ArchSpec.cpp

Re: [Lldb-commits] [PATCH] D24629: Allow for tests to be disabled at runtime

fjricci added a comment. The issue is that you can only commit a patch to xfail a test that fails when you run the test suite on master with no local changes. The problem is that if you run into test failures on other branches or in unconventional configurations, there is no good way to

Re: [Lldb-commits] [PATCH] D24629: Allow for tests to be disabled at runtime

zturner added a comment. If a set of tests is failing, wouldn't you just want to xfail them? https://reviews.llvm.org/D24629 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D24629: Allow for tests to be disabled at runtime

fjricci created this revision. fjricci added reviewers: zturner, labath, tfiala. fjricci added subscribers: lldb-commits, sas. The current implementation of the test suite allows the user to run a certain subset of tests using '-p', but does not allow the inverse, where a user wants to run all

[Lldb-commits] [lldb] r281652 - Fixing bot failures

Author: cbieneman Date: Thu Sep 15 15:23:31 2016 New Revision: 281652 URL: http://llvm.org/viewvc/llvm-project?rev=281652=rev Log: Fixing bot failures Need to only add debugserver as a test dependency on Darwin. Modified: lldb/trunk/lit/CMakeLists.txt Modified:

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

This revision was automatically updated to reflect the committed changes. Closed by commit rL281651: [LIT] First pass of LLDB LIT support (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D24591?vs=71537=71546#toc Repository: rL LLVM https://reviews.llvm.org/D24591

Re: [Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

clayborg requested changes to this revision. clayborg added a comment. Great fix. Just fix the testing so that it isn't ARM specific. There shouldn't be any: if self.getArchitecture() in ['arm']: do arm stuff else: do non arm stuff Also we will need to be able to test the set watch

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

beanz updated this revision to Diff 71537. beanz added a comment. - Removed the XFAIL for icc - Added support for LLDB_TEST__COMPILER options Assuming there are no objections, since the patch has been approved by two reviewers I'll commit it this afternoon. Thanks, -Chris

[Lldb-commits] [lldb] r281642 - Convert ArchSpec::ParseMachOCPUDashSubtypeTriple to use StringRef.

Author: zturner Date: Thu Sep 15 13:41:48 2016 New Revision: 281642 URL: http://llvm.org/viewvc/llvm-project?rev=281642=rev Log: Convert ArchSpec::ParseMachOCPUDashSubtypeTriple to use StringRef. This makes the code easier to grok, and since this is a very low level function it also is very

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

lldb-commits to bcc, lldb-dev to cc. > The biggest feature I see missing here is the ability to run tests remotely. Remote debugging is the most important use case for our team, and now we have a number of (experimental) bots running the remote test suite. We want to make sure we can debug

[Lldb-commits] [lldb] r281639 - added LLDB_PYTHON_TESTSUITE_ARCH Xcode variable

Author: tfiala Date: Thu Sep 15 13:28:03 2016 New Revision: 281639 URL: http://llvm.org/viewvc/llvm-project?rev=281639=rev Log: added LLDB_PYTHON_TESTSUITE_ARCH Xcode variable This Xcode build variable defaults to x86_64. It can be set to i386 to cause the lldb-python-test-suite target run the

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

clayborg added a comment. A few things about a the RegisterContext class in case it would change and thing that you are submitting here. The entire register context defines a buffer of bytes that can contain all register values. Each RegisterInfo contains the offset for the value of this

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain marked an inline comment as done. nitesh.jain added a comment. https://reviews.llvm.org/D24603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain updated this revision to Diff 71505. nitesh.jain added a comment. Updated diff as per suggestion. https://reviews.llvm.org/D24603 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.h Index:

Re: [Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I have some doubts about the validity of this patch. We should make sure those are cleared before putting this in. Comment at:

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1183 @@ +1182,3 @@ + case dwarf_config5_mips64: +return reg_info->byte_offset; + case dwarf_cause_mips: labath wrote: > Why do we need to do

[Lldb-commits] [lldb] r281606 - Reformat x86_64 register infos defines table

Author: dvlahovski Date: Thu Sep 15 07:58:27 2016 New Revision: 281606 URL: http://llvm.org/viewvc/llvm-project?rev=281606=rev Log: Reformat x86_64 register infos defines table Fix the table format of the register defines after clang-format. Added guards to prevent future reformatting again from

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

labath added a comment. Btw, I will be in the bay area from 3rd to 7th of October. Maybe we could sit down and talk the design and requirements through in person? I've been hoping to speak to some of you in person anyway, and this could be a good first topic on the agenda...

Re: [Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

labath added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1183 @@ +1182,3 @@ + case dwarf_config5_mips64: +return reg_info->byte_offset; + case dwarf_cause_mips: Why do we need to do this remapping?

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

labath added a comment. The biggest feature I see missing here is the ability to run tests remotely. Remote debugging is the most important use case for our team, and now we have a number of (experimental) bots running the remote test suite. We want to make sure we can debug correctly when the

[Lldb-commits] [lldb] r281601 - Fix TestSymbolContextTwoFiles on Android after rL281595

Author: tberghammer Date: Thu Sep 15 05:49:55 2016 New Revision: 281601 URL: http://llvm.org/viewvc/llvm-project?rev=281601=rev Log: Fix TestSymbolContextTwoFiles on Android after rL281595 Modified:

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath, jaydeep. nitesh.jain added subscribers: bhushan, slthakur, lldb-commits. Herald added a subscriber: sdardis. This patch add fix for reading and writing floating point register based on SR.FR bit.

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

nitesh.jain added a comment. Will submit separate patch for Floating point register read/write and ptrace changes. https://reviews.llvm.org/D24124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

nitesh.jain marked 2 inline comments as done. nitesh.jain added a comment. https://reviews.llvm.org/D24124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

nitesh.jain added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1940 @@ +1939,3 @@ + uint64_t dst_value; + RegisterValue reg_value; + lldb::ByteOrder byte_order = lldb::eByteOrderInvalid; The GetAsUint64

Re: [Lldb-commits] [PATCH] D24514: Add support for DW_AT_ranges_base attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL281595: Add support for DW_AT_ranges_base attribute (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D24514?vs=71316=71484#toc Repository: rL LLVM

[Lldb-commits] [lldb] r281595 - Add support for DW_AT_ranges_base attribute

Author: tberghammer Date: Thu Sep 15 03:53:33 2016 New Revision: 281595 URL: http://llvm.org/viewvc/llvm-project?rev=281595=rev Log: Add support for DW_AT_ranges_base attribute It is a new attribute emitted by clang as a GNU extension and will be part of Dwarf5. The purpose of the attribute is

[Lldb-commits] [lldb] r281594 - Try to fix windows build after rL281569

Author: tberghammer Date: Thu Sep 15 03:47:59 2016 New Revision: 281594 URL: http://llvm.org/viewvc/llvm-project?rev=281594=rev Log: Try to fix windows build after rL281569 Modified: lldb/trunk/include/lldb/Breakpoint/BreakpointOptions.h

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

nitesh.jain retitled this revision from "[LLDB][MIPS] Fix register read/write for big endian" to "[LLDB][MIPS] Fix register read/write for 32 bit big endian system". nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 71360.

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

If we want to add a testsuite runner which takes a source file, a place to put a breakpoint, the name of a variable to examine, and it runs through those in SB API, I'm all in favor. I don't know if that's going to add a lot of test coverage to lldb, but I have no problem with such a thing.