[Lldb-commits] [PATCH] D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127.

pablooliveira added a comment. > If you are fine with having lldb-server link against libLLVM in the > LLVM_LINK_LLVM_DYLIB case, I can make an lldb-only change that makes it work. > It won't affect our use case as we don't use that flag. @labath, I think that would be fine in the context of

[Lldb-commits] [lldb] r283186 - Finish adding the individual instruction tests to the x86 unwinder

Author: jmolenda Date: Tue Oct 4 00:10:06 2016 New Revision: 283186 URL: http://llvm.org/viewvc/llvm-project?rev=283186=rev Log: Finish adding the individual instruction tests to the x86 unwinder unittests. If I have time, I'd like to see if I can write some tests of the eh_frame augmentation

[Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

omjavaid added a comment. @labath Referring to your email on the mailing list. Thanks for helping out with this work. I think we should push this fix, as you suggested this does not fix everything in a holistic way but it corrects the functionality that is currently available right now with

[Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks correct to me. I had a couple of trivial inline comments, but this looks fine. > BreakpointID.cpp:80-81 > > -bool BreakpointID::ParseCanonicalReference(const char *input, >

[Lldb-commits] [lldb] r283176 - Fix TestNestedAliases.py

Author: zturner Date: Mon Oct 3 20:34:39 2016 New Revision: 283176 URL: http://llvm.org/viewvc/llvm-project?rev=283176=rev Log: Fix TestNestedAliases.py I missed an if/else branch when doing the conversion. Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp Modified:

[Lldb-commits] [PATCH] D24863: Keep dependencies separated between static and dynamic libraries. Fix for bug #28127.

labath added a comment. @pablooliveira @sylvestre.ledru : If you are fine with having lldb-server link against libLLVM in the LLVM_LINK_LLVM_DYLIB case, I can make an lldb-only change that makes it work. It won't affect our use case as we don't use that flag. Repository: rL LLVM

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

labath added inline comments. > dvlahovski wrote in TestMiniDumpNew.py:19 > But, should `test_deeper_stack_in_mini_dump` and > `test_local_variables_in_mini_dump` not have this decorator ? They are not building any code, so the would behave the same way anyway. You would be just running the

[Lldb-commits] [lldb] r283171 - Fix test when using remote debugging.

Author: labath Date: Mon Oct 3 19:32:20 2016 New Revision: 283171 URL: http://llvm.org/viewvc/llvm-project?rev=283171=rev Log: Fix test when using remote debugging. Summary: Use os.getcwd() instead of get_process_working_directory() as prefix for souce file. Reviewers: labath Subscribers:

[Lldb-commits] [PATCH] D25217: Fix test when using remote debugging.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm, thanks. https://reviews.llvm.org/D25217 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25217: Fix test when using remote debugging.

andrewford created this revision. andrewford added a reviewer: labath. andrewford added a subscriber: lldb-commits. Use os.getcwd() instead of get_process_working_directory() as prefix for souce file. https://reviews.llvm.org/D25217 Files:

[Lldb-commits] [lldb] r283168 - Try to fix failing tests when running remote test suite.

Author: zturner Date: Mon Oct 3 19:09:44 2016 New Revision: 283168 URL: http://llvm.org/viewvc/llvm-project?rev=283168=rev Log: Try to fix failing tests when running remote test suite. Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemoteLog.cpp Modified:

[Lldb-commits] [lldb] r283167 - Fix the data formatter for std::multiset in libc++ - this is a trivial amount of extra change on top of multimap

Author: enrico Date: Mon Oct 3 19:07:42 2016 New Revision: 283167 URL: http://llvm.org/viewvc/llvm-project?rev=283167=rev Log: Fix the data formatter for std::multiset in libc++ - this is a trivial amount of extra change on top of multimap Also, proper formatting.. Modified:

Re: [Lldb-commits] [lldb] r283160 - Changes to the std::multimap formatter to make it work against trunk libc++

Woops... Guess I am just gonna reformat the entire file... Sorry about that! On 10/03/16 04:43 PM, Zachary Turner wrote: > > > Was this clang-formatted? some of these lines look way longer than 80 columns. > > > > On Mon, Oct 3, 2016 at 4:41 PM Enrico Granata via

Re: [Lldb-commits] [lldb] r283160 - Changes to the std::multimap formatter to make it work against trunk libc++

Was this clang-formatted? some of these lines look way longer than 80 columns. On Mon, Oct 3, 2016 at 4:41 PM Enrico Granata via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: enrico > Date: Mon Oct 3 18:33:00 2016 > New Revision: 283160 > > URL:

[Lldb-commits] [lldb] r283160 - Changes to the std::multimap formatter to make it work against trunk libc++

Author: enrico Date: Mon Oct 3 18:33:00 2016 New Revision: 283160 URL: http://llvm.org/viewvc/llvm-project?rev=283160=rev Log: Changes to the std::multimap formatter to make it work against trunk libc++ Fixes rdar://28237486 Modified:

[Lldb-commits] [lldb] r283159 - Modernize some code related to Args usage / implementation.

Author: zturner Date: Mon Oct 3 18:20:36 2016 New Revision: 283159 URL: http://llvm.org/viewvc/llvm-project?rev=283159=rev Log: Modernize some code related to Args usage / implementation. Mostly this involves simplifying some logical constructs and using some ranges instead of index-based

[Lldb-commits] [lldb] r283157 - Refactor the Args class.

Author: zturner Date: Mon Oct 3 17:51:09 2016 New Revision: 283157 URL: http://llvm.org/viewvc/llvm-project?rev=283157=rev Log: Refactor the Args class. There were a number of issues with the Args class preventing efficient use of strings and incoporating LLVM's StringRef class. The two biggest

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

tfiala added a comment. I also just added a test case to validate we get a non-None answer to test instance self.id() calls. We use it in several places, so might as well make that explicit. That went in as r283156. https://reviews.llvm.org/D24988

[Lldb-commits] [lldb] r283156 - add a simple test case to validate test id()

Author: tfiala Date: Mon Oct 3 17:49:13 2016 New Revision: 283156 URL: http://llvm.org/viewvc/llvm-project?rev=283156=rev Log: add a simple test case to validate test id() Since we count on it in a few places, the test verifies that the test instance has an id() method that returns something

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Much better. I see you found test.id(), which gets as the module.class.test_method setup. That will be unique. Thanks! LGTM. https://reviews.llvm.org/D24988

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

fjricci updated this revision to Diff 73363. fjricci added a comment. Fix typo https://reviews.llvm.org/D24988 Files: packages/Python/lldbsuite/test/configuration.py packages/Python/lldbsuite/test/dotest.py packages/Python/lldbsuite/test/dotest_args.py

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

fjricci updated this revision to Diff 73362. fjricci added a comment. Match against filename + test case + method name https://reviews.llvm.org/D24988 Files: packages/Python/lldbsuite/test/configuration.py packages/Python/lldbsuite/test/dotest.py

Re: [Lldb-commits] [PATCH] D25099: Refactor Args a different way

Thanks, I'll fix it up before submitting On Mon, Oct 3, 2016 at 2:40 PM Jim Ingham wrote: > jingham added a comment. > > You messed up the meaning of one comment (noted inline). Otherwise this > looks fine to me too. > > > > > Args.cpp:97-98 > > + // Argument can be split

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

fjricci added a comment. In https://reviews.llvm.org/D24988#559775, @tfiala wrote: > In https://reviews.llvm.org/D24988#559314, @fjricci wrote: > > > For an example of something that couldn't be disabled with the original > > implementation, consider a test like: > > > >

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

jingham added a comment. You messed up the meaning of one comment (noted inline). Otherwise this looks fine to me too. > Args.cpp:97-98 > + // Argument can be split into multiple discontiguous pieces, for example: > + // "Hello " "World" > + // this would result in a single argument

Re: [Lldb-commits] [lldb] r282966 - IsValid is the way to ask a breakpoint location whether it is valid.

Ah, okay, thanks! Jim > On Oct 3, 2016, at 1:44 PM, Pavel Labath wrote: > > The test fails on remote targets because it tries to set breakpoints based on > remote paths. We'll have that fixed shortly. > > On 3 October 2016 at 11:13, Jim Ingham via lldb-commits >

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

tfiala added a comment. In https://reviews.llvm.org/D24988#559314, @fjricci wrote: > For an example of something that couldn't be disabled with the original > implementation, consider a test like: > > `CreateDuringStepTestCase.test_step_inst` > > Disabling by method name (`test_step_inst`)

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

dvlahovski added inline comments. > labath wrote in TestMiniDumpNew.py:19 > You can replace these with `NO_DEBUG_INFO_TESTCASE = True` at class level. But, should `test_deeper_stack_in_mini_dump` and `test_local_variables_in_mini_dump` not have this decorator ? https://reviews.llvm.org/D25196

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. That works fine. LGTM. https://reviews.llvm.org/D25099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

tfiala added a comment. In https://reviews.llvm.org/D25099#559701, @zturner wrote: > I know what this is. It should be fixed in this patch, I guess I didn't have > the newest patch uploaded. Okay, I'll give that a shot now. https://reviews.llvm.org/D25099

Re: [Lldb-commits] [lldb] r282966 - IsValid is the way to ask a breakpoint location whether it is valid.

The test fails on remote targets because it tries to set breakpoints based on remote paths. We'll have that fixed shortly. On 3 October 2016 at 11:13, Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > These tests were failing for a bogus reason, so I fixed the bogus reason >

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

zturner updated this revision to Diff 73335. zturner added a comment. I know what this is. It should be fixed in this patch, I guess I didn't have the newest patch uploaded. https://reviews.llvm.org/D25099 Files: include/lldb/Interpreter/Args.h source/Core/Logging.cpp

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

dvlahovski added a comment. In https://reviews.llvm.org/D25196#559368, @amccarth wrote: > I was hoping that, with your new mini dump parser, you'd be able to eliminate > the need for the Windows-specific minidump process plugin. > > When I wrote the Windows mini dump plugin, I tried to isolate

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

dvlahovski added inline comments. > labath wrote in ProcessMinidump.cpp:67 > It already is return true. > > Is that correct? What I meant here is: is there functionality that needs to be added here. In the WinMinidump plugin, this method is only returning true (as mine) and has a TODO saying

Re: [Lldb-commits] [lldb] r282966 - IsValid is the way to ask a breakpoint location whether it is valid.

These tests were failing for a bogus reason, so I fixed the bogus reason and let them try again. They succeed on MacOS, but apparently there's another failure reason for these configurations. Do you know the configuration for (in terms of the testsuite's "oslist"? If not, I'll find out what

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

amccarth added a comment. I was hoping that, with your new mini dump parser, you'd be able to eliminate the need for the Windows-specific minidump process plugin. When I wrote the Windows mini dump plugin, I tried to isolate the Windows API-specific bits using the pimpl idiom. Now that you've

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I have a bunch of small comments. I'll have another look through this once they are done. The high-level change we need is to avoid choosing the plugin to use at compile-time (your

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

tfiala added a comment. I will test this on macOS. I will have the results this afternoon. https://reviews.llvm.org/D25099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

fjricci added a comment. For an example of something that couldn't be disabled with the original implementation, consider a test like: `CreateDuringStepTestCase.test_step_inst` Disabling by method name (`test_step_inst`) would also disable `CreateDuringInstructionStepTestCase.test_step_inst`.

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

fjricci added a comment. The problem with the existing code is that file names are required to be unique, but method names are not. So if the user wants to disable an individual test method with a non-unique name, there is no way to do so. This patch still allows the tests to be disabled by

Re: [Lldb-commits] [PATCH] D25099: Refactor Args a different way

Yep I plan on doing that. -Todd > On Oct 3, 2016, at 10:29 AM, Zachary Turner wrote: > > He lgtm'ed my last patch, so I guess he's ok with the general concept. > Perhaps if someone could just run the test suite for me that would be good > enough. > >> On Mon, Oct 3,

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

dvlahovski added a comment. So, there will be changes to the way I handle the case where there is no ExceptionStream - I will probably create a StopReason = None. But I have to investigate if in that case lldb still hangs because it's trying to resume a process (that does not exists). I will

Re: [Lldb-commits] [PATCH] D25099: Refactor Args a different way

He lgtm'ed my last patch, so I guess he's ok with the general concept. Perhaps if someone could just run the test suite for me that would be good enough. On Mon, Oct 3, 2016 at 10:25 AM Todd Fiala wrote: > tfiala added a comment. > > @zturner , Greg is out this week (and

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

tfiala added a comment. @zturner , Greg is out this week (and was last Friday as well). I'll get somebody over here to review. https://reviews.llvm.org/D25099 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

tfiala added a comment. Hey @fjricci , What is the motivation for this change? It looks like the existing code works based on file names, which are required to be unique in the system. It looks like you're attempting to move it over to a classname.method scheme. Is that right? If so,

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

fjricci added a comment. Since this is strictly an improvement and simplification, and won't break anyone's workflow because it's still a new feature, I'll plan on merging this tomorrow unless I hear any objections. https://reviews.llvm.org/D24988

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

dvlahovski created this revision. dvlahovski added reviewers: labath, zturner. dvlahovski added subscribers: lldb-commits, amccarth. Herald added subscribers: modocache, mgorny, beanz. This plugin resembles the already existing Windows-only Minidump plugin. The WinMinidumpPlugin uses the Windows

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

zturner added a comment. Hi Greg, might you have a chance to look at this today? I've got a huge backlog of CLs to get in. The rest probably won't require reviews, but this one is a precursor to everything else. https://reviews.llvm.org/D25099

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

nitesh.jain updated this revision to Diff 73278. nitesh.jain added a comment. These diff remove manually bit twiddling due to the size of the floating point register that can change. We use register offset to get floating point register data based on endianess and it's size. We have not remove

Re: [Lldb-commits] [lldb] r282966 - IsValid is the way to ask a breakpoint location whether it is valid.

Hi, Are these build breakages somehow connected to this commit? http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/8703 http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu- 14.04-android/builds/9655 Thanks, Dimitar On Fri, Sep 30, 2016 at 11:07 PM, Jim Ingham via lldb-commits <

[Lldb-commits] [PATCH] D25179: [lldb] Improve identification of Linux core dumps. Fix for bug #30485.

rnchamberlain added a comment. More information, including readelf output from the dump, in the bugzilla here: https://llvm.org/bugs/show_bug.cgi?id=30485 https://reviews.llvm.org/D25179 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25179: [lldb] Improve identification of Linux core dumps. Fix for bug #30485.

rnchamberlain created this revision. rnchamberlain added reviewers: clayborg, ted, hhellyer. rnchamberlain added a subscriber: lldb-commits. ObjectFileELF::RefineModuleDetailsFromNote() identifies Linux core dumps by searching for library paths starting with /lib/x86_64-linux-gnu or