[Lldb-commits] [lldb] r283295 - Change Platform::GetRemoteSharedModule so if it's given a ModuleSpec

Author: jmolenda Date: Tue Oct 4 21:29:13 2016 New Revision: 283295 URL: http://llvm.org/viewvc/llvm-project?rev=283295=rev Log: Change Platform::GetRemoteSharedModule so if it's given a ModuleSpec which specifies a file path and UUID but not an architecture, open the file at that path and try

[Lldb-commits] [lldb] r283289 - The collision of class C and libsystem_c.dylib:C is a failure

Author: jingham Date: Tue Oct 4 20:19:15 2016 New Revision: 283289 URL: http://llvm.org/viewvc/llvm-project?rev=283289=rev Log: The collision of class C and libsystem_c.dylib:C is a failure worth preserving, but not essential to the purpose of this test so I broke it into a separate test.

[Lldb-commits] [lldb] r283287 - This test is failing because there's a global symbol "C" in libsystem_c.dylib,

Author: jingham Date: Tue Oct 4 20:09:43 2016 New Revision: 283287 URL: http://llvm.org/viewvc/llvm-project?rev=283287=rev Log: This test is failing because there's a global symbol "C" in libsystem_c.dylib, and that is defeating the lookup of the "struct C" here. Adding the bug for that.

[Lldb-commits] [lldb] r283285 - Revert "Re-commit "Use StringRef in Support/Darf APIs (NFC)""

Author: mehdi_amini Date: Tue Oct 4 20:04:02 2016 New Revision: 283285 URL: http://llvm.org/viewvc/llvm-project?rev=283285=rev Log: Revert "Re-commit "Use StringRef in Support/Darf APIs (NFC)"" One test seems randomly broken: DebugInfo/X86/gnu-public-names.ll Modified:

[Lldb-commits] [lldb] r283281 - Re-commit "Use StringRef in Support/Darf APIs (NFC)"

Author: mehdi_amini Date: Tue Oct 4 19:37:18 2016 New Revision: 283281 URL: http://llvm.org/viewvc/llvm-project?rev=283281=rev Log: Re-commit "Use StringRef in Support/Darf APIs (NFC)" This reverts commit r283278 and re-commit r283275 with the update to fix the build on the LLDB side.

[Lldb-commits] [lldb] r283276 - Add the new minidump files to the Xcode project.

Author: jingham Date: Tue Oct 4 19:07:01 2016 New Revision: 283276 URL: http://llvm.org/viewvc/llvm-project?rev=283276=rev Log: Add the new minidump files to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r283263 - xfailing tests for Minidump plugin

Author: dvlahovski Date: Tue Oct 4 16:55:47 2016 New Revision: 283263 URL: http://llvm.org/viewvc/llvm-project?rev=283263=rev Log: xfailing tests for Minidump plugin the tests are failing on the buildbot because there is an extra frame (maybe) on the call stack. Will investigate tomorrow.

[Lldb-commits] [lldb] r283262 - Fix the decorator of TestBreakpointCaseSensitivity

Author: tberghammer Date: Tue Oct 4 16:32:46 2016 New Revision: 283262 URL: http://llvm.org/viewvc/llvm-project?rev=283262=rev Log: Fix the decorator of TestBreakpointCaseSensitivity Modified:

Re: [Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

Ah, missed it there. No it is fine to put it in the header. Jim > On Oct 4, 2016, at 2:37 PM, Zachary Turner wrote: > > zturner added inline comments. > > >> jingham wrote in BreakpointIDList.cpp:329-330 >> Did you upload the latest version of your patch, I don't see a

[Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

zturner added inline comments. > jingham wrote in BreakpointIDList.cpp:329-330 > Did you upload the latest version of your patch, I don't see a comment here... I put the comment in the header. I can put it here if you prefer. Putting it on both places seems unnecessary though. LMK which you

[Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. No good deed goes unpunished... You made ParseCanonicalReference more beautiful but forgot to update the header doc. Also I didn't see the comment for SplitIDRangeExpression.

[Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

Eugene.Zelenko added a comment. Looks like patch was not committed. Please rebase with trunk and run Clang-format. https://reviews.llvm.org/D24124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25158: Convert some Breakpoint to StringRef

zturner updated this revision to Diff 73554. zturner added a comment. Fixed up `ParseCanonicalReference` and `SplitIDRangeExpression` as suggested. I could have probably returned an `Optional>` but it seemed like overkill. An empty pair seems sufficient for

[Lldb-commits] [PATCH] D25247: Make LLDB -Werror clean under clang

amccarth accepted this revision. amccarth added a comment. lgtm > UDPSocket.cpp:106 > +#if defined(_MSC_VER) && defined(UNICODE) > +"getaddrinfo(%s, %s, , ) returned error %i (%S)", > +#else Yuck. Given that this is going to get reduced from UTF-16 to MBCS, it might be cleaner to

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL283259: Adding a new Minidump post-mortem debugging plugin (authored by dvlahovski). Changed prior to commit: https://reviews.llvm.org/D25196?vs=73541=73551#toc Repository: rL LLVM

[Lldb-commits] [lldb] r283259 - Adding a new Minidump post-mortem debugging plugin

Author: dvlahovski Date: Tue Oct 4 16:02:13 2016 New Revision: 283259 URL: http://llvm.org/viewvc/llvm-project?rev=283259=rev Log: Adding a new Minidump post-mortem debugging plugin Summary: This plugin resembles the already existing Windows-only Minidump plugin. The WinMinidumpPlugin uses the

[Lldb-commits] [PATCH] D24549: [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite loop

Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D24549 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D25196 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25246: Disable warnings in LLDBWrapPython.cpp when LLVM_ENABLE_WERROR is used

zturner added a comment. In https://reviews.llvm.org/D25246#561323, @Eugene.Zelenko wrote: > You could use -Wno-error= instead. Yes but it's a little bit annoying to track down every single one we get in this file with all the different compilers. Since we can't really control the generated

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

dvlahovski updated this revision to Diff 73541. dvlahovski marked 2 inline comments as done. dvlahovski added a comment. Added a sanity check for loc_descr https://reviews.llvm.org/D25196 Files: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/Makefile

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

labath added a comment. Thanks for fixing all the comments. Unfortunately, on my last pass, I found one more case of unverified input (I think). > MinidumpParser.cpp:252 > +if (range_start <= addr && addr < range_start + range_size) { > + return Range(range_start,

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

dvlahovski marked an inline comment as done. dvlahovski added inline comments. > zturner wrote in MinidumpParser.cpp:81-82 > Change this line to `return GetData().slice(iter->second.rva, > iter->second.data_size);` Nice! :) > zturner wrote in MinidumpParser.h:35-36 > If the comment is long

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

dvlahovski updated this revision to Diff 73526. dvlahovski marked 6 inline comments as done. dvlahovski added a comment. Changes after Zachary's comments https://reviews.llvm.org/D25196 Files: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/Makefile

[Lldb-commits] [PATCH] D25247: Make LLDB -Werror clean under clang

zturner marked an inline comment as done. zturner added inline comments. > Eugene.Zelenko wrote in Platform.h:16 > This is application header. Should be in quotes. Same below. Thanks for pointing this out. Fixed locally https://reviews.llvm.org/D25247

[Lldb-commits] [PATCH] D24988: Improvements to testing blacklist

This revision was automatically updated to reflect the committed changes. Closed by commit rL283238: Improvements to testing blacklist (authored by fjricci). Changed prior to commit: https://reviews.llvm.org/D24988?vs=73363=73525#toc Repository: rL LLVM https://reviews.llvm.org/D24988

[Lldb-commits] [lldb] r283238 - Improvements to testing blacklist

Author: fjricci Date: Tue Oct 4 13:48:00 2016 New Revision: 283238 URL: http://llvm.org/viewvc/llvm-project?rev=283238=rev Log: Improvements to testing blacklist Summary: This patch is necessary because individual test cases are not required to have unique names. Therefore, test cases must now

[Lldb-commits] [PATCH] D25247: Make LLDB -Werror clean under clang

Eugene.Zelenko added inline comments. > Platform.h:16 > #include > #include > +#include This is application header. Should be in quotes. Same below. https://reviews.llvm.org/D25247 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25247: Make LLDB -Werror clean under clang

zturner added a comment. Thankfully, yes. Technically it's not supported by MSVC 2013, which is still a supported LLVM compiler. But we said long ago that we require MSVC 2015 for running the test suite on Windows. And in any case, LLVM is bumping to MSVC 2015 within the next 2 weeks. So

[Lldb-commits] [PATCH] D25247: Make LLDB -Werror clean under clang

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems reasonable. For testing we'll yell at you if the buildbots break. I take it we can now freely use the %z printf modifier. https://reviews.llvm.org/D25247

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

zturner added inline comments. > MinidumpParser.cpp:81-82 > > - return llvm::ArrayRef(m_data_sp->GetBytes() + iter->second.rva, > + return llvm::ArrayRef(GetData().data() + iter->second.rva, > iter->second.data_size); > } Change this line to `return

[Lldb-commits] [lldb] r283237 - Fix FixupEnvironment on Android after the Args refactor

Author: tberghammer Date: Tue Oct 4 13:35:39 2016 New Revision: 283237 URL: http://llvm.org/viewvc/llvm-project?rev=283237=rev Log: Fix FixupEnvironment on Android after the Args refactor Modified: lldb/trunk/source/Host/linux/ProcessLauncherLinux.cpp Modified:

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

dvlahovski updated this revision to Diff 73516. dvlahovski marked 5 inline comments as done. dvlahovski added a comment. Second iteration over CL - regarded Pavel's comments and encapsulated m_data_sp more in MinidumpParser https://reviews.llvm.org/D25196 Files:

[Lldb-commits] [PATCH] D25247: Make LLDB -Werror clean under clang

zturner created this revision. zturner added reviewers: amccarth, labath. zturner added a subscriber: lldb-commits. Herald added a subscriber: ki.stfu. Some of this is in Windows specific code, but some of it is not. In a few places I think I fixed real bugs in LLDB, but not sure how to really

[Lldb-commits] [PATCH] D25246: Disable warnings in LLDBWrapPython.cpp when LLVM_ENABLE_WERROR is used

labath added a comment. I wouldn't be opposed to completely disabling (a particular chosen set of warnings) for that file, regardless of whether we do -Werror or not. https://reviews.llvm.org/D25246 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D25246: Disable warnings in LLDBWrapPython.cpp when LLVM_ENABLE_WERROR is used

zturner created this revision. zturner added a reviewer: beanz. zturner added a subscriber: lldb-commits. Herald added a subscriber: mgorny. We don't control the generated code here, so there often isn't anything we can do about these warnings. They'll still show when -Werror is off so they

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

labath added a comment. Just a couple more details and I think we're ready. > MinidumpParser.cpp:105 > +MinidumpParser::GetThreadContext(const MinidumpThread ) { > + return td.GetContext(GetData().data()); > +} I think you have made it over-encapsulated now. :) Either a Parser function which

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

dvlahovski updated this revision to Diff 73504. dvlahovski marked 7 inline comments as done. dvlahovski added a comment. Updated the CL with regard to Pavel's comments https://reviews.llvm.org/D25196 Files: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/Makefile

[Lldb-commits] [PATCH] D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints

labath added a comment. In https://reviews.llvm.org/D25057#560325, @omjavaid wrote: > @labath Referring to your email on the mailing list. > > Thanks for helping out with this work. > > I think we should push this fix, as you suggested this does not fix > everything in a holistic way but it

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

This revision was automatically updated to reflect the committed changes. Closed by commit rL283157: Refactor the Args class. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D25099?vs=73335=73418#toc Repository: rL LLVM https://reviews.llvm.org/D25099 Files:

[Lldb-commits] [PATCH] D25217: Fix test when using remote debugging.

This revision was automatically updated to reflect the committed changes. Closed by commit rL283171: Fix test when using remote debugging. (authored by labath). Changed prior to commit: https://reviews.llvm.org/D25217?vs=73381=73419#toc Repository: rL LLVM https://reviews.llvm.org/D25217