[Lldb-commits] [lldb] r285172 - Enable the use of the new dyld SPI on the current

2016-10-25 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Oct 25 23:48:41 2016 New Revision: 285172 URL: http://llvm.org/viewvc/llvm-project?rev=285172=rev Log: Enable the use of the new dyld SPI on the current generation macosx/ios/tvos/watchos. Modified:

[Lldb-commits] [lldb] r285153 - SBWatchpoint::Disable doesn't actually work. Add a test that shows this.

2016-10-25 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Oct 25 20:09:21 2016 New Revision: 285153 URL: http://llvm.org/viewvc/llvm-project?rev=285153=rev Log: SBWatchpoint::Disable doesn't actually work. Add a test that shows this. Next to fix it! Added:

Re: [Lldb-commits] [lldb] r285068 - Revert "Improve the libstdc++ smart pointer formatters"

2016-10-25 Thread Jim Ingham via lldb-commits
I already fixed this in r285113. Jim > On Oct 25, 2016, at 2:49 PM, Tim Hammerquist via lldb-commits > wrote: > > Hi Pavel, > > Looks like some code left after this revert is still expecting this file > (added contemporary to r284828) that was removed in this

Re: [Lldb-commits] [lldb] r285068 - Revert "Improve the libstdc++ smart pointer formatters"

2016-10-25 Thread Tim Hammerquist via lldb-commits
Hi Pavel, Looks like some code left after this revert is still expecting this file (added contemporary to r284828) that was removed in this revision. --- lldb/trunk/source/Plugins/Language/CPlusPlus/LibStdcppSmartPointer.cpp (original) +++

[Lldb-commits] [lldb] r285114 - Fix a race condition between the "ephemeral watchpoint disabling" and commands the continue the process.

2016-10-25 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Oct 25 15:34:32 2016 New Revision: 285114 URL: http://llvm.org/viewvc/llvm-project?rev=285114=rev Log: Fix a race condition between the "ephemeral watchpoint disabling" and commands the continue the process. This closes https://reviews.llvm.org/D25875. Modified:

[Lldb-commits] [lldb] r285113 - Fixing up the project file for the removal of LibStdcppSmartPointer.cpp.

2016-10-25 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Oct 25 15:32:26 2016 New Revision: 285113 URL: http://llvm.org/viewvc/llvm-project?rev=285113=rev Log: Fixing up the project file for the removal of LibStdcppSmartPointer.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [PATCH] D25926: Don't set a software stepping breakpoint at 0 on arm or mips.

2016-10-25 Thread Jason Majors via lldb-commits
jmajors updated this revision to Diff 75779. jmajors added a comment. Restructured the code to skip setting a software breakpoint at 0. https://reviews.llvm.org/D25926 Files: packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

2016-10-25 Thread Pavel Labath via lldb-commits
labath updated this revision to Diff 75718. labath added a comment. clang-format the patch https://reviews.llvm.org/D25947 Files: source/Plugins/Process/FreeBSD/FreeBSDThread.cpp source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

2016-10-25 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: emaste, clayborg. labath added subscribers: lldb-commits, dmikulin. Herald added subscribers: modocache, mgorny, beanz, rengolin, aemerson. This is a test-the-water change about possibilities of reducing duplication in the register context

[Lldb-commits] [PATCH] D25922: Test infra: expose CFLAGS_NO_ARCH for use by test custom build rules

2016-10-25 Thread Todd Fiala via lldb-commits
tfiala added a comment. > I am not that excited by this, but I don't see a much better way to achieve > the result. :) > Possibly I'd consider making the variable name positive (instead of > CFLAGS_NO_DEBUG, have a INCLUDES var, and then the test can use $(INCLUDES) > $(TRIPLE_CFLAGS)). Jim

[Lldb-commits] [PATCH] D25905: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull

2016-10-25 Thread Dimitar Vlahovski via lldb-commits
dvlahovski updated this revision to Diff 75709. dvlahovski marked 4 inline comments as done. dvlahovski added a comment. Formatting correctly the test files source code, and added explanation in their makefile ReadModuleList() is called in DoLoadCore() https://reviews.llvm.org/D25905 Files:

[Lldb-commits] [PATCH] D25905: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull

2016-10-25 Thread Pavel Labath via lldb-commits
labath added a comment. Just a bit more cleanup and this will be fine. Sorry about the back and forth, I was in a hurry yesterday. Zachary, Adrian: any thoughts on your side? Comment at:

[Lldb-commits] [lldb] r285068 - Revert "Improve the libstdc++ smart pointer formatters"

2016-10-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Oct 25 08:24:53 2016 New Revision: 285068 URL: http://llvm.org/viewvc/llvm-project?rev=285068=rev Log: Revert "Improve the libstdc++ smart pointer formatters" This reverts commit r284828, as it causes an infinite loop in TestPrintStackTraces (funnily enough, only when

[Lldb-commits] [PATCH] D25926: Don't set a software stepping breakpoint at 0 on arm or mips.

2016-10-25 Thread Pavel Labath via lldb-commits
labath added a comment. Could you make two more changes to this patch? Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:1365 error = SetSoftwareBreakpoint(next_pc, 4); - else { +// If setting the breakpoint fails because next_pc is out of +// the

[Lldb-commits] [PATCH] D25922: Test infra: expose CFLAGS_NO_ARCH for use by test custom build rules

2016-10-25 Thread Pavel Labath via lldb-commits
labath added a comment. I am not that excited by this, but I don't see a much better way to achieve the result. :) Possibly I'd consider making the variable name positive (instead of CFLAGS_NO_DEBUG, have a INCLUDES var, and then the test can use `$(INCLUDES) $(TRIPLE_CFLAGS)`).