[Lldb-commits] [PATCH] D26124: [LLDB-MI] Escape MI output in a more consistent manner

enlight added a comment. Thanks for the review. `AddSlashes` is still used in a couple of places (but not for escaping MI output), so I'll leave it be for now. Repository: rL LLVM https://reviews.llvm.org/D26124 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D26245: [cmake] Build gtest from LLVM when building standalone

This revision was automatically updated to reflect the committed changes. Closed by commit rL285865: [cmake] Build gtest from LLVM when building standalone (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D26245?vs=76709=76801#toc Repository: rL LLVM

[Lldb-commits] [lldb] r285865 - [cmake] Build gtest from LLVM when building standalone

Author: mgorny Date: Wed Nov 2 17:57:23 2016 New Revision: 285865 URL: http://llvm.org/viewvc/llvm-project?rev=285865=rev Log: [cmake] Build gtest from LLVM when building standalone Include the gtest utility directory from LLVM sources when performing a stand-alone build of LLDB. This is

[Lldb-commits] [PATCH] D26245: [cmake] Build gtest from LLVM when building standalone

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D26245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D26260: Fix typo which broke debugging on older OSX systems after r285172.

This revision was automatically updated to reflect the committed changes. Closed by commit rL285858: Fix typo which broke debugging on older OSX systems after r285172. (authored by dperchik). Changed prior to commit: https://reviews.llvm.org/D26260?vs=76780=76784#toc Repository: rL LLVM

[Lldb-commits] [lldb] r285858 - Fix typo which broke debugging on older OSX systems after r285172.

Author: dperchik Date: Wed Nov 2 15:57:34 2016 New Revision: 285858 URL: http://llvm.org/viewvc/llvm-project?rev=285858=rev Log: Fix typo which broke debugging on older OSX systems after r285172. Reviewed by: jasonmolenda Subscribers: lldb-commits Differential Revision:

[Lldb-commits] [PATCH] D26260: Fix typo which broke debugging on older OSX systems after r285172.

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yes it was, thanks for catching that! Please commit. Repository: rL LLVM https://reviews.llvm.org/D26260 ___ lldb-commits

[Lldb-commits] [PATCH] D26260: Fix typo which broke debugging on older OSX systems after r285172.

dawn created this revision. dawn added a reviewer: jasonmolenda. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. Clearly ">=" was meant to be ">". :) Repository: rL LLVM https://reviews.llvm.org/D26260 Files:

[Lldb-commits] [PATCH] D26233: Fix Clang-tidy readability-redundant-string-cstr warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL285855: Fix Clang-tidy readability-redundant-string-cstr warnings (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D26233?vs=76679=76776#toc Repository: rL LLVM

[Lldb-commits] [lldb] r285855 - Fix Clang-tidy readability-redundant-string-cstr warnings

Author: malcolm.parsons Date: Wed Nov 2 15:34:10 2016 New Revision: 285855 URL: http://llvm.org/viewvc/llvm-project?rev=285855=rev Log: Fix Clang-tidy readability-redundant-string-cstr warnings Reviewers: zturner, labath Subscribers: tberghammer, danalbert, lldb-commits Differential

[Lldb-commits] [PATCH] D26249: [unittests] Split DWARF tests out of PDB, fix standalone build

mgorny retitled this revision from "[unittests] Avoid the dependency on private LLVM headers outside MSVC" to "[unittests] Split DWARF tests out of PDB, fix standalone build". mgorny updated the summary for this revision. mgorny updated this revision to Diff 76766. mgorny added a comment. Herald

[Lldb-commits] [PATCH] D26237: Remove KQueue.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL285847: Remove KQueue.cpp (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26237?vs=76689=76745#toc Repository: rL LLVM https://reviews.llvm.org/D26237 Files:

[Lldb-commits] [lldb] r285847 - Remove KQueue.cpp

Author: labath Date: Wed Nov 2 13:06:17 2016 New Revision: 285847 URL: http://llvm.org/viewvc/llvm-project?rev=285847=rev Log: Remove KQueue.cpp Summary: This class is unused. Reviewers: clayborg Subscribers: mgorny, modocache, lldb-commits Differential Revision:

[Lldb-commits] [PATCH] D26233: Fix Clang-tidy readability-redundant-string-cstr warnings

labath accepted this revision. labath added a comment. nice Repository: rL LLVM https://reviews.llvm.org/D26233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26233: Fix Clang-tidy readability-redundant-string-cstr warnings

malcolm.parsons added a comment. In https://reviews.llvm.org/D26233#586005, @zturner wrote: > Nice improvement. I assume you ran the test suite and everything passed? I think a change like this would fail to compile if it was wrong. check-lldb passed: == Issue Details

[Lldb-commits] [PATCH] D26233: Fix Clang-tidy readability-redundant-string-cstr warnings

malcolm.parsons created this revision. malcolm.parsons added a reviewer: zturner. malcolm.parsons added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. https://reviews.llvm.org/D26233 Files: source/Breakpoint/BreakpointResolverAddress.cpp

[Lldb-commits] [PATCH] D25681: [PseudoTerminal] Fix PseudoTerminal MSVC release crash

This revision was automatically updated to reflect the committed changes. Closed by commit rL285843: Fix crash in PseudoTerminal on Windows. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D25681?vs=75426=76742#toc Repository: rL LLVM

[Lldb-commits] [lldb] r285843 - Fix crash in PseudoTerminal on Windows.

Author: zturner Date: Wed Nov 2 12:42:12 2016 New Revision: 285843 URL: http://llvm.org/viewvc/llvm-project?rev=285843=rev Log: Fix crash in PseudoTerminal on Windows. Patch by Rudy Pons Differential Revision: https://reviews.llvm.org/D25681 Modified:

Re: [Lldb-commits] [PATCH] D26233: Fix Clang-tidy readability-redundant-string-cstr warnings

Me too, just wanted to make sure with such a large change. Anyway LGTM On Wed, Nov 2, 2016 at 10:43 AM Malcolm Parsons wrote: > malcolm.parsons added a comment. > > In https://reviews.llvm.org/D26233#586005, @zturner wrote: > > > Nice improvement. I assume you ran

[Lldb-commits] [lldb] r285839 - [CMake] Support LLDB_TEST_CLANG in check-lldb target(s)

Author: cbieneman Date: Wed Nov 2 12:19:26 2016 New Revision: 285839 URL: http://llvm.org/viewvc/llvm-project?rev=285839=rev Log: [CMake] Support LLDB_TEST_CLANG in check-lldb target(s) This just hooks up the in-tree compiler to be optionally used when running the test suite. Modified:

[Lldb-commits] [PATCH] D26170: Find clang resource directory via *nix-style lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rL285838: Find clang resource directory via *nix-style lookup (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D26170?vs=76496=76735#toc Repository: rL LLVM

[Lldb-commits] [lldb] r285838 - Find clang resource directory via *nix-style lookup

Author: cbieneman Date: Wed Nov 2 12:19:23 2016 New Revision: 285838 URL: http://llvm.org/viewvc/llvm-project?rev=285838=rev Log: Find clang resource directory via *nix-style lookup Summary: This patch allows the Darwin build to fall back to to Posix-style lookups for the clang resource

[Lldb-commits] [PATCH] D26233: Fix Clang-tidy readability-redundant-string-cstr warnings

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Nice improvement. I assume you ran the test suite and everything passed? Repository: rL LLVM https://reviews.llvm.org/D26233 ___

[Lldb-commits] [PATCH] D26249: [unittests] Avoid the dependency on private LLVM headers outside MSVC

zturner added a comment. That sounds reasonable. https://reviews.llvm.org/D26249 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26249: [unittests] Avoid the dependency on private LLVM headers outside MSVC

mgorny added a comment. I can't say it wouldn't work but I think exposing that as part of public API would be ugly-ish. So I'd rather go for either exposing it in llvm-config.h, or LLVMConfig.cmake (and then redeclaring inside LLDB) -- with preference on the former as requiring least work.

[Lldb-commits] [lldb] r285834 - Fix some warnings compiling with clang-cl on Windows.

Author: zturner Date: Wed Nov 2 11:59:42 2016 New Revision: 285834 URL: http://llvm.org/viewvc/llvm-project?rev=285834=rev Log: Fix some warnings compiling with clang-cl on Windows. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h

[Lldb-commits] [PATCH] D26249: [unittests] Avoid the dependency on private LLVM headers outside MSVC

zturner added a comment. What if we added a function to `llvm/DebugInfo/PDB/PDB.h` called `isDiaSupported()`, and in the implementation it returns `true` if the definition is present and `false` otherwise. Then instead of using the pre-processor to decide whether to run the test, we run all

[Lldb-commits] [PATCH] D26249: [unittests] Avoid the dependency on private LLVM headers outside MSVC

mgorny added a comment. In https://reviews.llvm.org/D26249#585869, @zturner wrote: > Is this necessary because of a standalone build, or for some other reason? > If this is to get Standalone build working, then it seems like this isn't > really a complete solution, because standalone build

[Lldb-commits] [PATCH] D26249: [unittests] Avoid the dependency on private LLVM headers outside MSVC

zturner added a comment. Is this necessary because of a standalone build, or for some other reason? If this is to get Standalone build working, then it seems like this isn't really a complete solution, because standalone build still wouldn't work on Windows since it would still be trying to

[Lldb-commits] [PATCH] D26249: [unittests] Avoid the dependency on private LLVM headers outside MSVC

mgorny created this revision. mgorny added reviewers: zturner, labath, k8stone. mgorny added a subscriber: lldb-commits. Avoid including private LLVM config.h when not using MSVC. The file is used only to determine whether DIA SDK is available, and this can be true only when using MSVC.

[Lldb-commits] [PATCH] D26237: Remove KQueue.cpp

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. As long as no one is using it in the Xcode project or in liblldb we can remove it. https://reviews.llvm.org/D26237 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D26243: Refactor Timer class

labath updated this revision to Diff 76701. labath added a comment. run clang-format https://reviews.llvm.org/D26243 Files: include/lldb/Core/Timer.h source/Core/Timer.cpp unittests/Core/CMakeLists.txt unittests/Core/TimerTest.cpp Index: unittests/Core/TimerTest.cpp

[Lldb-commits] [PATCH] D26243: Refactor Timer class

labath created this revision. labath added reviewers: tberghammer, clayborg. labath added a subscriber: lldb-commits. Herald added a subscriber: mgorny. While removing TimeValue from this class I noticed a lot of room for small simplifications here. Main are: - instead of complicated start-stop

[Lldb-commits] [lldb] r285801 - Remove TimeValue usage from two files

Author: labath Date: Wed Nov 2 07:18:42 2016 New Revision: 285801 URL: http://llvm.org/viewvc/llvm-project?rev=285801=rev Log: Remove TimeValue usage from two files Modified: lldb/trunk/source/Core/Communication.cpp lldb/trunk/source/Core/Log.cpp Modified:

[Lldb-commits] [PATCH] D26237: Remove KQueue.cpp

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. Herald added subscribers: modocache, mgorny. This class is unused (and apple specific, so it does not really belong into generic code). Can we remove it? https://reviews.llvm.org/D26237

[Lldb-commits] [lldb] r285798 - Fix printf errors in ProcessMinidump

Author: labath Date: Wed Nov 2 05:29:47 2016 New Revision: 285798 URL: http://llvm.org/viewvc/llvm-project?rev=285798=rev Log: Fix printf errors in ProcessMinidump Modified: lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp Modified:

[Lldb-commits] [lldb] r285797 - Remove TimeValue from UnwindLLDB.cpp

Author: labath Date: Wed Nov 2 05:27:54 2016 New Revision: 285797 URL: http://llvm.org/viewvc/llvm-project?rev=285797=rev Log: Remove TimeValue from UnwindLLDB.cpp Really NFC, as the code is #ifdefed out, but I did make sure it compiles if I enable it. Modified:

[Lldb-commits] [lldb] r285795 - Remove TimeValue usages from MacOSX-Kernel process plugin. NFC

Author: labath Date: Wed Nov 2 05:13:54 2016 New Revision: 285795 URL: http://llvm.org/viewvc/llvm-project?rev=285795=rev Log: Remove TimeValue usages from MacOSX-Kernel process plugin. NFC Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp

[Lldb-commits] [PATCH] D26190: [RFC] Solve linking inconsistency, proposal two

labath added a comment. In https://reviews.llvm.org/D26190#585106, @mehdi_amini wrote: > >> , but LLVM is not robust to mix and match build settings: building half of > >> the source with -DNDEBUG and not the other is likely to cause weird > >> runtime failures. That can be an issue because

[Lldb-commits] [PATCH] D26209: Fix windows build after r285702, missing include to define PATH_MAX

labath closed this revision. labath added a comment. I believe Zachary already fixed this. https://reviews.llvm.org/D26209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits