[Lldb-commits] [PATCH] D26249: [unittests] Split DWARF tests out of PDB, fix standalone build

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. looks good, sorry for the delay was busy with the LLVM dev conference. Comment at: unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp:33-36 +#if defined(_MSC_VER)

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

emaste added a comment. Good point. https://reviews.llvm.org/D26315 has the change to add FreeBSD support to make-core.sh -- just avoiding /bin/bash, and the core file handler check. I think we should be able to rename this directory to elf-core, and rename the individual cores to e.g.

[Lldb-commits] [PATCH] D26315: make-core.sh: add FreeBSD support

emaste added a comment. Output on FreeBSD, with the patch: % sh make-core.sh main.c + file=main.c + [ -z main.c ] + [ FreeBSD '=' Linux ] + ulimit -c 1000 + ulimit -c + real_limit=1000 + [ 1000 -lt 100 ] + cc -nostdlib -static -g main.c -o a.out + cat Executable file is in

[Lldb-commits] [PATCH] D26315: make-core.sh: add FreeBSD support

emaste created this revision. emaste added a reviewer: labath. emaste added a subscriber: lldb-commits. https://reviews.llvm.org/D26315 Files: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/make-core.sh Index:

[Lldb-commits] [PATCH] D26295: Change UnwindAssemblyInstEmulation to remove a register location instead of marking it as IsSame()

jasonmolenda added a comment. Ah, interesting point, I didn't think of that. However, this touches on another thing I've been thinking about as I look at the assembly inspection unwind plan generators. In the x86 unwind inspector, I've hardcoded the SysV-x86_64 ABI and the unwind plan

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

labath added a comment. I was very successful in creating tiny core files by avoiding linking with the standard library (you don't really need a full libc to crash :P ). I think this file should use the same approach as well (see the other core files in this directory, and the make-core.sh

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

emaste added a comment. We need to make sure this does not regress FreeBSD core handling -- I will test as soon as I can, and add FXSAVE parsing for FreeBSD. I'll use fpr_sse.cpp to generate FreeBSD core files as well (although note that we get ~2.5MB cores with default configuration, so

[Lldb-commits] [lldb] r286003 - Preliminary plumbing work to make 'parray' able to take offset and stride options

Author: enrico Date: Fri Nov 4 13:15:39 2016 New Revision: 286003 URL: http://llvm.org/viewvc/llvm-project?rev=286003=rev Log: Preliminary plumbing work to make 'parray' able to take offset and stride options Modified: lldb/trunk/include/lldb/DataFormatters/DumpValueObjectOptions.h

[Lldb-commits] [PATCH] D26295: Change UnwindAssemblyInstEmulation to remove a register location instead of marking it as IsSame()

tberghammer added a comment. My understanding (can be wrong) is that there IS a difference between not specifying a register in the unwind info versus specifying it as "is same" for volatile (caller saved) registers. I think for volatile registers not specifying them means that we can't access

Re: [Lldb-commits] GDBRemoteCommunicationClientTest.TestPacketSpeedJSON unit test hanging for anyone else?

Hi Jason, Sorry about that. The problem was in the present in the debug builds only. r285992 should fix it. pl On 4 November 2016 at 02:45, Jason Molenda wrote: > Is anyone else seeing a hang in > GDBRemoteCommunicationClientTest.TestPacketSpeedJSON when running the unit

[Lldb-commits] [lldb] r285992 - Fix GDBRemoteCommunicationClientTest.TestPacketSpeedJSON

Author: labath Date: Fri Nov 4 06:49:06 2016 New Revision: 285992 URL: http://llvm.org/viewvc/llvm-project?rev=285992=rev Log: Fix GDBRemoteCommunicationClientTest.TestPacketSpeedJSON The mock server was listening for only one packet (I forgot to put a loop around it), which caused the client