[Lldb-commits] [lldb] r289188 - Remove some more uses of Args::GetArgumentAtIndex.

2016-12-08 Thread Zachary Turner via lldb-commits
Author: zturner Date: Thu Dec 8 23:46:41 2016 New Revision: 289188 URL: http://llvm.org/viewvc/llvm-project?rev=289188=rev Log: Remove some more uses of Args::GetArgumentAtIndex. Modified: lldb/trunk/source/Commands/CommandObjectMultiword.cpp

[Lldb-commits] [lldb] r289169 - Calling SBDebugger::CeeateTarget being called on multiple threads was crashing LLDB.

2016-12-08 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Thu Dec 8 19:21:14 2016 New Revision: 289169 URL: http://llvm.org/viewvc/llvm-project?rev=289169=rev Log: Calling SBDebugger::CeeateTarget being called on multiple threads was crashing LLDB. I found the race condition in: ScriptInterpreter

[Lldb-commits] [lldb] r289168 - Fix some occurrences of passing StringRef to Printf.

2016-12-08 Thread Zachary Turner via lldb-commits
Author: zturner Date: Thu Dec 8 19:20:58 2016 New Revision: 289168 URL: http://llvm.org/viewvc/llvm-project?rev=289168=rev Log: Fix some occurrences of passing StringRef to Printf. Hopefully these will all disappear in the future once we move to formatv. Modified:

[Lldb-commits] [lldb] r289164 - Modernize the Args access pattern in a few more commands.

2016-12-08 Thread Zachary Turner via lldb-commits
Author: zturner Date: Thu Dec 8 19:08:29 2016 New Revision: 289164 URL: http://llvm.org/viewvc/llvm-project?rev=289164=rev Log: Modernize the Args access pattern in a few more commands. Modified: lldb/trunk/include/lldb/Interpreter/CommandObject.h

[Lldb-commits] [lldb] r289155 - Clean up the new TestInterruptThreadNames test a bit.

2016-12-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Dec 8 17:34:56 2016 New Revision: 289155 URL: http://llvm.org/viewvc/llvm-project?rev=289155=rev Log: Clean up the new TestInterruptThreadNames test a bit. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py

[Lldb-commits] [lldb] r289100 - Fixed a crasher that has been borking out heap for a long time.

2016-12-08 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Thu Dec 8 14:38:19 2016 New Revision: 289100 URL: http://llvm.org/viewvc/llvm-project?rev=289100=rev Log: Fixed a crasher that has been borking out heap for a long time. ThreadList had an assignment operator that didn't lock the "rhs" thread list object. This means a

Re: [Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

2016-12-08 Thread Zachary Turner via lldb-commits
Personally I'm not really a fan of source/line information at all. There is only a very small probability that anyone using a released LLDB (e.g. through Xcode) is going to have their log lines match up with ToT, because we're changing files all the time. You change one thing on line 10, and now

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

2016-12-08 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Seems weird that we are a C++ codebase and we fall back to C macros. We currently need the macro only for file + line and to also not have to worry about doing "if (log) log->". I am not a big fan of macros, but I am open to it if everyone else wants it.

[Lldb-commits] [PATCH] D27459: Straw-man proposal for new logging syntax

2016-12-08 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 80744. labath added a comment. Update the example to the formatv-based API https://reviews.llvm.org/D27459 Files: include/lldb/Core/Error.h include/lldb/Core/Log.h include/lldb/Host/FileSpec.h source/Plugins/Process/Linux/NativeProcessLinux.cpp