[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class

zturner added a comment. Technically it's backed by the error instance, so you could return a `StringRef` as long as you said that its lifetime is tied to the lifetime of the `Error` instance. Not super unreasonable, but also not high priority. I would vote for getting rid of c strings wherev

[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class

clayborg added a comment. You can't add anything extra to the AsCString() since it returns a "const char *". You can't return a StringRef because it isn't backed by anything. You could return a std::string. My vote would be to leave AsCString() alone and have it just return a pointer to the st

[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class

clayborg added a comment. Lets start with this. I would by default just emit the error string and then let users opt in via additional format modifiers to show the "error: " prefix and add the category. https://reviews.llvm.org/D28519 ___ lldb-com

[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class

labath added a comment. I think we should keep the `AsCString` and the formatted output identical, to minimize surprises. So if we want to add category, I think it should go into the `AsCString` as well. https://reviews.llvm.org/D28519 ___ lldb-co

[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class

labath added a comment. I wouldn't put just "error" as it is quite superfluous ("No such file." sounds like an error even without that prefix). And then you don't have the option to remove it if you need it for some reason (unless you add more format options...). I'd keep it without it, as it i

[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class

zturner added inline comments. Comment at: include/lldb/Core/Error.h:308-309 + llvm::StringRef Options) { +llvm::format_provider::format(error.AsCString(), OS, + Options); + } clayborg wro

[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class

clayborg added a comment. See inlined comment. Comment at: include/lldb/Core/Error.h:308-309 + llvm::StringRef Options) { +llvm::format_provider::format(error.AsCString(), OS, + Options); + } ---

[Lldb-commits] [PATCH] D28519: Add format_provider for the Error class

labath created this revision. labath added reviewers: zturner, clayborg. labath added a subscriber: lldb-commits. Herald added a subscriber: mgorny. The formatter supports the same options as the string-like classes, i.e. the ability to truncate the displayed string. I don't anticipate it would be

[Lldb-commits] [lldb] r291563 - XFAIL TestRegisterVariables on gcc-4.8-x86_64

Author: labath Date: Tue Jan 10 08:39:26 2017 New Revision: 291563 URL: http://llvm.org/viewvc/llvm-project?rev=291563&view=rev Log: XFAIL TestRegisterVariables on gcc-4.8-x86_64 I have previously enabled this test for this configuration. However, it turns out it only passes for gcc-4.9. Modifie

[Lldb-commits] [PATCH] D28466: Improve Type::GetTypeScopeAndBasenameHelper and add unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL291559: Improve Type::GetTypeScopeAndBasenameHelper and add unit tests (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D28466?vs=83669&id=83791#toc Repository: rL LLVM h

[Lldb-commits] [lldb] r291559 - Improve Type::GetTypeScopeAndBasenameHelper and add unit tests

Author: tberghammer Date: Tue Jan 10 05:13:59 2017 New Revision: 291559 URL: http://llvm.org/viewvc/llvm-project?rev=291559&view=rev Log: Improve Type::GetTypeScopeAndBasenameHelper and add unit tests Previously it failed to handle nested types inside templated classes making it impossible to loo

[Lldb-commits] [lldb] r291555 - [cmake] Fix LLVM_LINK_LLVM_DYLIB build, again

Author: labath Date: Tue Jan 10 03:40:38 2017 New Revision: 291555 URL: http://llvm.org/viewvc/llvm-project?rev=291555&view=rev Log: [cmake] Fix LLVM_LINK_LLVM_DYLIB build, again The llvm_config hack for lldb-server is only necessary for !DYLIB builds, as otherwise we would get unresolved symbols

[Lldb-commits] [lldb] r291554 - [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

Author: nitesh.jain Date: Tue Jan 10 03:33:43 2017 New Revision: 291554 URL: http://llvm.org/viewvc/llvm-project?rev=291554&view=rev Log: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS Reviewers: labath, clayborg Subscribers: jaydeep, bhushan, lldb-commits, slthakur Differential Revision:

[Lldb-commits] [lldb] r291553 - [LLDB][MIPS] Revert TestLldbGdbServer failure for MIPS

Author: nitesh.jain Date: Tue Jan 10 03:18:56 2017 New Revision: 291553 URL: http://llvm.org/viewvc/llvm-project?rev=291553&view=rev Log: [LLDB][MIPS] Revert TestLldbGdbServer failure for MIPS Removed: lldb/trunk/Python/ Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-serv

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

This revision was automatically updated to reflect the committed changes. Closed by commit rL291549: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D27088?vs=83520&id=83781#toc Repository: rL LLVM https://revi

[Lldb-commits] [lldb] r291549 - [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

Author: nitesh.jain Date: Tue Jan 10 02:20:01 2017 New Revision: 291549 URL: http://llvm.org/viewvc/llvm-project?rev=291549&view=rev Log: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS Reviewers: labath, clayborg Subscribers: jaydeep, bhushan, lldb-commits, slthakur Differential Revision: