zturner added inline comments.
Comment at: source/Core/Log.cpp:78
+ char *text;
+ vasprintf(&text, format, args);
+ message << text;
dancol wrote:
> I usually implement printf-into-std::string by using `vsnprintf` to figure
> out how many characters we genera
dancol added inline comments.
Comment at: source/Core/Log.cpp:78
+ char *text;
+ vasprintf(&text, format, args);
+ message << text;
I usually implement printf-into-std::string by using `vsnprintf` to figure out
how many characters we generate, using `std::str
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D27459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
labath updated this revision to Diff 84690.
labath added a comment.
Final version. No real changes, just removed usage changes in NativeProcessLinux
I will put in as sepearate patches.
https://reviews.llvm.org/D27459
Files:
include/lldb/Core/Log.h
source/Commands/CommandObjectLog.cpp
sour
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We need to check stub_max_size to make sure we don't get an integer underflow.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3999
+ //
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We need to agree on options names and move the object file loading code into
ObjectFile.cpp. See inlined comments.
Comment at: source/Commands/CommandObjectTar
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This looks fine to me. Thanks for cleaning this up!
Repository:
rL LLVM
https://reviews.llvm.org/D28758
___
lldb-commits mailing list
lldb-
abidh created this revision.
LLDB was using packet size advertised by the target as the max memory size to
write in one go. It is wrong because packets have other overhead apart from
memory payload. Also memory transferred through 'm' and 'M' packets needs 2
bytes in packet to transfer 1 of mem
abidh created this revision.
For bare-metal targets, lldb was missing a command like 'load' in gdb which can
be used to create executable image on the target. This was discussed in
http://lists.llvm.org/pipermail/lldb-dev/2016-December/011752.html
This diff adds an option to "target module load
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292212: [cmake] Make lldb build with the android ndk
toolchain file (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D28775?vs=84571&id=84651#toc
Repository:
rL LLVM
https://r
Author: labath
Date: Tue Jan 17 05:55:00 2017
New Revision: 292212
URL: http://llvm.org/viewvc/llvm-project?rev=292212&view=rev
Log:
[cmake] Make lldb build with the android ndk toolchain file
Summary:
The NDK cmake toolchain file defines CMAKE_SYSTEM_NAME=Android, so switch the
build to use that
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D28775
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
12 matches
Mail list logo
