[Lldb-commits] [lldb] r297259 - Back to xfailing this. For some reason on our buildbots

Author: jmolenda Date: Wed Mar 8 00:45:34 2017 New Revision: 297259 URL: http://llvm.org/viewvc/llvm-project?rev=297259=rev Log: Back to xfailing this. For some reason on our buildbots it fails, but it works on the local workstations. I'll need to figure out what the difference is between

[Lldb-commits] [lldb] r297258 - TestQueues should be passing again, remove the expected fail.

Author: jmolenda Date: Tue Mar 7 23:51:00 2017 New Revision: 297258 URL: http://llvm.org/viewvc/llvm-project?rev=297258=rev Log: TestQueues should be passing again, remove the expected fail. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py Modified:

Re: [Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

I can run build TargetTests though (I guess it doesn't depend on editline), and that one passes. On Tue, Mar 7, 2017 at 2:26 PM Zachary Turner wrote: > = > Issue Details > = > UNEXPECTED SUCCESS: test_and_run_command_dwarf >

Re: [Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

= Issue Details = UNEXPECTED SUCCESS: test_and_run_command_dwarf (lang/c/register_variables/TestRegisterVariables.py) UNEXPECTED SUCCESS: test_and_run_command_dwo (lang/c/register_variables/TestRegisterVariables.py) UNEXPECTED SUCCESS: test_dwarf

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

This revision was automatically updated to reflect the committed changes. Closed by commit rL297231: Make LLDB skip server-client roundtrip for signals that don't require any… (authored by eugene). Changed prior to commit: https://reviews.llvm.org/D30520?vs=90921=90930#toc Repository: rL

[Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. OK, let's give this another shot. (I haven't tried it on linux yet, so if you haven't either then let's wait until tomorrow, or maybe @eugene could try it out (?)). I don't think we need to

[Lldb-commits] [lldb] r297231 - Make LLDB skip server-client roundtrip for signals that don't require any actions

Author: eugene Date: Tue Mar 7 15:34:40 2017 New Revision: 297231 URL: http://llvm.org/viewvc/llvm-project?rev=297231=rev Log: Make LLDB skip server-client roundtrip for signals that don't require any actions If QPassSignals packaet is supported by lldb-server, lldb-client will utilize it and

[Lldb-commits] [PATCH] D30702: Fix remaining threading issues in Log.h

zturner added inline comments. Comment at: source/Utility/Log.cpp:90-91 uint32_t options, uint32_t flags) { - log.GetMask().Set(flags); - if (log.GetMask().Get()) { -log.GetOptions().Reset(options); + uint32_t mask =

[Lldb-commits] [lldb] r297228 - fix format specifier warnings

Author: penryu Date: Tue Mar 7 15:26:04 2017 New Revision: 297228 URL: http://llvm.org/viewvc/llvm-project?rev=297228=rev Log: fix format specifier warnings Modified: lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

labath accepted this revision. labath added a comment. Thank you. https://reviews.llvm.org/D30520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D30702: Fix remaining threading issues in Log.h

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. With my limited std::atomic experience, this seems fine. https://reviews.llvm.org/D30702 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

eugene updated this revision to Diff 90921. eugene added a comment. Rename ASSERT_EQ_ARRAYS to EXPECT_EQ_ARRAYS https://reviews.llvm.org/D30520 Files: include/lldb/Target/Process.h include/lldb/Target/UnixSignals.h source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

[Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

zturner updated this revision to Diff 90905. zturner added a comment. Fixed all the outstanding issues. I simplified the logic in `ModuleCache`, but I think it makes more sense this way, and the unit tests still pass. If we really care about the case where we want to create a directory on top

Re: [Lldb-commits] [lldb] r297139 - Revert "Use LLVM for all stat-related functionality."

Thanks, Pavel. I think if we do this again we should indirect the new API through the LLDB FileSpec API or at least a global function somewhere in LLDB, so that we can change implementations without having to touch so much source code. Sean > On Mar 7, 2017, at 5:19 AM, Pavel Labath via

[Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:197 + namespace fs = llvm::sys::fs; + if (fs::get_file_type(local_path_spec.GetPath(), false) != + fs::file_type::symlink_file) labath wrote: > labath

[Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

labath added a comment. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:197 + namespace fs = llvm::sys::fs; + if (fs::get_file_type(local_path_spec.GetPath(), false) != + fs::file_type::symlink_file) labath wrote: > This still

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

clayborg added a comment. How does VSDO get loaded when debugging a normal process? In the core file case you probably need to create the VSDO module from memory by locating it somehow and add it to the target before the dynamic loader goes looking for it. Wouldn't that fix the issue?

[Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

zturner created this revision. Herald added a subscriber: emaste. This was broken due to LLVM's stat code following symlinks. I've added an option on the LLVM side to not follow symlinks and updated this patch to use it everywhere possible. The cases I couldn't get were where LLDB calls

[Lldb-commits] [PATCH] D30574: Android.rules: add support for clang compiler

This revision was automatically updated to reflect the committed changes. Closed by commit rL297145: Android.rules: add support for clang compiler (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30574?vs=90477=90850#toc Repository: rL LLVM

[Lldb-commits] [lldb] r297145 - Android.rules: add support for clang compiler

Author: labath Date: Tue Mar 7 08:57:37 2017 New Revision: 297145 URL: http://llvm.org/viewvc/llvm-project?rev=297145=rev Log: Android.rules: add support for clang compiler Summary: building executables with the NDK clang requires -target and -gcc-toolchain arguments. Reviewers: eugene,

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

labath added a comment. Thank you for updating that. Let me know what the make_core investigation uncovers. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:164 + case llvm::Triple::mips64el: +const RegisterContextLinux_mips64

Re: [Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.

Yea, that would do the trick. On 7 March 2017 at 14:47, Zachary Turner wrote: > I think i can address this by adding a bool to llvm::sys::fs::status which > indicates whether to follow symlinks > > On Tue, Mar 7, 2017 at 5:41 AM Pavel Labath via Phabricator >

Re: [Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.

I think i can address this by adding a bool to llvm::sys::fs::status which indicates whether to follow symlinks On Tue, Mar 7, 2017 at 5:41 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > Zachary, unfortunately I had to revert this -- while

[Lldb-commits] [PATCH] D29581: Initial implementation of SB APIs for Tracing support.

ravitheja added inline comments. Comment at: include/lldb/API/SBTraceOptions.h:38 + /// They should be formatted as a JSON Array. + void setTraceParams(lldb::SBStream ); + clayborg wrote: > This should probably be: > > ``` > void

[Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.

labath added a comment. Zachary, unfortunately I had to revert this -- while investigating the breakages I've found a problem I don't think any of us realised -- llvm's statting code is based on stat(2), while lldb uses lstat(2). I think we need to go back and re-audit each case to see whether

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

labath added a comment. The VDSO is a pretty standard shared library in most aspects -- it contains the implementations of a couple of functions whose implementation can depend on the specific hardware revision (the fastest way to make a syscall, the fastest way to obtain system time, etc.).

[Lldb-commits] [lldb] r297139 - Revert "Use LLVM for all stat-related functionality."

Author: labath Date: Tue Mar 7 07:19:15 2017 New Revision: 297139 URL: http://llvm.org/viewvc/llvm-project?rev=297139=rev Log: Revert "Use LLVM for all stat-related functionality." this reverts r297116 because it breaks the unittests and TestCompDirSymlink. The ModuleCache unit test is

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

nitesh.jain added a comment. In https://reviews.llvm.org/D30454#693614, @clayborg wrote: > So a ModuleSpec allows you to specify a module by path, UUID and many other > things. This is falling down for a magic file that doesn't actually exist > right? Yes. > "vsdo" is just a made up

[Lldb-commits] [PATCH] D30520: Make LLDB skip server-client roundtrip for signals that don't require any actions

labath added a comment. Comment at: unittests/Signals/UnixSignalsTest.cpp:43 + +#define ASSERT_EQ_ARRAYS(expected, observed) \ + AssertEqArrays((expected), (observed), __FILE__, __LINE__); eugene wrote: > labath wrote: > >

[Lldb-commits] [lldb] r297128 - Fixed a missing brace.

Author: spyffe Date: Tue Mar 7 02:31:41 2017 New Revision: 297128 URL: http://llvm.org/viewvc/llvm-project?rev=297128=rev Log: Fixed a missing brace. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp Modified: