[Lldb-commits] [PATCH] D30927: Normalize the LLVM cmake path before appending it to the module path

hughbe updated this revision to Diff 91676. hughbe added a comment. Address feedback from Zachary Turner https://reviews.llvm.org/D30927 Files: cmake/modules/LLDBStandalone.cmake Index: cmake/modules/LLDBStandalone.cmake ===

Re: [Lldb-commits] [PATCH] D30927: Normalize the LLVM cmake path before appending it to the module path

Shouldn't this be file(TO_CMAKE_PATH...)? On Mon, Mar 13, 2017 at 9:09 PM Hugh Bellamy via Phabricator via lldb-commits wrote: > hughbe updated this revision to Diff 91668. > hughbe added a comment. > > Fix preview > > > https://reviews.llvm.org/D30927 > > Files: >

Re: [Lldb-commits] [PATCH] D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB

Lgtm, no need to request a review for these kind of trivial warning fixes On Mon, Mar 13, 2017 at 9:11 PM Hugh Bellamy via Phabricator via lldb-commits wrote: > hughbe updated this revision to Diff 91670. > hughbe added a comment. > > Fix file names > > >

[Lldb-commits] [PATCH] D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB

hughbe updated this revision to Diff 91670. hughbe added a comment. Fix file names https://reviews.llvm.org/D30926 Files: source/Core/FormatEntity.cpp Index: source/Core/FormatEntity.cpp === --- source/Core/FormatEntity.cpp

[Lldb-commits] [PATCH] D30927: Normalize the LLVM cmake path before appending it to the module path

hughbe created this revision. hughbe added a project: LLDB. Herald added a subscriber: mgorny. LLVM_CMAKE_PATH has backlashes in it. CMake then tries to append this to CMAKE_MODULE_PATH but gets confused and errors out as it thinks we're providing an escape sequence (that's unknown, causing

[Lldb-commits] [PATCH] D30927: Normalize the LLVM cmake path before appending it to the module path

hughbe updated this revision to Diff 91668. hughbe added a comment. Fix preview https://reviews.llvm.org/D30927 Files: cmake/modules/LLDBStandalone.cmake Index: cmake/modules/LLDBStandalone.cmake === ---

[Lldb-commits] [PATCH] D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB

hughbe created this revision. I've been porting swift-lldb to Windows/MSVC, and encountered some size_t/unsigned implicit conversion warnings. I sent a PR (https://github.com/apple/swift-lldb/pull/161) and @jimingham suggested I push some of them here. Repository: rL LLVM

[Lldb-commits] [lldb] r297701 - update.

Author: jmolenda Date: Mon Mar 13 22:28:27 2017 New Revision: 297701 URL: http://llvm.org/viewvc/llvm-project?rev=297701=rev Log: update. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r297691 - [debugserver] NFC. Missed one bit of cleanup in r297688

Author: cbieneman Date: Mon Mar 13 18:46:50 2017 New Revision: 297691 URL: http://llvm.org/viewvc/llvm-project?rev=297691=rev Log: [debugserver] NFC. Missed one bit of cleanup in r297688 I did this cleanup in the x86_64, but missed it in the i386 code. This just simplifies the calls to

[Lldb-commits] [lldb] r297688 - [debugserver] NFC. Cleanup DNBArchImpl*::GetFPUState()

Author: cbieneman Date: Mon Mar 13 18:27:58 2017 New Revision: 297688 URL: http://llvm.org/viewvc/llvm-project?rev=297688=rev Log: [debugserver] NFC. Cleanup DNBArchImpl*::GetFPUState() This patch consolidates the DEBUG_FPU_REGS code for i386 and x86_64 to take advantage of the fact that the

[Lldb-commits] [lldb] r297685 - [debugserver] This is a small cleanup patch to AVX support detection

Author: cbieneman Date: Mon Mar 13 18:19:04 2017 New Revision: 297685 URL: http://llvm.org/viewvc/llvm-project?rev=297685=rev Log: [debugserver] This is a small cleanup patch to AVX support detection Summary: The first Sandybridge iMacs with AVX support shipped in Spring 2011 with Snow Leopard

[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

This revision was automatically updated to reflect the committed changes. Closed by commit rL297685: [debugserver] This is a small cleanup patch to AVX support detection (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D30918?vs=91644=91645#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. looks good to me. Comment at: tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp:66 + int error = ::sysctlbyname(feature, , _size, NULL, 0); + return

[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

beanz updated this revision to Diff 91643. beanz added a comment. Updates based on feedback from Jason and Zachary. https://reviews.llvm.org/D30918 Files: tools/debugserver/debugserver.xcodeproj/project.pbxproj tools/debugserver/source/MacOSX/CMakeLists.txt

[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

zturner added inline comments. Comment at: tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp:66 + int error = ::sysctlbyname(feature, , _size, NULL, 0); + return !error & answer; +} jasonmolenda wrote: > I see what you're doing -- this can either

[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

jasonmolenda added a comment. Hah, I misread what the 'buffer[first_letter] & 0x40' line was doing still. Maybe use isupper() here instead of the bitmask? https://reviews.llvm.org/D30918 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

jasonmolenda requested changes to this revision. jasonmolenda added a comment. This revision now requires changes to proceed. Looks good, a few small suggestions from reading the code afresh. I'm not sure how many open source contributors we may have running macOS 10.6 or earlier (or macOS

[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

beanz updated this revision to Diff 91640. beanz added a comment. Removing some extra changes that accidentally came along for the ride in my initial upload. https://reviews.llvm.org/D30918 Files: tools/debugserver/debugserver.xcodeproj/project.pbxproj

[Lldb-commits] [PATCH] D30918: [debugserver] This is a small cleanup patch to AVX support detection

beanz created this revision. Herald added a subscriber: mgorny. The first Sandybridge iMacs with AVX support shipped in Spring 2011 with Snow Leopard as their OS. Unfortunately due to a kernel bug debugging AVX code was not really possible until 10.7.4. The old code here checked the kernel

[Lldb-commits] [lldb] r297640 - Fix up some enumerate() callsites in LLDB.

Author: zturner Date: Mon Mar 13 12:12:12 2017 New Revision: 297640 URL: http://llvm.org/viewvc/llvm-project?rev=297640=rev Log: Fix up some enumerate() callsites in LLDB. Modified: lldb/trunk/source/Commands/CommandObjectArgs.cpp lldb/trunk/source/Commands/CommandObjectType.cpp

[Lldb-commits] [lldb] r297637 - Fix another occurrence of needing to use member accessors.

Author: zturner Date: Mon Mar 13 11:39:00 2017 New Revision: 297637 URL: http://llvm.org/viewvc/llvm-project?rev=297637=rev Log: Fix another occurrence of needing to use member accessors. Modified: lldb/trunk/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp Modified:

[Lldb-commits] [PATCH] D30844: pthread_setname_np first appeared in glibc 2.12

jroelofs closed this revision. jroelofs added a comment. r297626 https://reviews.llvm.org/D30844 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r297626 - Delete dead code. NFC

Author: jroelofs Date: Mon Mar 13 10:25:01 2017 New Revision: 297626 URL: http://llvm.org/viewvc/llvm-project?rev=297626=rev Log: Delete dead code. NFC Also has the side-effect of fixing the build on systems with glibc < 2.12 https://reviews.llvm.org/D30844 Modified:

[Lldb-commits] [PATCH] D30844: pthread_setname_np first appeared in glibc 2.12

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. thank you. https://reviews.llvm.org/D30844 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D30844: pthread_setname_np first appeared in glibc 2.12

jroelofs updated this revision to Diff 91566. jroelofs added a comment. It builds, so the code was dead anyway. Didn't re-run the tests. https://reviews.llvm.org/D30844 Files: include/lldb/Host/linux/HostThreadLinux.h source/Host/linux/HostThreadLinux.cpp Index:

[Lldb-commits] [PATCH] D30844: pthread_setname_np first appeared in glibc 2.12

labath added a comment. In https://reviews.llvm.org/D30844#699265, @jroelofs wrote: > > If you want to get your build working, I suggest you just remove the > > setting code. > > @labath I have my local build working, but I don't want to carry local > patches if possible. Yes, that's what I

[Lldb-commits] [PATCH] D30894: Remove lldb streams from the Log class completely

labath created this revision. Herald added a subscriber: emaste. previously we switched to llvm streams for log output, this completes the switch for the error streams. I also clean up the includes and remove the unused argument from DisableAllLogChannels(). This required adding a bit of boiler

[Lldb-commits] [PATCH] D30844: pthread_setname_np first appeared in glibc 2.12

jroelofs added a comment. > If you want to get your build working, I suggest you just remove the setting > code. @labath I have my local build working, but I don't want to carry local patches if possible. How about the original patch, which adds the glibc 2.12 check: void

Re: [Lldb-commits] [PATCH] D30844: pthread_setname_np first appeared in glibc 2.12

On 13 March 2017 at 12:35, Zachary Turner wrote: > Can we just copy the non portable system call to this location and inline it > here with appropriate glibc check so that we can still delete all that other > obsolete code? > That makes sense. I think that code belongs in

Re: [Lldb-commits] [PATCH] D30844: pthread_setname_np first appeared in glibc 2.12

Can we just copy the non portable system call to this location and inline it here with appropriate glibc check so that we can still delete all that other obsolete code? On Mon, Mar 13, 2017 at 4:28 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath requested changes to

[Lldb-commits] [PATCH] D30737: Android.rules: Add libc++ support

This revision was automatically updated to reflect the committed changes. Closed by commit rL297616: Android.rules: Add libc++ support (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30737?vs=91018=91540#toc Repository: rL LLVM https://reviews.llvm.org/D30737

[Lldb-commits] [lldb] r297616 - Android.rules: Add libc++ support

Author: labath Date: Mon Mar 13 07:07:48 2017 New Revision: 297616 URL: http://llvm.org/viewvc/llvm-project?rev=297616=rev Log: Android.rules: Add libc++ support Summary: This adds support for building libc++ tests when targetting android. The tests are still not passing due to several other

[Lldb-commits] [PATCH] D30779: dotest.py: remove the ability to specify different architectures/compilers in a single invocation

labath added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:1204 +os.environ["ARCH"] = configuration.arch +os.environ["CC"] = configuration.compiler +configString = "arch=%s compiler=%s" % (configuration.arch, zturner wrote: >

[Lldb-commits] [PATCH] D30817: BreakpointResolverFileLine: Correct treatment of move-to-nearest-code for multiple modules

labath added a comment. I like the idea of using the function declaration line, as it will solve a couple of other corner cases also (we've had one user try to set a breakpoint on a macro definition and expect that to work). I'll try to implement that instead. https://reviews.llvm.org/D30817

[Lldb-commits] [lldb] r297615 - Fix windows build broken by r297612

Author: labath Date: Mon Mar 13 06:23:59 2017 New Revision: 297615 URL: http://llvm.org/viewvc/llvm-project?rev=297615=rev Log: Fix windows build broken by r297612 I have got my boolean logic incorrect. Sorry about the spam. Modified: lldb/trunk/source/Host/common/FileSpec.cpp Modified:

[Lldb-commits] [PATCH] D30844: pthread_setname_np first appeared in glibc 2.12

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. We need the getter code to get the name of the threads of the process we are debugging, so this cannot go away. It also probably does not make sense to move this code into llvm, as

[Lldb-commits] [lldb] r297612 - Fix android build

Author: labath Date: Mon Mar 13 05:59:23 2017 New Revision: 297612 URL: http://llvm.org/viewvc/llvm-project?rev=297612=rev Log: Fix android build getpwent is not available on android until API level 21, and even then it is only available when doing a non-static link. Since android's concept of

[Lldb-commits] [lldb] r297609 - Fix Linux build for the FileSpec changes

Author: labath Date: Mon Mar 13 04:46:15 2017 New Revision: 297609 URL: http://llvm.org/viewvc/llvm-project?rev=297609=rev Log: Fix Linux build for the FileSpec changes Propagate changes that were made during review, and fix a couple of warnings while I'm in there. Modified: