[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks fine to me, I don't know the debug_types sections that you're supporting but I read over the code and don't have any problems. Comment at:

[Lldb-commits] [lldb] r300654 - [CMake] Add configure check for sys/event.h

Author: cbieneman Date: Tue Apr 18 21:53:53 2017 New Revision: 300654 URL: http://llvm.org/viewvc/llvm-project?rev=300654=rev Log: [CMake] Add configure check for sys/event.h This enables the kqueue path in MainLoop for Darwin and BSD. Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [lldb] r300647 - One more attempt and Windows

Author: cbieneman Date: Tue Apr 18 20:32:08 2017 New Revision: 300647 URL: http://llvm.org/viewvc/llvm-project?rev=300647=rev Log: One more attempt and Windows This is the last Windows compile error, so... Hit me with your best shot. Modified: lldb/trunk/source/Host/common/MainLoop.cpp

[Lldb-commits] [lldb] r300640 - Another netbsd build failure...

Author: cbieneman Date: Tue Apr 18 20:17:29 2017 New Revision: 300640 URL: http://llvm.org/viewvc/llvm-project?rev=300640=rev Log: Another netbsd build failure... Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modified: lldb/trunk/source/Host/common/MainLoop.cpp URL:

[Lldb-commits] [lldb] r300638 - Buildbot wack-a-mole!

Author: cbieneman Date: Tue Apr 18 20:15:17 2017 New Revision: 300638 URL: http://llvm.org/viewvc/llvm-project?rev=300638=rev Log: Buildbot wack-a-mole! This should fix the netbsd bot I just broke. Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modified:

[Lldb-commits] [lldb] r300636 - ifdefing out the signal handling code on Windows

Author: cbieneman Date: Tue Apr 18 20:00:16 2017 New Revision: 300636 URL: http://llvm.org/viewvc/llvm-project?rev=300636=rev Log: ifdefing out the signal handling code on Windows *fingers crossed* This might fix the Window bots, but I really don't know... Modified:

[Lldb-commits] [lldb] r300618 - Define HAVE_SIGACTION to 1 in Xcode build

Author: cbieneman Date: Tue Apr 18 17:37:00 2017 New Revision: 300618 URL: http://llvm.org/viewvc/llvm-project?rev=300618=rev Log: Define HAVE_SIGACTION to 1 in Xcode build This is needed to make the Xcode project build since it doesn't have auto-generated Config header. Modified:

[Lldb-commits] [lldb] r300615 - Include time.h, and fix a Darwin warning

Author: cbieneman Date: Tue Apr 18 17:11:13 2017 New Revision: 300615 URL: http://llvm.org/viewvc/llvm-project?rev=300615=rev Log: Include time.h, and fix a Darwin warning This is a little more cleanup from r300579. Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modified:

Re: [Lldb-commits] [lldb] r300610 - Fix Windows bot failure

Ah! Missing include then. I'll fix it correctly. -Chris > On Apr 18, 2017, at 3:18 PM, Adrian McCarthy wrote: > > Actually, Windows does have `struct timespec`. It's defined in `` > and ``. > > https://msdn.microsoft.com/en-us/library/mt633792.aspx >

Re: [Lldb-commits] [lldb] r300610 - Fix Windows bot failure

Actually, Windows does have `struct timespec`. It's defined in `` and ``. https://msdn.microsoft.com/en-us/library/mt633792.aspx I suspect somebody had suppressed it for some reason. On Tue, Apr 18, 2017 at 2:47 PM, Chris Bieneman via lldb-commits < lldb-commits@lists.llvm.org> wrote: >

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:197 +ifeq "$(DWARF_TYPE_UNITS)" "YES" + DEBUG_INFO_FLAG ?= -gdwarf-4 +else This shouldn't be necessary on any platform LLDB cares about. DWARF 4 should be the

[Lldb-commits] [lldb] r300610 - Fix Windows bot failure

Author: cbieneman Date: Tue Apr 18 16:47:50 2017 New Revision: 300610 URL: http://llvm.org/viewvc/llvm-project?rev=300610=rev Log: Fix Windows bot failure timespec is not available on Windows, and we should use size_t instead of nfds_t. Modified: lldb/trunk/source/Host/common/MainLoop.cpp

[Lldb-commits] [lldb] r300606 - Fixing error on Android build (-Werror)

Author: cbieneman Date: Tue Apr 18 16:35:26 2017 New Revision: 300606 URL: http://llvm.org/viewvc/llvm-project?rev=300606=rev Log: Fixing error on Android build (-Werror) This is fallout from r300579. Modified: lldb/trunk/source/Host/common/UDPSocket.cpp Modified:

[Lldb-commits] [lldb] r300605 - Removing unused include

Author: cbieneman Date: Tue Apr 18 16:23:55 2017 New Revision: 300605 URL: http://llvm.org/viewvc/llvm-project?rev=300605=rev Log: Removing unused include This is causing the Windows bot failures. Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modified:

[Lldb-commits] [lldb] r300590 - [CMake] Adding configure-time check for sigaction

Author: cbieneman Date: Tue Apr 18 15:49:09 2017 New Revision: 300590 URL: http://llvm.org/viewvc/llvm-project?rev=300590=rev Log: [CMake] Adding configure-time check for sigaction Hopefully this will fix the netbsd bot that I broke... Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [lldb] r300589 - Writing multi-platform code is hard...

Author: cbieneman Date: Tue Apr 18 15:49:05 2017 New Revision: 300589 URL: http://llvm.org/viewvc/llvm-project?rev=300589=rev Log: Writing multi-platform code is hard... Fixing another error from r300579. Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modified:

[Lldb-commits] [lldb] r300587 - Fix broken windows build.

Author: cbieneman Date: Tue Apr 18 15:37:05 2017 New Revision: 300587 URL: http://llvm.org/viewvc/llvm-project?rev=300587=rev Log: Fix broken windows build. This is not ideal, but it should get the bot going again. I'll need to revisit this if we want to get signal handling working on Windows.

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This looks good to me. https://reviews.llvm.org/D32125 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r300582 - Fixing bot failure caused by r300579

Author: cbieneman Date: Tue Apr 18 15:08:29 2017 New Revision: 300582 URL: http://llvm.org/viewvc/llvm-project?rev=300582=rev Log: Fixing bot failure caused by r300579 Modified: lldb/trunk/source/Host/common/Socket.cpp Modified: lldb/trunk/source/Host/common/Socket.cpp URL:

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

labath added a comment. In https://reviews.llvm.org/D32167#729508, @clayborg wrote: > Yeah, I was having trouble getting a real read on what was failing due to a > non Ubuntu setup at work for me. Is there any way to run a patch on one of > the buildbots? If not, can you email me the list of

[Lldb-commits] [PATCH] D31823: Update LLDB Host to support IPv6 over TCP

This revision was automatically updated to reflect the committed changes. Closed by commit rL300579: Update LLDB Host to support IPv6 over TCP (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D31823?vs=95453=95616#toc Repository: rL LLVM

[Lldb-commits] [lldb] r300580 - Update DebugServer to support IPv6 over TCP

Author: cbieneman Date: Tue Apr 18 15:01:59 2017 New Revision: 300580 URL: http://llvm.org/viewvc/llvm-project?rev=300580=rev Log: Update DebugServer to support IPv6 over TCP Summary: This patch adds IPv6 support to debugserver. It follows a similar pattern to the changes proposed for LLDB/Host

[Lldb-commits] [lldb] r300579 - Update LLDB Host to support IPv6 over TCP

Author: cbieneman Date: Tue Apr 18 15:01:52 2017 New Revision: 300579 URL: http://llvm.org/viewvc/llvm-project?rev=300579=rev Log: Update LLDB Host to support IPv6 over TCP Summary: This patch adds IPv6 support to LLDB/Host's TCP socket implementation. Supporting IPv6 involved a few significant

[Lldb-commits] [PATCH] D32184: Teach RenderScriptRuntime about changed context representation.

dgross added a comment. Context representation changed here: https://android-review.googlesource.com/#/c/343816/ New API added here: https://android-review.googlesource.com/#/c/365839/ https://reviews.llvm.org/D32184 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. Yeah, I was having trouble getting a real read on what was failing due to a non Ubuntu setup at work for me. Is there any way to run a patch on one of the buildbots? If not, can you email me the list of what is failing? https://reviews.llvm.org/D32167

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

labath added a comment. The new tests which are not passing need to be disabled -- we cannot have a red tree while this is being developed. https://reviews.llvm.org/D32167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r300564 - Add back code to implement "frame var -a, -l, -g" filters.

Author: jingham Date: Tue Apr 18 11:52:16 2017 New Revision: 300564 URL: http://llvm.org/viewvc/llvm-project?rev=300564=rev Log: Add back code to implement "frame var -a,-l,-g" filters. r285226 dropped the code that did these checks. I am pretty sure that was inadvertent, so I added that back

[Lldb-commits] [PATCH] D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure

clayborg resigned from this revision. clayborg added a reviewer: jingham. clayborg added a comment. Jim, can you take a look at this and see if this could be fixed in a nicer way? I would prefer to not see anything related to delay slots in a test. Can we abstract this better? Maybe ask the

[Lldb-commits] [PATCH] D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure

nitesh.jain created this revision. Herald added a subscriber: arichardson. In case of MIPS, we never add breakpoint in the delay slot. Hence while doing stepping, the delay slot instruction will be skipped. https://reviews.llvm.org/D32168 Files:

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

nitesh.jain added a comment. In https://reviews.llvm.org/D32125#728166, @krytarowski wrote: > Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms 20+ > years ago. > > It's perhaps no-op, but it might be noted in the commit message what > platforms are supposed to be

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

nitesh.jain updated this revision to Diff 95573. nitesh.jain added a comment. Update diff as per suggestion. https://reviews.llvm.org/D32125 Files: cmake/modules/HandleLLVMOptions.cmake Index: cmake/modules/HandleLLVMOptions.cmake

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg created this revision. This patch adds support for type units and parsing the .debug_types section which allows LLDB to debug binaries that were built with "-gdwarf-4 -fdebug-types-section". This patch takes into account how DWARF 5 will represent type units: all compile units will

[Lldb-commits] [lldb] r300548 - Introduce FPR and Debug Registers/NetBSD/amd64 support

Author: kamil Date: Tue Apr 18 07:53:35 2017 New Revision: 300548 URL: http://llvm.org/viewvc/llvm-project?rev=300548=rev Log: Introduce FPR and Debug Registers/NetBSD/amd64 support Summary: This code offers Debug Registers (80386) model in LLDB/amd64. This is initial support and has one issue

[Lldb-commits] [PATCH] D32080: Introduce FPR and Debug Registers/NetBSD/amd64 support

krytarowski added inline comments. Comment at: source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:22 +// clang-format off +#include labath wrote: > It is enough to place an empty line between the block's of includes that > cannot be

[Lldb-commits] [PATCH] D32137: [Utility] Placate another GCC warning

labath added a comment. I am confused. `m_registers_count` is declared as `uint8_t` at `RegisterContextPOSIX_mips64.h:67`... https://reviews.llvm.org/D32137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D32087: Modify GDBRemoteCommunication::ScopedTimeout to not ever decrease a timeout

0 means 0 here. For the time being, we don't have a way to specify infinite gdb timeout. On 15 April 2017 at 15:45, Zachary Turner wrote: > Does 0 mean infinite here? If so are the newly introduced semantics here > still correct? > On Sat, Apr 15, 2017 at 3:34 AM Pavel

[Lldb-commits] [PATCH] D32080: Introduce FPR and Debug Registers/NetBSD/amd64 support

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Comment at: source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:22 +// clang-format off +#include It is enough to place an empty