[Lldb-commits] [PATCH] D32626: Make the symbol demangling loop order independent

scott.smith abandoned this revision. scott.smith added a comment. Turns out I'm planning on making more drastic changes to this loop, so there's no point in reviewing this step. Repository: rL LLVM https://reviews.llvm.org/D32626 ___

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham closed this revision. jingham added a comment. Sure. Closed with r301609. Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r301609 - Provide a mechanism to do some pre-loading of symbols up front.

Author: jingham Date: Thu Apr 27 19:51:06 2017 New Revision: 301609 URL: http://llvm.org/viewvc/llvm-project?rev=301609=rev Log: Provide a mechanism to do some pre-loading of symbols up front. Loading a shared library can require a large amount of work; rather than do that serially for each

[Lldb-commits] [lldb] r301608 - Add a newline to suppress compiler warnings.

Author: jingham Date: Thu Apr 27 19:44:07 2017 New Revision: 301608 URL: http://llvm.org/viewvc/llvm-project?rev=301608=rev Log: Add a newline to suppress compiler warnings. Modified: lldb/trunk/include/lldb/Core/TraceOptions.h Modified: lldb/trunk/include/lldb/Core/TraceOptions.h URL:

[Lldb-commits] [PATCH] D32568: Protect Proces::GetMemoryRegionInfo and ::GetFileLoadAddress with a lock

scott.smith abandoned this revision. scott.smith added a comment. Further testing shows this is not necessary. I'll abandon it. Repository: rL LLVM https://reviews.llvm.org/D32568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32626: Make the symbol demangling loop order independent

jingham added a reviewer: clayborg. jingham added a comment. Adding Greg as a reviewer. You can generally see from the CODE_OWNERS.txt file who has overall responsibility for areas in lldb, and you should at least assign them as a reviewer. For Symbol parsing stuff that's definitely Greg.

[Lldb-commits] [PATCH] D32626: Make the ELF symbol demangling loop order independent

scott.smith added a comment. I welcome any suggestions on how to update the comments near the code I touched. I can make the code functionally the same, but it doesn't mean I know why it's doing what it's doing :-) Comment at: source/Symbol/Symtab.cpp:382 -

[Lldb-commits] [PATCH] D32626: Make the ELF symbol demangling loop order independent

scott.smith created this revision. Currently, the loop will insert entries into the class_contexts set, and then use the absence or presence to affect decisions made by later iterations of the same loop. In order to support parallelizing the loop, this change moves those decisions to always

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith added a comment. Can someone commit this for me? Thanks! Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r301600 - integrate SBTrace changes into Xcode project

Author: penryu Date: Thu Apr 27 18:09:08 2017 New Revision: 301600 URL: http://llvm.org/viewvc/llvm-project?rev=301600=rev Log: integrate SBTrace changes into Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

clayborg accepted this revision. clayborg added a comment. Looks good. Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32600: Resurrect pselect MainLoop implementation

zturner added inline comments. Comment at: source/Host/common/MainLoop.cpp:135 + +template void MainLoop::RunImpl::ForEachReadFD(F &) { + assert(num_events >= 0); Why do we need this function? Just have a function that returns an `ArrayRef` and let the

[Lldb-commits] [PATCH] D32600: Resurrect pselect MainLoop implementation

eugene added inline comments. Comment at: source/Host/common/MainLoop.cpp:82 + int queue_id; + std::vector events; + struct kevent event_list[4]; here and below struct seems to be redundant https://reviews.llvm.org/D32600

[Lldb-commits] LLVM lab network glitch

Some of builders lost connection with master recently due to network glitch. Thank you for understanding. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks good. Thanks for working on this! Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith updated this revision to Diff 97002. scott.smith added a comment. Add test to print expression (calls func, hence resolves symbols). Also better parameterize the common test to reduce code duplication. Repository: rL LLVM https://reviews.llvm.org/D32598 Files:

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham added a comment. That test is good. That tests the lazy lookup of the dwarf type indices. The other thing this changes is symbol reading. Can you also add a similar test that relies on finding a symbol in a shared library we might not have read in? It probably fine to add it to

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith updated this revision to Diff 96991. scott.smith added a comment. Fix default param to setup_common so that we actually test both paths. Repository: rL LLVM https://reviews.llvm.org/D32598 Files: include/lldb/Core/Module.h include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith updated this revision to Diff 96990. scott.smith added a comment. 1. Rename to preload-symbols / PreloadSymbols() 2. Modify an existing test to run with and without symbol preloading. Repository: rL LLVM https://reviews.llvm.org/D32598 Files: include/lldb/Core/Module.h

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham added a comment. Yes, I like that better too. Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r301581 - Fixing Windows bot

Author: cbieneman Date: Thu Apr 27 14:56:54 2017 New Revision: 301581 URL: http://llvm.org/viewvc/llvm-project?rev=301581=rev Log: Fixing Windows bot URL: http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc2015/builds/8700 Modified: lldb/trunk/include/lldb/Host/PosixApi.h Modified:

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

clayborg added a comment. Would "preload-symbols" be a bit more clear and concise? Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r301579 - Fix GreenDragon bots

Author: cbieneman Date: Thu Apr 27 14:45:13 2017 New Revision: 301579 URL: http://llvm.org/viewvc/llvm-project?rev=301579=rev Log: Fix GreenDragon bots We don't actually need to include Compiler.h here because it is only used on Windows and Windows/PosixAPI.h includes it. Modified:

[Lldb-commits] [lldb] r301580 - NFC. Add comment about debugserver usage

Author: cbieneman Date: Thu Apr 27 14:45:16 2017 New Revision: 301580 URL: http://llvm.org/viewvc/llvm-project?rev=301580=rev Log: NFC. Add comment about debugserver usage This just adds a comment to SocketAddress about it being used by debugserver and the implications of that. If we need to

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This is picky but can you call it "symbol-cache-priming". The help text explains it, but this is a very specific cache so we should scope it in case we have some other one later

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham added a comment. Ah, sorry. I was talking about an lldb, which you access through the "setting set/get" command. Those are actually implemented by adding a property on the class in question. Look in Target.cpp for the TargetProperties class. You'll just want to add another property

Re: [Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

"(lldb) settings set target.cache-priming foo" On Thu, Apr 27, 2017 at 11:53 AM Scott Smith via Phabricator via lldb-commits wrote: > scott.smith added a comment. > > In https://reviews.llvm.org/D32598#739804, @jingham wrote: > > > Instead of having the cache priming

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith added a comment. In https://reviews.llvm.org/D32598#739779, @clayborg wrote: > Making an empty main program and saying I see no difference is not enough > testing to enable this. It's not quite an empty main program; it links in 40+ shared libraries with 2M+ symbols. The point

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Instead of having the cache priming be determined by platform or something like that, it would be better to add a setting (on the target level seems right) that controls this. I

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

clayborg added a comment. Making an empty main program and saying I see no difference is not enough testing to enable this. I also don't see the benefit of this path. When LLDB is used for symbolication, it might never actually load any debug info or symbols from modules that are added to a

[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

krytarowski added a comment. In https://reviews.llvm.org/D32149#739727, @labath wrote: > In https://reviews.llvm.org/D32149#738250, @krytarowski wrote: > > > ping? > > > Sorry, I wasn't responding partially because I was waiting to see how the > discussion on https://reviews.llvm.org/D32434

[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

labath added a comment. In https://reviews.llvm.org/D32149#738250, @krytarowski wrote: > ping? Sorry, I wasn't responding partially because I was waiting to see how the discussion on https://reviews.llvm.org/D32434 settles, as I think it may have effect on the test strategy. I'll write more

[Lldb-commits] [PATCH] D32600: Resurrect pselect MainLoop implementation

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This looks like a nice improvement. There are some formatting inconsistencies, can you run clang-format? https://reviews.llvm.org/D32600 ___

[Lldb-commits] [PATCH] D32568: Protect Proces::GetMemoryRegionInfo and ::GetFileLoadAddress with a lock

labath added a comment. In https://reviews.llvm.org/D32568#739607, @scott.smith wrote: > In https://reviews.llvm.org/D32568#739190, @labath wrote: > > > This is not necessary. NativeProcess classes are only used in lldb-server, > > which is completely single threaded. If you want to change

[Lldb-commits] [PATCH] D32600: Resurrect pselect MainLoop implementation

labath created this revision. Herald added a subscriber: srhines. It turns out that even though ppoll is available on all the android devices we support, it does not seem to be working properly on all of them -- MainLoop just does a busy loop with ppoll returning EINTR and not making any

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

jingham added a reviewer: clayborg. jingham added a comment. Adding Greg as a Reviewer. Repository: rL LLVM https://reviews.llvm.org/D32598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Couple tiny tweaks to the comment, and this is good to go. Comment at: include/lldb/API/SBInstructionList.h:36-38 + // Its return the number of instructions

[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

scott.smith added a comment. Here's the controversial patch. It has been brought up that the intent is to not load symbols before they are needed, but at least in my experience this patch has no effect on performance when running: lldb -b -o run /path/to/myprogram where myprogram has

[Lldb-commits] [PATCH] D32597: Initiate loading of shared libraries in parallel

scott.smith created this revision. This change forks a thread for each shared library, so that as much work as possible can be done in parallel. Repository: rL LLVM https://reviews.llvm.org/D32597 Files: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp

[Lldb-commits] [PATCH] D32568: Protect Proces::GetMemoryRegionInfo and ::GetFileLoadAddress with a lock

scott.smith added a comment. In https://reviews.llvm.org/D32568#739190, @labath wrote: > This is not necessary. NativeProcess classes are only used in lldb-server, > which is completely single threaded. If you want to change that, then we > should start with a discussion of what you intend to

[Lldb-commits] [PATCH] D32306: Remove lock from ConstString::GetLength

scott.smith marked 3 inline comments as done. scott.smith added inline comments. Comment at: source/Utility/ConstString.cpp:49 + // pointer, we don't need the lock. const StringPoolEntryType = GetStringMapEntryFromKeyData(ccstr); return entry.getKey().size();

[Lldb-commits] [lldb] r301559 - Update GDB remote command regex for IPv6

Author: cbieneman Date: Thu Apr 27 11:13:58 2017 New Revision: 301559 URL: http://llvm.org/viewvc/llvm-project?rev=301559=rev Log: Update GDB remote command regex for IPv6 This updates the regular expression used to match host/port pairs for the gdb-remote command to also match IPv6 addresses.

[Lldb-commits] [lldb] r301553 - [CMake] Abstract Config.h generation for Xcode

Author: cbieneman Date: Thu Apr 27 11:04:26 2017 New Revision: 301553 URL: http://llvm.org/viewvc/llvm-project?rev=301553=rev Log: [CMake] Abstract Config.h generation for Xcode This patch abstracts the generation of Config.h and creates a dummy project entry point to allow generation of LLDB's

Re: [Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

Thanks, I will give it a try! On 27.04.2017 17:59, Zachary Turner wrote: > In case it's not obvious, note the space in the command I said to run. > `git-clang-format` has a dash, and when you run `git clang-format` > (with a space), it will run the file with the dash. > > On Thu, Apr 27, 2017

Re: [Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

In case it's not obvious, note the space in the command I said to run. `git-clang-format` has a dash, and when you run `git clang-format` (with a space), it will run the file with the dash. On Thu, Apr 27, 2017 at 8:58 AM Zachary Turner wrote: > There is a file in the repo

[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

krytarowski added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:302 + // default 32 or 64 bit arch (without any architecture revision) based on + // object file's class. if (header.e_type == ET_CORE) { joerg wrote: > Unrelated

[Lldb-commits] [PATCH] D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure

clayborg added inline comments. Comment at: include/lldb/API/SBInstructionList.h:36-38 + // Its return the number of instructions between start and end address + // if canSetBreakpoint is true then count will correspond to + // number of instructions on which breakpoint can

[Lldb-commits] [PATCH] D32585: Implementation of remote packets for Trace data.

clayborg added a comment. This patch does nicely follow the way other GDB remote packets are implemented. I wonder if we should just have a "jTrace" packet that is JSON from the start? This is more of a question to anyone that cares about the direction of the GDB remote protocol we are using.

[Lldb-commits] [PATCH] D32584: Fixing the build break introduced by the change in LangStandard in clang

clayborg added a comment. looks fine https://reviews.llvm.org/D32584 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

joerg added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:55 const char *const LLDB_NT_OWNER_NETBSD = "NetBSD"; +const char *const LLDB_NT_OWNER_NETBSDCORE = "NetBSD-CORE"; const char *const LLDB_NT_OWNER_OPENBSD = "OpenBSD"; Not

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

nitesh.jain added a comment. Hi Ki, The changes has been committed (https://reviews.llvm.org/rL301537). Thanks Repository: rL LLVM https://reviews.llvm.org/D32340 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r301537 - [LLDB][MIPS] Forgot to add check in commit rl301530

Author: nitesh.jain Date: Thu Apr 27 07:27:42 2017 New Revision: 301537 URL: http://llvm.org/viewvc/llvm-project?rev=301537=rev Log: [LLDB][MIPS] Forgot to add check in commit rl301530 Reviewers: ki.stfu, labath Subscribers: jaydeep, bhushan, lldb-commits, slthakur Modified:

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

nitesh.jain added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:329 +# We need to get past these instructions with a step to reach call to s_MyFunction. +self.runCmd("-exec-step --thread 1")

[Lldb-commits] [lldb] r301534 - TCPSocket: add back support for "*" address

Author: labath Date: Thu Apr 27 06:32:25 2017 New Revision: 301534 URL: http://llvm.org/viewvc/llvm-project?rev=301534=rev Log: TCPSocket: add back support for "*" address before r301492, we could specify "*:1234" as an address to lldb-server and it would interpret that as "any". I am not sure

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

ki.stfu added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:329 +# We need to get past these instructions with a step to reach call to s_MyFunction. +self.runCmd("-exec-step --thread 1")

[Lldb-commits] [PATCH] D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure

nitesh.jain updated this revision to Diff 96891. nitesh.jain added a comment. Update Diff as per suggestion https://reviews.llvm.org/D32168 Files: include/lldb/API/SBAddress.h include/lldb/API/SBInstruction.h include/lldb/API/SBInstructionList.h include/lldb/Core/Disassembler.h

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

This revision was automatically updated to reflect the committed changes. Closed by commit rL301530: [LLDB][MIPS] Fix TestMiExec.py failure. (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D32340?vs=96368=96890#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D32568: Protect Proces::GetMemoryRegionInfo and ::GetFileLoadAddress with a lock

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This is not necessary. NativeProcess classes are only used in lldb-server, which is completely single threaded. If you want to change that, then we should start with a discussion of

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

vbalu updated this revision to Diff 96878. vbalu added a comment. Removed the changes from test frame work. https://reviews.llvm.org/D32522 Files: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py Index: