[Lldb-commits] [lldb] r309429 - [CMake] Add SharingPtr.h to the Framework header list

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 13:27:38 2017 New Revision: 309429 URL: http://llvm.org/viewvc/llvm-project?rev=309429=rev Log: [CMake] Add SharingPtr.h to the Framework header list lldb-forward.h which is a public header uses SharingPtr, so we need to include that header as well. Modified:

[Lldb-commits] [lldb] r309428 - [CMake] debugserver-nonui doesn't go in the framework

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 13:27:37 2017 New Revision: 309428 URL: http://llvm.org/viewvc/llvm-project?rev=309428=rev Log: [CMake] debugserver-nonui doesn't go in the framework Small change to correct the install path of the nonui debugserver. Modified:

[Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

2017-07-28 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. It would be nice to auto detect the names correctly? Comment at: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp:389 + struct __lldb_dlopen_result { void *image_ptr; const char *error_str; } the_result; +

[Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

2017-07-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp:389 + struct __lldb_dlopen_result { void *image_ptr; const char *error_str; } the_result; + the_result.image_ptr = __dl_dlopen ("%s", 2);

[Lldb-commits] [PATCH] D35740: Fix PR33875 by distinguishing between DWO and clang modules

2017-07-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I looked at this briefly last week but I could not find a good fix in the amount of time I had left. This fixes the current test failure, but it does not fix the underlying bug, which is that we (sometimes?) set the compile unit offset for non-dwo, non-dsym DIEs as 0.

[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

2017-07-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added a reviewer: eugene. labath added a comment. I am not able to test this right now. Eugene, can you take a look? Comment at: tools/lldb-server/lldb-gdbserver.cpp:241 + std::unique_ptr connection_up; + if (connection_fd != -1) { +// Build the connection string.

[Lldb-commits] [lldb] r309396 - [CMake] libcompression is optional not required for debugserver

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 08:44:16 2017 New Revision: 309396 URL: http://llvm.org/viewvc/llvm-project?rev=309396=rev Log: [CMake] libcompression is optional not required for debugserver Fix a quick bug from r309395. Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt

[Lldb-commits] [lldb] r309395 - [CMake] Add checks for libcompression

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 08:39:51 2017 New Revision: 309395 URL: http://llvm.org/viewvc/llvm-project?rev=309395=rev Log: [CMake] Add checks for libcompression This enables libcompression when available in the CMake build system. Modified:

[Lldb-commits] [lldb] r309392 - [CMake] Adapt to clang r309390

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 08:39:49 2017 New Revision: 309392 URL: http://llvm.org/viewvc/llvm-project?rev=309392=rev Log: [CMake] Adapt to clang r309390 This removes the configuration order dependence between LLDB and Clang. Modified: lldb/trunk/cmake/modules/AddLLDB.cmake

[Lldb-commits] [lldb] r309393 - [CMake] Enable OS_LOG support on Darwin

2017-07-28 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Fri Jul 28 08:39:50 2017 New Revision: 309393 URL: http://llvm.org/viewvc/llvm-project?rev=309393=rev Log: [CMake] Enable OS_LOG support on Darwin This gets CMake to match the Xcode project build Modified: lldb/trunk/CMakeLists.txt Modified: