[Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

labath updated this revision to Diff 120714. labath added a comment. rename argument to normalized_triple, check that the architecture is not empty. https://reviews.llvm.org/D39387 Files: include/lldb/Core/ArchSpec.h include/lldb/Host/HostInfoBase.h include/lldb/Target/Platform.h

[Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

zturner added inline comments. Comment at: source/Core/ArchSpec.cpp:890 +bool ArchSpec::ContainsOnlyArch(const llvm::Triple ) { + return triple.getOSName().empty() && + triple.getVendorName().empty() && Should you also add

[Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

labath updated this revision to Diff 120712. labath added a comment. Address review comments https://reviews.llvm.org/D39387 Files: include/lldb/Core/ArchSpec.h include/lldb/Host/HostInfoBase.h include/lldb/Target/Platform.h packages/Python/lldbsuite/test/source-manager/main.c

[Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

labath marked 3 inline comments as done. labath added inline comments. Comment at: include/lldb/Target/Platform.h:524 + //--- + ArchSpec GetAugmentedArchSpec(llvm::StringRef triple); +

[Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

rsmith added a comment. In https://reviews.llvm.org/D39307#907358, @xiaobai wrote: > It seems like clang shouldn't even be asking us about this in the first > place, but I don't fully understand why it's trying to do what it's trying to > do. It looks like there are two issues here: clang is

[Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

zturner added inline comments. Comment at: source/Target/Platform.cpp:986-991 +if (normalized_triple.getVendorName().empty()) + normalized_triple.setVendor(compatible_triple.getVendor()); +if (normalized_triple.getOSName().empty()) +

[Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

zturner added inline comments. Comment at: source/Target/Platform.cpp:986-991 +if (normalized_triple.getVendorName().empty()) + normalized_triple.setVendor(compatible_triple.getVendor()); +if (normalized_triple.getOSName().empty()) +

Re: [Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

On Fri, Oct 27, 2017 at 2:13 PM Jason Molenda wrote: > haven't had a chance to look at the patch yet, but just to comment on one > part from Zach: > > > On Oct 27, 2017, at 2:06 PM, Zachary Turner via Phabricator via > lldb-commits wrote: > > > >

[Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

labath added inline comments. Comment at: source/Target/Platform.cpp:986-991 +if (normalized_triple.getVendorName().empty()) + normalized_triple.setVendor(compatible_triple.getVendor()); +if (normalized_triple.getOSName().empty()) +

[Lldb-commits] [lldb] r316800 - [CMake] Build clang as dependency when using in-tree clang for tests.

Author: davide Date: Fri Oct 27 14:22:57 2017 New Revision: 316800 URL: http://llvm.org/viewvc/llvm-project?rev=316800=rev Log: [CMake] Build clang as dependency when using in-tree clang for tests. Discussed with Zachary Turner and Pavel Labath on lldb-dev. Let's hope this doesn't break anything

Re: [Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

haven't had a chance to look at the patch yet, but just to comment on one part from Zach: > On Oct 27, 2017, at 2:06 PM, Zachary Turner via Phabricator via lldb-commits > wrote: > > > > Comment at: source/Target/Platform.cpp:986-991 > +if

[Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

zturner added inline comments. Comment at: include/lldb/Host/HostInfoBase.h:85 + //--- + /// If the triple contains not specify the vendor, os, and environment parts, + /// we "augment" these using

[Lldb-commits] [PATCH] D39387: Invert ArchSpec<->Platform dependency

labath created this revision. Herald added subscribers: javed.absar, mgorny. ArchSpec::SetTriple was taking a Platform as an argument, and used it to fill in missing pieces of the specified triple. I invert the dependency by moving this code to other classes. For this purpose, I've created three

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rL316773: New lldb python module for managing diagnostic breakpoints (authored by dhinton). Repository: rL LLVM https://reviews.llvm.org/D36347 Files: cfe/trunk/utils/clangdiag.py Index:

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

This revision was automatically updated to reflect the committed changes. Closed by commit rL316772: Add specific ppc64le hardware watchpoint handler (authored by labath). Changed prior to commit: https://reviews.llvm.org/D38897?vs=119885=120632#toc Repository: rL LLVM

[Lldb-commits] [lldb] r316772 - Add specific ppc64le hardware watchpoint handler

Author: labath Date: Fri Oct 27 10:02:32 2017 New Revision: 316772 URL: http://llvm.org/viewvc/llvm-project?rev=316772=rev Log: Add specific ppc64le hardware watchpoint handler Summary: Add hardware watchpoint funcionality for ppc64le Reviewers: clayborg, zturner Reviewed By: clayborg

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120629. hintonda added a comment. - Remove whitespace. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/null +++ utils/clangdiag.py @@ -0,0

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120628. hintonda added a comment. - Add support for individual DiagID's, and print out number of breakpoints added. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py

[Lldb-commits] [PATCH] D39283: [lldb-dev] Update LLDB test cases for 'inlineStepping'

CarlosAlbertoEnciso added a comment. Hi Tamas, What I have done is to use the original code (original.cpp), modified code (calling.cpp), created ELFs for both test cases before and after the compiler change and debug them using LLDB, in order to show the issue while debugging at instruction

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

gut added a subscriber: eugene. gut added a comment. In https://reviews.llvm.org/D38897#908283, @gut wrote: > In https://reviews.llvm.org/D38897#903581, @clayborg wrote: > > > Looks fine. Thanks for doing the changes. > > > Hi, it's been already 4 days since this patch was accepted but not