[Lldb-commits] [lldb] r325452 - Add DEBUGSERVER_PATH to the cache so it'll be available for tests.

2018-02-17 Thread Don Hinton via lldb-commits
Author: dhinton Date: Sat Feb 17 15:06:15 2018 New Revision: 325452 URL: http://llvm.org/viewvc/llvm-project?rev=325452=rev Log: Add DEBUGSERVER_PATH to the cache so it'll be available for tests. This fixed a problem caused by r325442. Differential Revision: https://reviews.llvm.org/D43432

[Lldb-commits] [PATCH] D43432: [cmake] Fix LLDB_CODESIGN_IDENTITY logic.

2018-02-17 Thread Don Hinton via Phabricator via lldb-commits
hintonda added a comment. This is causing test failures due debugserver not found. The fix should be to add DEBUGSERVER_PATH to the cache -- it was originally available in the root scope. I hope to have a fix in as soon as I validated the fix locally, but if this is causing an issue for

[Lldb-commits] [PATCH] D43432: [cmake] Fix LLDB_CODESIGN_IDENTITY logic.

2018-02-17 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325442: [cmake] Fix LLDB_CODESIGN_IDENTITY logic. (authored by dhinton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43432 Files:

[Lldb-commits] [lldb] r325442 - [cmake] Fix LLDB_CODESIGN_IDENTITY logic.

2018-02-17 Thread Don Hinton via lldb-commits
Author: dhinton Date: Sat Feb 17 11:17:21 2018 New Revision: 325442 URL: http://llvm.org/viewvc/llvm-project?rev=325442=rev Log: [cmake] Fix LLDB_CODESIGN_IDENTITY logic. Summary: Consolidate LLDB_CODESIGN_IDENTITY logic in one place and use SKIP_DEBUGSERVER, which can be set independently, to

[Lldb-commits] [PATCH] D43432: [cmake] Fix LLDB_CODESIGN_IDENTITY logic.

2018-02-17 Thread Vedant Kumar via Phabricator via lldb-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm! https://reviews.llvm.org/D43432 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D43419: Fix TestBreakpointInGlobalConstructor for Windows

2018-02-17 Thread Pavel Labath via Phabricator via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Yeah, setting this to zero would break other platforms that are able to locate shared libraries before running the executable. On linux, we try to locate them as well, but it's kind