friss created this revision.
This test launches a helper that uses the debugserver. The environment
variable sepcifying the debug server wasn't passed to this helper, thus
it was using the default one.
I'd love to hear if anyone has a nicer idea how to get access to the
alternative server passed
Author: friss
Date: Tue Feb 20 22:20:03 2018
New Revision: 325666
URL: http://llvm.org/viewvc/llvm-project?rev=325666=rev
Log:
Fix TestAppleTypesIsProduced after r324226
This test was accessing self.debug_info, which doesn't exist anymore. For
some reason the macOS bots are skipping this test
labath added a comment.
I was actually thinking of making this unconditional. It makes the behaviour
easier to understand and this test really does not care about whether the
libraries were resolved statically or not.
I'm with Jim that we should make targeted tests for that functionality.
amccarth created this revision.
amccarth added a reviewer: zturner.
Herald added a subscriber: sanjoy.
This test uses the SB API to set and read back bytes of data, and it works fine
when Python 2 is the scripting language. On Windows, however, Python 3 is the
default.
Note this line from the
amccarth added a comment.
In https://reviews.llvm.org/D43419#1013559, @jingham wrote:
> At some point we should introduce "platformCapacities" so that you could do:
>
> if not test.getPlatformCapacities("preload-dylibs"):
>
>
> so we are testing specific features not the whole platform.
amccarth updated this revision to Diff 135124.
amccarth added a comment.
Wrapped the modified docstring.
https://reviews.llvm.org/D43419
Files:
lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
At some point we should introduce "platformCapacities" so that you could do:
if not test.getPlatformCapacities("preload-dylibs"):
so we are testing specific features not the
amccarth updated this revision to Diff 135120.
amccarth added a comment.
Added new special value to accommodate the fact that Windows may postpone
resolving the breakpoints for DLLs that aren't yet loaded.
https://reviews.llvm.org/D43419
Files:
davide added a comment.
LGTM. This is really good work, thanks
https://reviews.llvm.org/D43506
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
We don’t parse libraries beyond getting sections until we look for symbols,
this doesn’t seem to slow startup noticeably, and since I find it super useful
especially for a program like lldb, where the driver has very little code in it
and most of the functionality is in libraries, I’m happy
owenpshaw updated this revision to Diff 135087.
owenpshaw added a comment.
Herald added a subscriber: arichardson.
Update patch to include new @skipIfXmlSupportMissing decorator on test
https://reviews.llvm.org/D42145
Files:
include/lldb/Host/XML.h
include/lldb/Target/MemoryRegionInfo.h
amccarth added a comment.
I have reservations about making the debugger try to pre-locate the modules and
their PDBs before those modules are actually loaded. For a few reasons.
(1) On Windows, module resolution is complex. Search paths, the safe search
path, manifests, the side-by-side
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Thanks!
By the way, just in case you are motivated :-), one outstanding task is also to
replace all uses of the `clean` target in the makefiles with simply removing
the test build
jankratochvil created this revision.
jankratochvil added reviewers: labath, clayborg.
jankratochvil added a dependency: D40475: DWZ 10/11: DWZ test mode.
So far `/usr/lib/debug/.build-id/**.debug` files could be opened any way. But
with DWZ they can contain relative filename reference to
jankratochvil updated this revision to Diff 135063.
jankratochvil retitled this revision from "DWZ 12/12: DWZ test mode" to "DWZ
10/11: DWZ test mode".
jankratochvil added a comment.
Herald added subscribers: JDevlieghere, mgorny.
It now includes also unittests/SymbolFile/DWZ/ which should PASS
jankratochvil updated this revision to Diff 135060.
jankratochvil marked an inline comment as done.
jankratochvil retitled this revision from "DWZ 11/12: Main functionality" to
"DWZ 09/11: Main functionality".
https://reviews.llvm.org/D40474
Files:
include/lldb/Utility/ConstString.h
jankratochvil updated this revision to Diff 135059.
jankratochvil retitled this revision from "DWZ 10/12: Adjust existing code for
the DWZ support." to "DWZ 08/11: Adjust existing code for the DWZ support.".
https://reviews.llvm.org/D40473
Files:
jankratochvil added a subscriber: alexshap.
jankratochvil added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp:199-202
+ if (die_ref.cu_offset == DW_INVALID_OFFSET
+ // FIXME: Workaround default cu_offset = 0 in DIERef ctor.
+ // Why
jankratochvil updated this revision to Diff 135058.
https://reviews.llvm.org/D40472
Files:
source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h
Index: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h
jankratochvil updated this revision to Diff 135055.
jankratochvil retitled this revision from "DWZ 09/12: Protect
DWARFDebugInfo::m_compile_units by a new mutex" to "DWZ 07/11: Protect
DWARFDebugInfo::m_compile_units by a new mutex".
jankratochvil edited the summary of this revision.
jankratochvil updated this revision to Diff 135053.
jankratochvil retitled this revision from "DWZ 07/12: Protect
DWARFCompileUnit::m_die_array by a new mutex" to "DWZ 06/11: Protect
DWARFCompileUnit::m_die_array by a new mutex".
jankratochvil edited the summary of this revision.
jankratochvil added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:123
size_t DWARFCompileUnit::ExtractDIEsIfNeeded(bool cu_die_only) {
- const size_t initial_die_array_size = m_data->m_die_array.size();
- if ((cu_die_only &&
jankratochvil updated this revision to Diff 135051.
jankratochvil retitled this revision from "DWZ 06/12: Mask DW_TAG_partial_unit
as DW_TAG_compile_unit for Tag()" to "DWZ 04/11: Match also DW_TAG_partial_unit
when DW_TAG_compile_unit is matched".
https://reviews.llvm.org/D40469
Files:
jankratochvil updated this revision to Diff 135050.
jankratochvil retitled this revision from "DWZ 05/12: Support reading section
".gnu_debugaltlink"" to "DWZ 04/11: Support reading section
".gnu_debugaltlink"".
https://reviews.llvm.org/D40468
Files:
include/lldb/lldb-enumerations.h
jankratochvil added a comment.
In https://reviews.llvm.org/D40469#936245, @clayborg wrote:
> Seems like it would be cleaner to leave DWARFDebugInfoEntry and DWARFDie
> alone and just make clients deal with accepting DW_TAG_partial_unit when and
> where they need to. I don't like the idea of
jankratochvil updated this revision to Diff 135049.
jankratochvil retitled this revision from "DWZ 04/12: Separate Offset also into
FileOffset" to "DWZ 03/11: Separate Offset also into FileOffset".
https://reviews.llvm.org/D40467
Files:
include/lldb/Expression/DWARFExpression.h
jankratochvil updated this revision to Diff 135048.
jankratochvil retitled this revision from "DWZ 03/12: Move the codebase to use:
DWARFCompileUnit -> DWARFUnit" to "DWZ 02/11: Move the codebase to use:
DWARFCompileUnit -> DWARFUnit".
jankratochvil edited the summary of this revision.
jankratochvil updated this revision to Diff 135047.
https://reviews.llvm.org/D40466
Files:
source/Plugins/SymbolFile/DWARF/CMakeLists.txt
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
labath created this revision.
labath added reviewers: davide, aprantl.
These were not being flaky, but they're still making the tree dirty.
These tests were using lldbutil.append_to_process_working_directory to
derive the file path so I fix them by modifying the function to return
the build
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325570: Avoid dirtying the source tree in breakpoint command
tests (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43464
Author: labath
Date: Tue Feb 20 02:24:37 2018
New Revision: 325570
URL: http://llvm.org/viewvc/llvm-project?rev=325570=rev
Log:
Avoid dirtying the source tree in breakpoint command tests
Summary:
The paralelization patch exposed a bunch of cases where we were still
touching the source tree (as
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325568: Handle typeof() expressions (authored by
JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43471?vs=134965=135025#toc
Author: jdevlieghere
Date: Tue Feb 20 02:15:08 2018
New Revision: 325568
URL: http://llvm.org/viewvc/llvm-project?rev=325568=rev
Log:
Handle typeof() expressions
Before this patch, LLDB was not able to evaluate expressions that
resulted in a value with a typeof- or decltype-type. This patch
33 matches
Mail list logo
