[Lldb-commits] [lldb] r326166 - Mark test_*int*_t_dwarf as failing on FreeBSD

Author: emaste Date: Mon Feb 26 18:54:17 2018 New Revision: 326166 URL: http://llvm.org/viewvc/llvm-project?rev=326166=rev Log: Mark test_*int*_t_dwarf as failing on FreeBSD Further investigation required; tests will be enabled on the buildbot worker soon. Marking failing tests for now in order

Re: [Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

Llvm also separates the Integration tests (test-suite) from the regression tests. That’s another approach to handling the Cartesian product testing On Mon, Feb 26, 2018 at 6:01 PM Paul Robinson via Phabricator via lldb-commits wrote: > probinson added a comment. > >

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

probinson added a comment. In https://reviews.llvm.org/D32167#1020032, @labath wrote: > Running the entire dotest test suite in -fdebug-types-section is certainly a > good way to catch problems, but it's not the way to write regression tests. Is there testing in place that is more

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

owenpshaw added a comment. Thanks! Just a reminder that I don't have commit access, so someone will need to land this for me. Appreciate all the help. https://reviews.llvm.org/D42145 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D43784: Un-XFAIL TestCallStdStringFunction.test for Windows

amccarth abandoned this revision. amccarth added a comment. Abandoning. This isn't really working on Windows. The breakpoint fails to set for reasons I don't understand yet. https://reviews.llvm.org/D43784 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath accepted this revision. labath added a comment. Sorry, I forgot about that. This looks fine as far as I am concerned. Thank you for flying lldb, and in particular, for creating the gdb-client testing framework. https://reviews.llvm.org/D42145

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg updated this revision to Diff 135999. clayborg added a comment. Address Adrian's comments. https://reviews.llvm.org/D32167 Files: include/lldb/lldb-enumerations.h include/lldb/lldb-forward.h packages/Python/lldbsuite/test/lldbinline.py

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

owenpshaw added a comment. @labath, any other changes you'd like to see on this one? Skipping the test if there's no xml support seemed to be the final todo. https://reviews.llvm.org/D42145 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D43694: Add a sanity check for inline tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL326140: Add a sanity check for inline testcases. (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r326140 - Add a sanity check for inline testcases.

Author: adrian Date: Mon Feb 26 14:40:20 2018 New Revision: 326140 URL: http://llvm.org/viewvc/llvm-project?rev=326140=rev Log: Add a sanity check for inline testcases. When writing an inline test, there is no way to make sure that any of the inline commands are actually executed, so this patch

[Lldb-commits] [lldb] r326139 - Revert r326134 due to broken buildbot

Author: emaste Date: Mon Feb 26 14:36:41 2018 New Revision: 326139 URL: http://llvm.org/viewvc/llvm-project?rev=326139=rev Log: Revert r326134 due to broken buildbot Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/enum_types/TestCPP11EnumTypes.py Modified:

[Lldb-commits] [PATCH] D43784: Un-XFAIL TestCallStdStringFunction.test for Windows

amccarth added a comment. Nice catch. I'll take a closer look to see what exactly is happening on Windows. https://reviews.llvm.org/D43784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r326134 - Mark test_*int*_t_dwarf as failing on FreeBSD

Author: emaste Date: Mon Feb 26 14:12:24 2018 New Revision: 326134 URL: http://llvm.org/viewvc/llvm-project?rev=326134=rev Log: Mark test_*int*_t_dwarf as failing on FreeBSD Further investigation required; tests will be enabled on the buildbot worker soon. Marking failing tests for now in order

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg updated this revision to Diff 135977. clayborg added a comment. clang format fixed comments removed white space fixed functionalities/breakpoint/inlined_breakpoints/TestInlinedBreakpoints.py failures https://reviews.llvm.org/D32167 Files: include/lldb/lldb-enumerations.h

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath updated this revision to Diff 135975. labath added a comment. Remove the changes to source/Plugins/SymbolVendor/CMakeLists.txt that snuck in (I was experimenting with enabling the plugin on non-mac systems, but realized that's not possible right now). https://reviews.llvm.org/D42955

[Lldb-commits] [PATCH] D43784: Un-XFAIL TestCallStdStringFunction.test for Windows

labath added a comment. Btw, today I found out that this test is passing just accidentally because the CHECK lines are matching the output printed by the inferior and not the results of the evaluated expressions (the situation may be different on windows, if you don't do stdin/out redirection

[Lldb-commits] [PATCH] D43784: Un-XFAIL TestCallStdStringFunction.test for Windows

amccarth created this revision. amccarth added a reviewer: zturner. Herald added a subscriber: sanjoy. This test was passing unexpectedly, which causes ninja to short-circuit out of running the dotest.py tests. The bug report (https://bugs.llvm.org/show_bug.cgi?id=21765) appears to be obsolete

[Lldb-commits] [PATCH] D43688: Partial fix for TestConflictingSymbol.py on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL326130: Partial fix for TestConflictingSymbol.py on Windows (authored by amccarth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r326130 - Partial fix for TestConflictingSymbol.py on Windows

Author: amccarth Date: Mon Feb 26 13:22:39 2018 New Revision: 326130 URL: http://llvm.org/viewvc/llvm-project?rev=326130=rev Log: Partial fix for TestConflictingSymbol.py on Windows Without this fix, the test ERRORs because the link of the inferior fails. This patch adds the LLDB_TEST_API macro

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

vsk added a comment. I'm concerned about the time it takes to run the test suite. If we can get decent test coverage of this patch without adding a new debug info flavor, that'd be ideal. Comment at: packages/Python/lldbsuite/test/lldbtest.py:718

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. In https://reviews.llvm.org/D32167#1019701, @labath wrote: > In https://reviews.llvm.org/D32167#1019635, @jingham wrote: > > > Note, I have (though very very occasionally) seen a dsymutil bug that broke > > line tables. So it would be good to keep a few "set a

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. I am afraid of the opposite: we test what we think we need to test and our simple tests cases don't adequately test the feature we are adding. I can certainly limit the testing to very simple test cases with a one test for a class and one for a enum, but that wouldn't

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

labath added a comment. In https://reviews.llvm.org/D32167#1019635, @jingham wrote: > Note, I have (though very very occasionally) seen a dsymutil bug that broke > line tables. So it would be good to keep a few "set a breakpoint and run to > it" tests just to sanity check this. But most

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

davide added a comment. In https://reviews.llvm.org/D32167#1019621, @labath wrote: > In https://reviews.llvm.org/D32167#1019504, @clayborg wrote: > > > In https://reviews.llvm.org/D32167#1019467, @labath wrote: > > > > > However, I am not so sure about the proliferation of debug info variants >

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

jingham added a comment. Right now, which tests are "run all variants" is represents more history than policy. Opt out of all variants is opt in, and while I at least kick out obvious tests that don't really need to run all variants when I touch them, but I don't think we have done a careful

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

labath added a comment. In https://reviews.llvm.org/D32167#1019504, @clayborg wrote: > In https://reviews.llvm.org/D32167#1019467, @labath wrote: > > > However, I am not so sure about the proliferation of debug info variants > > that we seem to be having. Right now we have two outstanding

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. In https://reviews.llvm.org/D32167#1019504, @clayborg wrote: > In https://reviews.llvm.org/D32167#1019467, @labath wrote: > > > So, I tried this out on my machine, and got just one failure: > > > > ==

Re: [Lldb-commits] [PATCH] D43686: Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it

On 23 February 2018 at 15:42, Jim Ingham wrote: > BTW, one thing I like about writing dotest.py tests is that it is easy to > craft fairly rich failure messages so if you get errors on systems you don't > have access to or are dealing with something that fails intermittently

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. In https://reviews.llvm.org/D32167#1019467, @labath wrote: > So, I tried this out on my machine, and got just one failure: > > == > FAIL: test_with_run_command_dwarf_type_units >

[Lldb-commits] [PATCH] D43686: Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it

This revision was automatically updated to reflect the committed changes. Closed by commit rL326112: Add lldb-test breakpoint command and convert the case-sensitivity test to use… (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[Lldb-commits] [lldb] r326112 - Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it

Author: labath Date: Mon Feb 26 10:50:16 2018 New Revision: 326112 URL: http://llvm.org/viewvc/llvm-project?rev=326112=rev Log: Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it Summary: The command takes two input arguments: a module to use as a debug target

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

emaste added inline comments. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:197 +ifeq "$(DWARF_TYPE_UNITS)" "YES" + DEBUG_INFO_FLAG ?= -gdwarf-4 +else clayborg wrote: > aprantl wrote: > > This shouldn't be necessary on any platform LLDB

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

labath added a comment. So, I tried this out on my machine, and got just one failure: == FAIL: test_with_run_command_dwarf_type_units (TestInlinedBreakpoints.InlinedBreakpointsTestCase) Test 'b basic_types.cpp:176'

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. In https://reviews.llvm.org/D32167#1019399, @davide wrote: > This commit has no tests. It should have many. I has full testing. Please read the commit and notice there is a new debug info flavor that is added. So of course it is tested. > It's very big, so it could

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg updated this revision to Diff 135913. clayborg added a comment. Herald added subscribers: JDevlieghere, eraman, arichardson, emaste. Updated to top of tree sources and verified it passes all tests on linux. https://reviews.llvm.org/D32167 Files: include/lldb/lldb-enumerations.h

[Lldb-commits] [PATCH] D43705: Fix tabs/spaces in TestUnicodeSymbols.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL326095: Fix tabs/spaces indentation problem in TestUnicodeSymbols.py (authored by amccarth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r326095 - Fix tabs/spaces indentation problem in TestUnicodeSymbols.py

Author: amccarth Date: Mon Feb 26 07:53:31 2018 New Revision: 326095 URL: http://llvm.org/viewvc/llvm-project?rev=326095=rev Log: Fix tabs/spaces indentation problem in TestUnicodeSymbols.py Differential Revision: https://reviews.llvm.org/D43705 Modified:

[Lldb-commits] [lldb] r326091 - Re-land: "[Support] Replace HashString with djbHash."

Author: jdevlieghere Date: Mon Feb 26 07:16:42 2018 New Revision: 326091 URL: http://llvm.org/viewvc/llvm-project?rev=326091=rev Log: Re-land: "[Support] Replace HashString with djbHash." This patch removes the HashString function from StringExtraces and replaces its uses with calls to djbHash

[Lldb-commits] [lldb] r326082 - Revert "[Support] Replace HashString with djbHash."

Author: jdevlieghere Date: Mon Feb 26 04:05:18 2018 New Revision: 326082 URL: http://llvm.org/viewvc/llvm-project?rev=326082=rev Log: Revert "[Support] Replace HashString with djbHash." It looks like some of our tests depend on the ordering of hashed values. I'm reverting my changes while I try

[Lldb-commits] [lldb] r326081 - [Support] Replace HashString with djbHash.

Author: jdevlieghere Date: Mon Feb 26 03:30:13 2018 New Revision: 326081 URL: http://llvm.org/viewvc/llvm-project?rev=326081=rev Log: [Support] Replace HashString with djbHash. This removes the HashString function from StringExtraces and replaces its uses with calls to djbHash from DJB.h This