[Lldb-commits] [lldb] r327941 - Add a suggestion to convert dotest tests to use run_to_source_breakpoint.

Author: jingham Date: Mon Mar 19 19:15:23 2018 New Revision: 327941 URL: http://llvm.org/viewvc/llvm-project?rev=327941=rev Log: Add a suggestion to convert dotest tests to use run_to_source_breakpoint. Modified: lldb/trunk/www/projects.html Modified: lldb/trunk/www/projects.html URL:

Re: [Lldb-commits] [lldb] r327924 - Modernize a test.

So that file you are looking for is "packages/Python/lldbsuite/test/README-testsuite. It would be great to have a fresh pair of eyes look this over and add whatever you would have found useful... Jim > On Mar 19, 2018, at 6:44 PM, Davide Italiano wrote: > > On Mon,

Re: [Lldb-commits] [lldb] r327924 - Modernize a test.

On Mon, Mar 19, 2018 at 6:38 PM, Jim Ingham wrote: > Yes, I should have written this function much earlier. I've been trying to > convert over to it every time a tests draws my attention (in this case 'cause > I pointed it out for you to copy...) > > It is the way to make a

Re: [Lldb-commits] [lldb] r327924 - Modernize a test.

Yes, I should have written this function much earlier. I've been trying to convert over to it every time a tests draws my attention (in this case 'cause I pointed it out for you to copy...) It is the way to make a test in the sample_test/TestSampleTest.py. That seemed the most effective way

Re: [Lldb-commits] [lldb] r327924 - Modernize a test.

On Mon, Mar 19, 2018 at 4:15 PM, Jim Ingham via lldb-commits wrote: > Author: jingham > Date: Mon Mar 19 16:15:06 2018 > New Revision: 327924 > > URL: http://llvm.org/viewvc/llvm-project?rev=327924=rev > Log: > Modernize a test. > > Modified: > >

[Lldb-commits] [PATCH] D44456: [SymbolFilePDB] Simplify getting the source file path

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL327925: [SymbolFilePDB] Simplify getting the source file path (authored by asmith, committed by ). Changed prior to

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

owenpshaw added a comment. In https://reviews.llvm.org/D42145#1034499, @labath wrote: > I like this a lot. That's the kind of change I wanted to do as a follow-up > one day. Thank you. Thanks! I don't have commit access to land this. https://reviews.llvm.org/D42145

[Lldb-commits] [lldb] r327924 - Modernize a test.

Author: jingham Date: Mon Mar 19 16:15:06 2018 New Revision: 327924 URL: http://llvm.org/viewvc/llvm-project?rev=327924=rev Log: Modernize a test. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/incomplete-types/TestCppIncompleteTypes.py Modified:

[Lldb-commits] [lldb] r327922 - Rename remotectl_com.apple.internal.xpc.remote.debugserver.plist

Author: jmolenda Date: Mon Mar 19 16:07:31 2018 New Revision: 327922 URL: http://llvm.org/viewvc/llvm-project?rev=327922=rev Log: Rename remotectl_com.apple.internal.xpc.remote.debugserver.plist to com.apple.internal.xpc.remote.debugserver.plist, not sure where that remotectl_ prefix came from.

[Lldb-commits] [lldb] r327918 - I didn't see that SocketAddress.cpp was already being pulled

Author: jmolenda Date: Mon Mar 19 15:55:19 2018 New Revision: 327918 URL: http://llvm.org/viewvc/llvm-project?rev=327918=rev Log: I didn't see that SocketAddress.cpp was already being pulled in to debugserver; my re-addition resulted in duplicated symbols. Remove my added SocketAddress.cpp, and

[Lldb-commits] [lldb] r327915 - Add the ios-mini target to the top-level xcodeproj, which builds

Author: jmolenda Date: Mon Mar 19 15:04:45 2018 New Revision: 327915 URL: http://llvm.org/viewvc/llvm-project?rev=327915=rev Log: Add the ios-mini target to the top-level xcodeproj, which builds the debugserver-mini target in debugserver. Add a new plist which needs to be installed for

[Lldb-commits] [lldb] r327913 - Add DWARFUnit.cpp to the correct target.

Author: jmolenda Date: Mon Mar 19 14:55:48 2018 New Revision: 327913 URL: http://llvm.org/viewvc/llvm-project?rev=327913=rev Log: Add DWARFUnit.cpp to the correct target. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r327906 - [test] Skip flaky tests in TestMiSyntax on Darwin

Author: vedantk Date: Mon Mar 19 13:50:50 2018 New Revision: 327906 URL: http://llvm.org/viewvc/llvm-project?rev=327906=rev Log: [test] Skip flaky tests in TestMiSyntax on Darwin These tests tend to time out locally and on our bots. Modified:

[Lldb-commits] [lldb] r327905 - [test] Skip flaky TestThreadStates tests on Darwin

Author: vedantk Date: Mon Mar 19 13:50:49 2018 New Revision: 327905 URL: http://llvm.org/viewvc/llvm-project?rev=327905=rev Log: [test] Skip flaky TestThreadStates tests on Darwin These tests do not pass/fail consistently, so just skip them. This is llvm.org/pr15824 & rdar://problem/28557237.

[Lldb-commits] [PATCH] D44455: [SymbolFilePDB] Remove a few null pointer checks by passing ref

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Feel free to use your own judgement, and if you think it doesn't pass some complexity threshold, you can just submit without review and we can do post-commit review. Repository: rL LLVM

[Lldb-commits] [lldb] r327893 - [ClangASTContext] Remove dead code. NFCI.

Author: davide Date: Mon Mar 19 12:35:20 2018 New Revision: 327893 URL: http://llvm.org/viewvc/llvm-project?rev=327893=rev Log: [ClangASTContext] Remove dead code. NFCI. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL:

[Lldb-commits] [PATCH] D44613: Support template template parameters

friss added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2043 +is_template_template_argument = true; +[[clang::fallthrough]]; case DW_TAG_template_type_parameter: clayborg wrote: > Shouldn't we be using a

[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

clayborg added subscribers: labath, clayborg. clayborg added a comment. I would be nice to have the option to nuke each test build directory if the test passed. Can be an option that we specify. That way, the only folders left over could be the tests that are failing. The options doesn't need

Re: [Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

I would be nice to have the option to nuke each test build directory if the test passed. Can be an option that we specify. That way, the only folders left over could be the tests that are failing. The options doesn't need to default to true, but if anyone is in that code and would know how to

[Lldb-commits] [lldb] r327865 - Xcode: Include DWARFUnit.{h, cpp} in the build

Author: vedantk Date: Mon Mar 19 09:24:58 2018 New Revision: 327865 URL: http://llvm.org/viewvc/llvm-project?rev=327865=rev Log: Xcode: Include DWARFUnit.{h,cpp} in the build This should address a bot failure due to r327809. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: