[Lldb-commits] [lldb] r328062 - [Testsuite] Modernize this test to be run out-of-tree.

Author: davide Date: Tue Mar 20 16:47:47 2018 New Revision: 328062 URL: http://llvm.org/viewvc/llvm-project?rev=328062=rev Log: [Testsuite] Modernize this test to be run out-of-tree. New tests should run the make syntax voodoo $@ and $< instead of hardcoding the names. We should also document

[Lldb-commits] [PATCH] D44321: Support demangling for D symbols via dlopen

johanengelen added a comment. In https://reviews.llvm.org/D44321#1038241, @timotheecour wrote: > > When druntime is initialized, a number of resources are allocated (e.g. > > memory and mutex). Yes you initialize druntime once, I can see that. You > > don't deinitialize druntime at all: that's

Re: [Lldb-commits] [lldb] r328025 - [ExpressionParser] Re-implement r327356 in a less disruptive way.

This apparently uncovered a crash in the linux build, looking now. http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake Thanks, -- Davide On Tue, Mar 20, 2018 at 12:46 PM, Davide Italiano via lldb-commits wrote: > Author: davide > Date: Tue Mar 20

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

Thanks for fixing this is the right way and taking the time! Greg > On Mar 20, 2018, at 12:49 PM, Davide Italiano via lldb-commits > wrote: > > Fixed in a nicer/cleaner way (that doesn't regress the current > behavior), thank you everybody for your excellent

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

Fixed in a nicer/cleaner way (that doesn't regress the current behavior), thank you everybody for your excellent feedback! davide@Davidinos-Mac-Pro ~/w/l/llvm-project-20170507> git llvm push Pushing 1 commit: 8875fcce772 [ExpressionParser] Re-implement r327356 in a less disruptive way. Sending

[Lldb-commits] [lldb] r328025 - [ExpressionParser] Re-implement r327356 in a less disruptive way.

Author: davide Date: Tue Mar 20 12:46:32 2018 New Revision: 328025 URL: http://llvm.org/viewvc/llvm-project?rev=328025=rev Log: [ExpressionParser] Re-implement r327356 in a less disruptive way. Instead of applying the sledgehammer of refusing to insert any C++ symbol in the ASTContext, try to

[Lldb-commits] [lldb] r328020 - [lldb-dotest] Wrap arguments in single quotes

Author: jdevlieghere Date: Tue Mar 20 12:18:11 2018 New Revision: 328020 URL: http://llvm.org/viewvc/llvm-project?rev=328020=rev Log: [lldb-dotest] Wrap arguments in single quotes If we don't wrap arguments to the wrapper in single quotes, combined arguments, for example for -E, don't reach

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

lbianc added a comment. Yes, I'm running Linux and this test was not working for me, so as discussion above, it was separated to be executed on non Linux and Windows, but the variable number got wrong. Sorry for that. https://reviews.llvm.org/D44472

[Lldb-commits] [lldb] r328013 - [TestExpr] Fix a typo in a test, unbreaking the lldb Mac OS X bot.

Author: davide Date: Tue Mar 20 11:32:47 2018 New Revision: 328013 URL: http://llvm.org/viewvc/llvm-project?rev=328013=rev Log: [TestExpr] Fix a typo in a test, unbreaking the lldb Mac OS X bot. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/test/TestExprs2.py

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

davide added a comment. I think I understand why this is failing: AssertionError: False is not True : 'expression ((char**)environ)[0]' returns expected result, got '(char *) $0 = 0x7ffeefbff753 "COMMAND_MODE=unix2003"'

Re: [Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

I think I understand why this is failing: AssertionError: False is not True : 'expression ((char**)environ)[0]' returns expected result, got '(char *) $0 = 0x7ffeefbff753 "COMMAND_MODE=unix2003"' Config=x86_64-/Users/davide/work/llvm-monorepo/build-release/bin/clang-7.0 but the test shows

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

lbianc added a comment. @davide Let me know if you need that I change it on my diff or any other help. https://reviews.llvm.org/D44472 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

davide added a comment. In https://reviews.llvm.org/D44472#1043464, @lbianc wrote: > @davide Are you sure this is the correct patch? This one was not merged yet. > Could you give more details about the issue? Is it related with one of our > changes? Apologies, this is the right one commit

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

davide added a comment. In https://reviews.llvm.org/D44472#1043510, @davide wrote: > In https://reviews.llvm.org/D44472#1043464, @lbianc wrote: > > > @davide Are you sure this is the correct patch? This one was not merged yet. > > Could you give more details about the issue? Is it related with

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

lbianc added a comment. @davide Are you sure this is the correct patch? This one was not merged yet. Could you give more details about the issue? Is it related with one of our changes? https://reviews.llvm.org/D44472 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

davide added subscribers: alexandreyy, labath, davide. davide added a comment. Leonardo, this breaks the Mac OS X bot. I'm going to revert this to get the bots green again, unless you have a super quick fix (please let me know :) https://reviews.llvm.org/D44472

Re: [Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

Leonardo, this breaks the Mac OS X bot. I'm going to revert this to get the bots green again, unless you have a super quick fix (please let me know :) On Tue, Mar 20, 2018 at 5:28 AM, Alexandre Yukio Yamashita via Phabricator via lldb-commits wrote: > alexandreyy

Re: [Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

> On Mar 20, 2018, at 4:55 AM, Pavel Labath via lldb-commits > wrote: > > Deleting the test build dir is fairly easy. I can whip up a patch for that, > but I'm not sure if that's the part that is bothering you the most here. > Dealing with the log files is a bot

[Lldb-commits] [lldb] r327996 - Move StringExtractorGDBRemote.h to the include folder

Author: labath Date: Tue Mar 20 09:14:00 2018 New Revision: 327996 URL: http://llvm.org/viewvc/llvm-project?rev=327996=rev Log: Move StringExtractorGDBRemote.h to the include folder While trying to use this header I noticed that it is not in the include folder. Move it to there and update all

[Lldb-commits] [lldb] r327981 - [LLDB] Fix TestTargetXMLArch's expected arch

Author: labath Date: Tue Mar 20 06:46:05 2018 New Revision: 327981 URL: http://llvm.org/viewvc/llvm-project?rev=327981=rev Log: [LLDB] Fix TestTargetXMLArch's expected arch Summary: When running on an architecture other than x86_64, the target.ConnectRemote() part of the test may add platform

[Lldb-commits] [lldb] r327977 - Fix some tests for PPC64le architecture

Author: labath Date: Tue Mar 20 05:46:33 2018 New Revision: 327977 URL: http://llvm.org/viewvc/llvm-project?rev=327977=rev Log: Fix some tests for PPC64le architecture Summary: - Fix test jump for powerpc64le Jumping directly to the return line on power architecture dos not means returning

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

alexandreyy added a comment. In https://reviews.llvm.org/D44472#1039812, @labath wrote: > I like what you did with the test. Originally, I wanted to just compare the > raw memory contents, but this keeps it more inline with the spirit of the > original test. I have just one question about the

[Lldb-commits] [PATCH] D44680: [dotest] Remove test build directories for passing tests

labath created this revision. labath added reviewers: aprantl, clayborg. This logic is hooked into the same mechanism as the deletion of log files, which makes it possible to use the --log-success argument to have dotest keep the files around (for comparative analysis or whatever). This makes

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL327970: Re-land: [lldb] Use vFlash commands when writing to targets flash memory… (authored by labath, committed by ).

[Lldb-commits] [lldb] r327970 - Re-land: [lldb] Use vFlash commands when writing to target's flash memory regions

Author: labath Date: Tue Mar 20 04:56:24 2018 New Revision: 327970 URL: http://llvm.org/viewvc/llvm-project?rev=327970=rev Log: Re-land: [lldb] Use vFlash commands when writing to target's flash memory regions The difference between this and the previous patch is that now we use ELF physical

[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

labath added a subscriber: aprantl. labath added a comment. Deleting the test build dir is fairly easy. I can whip up a patch for that, but I'm not sure if that's the part that is bothering you the most here. Dealing with the log files is a bot more complicated and there doesn't seem to be a

Re: [Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

Deleting the test build dir is fairly easy. I can whip up a patch for that, but I'm not sure if that's the part that is bothering you the most here. Dealing with the log files is a bot more complicated and there doesn't seem to be a clear consensus on what to do with them. The last discussion