[Lldb-commits] [lldb] r331242 - Fix type_lookup test to make buildbots happy

Author: eugene Date: Mon Apr 30 20:06:05 2018 New Revision: 331242 URL: http://llvm.org/viewvc/llvm-project?rev=331242=rev Log: Fix type_lookup test to make buildbots happy Added: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/type_lookup/TestCppTypeLookup.py - copied, changed

[Lldb-commits] [lldb] r331239 - Log to the process channel, not target twice.

Author: jmolenda Date: Mon Apr 30 17:42:17 2018 New Revision: 331239 URL: http://llvm.org/viewvc/llvm-project?rev=331239=rev Log: Log to the process channel, not target twice. Modified: lldb/trunk/source/Utility/ArchSpec.cpp Modified: lldb/trunk/source/Utility/ArchSpec.cpp URL:

Re: [Lldb-commits] [lldb] r331236 - Add logging when ArchSpec::SetArchitecture is given a cputype and

> On Apr 30, 2018, at 5:23 PM, Davide Italiano wrote: > > On Mon, Apr 30, 2018 at 5:05 PM, Jason Molenda via lldb-commits > wrote: >> >> fAnyCategoriesSet(LIBLLDB_LOG_TARGET | LIBLLDB_LOG_TARGET | >> LIBLLDB_LOG_PLATFORM)); > > Did you

Re: [Lldb-commits] [lldb] r331236 - Add logging when ArchSpec::SetArchitecture is given a cputype and

On Mon, Apr 30, 2018 at 5:05 PM, Jason Molenda via lldb-commits wrote: > Author: jmolenda > Date: Mon Apr 30 17:05:54 2018 > New Revision: 331236 > > URL: http://llvm.org/viewvc/llvm-project?rev=331236=rev > Log: > Add logging when ArchSpec::SetArchitecture is given a

[Lldb-commits] [lldb] r331236 - Add logging when ArchSpec::SetArchitecture is given a cputype and

Author: jmolenda Date: Mon Apr 30 17:05:54 2018 New Revision: 331236 URL: http://llvm.org/viewvc/llvm-project?rev=331236=rev Log: Add logging when ArchSpec::SetArchitecture is given a cputype and cpusubtype that don't map to any known core definition. Modified:

[Lldb-commits] [PATCH] D46088: Refactor GetNextPersistentVariableName into a non-virtual method

This revision was automatically updated to reflect the committed changes. Closed by commit rL331235: Refactor GetNextPersistentVariableName into a non-virtual method (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r331235 - Refactor GetNextPersistentVariableName into a non-virtual method

Author: adrian Date: Mon Apr 30 16:59:17 2018 New Revision: 331235 URL: http://llvm.org/viewvc/llvm-project?rev=331235=rev Log: Refactor GetNextPersistentVariableName into a non-virtual method that takes a prefix string. This simplifies the implementation and allows plugins such as the Swift

[Lldb-commits] [PATCH] D46083: Move the persistent variable counter into Target

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL331234: Move the persistent variable counter into Target (authored by adrian, committed by ). Herald added a

[Lldb-commits] [lldb] r331234 - Move the persistent variable counter into Target

Author: adrian Date: Mon Apr 30 16:59:15 2018 New Revision: 331234 URL: http://llvm.org/viewvc/llvm-project?rev=331234=rev Log: Move the persistent variable counter into Target so it can be shared across multiple language plugins. In a multi-language project it is counterintuitive to have a

[Lldb-commits] [PATCH] D46088: Refactor GetNextPersistentVariableName into a non-virtual method

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That's fine. https://reviews.llvm.org/D46088 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D46088: Refactor GetNextPersistentVariableName into a non-virtual method

aprantl updated this revision to Diff 144649. aprantl added a comment. Address review feedback. https://reviews.llvm.org/D46088 Files: include/lldb/Expression/ExpressionVariable.h source/Core/ValueObject.cpp source/Expression/ExpressionVariable.cpp source/Expression/Materializer.cpp

[Lldb-commits] [PATCH] D46292: Use the UUID from the minidump's CodeView Record for placeholder modules

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. The big picture here is fine. I see a couple opportunities in the details, but I won't block on them. Comment at: include/lldb/Core/Module.h:779 +

[Lldb-commits] [PATCH] D46083: Move the persistent variable counter into Target

jingham added a comment. Eh, must have. The page really shouldn't let you overall submit if there are uncommitted comments, but whatever. Let's see if I did it right this time.. Comment at: source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp:668 ConstString

[Lldb-commits] [PATCH] D46083: Move the persistent variable counter into Target

aprantl added a comment. I'm sorry: which inline comment? Did you perhaps forget to hit "Submit"? https://reviews.llvm.org/D46083 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46083: Move the persistent variable counter into Target

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Except for the inline comment, this is okay. If we thought hard we might find another likely reason why we'd want to use two result prefixes besides a language that has an error

[Lldb-commits] [PATCH] D46292: Use the UUID from the minidump's CodeView Record for placeholder modules

lemo created this revision. lemo added reviewers: amccarth, clayborg, labath. lemo added a project: LLDB. This change adds support for two types of Minidump CodeView records: 1. PDB70 (reference: https://crashpad.chromium.org/doxygen/structcrashpad_1_1CodeViewRecordPDB70.html) This is by far

[Lldb-commits] [PATCH] D46220: Remove premature caching of the global variables list in CompileUnit.

This revision was automatically updated to reflect the committed changes. Closed by commit rL331230: Remove premature caching of the global variables list in CompileUnit. (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r331230 - Remove premature caching of the global variables list in CompileUnit.

Author: adrian Date: Mon Apr 30 14:54:02 2018 New Revision: 331230 URL: http://llvm.org/viewvc/llvm-project?rev=331230=rev Log: Remove premature caching of the global variables list in CompileUnit. This fixes a bug where (lldb) target var g_ptr would populate the global variables list with

[Lldb-commits] [PATCH] D40470: DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rL331229: Protect DWARFCompileUnit::m_die_array by a new mutex (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [lldb] r331229 - Protect DWARFCompileUnit::m_die_array by a new mutex

Author: jankratochvil Date: Mon Apr 30 14:37:30 2018 New Revision: 331229 URL: http://llvm.org/viewvc/llvm-project?rev=331229=rev Log: Protect DWARFCompileUnit::m_die_array by a new mutex Multiple DW_TAG_compile_unit being indexed in a multithreaded way can request reading of the same

[Lldb-commits] [PATCH] D40474: DWZ 05/07: Main functionality

jankratochvil updated this revision to Diff 144640. https://reviews.llvm.org/D40474 Files: include/lldb/Utility/ConstString.h include/lldb/Utility/FileSpec.h source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h

[Lldb-commits] [PATCH] D40474: DWZ 05/07: Main functionality

jankratochvil updated this revision to Diff 144639. https://reviews.llvm.org/D40474 Files: include/lldb/Utility/ConstString.h include/lldb/Utility/FileSpec.h source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h

[Lldb-commits] [PATCH] D40470: DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:335 m_die_array.swap(tmp_array); -if (keep_compile_unit_die) +m_die_array_size_atomic = 0; +if (keep_compile_unit_die)

[Lldb-commits] [PATCH] D40470: DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Much better. https://reviews.llvm.org/D40470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D40470: DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil updated this revision to Diff 144638. jankratochvil marked an inline comment as done. https://reviews.llvm.org/D40470 Files: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFUnit.h Index: source/Plugins/SymbolFile/DWARF/DWARFUnit.h

[Lldb-commits] [PATCH] D46220: Remove premature caching of the global variables list in CompileUnit.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sounds good. Looks fine. https://reviews.llvm.org/D46220 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D43512: DWZ 07/07: Fix for symlinked .build-id/**.debug files

jankratochvil planned changes to this revision. jankratochvil added a comment. The testcase needs some updates after recent upstream testsuite changes. https://reviews.llvm.org/D43512 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D46220: Remove premature caching of the global variables list in CompileUnit.

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4221 if (variable_list_sp.get() == NULL) { variable_list_sp.reset(new VariableList()); } clayborg wrote: > So do we

[Lldb-commits] [PATCH] D46128: Fix expression parser to not accept any type whose basename matches for a type that must exist at root level

This revision was automatically updated to reflect the committed changes. Closed by commit rL331227: Fix expression parser to not accept any type whose basename matches for a type… (authored by gclayton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r331227 - Fix expression parser to not accept any type whose basename matches for a type that must exist at root level

Author: gclayton Date: Mon Apr 30 14:06:30 2018 New Revision: 331227 URL: http://llvm.org/viewvc/llvm-project?rev=331227=rev Log: Fix expression parser to not accept any type whose basename matches for a type that must exist at root level This patch fixes an issue where we weren't looking for

[Lldb-commits] [PATCH] D46220: Remove premature caching of the global variables list in CompileUnit.

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4221 if (variable_list_sp.get() == NULL) { variable_list_sp.reset(new VariableList()); } So do we cache now somewhere

[Lldb-commits] [PATCH] D46128: Fix expression parser to not accept any type whose basename matches for a type that must exist at root level

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. To aid with reviewing I documented LLDB's current behavior. I don't understand the implementation well enough to comment on it, but I do think the the new behavior is superior over the old

[Lldb-commits] [PATCH] D46220: Remove premature caching of the global variables list in CompileUnit.

aprantl added a comment. ping. https://reviews.llvm.org/D46220 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46083: Move the persistent variable counter into Target

aprantl updated this revision to Diff 144628. aprantl added a comment. Thread an is_error flag through for plugins that need it. https://reviews.llvm.org/D46083 Files: include/lldb/Expression/ExpressionVariable.h source/Core/ValueObject.cpp source/Expression/ExpressionVariable.cpp

[Lldb-commits] [PATCH] D40470: DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:335 m_die_array.swap(tmp_array); -if (keep_compile_unit_die) +

[Lldb-commits] [PATCH] D40470: DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:56 +return 0; + std::shared_ptr m_die_array_size_atomic_set(nullptr, + [&](void*){ m_die_array_size_atomic =

[Lldb-commits] [PATCH] D40470: DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil updated this revision to Diff 144589. jankratochvil added a comment. Removed the `m_die_array_size_atomic_set` `m_` prefix, used `CleanUp`. https://reviews.llvm.org/D40470 Files: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFUnit.h

[Lldb-commits] [PATCH] D40470: DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:56 +return 0; + std::shared_ptr m_die_array_size_atomic_set(nullptr, + [&](void*){

[Lldb-commits] [PATCH] D40470: DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil updated this revision to Diff 144576. https://reviews.llvm.org/D40470 Files: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWARF/DWARFUnit.h Index: source/Plugins/SymbolFile/DWARF/DWARFUnit.h

[Lldb-commits] [PATCH] D46144: Reflow paragraphs in comments.

This revision was automatically updated to reflect the committed changes. Closed by commit rL331197: Reflow paragraphs in comments. (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D46144?vs=144420=144575#toc

[Lldb-commits] [PATCH] D40469: DWZ 02/07: Match also DW_TAG_partial_unit when DW_TAG_compile_unit is matched

This revision was automatically updated to reflect the committed changes. Closed by commit rL331194: Match also DW_TAG_partial_unit when DW_TAG_compile_unit is matched (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r331194 - Match also DW_TAG_partial_unit when DW_TAG_compile_unit is matched

Author: jankratochvil Date: Mon Apr 30 09:04:32 2018 New Revision: 331194 URL: http://llvm.org/viewvc/llvm-project?rev=331194=rev Log: Match also DW_TAG_partial_unit when DW_TAG_compile_unit is matched Code commonly checks if the parent DIE is DW_TAG_compile_unit. But DW_TAG_partial_unit also

[Lldb-commits] [PATCH] D46144: Reflow paragraphs in comments.

aprantl added inline comments. Comment at: source/Host/common/MainLoop.cpp:158 // ppoll(2) is not supported on older all android versions. Also, older - // versions android (API <= 19) implemented pselect in a non-atomic way, as a - // combination of pthread_sigmask and

[Lldb-commits] [PATCH] D46144: Reflow paragraphs in comments.

JDevlieghere accepted this revision. JDevlieghere added a comment.  Comment at: source/Host/common/MainLoop.cpp:158 // ppoll(2) is not supported on older all android versions. Also, older - // versions android (API <= 19) implemented pselect in a non-atomic way, as a -

[Lldb-commits] [lldb] r331180 - llgs tests: Use noack-mode for communication to avoid pr37294

Author: labath Date: Mon Apr 30 07:30:02 2018 New Revision: 331180 URL: http://llvm.org/viewvc/llvm-project?rev=331180=rev Log: llgs tests: Use noack-mode for communication to avoid pr37294 Modified: lldb/trunk/unittests/tools/lldb-server/tests/TestClient.cpp

[Lldb-commits] [PATCH] D40469: DWZ 02/07: Match also DW_TAG_partial_unit when DW_TAG_compile_unit is matched

labath edited reviewers, added: aprantl, JDevlieghere; removed: labath. labath added a comment. Adding some debug info people, as I don't feel qualified to review this. https://reviews.llvm.org/D40469 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

This revision was automatically updated to reflect the committed changes. Closed by commit rL331173: ObjectFileELF: Add support for arbitrarily named code sections (authored by labath, committed by ). Herald added a subscriber: JDevlieghere. Changed prior to commit:

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

labath added a comment. I've committed this as r331173. I've had to revert the lldb-test changes, as something similar has been implemented already, and I've merged your lldb-test test with an existing section types test. https://reviews.llvm.org/D44998

[Lldb-commits] [lldb] r331173 - ObjectFileELF: Add support for arbitrarily named code sections

Author: labath Date: Mon Apr 30 06:23:47 2018 New Revision: 331173 URL: http://llvm.org/viewvc/llvm-project?rev=331173=rev Log: ObjectFileELF: Add support for arbitrarily named code sections ObjectFileELF assumes that code section has ".text" name. There is an exception for kalimba toolchain

[Lldb-commits] [PATCH] D46128: Fix expression parser to not accept any type whose basename matches for a type that must exist at root level

labath resigned from this revision. labath added a comment. Jim seems to have an idea on how the type lookup should work, so I'll defer to him. https://reviews.llvm.org/D46128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r331172 - Fixup r331049 (FileSpec auto-normalization)

Author: labath Date: Mon Apr 30 05:59:14 2018 New Revision: 331172 URL: http://llvm.org/viewvc/llvm-project?rev=331172=rev Log: Fixup r331049 (FileSpec auto-normalization) A typo in the patch (using syntax instead of m_syntax) resulted in the normalization not working properly for windows