[Lldb-commits] [lldb] r331501 - Add children and child[N] properties to SBValue.i.

Author: jingham Date: Thu May 3 18:31:47 2018 New Revision: 331501 URL: http://llvm.org/viewvc/llvm-project?rev=331501=rev Log: Add children and child[N] properties to SBValue.i. Also fixed some bad formatting in SBValue.i. Modified:

[Lldb-commits] [lldb] r331497 - The on-ios-device command line lldb has an optimization where

Author: jmolenda Date: Thu May 3 17:59:37 2018 New Revision: 331497 URL: http://llvm.org/viewvc/llvm-project?rev=331497=rev Log: The on-ios-device command line lldb has an optimization where when it and the inferior process both have the same shared cache (a conglomeration of all libraries at

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

aprantl added a comment. As Greg suspected, the problem was that target was null. I rewrote that patch to not use a SymbolContext in the first place. Repository: rL LLVM https://reviews.llvm.org/D46362 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r331492 - DWARFExpression: Convert file addresses to load addresses early on.

Author: adrian Date: Thu May 3 16:32:47 2018 New Revision: 331492 URL: http://llvm.org/viewvc/llvm-project?rev=331492=rev Log: DWARFExpression: Convert file addresses to load addresses early on. This is a change that only affects Swift and is NFC for the language plugins on llvm.org. In Swift,

Re: [Lldb-commits] [lldb] r331082 - Fix build bots after r331049 broke them.

I would like to apologize for communicating this so late (mainly because I worked on the swift bits which are a little behind and I didn't update my checkout) but this commit completely broke debugging in some cases (on MacOS). Testcase: #import int main() { id keys[1] = { @"abc" }; id

Re: [Lldb-commits] [lldb] r331082 - Fix build bots after r331049 broke them.

On Fri, Apr 27, 2018 at 2:10 PM, Greg Clayton via lldb-commits wrote: > Author: gclayton > Date: Fri Apr 27 14:10:07 2018 > New Revision: 331082 > > URL: http://llvm.org/viewvc/llvm-project?rev=331082=rev > Log: > Fix build bots after r331049 broke them. > I would

Re: [Lldb-commits] [lldb] r331480 - Revert "DWARFExpression: Convert file addresses to load addresses early on."

One issue after looking closer at the code is you didn't specify you wanted the target filled in when calling: auto sc = frame->GetSymbolContext(eSymbolContextFunction); It should be: auto sc = frame->GetSymbolContext(eSymbolContextTarget | eSymbolContextModule | eSymbolContextCompUnit |

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

aprantl added a comment. Yes, I must have added a mistake in my last edit before landing this. I reverted that patch for now. Repository: rL LLVM https://reviews.llvm.org/D46362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r331480 - Revert "DWARFExpression: Convert file addresses to load addresses early on."

Author: adrian Date: Thu May 3 13:19:39 2018 New Revision: 331480 URL: http://llvm.org/viewvc/llvm-project?rev=331480=rev Log: Revert "DWARFExpression: Convert file addresses to load addresses early on." This reverts commit 331462 while investigating bot breakage. Modified:

Re: [Lldb-commits] [lldb] r331479 - Add back condition that was accidentally removed in r331462.

Was this the "please make sure global variable expression can be evaluated when not running" issue you ran into? > On May 3, 2018, at 1:13 PM, Adrian Prantl via lldb-commits > wrote: > > Author: adrian > Date: Thu May 3 13:13:58 2018 > New Revision: 331479 > >

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

labath added a comment. It looks like this has caused a bunch of tests to crash on linux http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/22800. The crashes seem to be happening during printing of global variables ( `HandleCommand(command = "target variable

[Lldb-commits] [lldb] r331479 - Add back condition that was accidentally removed in r331462.

Author: adrian Date: Thu May 3 13:13:58 2018 New Revision: 331479 URL: http://llvm.org/viewvc/llvm-project?rev=331479=rev Log: Add back condition that was accidentally removed in r331462. This should make the bots much happier. Modified: lldb/trunk/source/Core/ValueObjectVariable.cpp

[Lldb-commits] [PATCH] D46395: Remove Process references from the Host module

clayborg added inline comments. Comment at: source/Host/macosx/Host.mm:1501 +bool monitoring = launch_info.MonitorProcess(); +(void)monitoring; +assert(monitoring); Do we not have a macro for silencing unused variables? Comment at:

[Lldb-commits] [PATCH] D46395: Remove Process references from the Host module

davide accepted this revision. davide added a comment. lg https://reviews.llvm.org/D46395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46395: Remove Process references from the Host module

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This is a cleaner approach. Might be worth adding a comment in the MonitoringProcessLauncher.h saying that the monitoring callback in the ProcessLaunchInfo is required? You might from the

[Lldb-commits] [PATCH] D46395: Remove Process references from the Host module

labath created this revision. labath added reviewers: jingham, davide. Herald added a subscriber: emaste. The Process class was only being referenced because of the last-ditch effort in the process launchers to set a process exit callback in case one isn't set already. Although launching a

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

This revision was automatically updated to reflect the committed changes. Closed by commit rL331463: [CMake] Unify and relayer testing (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D46334?vs=145033=145035#toc Repository: rL LLVM

[Lldb-commits] [lldb] r331463 - [CMake] Unify and relayer testing

Author: jdevlieghere Date: Thu May 3 09:54:10 2018 New Revision: 331463 URL: http://llvm.org/viewvc/llvm-project?rev=331463=rev Log: [CMake] Unify and relayer testing This patch restructures part of LLDB's testing configuration: 1. I moved the test dependencies up the chain so every dotest

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

This revision was automatically updated to reflect the committed changes. Closed by commit rL331462: DWARFExpression: Convert file addresses to load addresses early on. (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r331462 - DWARFExpression: Convert file addresses to load addresses early on.

Author: adrian Date: Thu May 3 09:51:37 2018 New Revision: 331462 URL: http://llvm.org/viewvc/llvm-project?rev=331462=rev Log: DWARFExpression: Convert file addresses to load addresses early on. This is a change that only affects Swift and is NFC for the language plugins on llvm.org. In Swift,

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. I still need to verify this works with VS on Windows, but feel free to check in to unblock the bots https://reviews.llvm.org/D46334

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

JDevlieghere updated this revision to Diff 145033. JDevlieghere added a comment. Herald added a reviewer: alexshap. update diff pro forma https://reviews.llvm.org/D46334 Files: CMakeLists.txt lit/CMakeLists.txt lit/Suite/lit.site.cfg.in test/CMakeLists.txt test/lldb-dotest.in

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

labath added subscribers: aprantl, davide, JDevlieghere, zturner. labath added a comment. I remember hearing some people use the check-lldb-single target, but it had to do with running the tests against some remote devices/stubs that did not handle multiple connections very well. However, the

Re: [Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

I remember hearing some people use the check-lldb-single target, but it had to do with running the tests against some remote devices/stubs that did not handle multiple connections very well. However, the way it seems to me, with the transition to lit, this target will have to go away sooner or

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

aprantl updated this revision to Diff 145032. aprantl added a comment. Thanks for the excellent feedback! Addressed comments. https://reviews.llvm.org/D46362 Files: include/lldb/Core/Value.h source/Core/Value.cpp source/Core/ValueObjectVariable.cpp source/Expression/DWARFExpression.cpp

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

aprantl added a comment. > If by as-is you mean with a big comment in the config file before the > creation of check-single that it is broken, then yes, let's get the bots > unblocked and then fix the issue. Sounds good. Thanks! https://reviews.llvm.org/D46334

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

stella.stamenova added a comment. If by as-is you mean with a big comment in the config file before the creation of check-single that it is broken, then yes, let's get the bots unblocked and then fix the issue. https://reviews.llvm.org/D46334 ___

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

aprantl added a comment. If that's okay with you I would suggest landing this as is to unblock the bots, and we'll keep working on fixing the check-single target ASAP, too. https://reviews.llvm.org/D46334 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

stella.stamenova added a comment. In its current version, the patch won't *break* the windows build (the previous change broke the build as well as tests), so if it will unblock the bots, Jonas could check it in and then fix check-single in a follow up patch. I think it needs to be explicit if

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. Ping. I would like to get this in. As for testing, the full matrix should be run on .debug_types as it is the main form of type uniquing that is defined by the DWARF spec. Any formats that are fully accepted and written into the DWARF spec should be fully tested to

[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

aprantl added a comment. Is there a way to land a partial version of this patch to un-block the green dragon bots and keep iterating on the check-single target separately? Or do other bots depend on check-single working correctly? I'm really uneasy about the fact that we are loosing signal

[Lldb-commits] [lldb] r331458 - Remove the timed_out out-argument from Predicate::WaitForValueEqualTo

Author: labath Date: Thu May 3 08:33:41 2018 New Revision: 331458 URL: http://llvm.org/viewvc/llvm-project?rev=331458=rev Log: Remove the timed_out out-argument from Predicate::WaitForValueEqualTo The function can only return in one of two ways: the Predicate value is successfully set within

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. great fix. Just resolve the file address using the module function and this is good to go. Comment at: source/Core/Value.cpp:683-685 + ObjectFile *objfile =

[Lldb-commits] [PATCH] D46318: lldb-test symbols: Add ability to do name-based lookup

This revision was automatically updated to reflect the committed changes. labath marked 2 inline comments as done. Closed by commit rL331447: lldb-test symbols: Add ability to do name-based lookup (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r331447 - lldb-test symbols: Add ability to do name-based lookup

Author: labath Date: Thu May 3 03:57:16 2018 New Revision: 331447 URL: http://llvm.org/viewvc/llvm-project?rev=331447=rev Log: lldb-test symbols: Add ability to do name-based lookup Summary: lldb-test already had the ability to dump all symbol information in a module. This is interesting, but

[Lldb-commits] [PATCH] D46318: lldb-test symbols: Add ability to do name-based lookup

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A few more nits but otherwise this LGTM. Comment at: tools/lldb-test/lldb-test.cpp:463 DebuggerLifetime->Terminate(); return 0; labath

[Lldb-commits] [PATCH] D46362: DWARFExpression: Convert file addresses to load addresses early on

labath added a comment. One day I'd like us to have a unit testing framework for the dwarf expression evaluator. The evaluator looks like a thing that is both complex enough (so it's worth doing it) and /ought to be/ self-contained enough (so it is doable). Then we could test these, and all

[Lldb-commits] [PATCH] D44998: ObjectFileELF: Add support for arbitrarily named code sections

kbaladurin added a comment. Thank you very much! Repository: rL LLVM https://reviews.llvm.org/D44998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits