Re: [Lldb-commits] [lldb] r332162 - [LLDB] Support GNU-style compressed debug sections (.zdebug)

On Fri, May 11, 2018 at 5:57 PM, Davide Italiano wrote: > On Fri, May 11, 2018 at 5:29 PM, Davide Italiano via lldb-commits > wrote: >> Author: davide >> Date: Fri May 11 17:29:25 2018 >> New Revision: 332162 >> >> URL:

[Lldb-commits] [lldb] r332165 - Revert "[LLDB] Support GNU-style compressed debug sections (.zdebug)"

Author: davide Date: Fri May 11 18:25:48 2018 New Revision: 332165 URL: http://llvm.org/viewvc/llvm-project?rev=332165=rev Log: Revert "[LLDB] Support GNU-style compressed debug sections (.zdebug)" This reverts commit r332162 as it breaks the bots (Ubuntu 14.04) with the following message:

Re: [Lldb-commits] [lldb] r332162 - [LLDB] Support GNU-style compressed debug sections (.zdebug)

On Fri, May 11, 2018 at 5:29 PM, Davide Italiano via lldb-commits wrote: > Author: davide > Date: Fri May 11 17:29:25 2018 > New Revision: 332162 > > URL: http://llvm.org/viewvc/llvm-project?rev=332162=rev > Log: > [LLDB] Support GNU-style compressed debug sections

[Lldb-commits] [lldb] r332163 - [LanguageRuntime/ObjC] Turn off ISA logging once and for all.

Author: davide Date: Fri May 11 17:33:12 2018 New Revision: 332163 URL: http://llvm.org/viewvc/llvm-project?rev=332163=rev Log: [LanguageRuntime/ObjC] Turn off ISA logging once and for all. On behalf of Jim, who's out today. Modified:

[Lldb-commits] [PATCH] D45628: [LLDB] Support GNU-style compressed debug sections (.zdebug)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL332162: [LLDB] Support GNU-style compressed debug sections (.zdebug) (authored by davide, committed by ). Changed prior

[Lldb-commits] [lldb] r332162 - [LLDB] Support GNU-style compressed debug sections (.zdebug)

Author: davide Date: Fri May 11 17:29:25 2018 New Revision: 332162 URL: http://llvm.org/viewvc/llvm-project?rev=332162=rev Log: [LLDB] Support GNU-style compressed debug sections (.zdebug) Patch by Erik Welander! Differential Revision: https://reviews.llvm.org/D45628 Added:

[Lldb-commits] [PATCH] D46783: FileSpec objects that resolve to "." should have "." in m_filename and m_directory empty.

clayborg created this revision. clayborg added reviewers: labath, jingham, davide, zturner. After switching to LLVM normalization, if we init FileSpec with "." we would end up with m_directory being NULL and m_filename being "". This patch fixes this by allowing the path to be normalized and if

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

probinson added a comment. Go for it. It sounds like an abstraction that hides the multiple-section nature of the beast will particularly help LLDB; on the LLVM side the dumper will want to remain a bit more cognizant of the underlying sections. But we can surely leverage ideas from each

[Lldb-commits] [lldb] r332140 - Conditionally compile a Darwin-only test.

Author: adrian Date: Fri May 11 14:05:32 2018 New Revision: 332140 URL: http://llvm.org/viewvc/llvm-project?rev=332140=rev Log: Conditionally compile a Darwin-only test. Modified: lldb/trunk/unittests/Host/HostInfoTest.cpp Modified: lldb/trunk/unittests/Host/HostInfoTest.cpp URL:

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

clayborg added a comment. After reading Pavel's and Paul's comments, I will come up with a solution that allows multiple sections to be combined into one large section. That way it will be all legal and easy to extend. If we have just .debug_info, then we can use a base class that just calls

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

probinson added a comment. I haven't given Pavel's comments as much thought as they deserve, but here are some of mine. It's a worthwhile point that a class ought to represent some useful and reasonably well defined abstraction. DataExtractor has one, and DWARFDataExtractor builds on that

[Lldb-commits] [lldb] r332126 - Yet another follow-up to r332111. This also handles the case where an

Author: adrian Date: Fri May 11 12:29:25 2018 New Revision: 332126 URL: http://llvm.org/viewvc/llvm-project?rev=332126=rev Log: Yet another follow-up to r332111. This also handles the case where an LLDB.framework is built inside the LLDB build directory (but not inside an Xcode installation).

[Lldb-commits] [lldb] r332120 - Fix a regression in r332111. The LLDB.framework path component is not

Author: adrian Date: Fri May 11 12:00:58 2018 New Revision: 332120 URL: http://llvm.org/viewvc/llvm-project?rev=332120=rev Log: Fix a regression in r332111. The LLDB.framework path component is not usually the last component. Modified: lldb/trunk/source/Host/macosx/HostInfoMacOSX.mm

[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

compnerd added inline comments. Comment at: cmake/modules/FindLibEdit.cmake:11-14 +# libedit_FOUND - true if libedit was found +# libedit_INCLUDE_DIRS - include search path +# libedit_LIBRARIES - libraries to link +# libedit_VERSION - version number

[Lldb-commits] [PATCH] D46733: Add a lock to PlatformPOSIX::DoLoadImage

This revision was automatically updated to reflect the committed changes. Closed by commit rL332115: Add a lock to PlatformPOSIX::DoLoadImage (authored by friss, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r332115 - Add a lock to PlatformPOSIX::DoLoadImage

Author: friss Date: Fri May 11 11:21:11 2018 New Revision: 332115 URL: http://llvm.org/viewvc/llvm-project?rev=332115=rev Log: Add a lock to PlatformPOSIX::DoLoadImage Summary: Multiple threads could be calling into DoLoadImage concurrently, only one should be allowed to create the

[Lldb-commits] [PATCH] D46736: HostInfoMacOSX: Share the clang resource directory with Swift.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332111: HostInfoMacOSX: Share the clang resource directory with Swift. (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r332111 - HostInfoMacOSX: Share the clang resource directory with Swift.

Author: adrian Date: Fri May 11 10:54:09 2018 New Revision: 332111 URL: http://llvm.org/viewvc/llvm-project?rev=332111=rev Log: HostInfoMacOSX: Share the clang resource directory with Swift. Inside Xcode and in Xcode toolchains LLDB is always in lockstep with the Swift compiler, so it can reuse

[Lldb-commits] [PATCH] D46736: HostInfoMacOSX: Share the clang resource directory with Swift.

friss accepted this revision. friss added inline comments. This revision is now accepted and ready to land. Comment at: source/Host/macosx/HostInfoMacOSX.mm:288 + // Fall back to the Clang resource directory inside the framework. + raw_path.resize(rev_it - r_end);

[Lldb-commits] [PATCH] D46753: FileSpec: Remove PathSyntax enum and use llvm version instead

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Fine to use llvm's enum as long as we don't export the style through the SB API https://reviews.llvm.org/D46753 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D46733: Add a lock to PlatformPOSIX::DoLoadImage

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Much better. https://reviews.llvm.org/D46733 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D46687: Remove custom path manipulation functions from FileSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rL332088: Remove custom path manipulation functions from FileSpec (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46687

[Lldb-commits] [lldb] r332088 - Remove custom path manipulation functions from FileSpec

Author: labath Date: Fri May 11 04:55:34 2018 New Revision: 332088 URL: http://llvm.org/viewvc/llvm-project?rev=332088=rev Log: Remove custom path manipulation functions from FileSpec Summary: now that llvm supports host-agnostic path manipulation functions (and most of their kinks have been

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

labath added a comment. The thing here is that I don't see how can be done in a non-hacky way in DWARFDataExtractor while DWARFDataExtractor remains a (subclass of) DataExtractor. And it is a hack because as soon as you slide the extractor, a number of its functions become booby-trapped