[Lldb-commits] [PATCH] D47278: Remove lldb-private headers when building LLDB.framework with CMake

xiaobai updated this revision to Diff 148688. xiaobai added a comment. Updating to reflect changes in r04 https://reviews.llvm.org/D47278 Files: source/API/CMakeLists.txt Index: source/API/CMakeLists.txt === ---

[Lldb-commits] [lldb] r333322 - Fix Xcode build broken by SystemInitializerFull.h move

Author: xiaobai Date: Fri May 25 16:21:07 2018 New Revision: 22 URL: http://llvm.org/viewvc/llvm-project?rev=22=rev Log: Fix Xcode build broken by SystemInitializerFull.h move Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [PATCH] D47342: Move SystemInitializerFull header to source/API

This revision was automatically updated to reflect the committed changes. Closed by commit rL04: Move SystemInitializerFull header to source/API (authored by xiaobai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r333304 - Move SystemInitializerFull header to source/API

Author: xiaobai Date: Fri May 25 13:28:16 2018 New Revision: 04 URL: http://llvm.org/viewvc/llvm-project?rev=04=rev Log: Move SystemInitializerFull header to source/API Summary: It seems to me that files in include/lldb/API/ are headers that should be exposed to liblldb users. Because

[Lldb-commits] [lldb] r333299 - Fix typo in CMake comments

Author: xiaobai Date: Fri May 25 11:59:21 2018 New Revision: 333299 URL: http://llvm.org/viewvc/llvm-project?rev=333299=rev Log: Fix typo in CMake comments Modified: lldb/trunk/cmake/modules/LLDBStandalone.cmake Modified: lldb/trunk/cmake/modules/LLDBStandalone.cmake URL:

[Lldb-commits] [PATCH] D47302: [lldb, lldb-mi] Add method AddCurrentTargetSharedObjectPath to the SBDebugger.

polyakov.alex added a comment. In https://reviews.llvm.org/D47302#637, @clayborg wrote: > In https://reviews.llvm.org/D47302#569, @polyakov.alex wrote: > > > In https://reviews.llvm.org/D47302#497, @clayborg wrote: > > > > > no. Create a new SBTargetSettings class. SBTarget will hand

[Lldb-commits] [PATCH] D47384: Remove dependency from Host to clang

zturner created this revision. zturner added reviewers: labath, davide. Herald added a subscriber: mgorny. The idea is to move the discovery of the clang resource directory into a more appropriate place, such as the clang expression parser. By continuing with this pattern we can isolate all

[Lldb-commits] [PATCH] D47235: Move ModuleList's dependency on clangDriver into Host

zturner added a comment. That sounds good to me as well. https://reviews.llvm.org/D47235 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r333273 - Fix format string

Author: d0k Date: Fri May 25 05:59:59 2018 New Revision: 333273 URL: http://llvm.org/viewvc/llvm-project?rev=333273=rev Log: Fix format string PRIx64 already has the x inside, so this was creating a nonsensical format string. Modified:

[Lldb-commits] [PATCH] D47368: ManualDWARFIndex: Treat DW_TAG_subprogram and DW_TAG_inlined_subroutine the same way

labath created this revision. labath added reviewers: clayborg, JDevlieghere. Herald added a subscriber: eraman. We were treating subprograms and inlined subroutines differently when building the index. The difference was in which indexes were individual tags inserted (subprograms went to all

[Lldb-commits] [lldb] r333266 - ManualDWARFIndex: Fix misclassification of methods in unions

Author: labath Date: Fri May 25 03:49:11 2018 New Revision: 333266 URL: http://llvm.org/viewvc/llvm-project?rev=333266=rev Log: ManualDWARFIndex: Fix misclassification of methods in unions Apple index was already treating them as methods. Not doing the same seems like an omission. Added:

[Lldb-commits] [lldb] r333264 - ManualDWARFIndex: reduce long parameter lists

Author: labath Date: Fri May 25 02:55:51 2018 New Revision: 333264 URL: http://llvm.org/viewvc/llvm-project?rev=333264=rev Log: ManualDWARFIndex: reduce long parameter lists Several functions were passing a list of 8 NameToDIE arguments around. This puts those variables in a struct and passes

[Lldb-commits] [PATCH] D47235: Move ModuleList's dependency on clangDriver into Host

labath added a comment. Moving the assertion into `ClangModulesDeclVendor` seems like a good idea to me. If that's the only place that actually requires the value to be non-empty, then it should be the thing asserting it (we can put a helpful message in the assert statement telling the user

[Lldb-commits] [PATCH] D47302: [lldb, lldb-mi] Add method AddCurrentTargetSharedObjectPath to the SBDebugger.

labath added a comment. In https://reviews.llvm.org/D47302#641, @clayborg wrote: > Be sure to not pass through any experimental settings. About that, do we want to have some non-api breaking way of accessing the settings (like, `SBSomething GetSetting(std::string setting_name)`). This

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:312 void DWARFUnit::ClearDIEs(bool keep_compile_unit_die) { + m_die_array.clear(); labath wrote: > You are ignoring the keep_compile_unit_die argument here. Is

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

labath added a comment. +1 for the cleanup. The `m_die_array_size` function is just weird Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:312 void DWARFUnit::ClearDIEs(bool keep_compile_unit_die) { + m_die_array.clear(); You are ignoring the