[Lldb-commits] [PATCH] D47797: [lldb-mi] Re-implement MI -exec-next command.

stella.stamenova added inline comments. Comment at: lit/tools/lldb-mi/exec/exec-next.test:2 +# XFAIL: windows +# -> llvm.org/pr24452 +# aprantl wrote: > @stella.stemanova: Would be interesting to understand why (/if ?) this > doesn't work on windows I can test i

[Lldb-commits] [PATCH] D47792: Fix up Info.plist when building LLDB.framework with CMake

clayborg added inline comments. Comment at: source/API/CMakeLists.txt:184 + set(EXECUTABLE_NAME "LLDB") + set(CURRENT_PROJECT_VERSION "360.99.0") set_target_properties(liblldb PROPERTIES Currently the apple generic versioning is used and the value for this i

[Lldb-commits] [PATCH] D47792: Fix up Info.plist when building LLDB.framework with CMake

sas added inline comments. Comment at: source/API/CMakeLists.txt:184 + set(EXECUTABLE_NAME "LLDB") + set(CURRENT_PROJECT_VERSION "360.99.0") set_target_properties(liblldb PROPERTIES Hardcoding this here isn't ideal. Where did you get this number from? Is the

[Lldb-commits] [PATCH] D47801: Make lldb tools dependent on liblldb target when building LLDB.framework with CMake

sas added a comment. Don't we risk creating circular dependencies with this? What happens when a tool depends on liblldb? you'll have theTool depend on liblldb and liblldb depend on theTool. https://reviews.llvm.org/D47801 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D47797: [lldb-mi] Re-implement MI -exec-next command.

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lit/tools/lldb-mi/exec/exec-next.test:2 +# XFAIL: windows +# -> llvm.org/pr24452 +# @stella.stemanova: Would be interesting to understand w

[Lldb-commits] [PATCH] D47801: Make lldb tools dependent on liblldb target when building LLDB.framework with CMake

xiaobai created this revision. xiaobai added reviewers: sas, clayborg, labath. Herald added a subscriber: mgorny. When you build LLDB.framework with cmake, the liblldb target is built as a framework. When lldb tools are built with INCLUDE_IN_FRAMEWORK, then LLDB.framework should depend on those to

[Lldb-commits] [PATCH] D47797: [lldb-mi] Re-implement MI -exec-next command.

polyakov.alex created this revision. polyakov.alex added reviewers: aprantl, clayborg. Herald added a subscriber: ki.stfu. Now -exec-next command uses SB API for stepping over. https://reviews.llvm.org/D47797 Files: lit/tools/lldb-mi/exec/exec-next.test lit/tools/lldb-mi/exec/inputs/main.c

[Lldb-commits] [PATCH] D47781: DebugNamesDWARFIndex: Add ability to lookup variables

clayborg added a comment. Feel free to check into it and modify the contract for GetGlobalVariables and possibly rename "name" to "basename" to be clear what the argument is. Then modify the headerdoc to clearly state what we are looking for if the filtering is going on higher up https://revi

[Lldb-commits] [PATCH] D47781: DebugNamesDWARFIndex: Add ability to lookup variables

labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:70 + continue; + +Append(entry, offsets); clayborg wrote: > Need to check for the context matches here if context is not empty. Hmm... thanks for pointing

[Lldb-commits] [PATCH] D47791: Initial support for Hexagon target.

ruiu added inline comments. Comment at: ELF/Arch/Hexagon.cpp:47 + for (size_t Bit = 0; Bit != 32; ++Bit) { +const bool ValBit = (Data >> Off) & 1; +const bool MaskBit = (Mask >> Bit) & 1; We normally don't add `const` if the variable's scope is narrow.

[Lldb-commits] [PATCH] D47791: Initial support for Hexagon target.

sidneym updated this revision to Diff 150013. sidneym added a comment. Made the changes Rui suggested. Repository: rLLD LLVM Linker https://reviews.llvm.org/D47791 Files: ELF/Arch/Hexagon.cpp ELF/CMakeLists.txt ELF/Target.cpp ELF/Target.h test/ELF/Inputs/hexagon.s test/ELF/hexago

[Lldb-commits] [PATCH] D47791: Initial support for Hexagon target.

ruiu added inline comments. Comment at: ELF/Arch/Hexagon.cpp:46 + + for (size_t Bit = 0; Bit != sizeof(uint32_t) * 8; ++Bit) { +const bool ValBit = (Data >> Off) & 1; sizeof(uint32_t) * 8 is always 32. Comment at: ELF/Arch/Hexagon.cpp:77 +

[Lldb-commits] [PATCH] D47792: Fix up Info.plist when building LLDB.framework with CMake

xiaobai created this revision. xiaobai added reviewers: sas, clayborg. Herald added a subscriber: mgorny. We weren't using the Info.plist template in resources previously. When using that template, some of the key's values weren't being populated because some variables were not being defined. In o

[Lldb-commits] [PATCH] D47791: Initial support for Hexagon target.

sidneym created this revision. sidneym added reviewers: ruiu, shankar.easwaran, kparzysz, bcahoon. sidneym added a project: lld. Herald added subscribers: MaskRay, arichardson, mgorny, emaste. Herald added a reviewer: espindola. Support B22_PCREL relocation along with a simple test. I'm also work

[Lldb-commits] [PATCH] D47708: PDB support of function-level linking and splitted functions

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM - will commit for you https://reviews.llvm.org/D47708 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[Lldb-commits] [PATCH] D47781: DebugNamesDWARFIndex: Add ability to lookup variables

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Check the context as noted in inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:70 + continue; + +Append(entry, off

[Lldb-commits] [PATCH] D47629: [DWARF] Add (empty) DebugNamesDWARFIndex class and a setting to control its use

clayborg accepted this revision. clayborg added a comment. I like this new setting much better. Looks good. https://reviews.llvm.org/D47629 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] r334025 - [lit, pdb] Fix func-symbols.test (on Windows)

Author: stella.stamenova Date: Tue Jun 5 09:20:36 2018 New Revision: 334025 URL: http://llvm.org/viewvc/llvm-project?rev=334025&view=rev Log: [lit, pdb] Fix func-symbols.test (on Windows) Summary: This test was failing sporadically on windows because the order in which the symbols are generated

[Lldb-commits] [PATCH] D47781: DebugNamesDWARFIndex: Add ability to lookup variables

labath created this revision. labath added reviewers: clayborg, JDevlieghere. Herald added a subscriber: aprantl. This adds the ability to lookup variables to the DWARF v5 index class. find-basic-variable.cpp test is extended to cover this scenario as well, and I have added a new test which verifi

[Lldb-commits] [PATCH] D47629: [DWARF] Add (empty) DebugNamesDWARFIndex class and a setting to control its use

labath updated this revision to Diff 149964. labath added a comment. This makes the setting non-experimental and renames it to "ignore-file-indexes". I've also wired up the index dump methods to Module::Dump so that I could write a test that apple indexes are indeed being used after this. https:

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil added a comment. Thanks for https://reviews.llvm.org/rL333996 fixups. Repository: rL LLVM https://reviews.llvm.org/D40470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] r334012 - DWARFIndex: more GetFunctions cleanup

Author: labath Date: Tue Jun 5 05:13:22 2018 New Revision: 334012 URL: http://llvm.org/viewvc/llvm-project?rev=334012&view=rev Log: DWARFIndex: more GetFunctions cleanup This applies similar simplification as r334004, only it touches the regex version of the method. Modified: lldb/trunk/sou

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

labath added a comment. In https://reviews.llvm.org/D47062#1109399, @JDevlieghere wrote: > I'm going to hold off on this until we have decided what to do for > https://reviews.llvm.org/D46005. If we run the test cases as separate lit > invocations, then the test format is in a better position t

[Lldb-commits] [PATCH] D47265: WIP: lit: Run each test separately

labath updated this revision to Diff 149936. labath added a comment. No real change in functionality, just updating the diff to remove the unrelated changes. https://reviews.llvm.org/D47265 Files: lit/Suite/lldbtest.py Index: lit/Suite/lldbtest.py ===

[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

This revision was automatically updated to reflect the committed changes. Closed by commit rL334009: dotest: make inline tests compatible with -f (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47579 Files: lldb/tru

[Lldb-commits] [lldb] r334009 - dotest: make inline tests compatible with -f

Author: labath Date: Tue Jun 5 03:58:44 2018 New Revision: 334009 URL: http://llvm.org/viewvc/llvm-project?rev=334009&view=rev Log: dotest: make inline tests compatible with -f Summary: This is split off from D47265 where I needed to be able to invoke every test with -f. That patch is kinda dead

[Lldb-commits] [lldb] r334006 - Fix windows build broken by r334004

Author: labath Date: Tue Jun 5 03:49:56 2018 New Revision: 334006 URL: http://llvm.org/viewvc/llvm-project?rev=334006&view=rev Log: Fix windows build broken by r334004 The problem was a link error due to a missing =0 on an abstract method. Interestingly, this was not a problem for clang/linux.

[Lldb-commits] [PATCH] D47147: DWARFIndex: Reduce duplication in the GetFunctions methods

This revision was automatically updated to reflect the committed changes. Closed by commit rL334004: DWARFIndex: simplify GetFunctions methods (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47147?vs=149702&id=1499

[Lldb-commits] [lldb] r334004 - DWARFIndex: simplify GetFunctions methods

Author: labath Date: Tue Jun 5 03:33:56 2018 New Revision: 334004 URL: http://llvm.org/viewvc/llvm-project?rev=334004&view=rev Log: DWARFIndex: simplify GetFunctions methods Now that Apple index determines method-ness straight from the debug info, we don't need to resolve the functions into Symb

[Lldb-commits] [lldb] r334003 - Really fix ClangParserTest

Author: labath Date: Tue Jun 5 03:29:48 2018 New Revision: 334003 URL: http://llvm.org/viewvc/llvm-project?rev=334003&view=rev Log: Really fix ClangParserTest It turns out the test needs a fixture after all (to initialize HostInfo), so provide one that does that. Modified: lldb/trunk/unitte

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

labath added a comment. Well, with these kinds of safeguards **I think** this could work. If I was the maintainer of std::vector in libstdc++ I am not sure if I would accept such a patch, but I am not, so feel free to try. :) Repository: rL LLVM https://reviews.llvm.org/D47492 ___

[Lldb-commits] [lldb] r333996 - Fixup r333987

Author: labath Date: Tue Jun 5 02:56:14 2018 New Revision: 333996 URL: http://llvm.org/viewvc/llvm-project?rev=333996&view=rev Log: Fixup r333987 - add #include (fixes windows build) - remove std::move (fixes "using move prevents copy ellision" warnings) Modified: lldb/trunk/source/Plugins

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

jankratochvil added a comment. In https://reviews.llvm.org/D47492#1122080, @labath wrote: > It doesn't look like your code verifies that the user hasn't replaced the > global `operator new` by defining a custom version. > http://en.cppreference.com/w/cpp/memory/new/operator_new: I asked about

[Lldb-commits] [lldb] r333992 - Fix ClangParserTest.cpp

Author: labath Date: Tue Jun 5 02:33:26 2018 New Revision: 333992 URL: http://llvm.org/viewvc/llvm-project?rev=333992&view=rev Log: Fix ClangParserTest.cpp The test does not use a test fixture, so it needs to be declared with the TEST macro. Modified: lldb/trunk/unittests/Expression/ClangPa

[Lldb-commits] [PATCH] D47629: [DWARF] Add (empty) DebugNamesDWARFIndex class and a setting to control its use

labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:122 +PropertyDefinition g_experimental_properties[] = { +{"use-debug-names", OptionValue::eTypeBoolean, true, 0, nullptr, nullptr, + "Use .debug_names index section."}, -

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

labath added a comment. In https://reviews.llvm.org/D47492#1122039, @jankratochvil wrote: > In https://reviews.llvm.org/D47492#1121543, @dblaikie wrote: > > > Happy to help explain it - which part(s) are you having a bit of trouble > > with? > > > What's wrong on this implementation >

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil added a comment. FYI I have reordered `m_cu->m_die_array_scoped_mutex.unlock_shared();` in `DWARFUnit::ScopedExtractDIEs::~ScopedExtractDIEs()` during commit (it was written this new way in some other of the 4 offered variants). Repository: rL LLVM https://reviews.llvm.org/D40

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

This revision was automatically updated to reflect the committed changes. Closed by commit rL333987: Protect DWARFCompileUnit::m_die_array by new mutexes (authored by jankratochvil, committed by ). Changed prior to commit: https://reviews.llvm.org/D40470?vs=149609&id=149917#toc Repository: r

[Lldb-commits] [lldb] r333987 - Protect DWARFCompileUnit::m_die_array by new mutexes

Author: jankratochvil Date: Tue Jun 5 01:52:18 2018 New Revision: 333987 URL: http://llvm.org/viewvc/llvm-project?rev=333987&view=rev Log: Protect DWARFCompileUnit::m_die_array by new mutexes If BuildAddressRangeTable called ExtractDIEsIfNeeded(false), then another thread started processing data

[Lldb-commits] [PATCH] D47492: DWARFUnit::m_die_array swap()->shrink_to_fit()

jankratochvil added a comment. In https://reviews.llvm.org/D47492#1121543, @dblaikie wrote: > Happy to help explain it - which part(s) are you having a bit of trouble with? What's wrong on this implementation ? > It seems like th