jingham added a comment.
This is great. The only quibble I have is that I would really like to restrict
ArgsWithSuffix to be "OptionsWithSuffix". I don't think we want to add:
(lldb) some_cmd -f 0 -g 0 SomeArg OtherArg -- raw string
That seems unnecessarily general, and not terribly helpful.
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This is good. I had a few inline comments, mostly about the command syntax. I
think you should switch "-m" to "-s" since that's what we use in the other
similar places.
For the
davide created this revision.
davide added a reviewer: labath.
Herald added a subscriber: krytarowski.
On systems where it's not supported.
As far as I understand Linux is the only systems which now ships with libstdcxx
(maybe NetBSD?, but I'm not entirely sure of the state of lldb on the platfor
teemperor created this revision.
teemperor added a reviewer: jingham.
Herald added a subscriber: mgorny.
A subset of the LLDB commands follows this command line interface style:
[arguments] --
The parsing code for this interface has been so far been duplicated into the
different
command obj
amccarth added inline comments.
Comment at: source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp:52
if (!m_reg_context_sp)
-m_reg_context_sp = CreateRegisterContextForFrameIndex(0);
+m_reg_context_sp = CreateRegisterContextForZerothFrame();
stella.stamenova added a comment.
I'm actually in the middle of cleaning up the change attached to this bug:
https://bugs.llvm.org/show_bug.cgi?id=37495 which is equivalent functionally
but follows the pattern for the other targets. Let me run some tests and I'll
submit it for review. It should
Author: davide
Date: Mon Jul 9 14:56:28 2018
New Revision: 336608
URL: http://llvm.org/viewvc/llvm-project?rev=336608&view=rev
Log:
Rollback [test-suite] Add a decorator for the lack of libstdcxx on the system.
Pavel suggested an alternative approach that I'll try to implement.
Modified:
ll
Author: davide
Date: Mon Jul 9 14:53:43 2018
New Revision: 336607
URL: http://llvm.org/viewvc/llvm-project?rev=336607&view=rev
Log:
[ObjCRuntime] Add support for obfuscation in tagged pointers.
This is the default in MacOS Mojave. No testcases, as basically
we have a lot of coverage (and the tes
jasonmolenda added a comment.
(just to be clear, the m_thread_pcs.clear() in
ProcessGDBRemote::UpdateThreadIDList that I called a bug -- today we only have
two ways of populating that, jThreadsInfo or the thread-pcs: value in the stop
packet. So clearing it unconditionally here, and then popul
jasonmolenda added a comment.
I could imagine there being a bug in this ProcessGDBRemote::UpdateThreadIDList
-> ProcessGDBRemote::UpdateThreadIDsFromStopReplyThreadsValue sequence when
talking to a gdb-remote stub that does not implement the lldb-enhancement
jThreadsInfo. If jThreadsInfo isn't
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336582: Don't take the address of an xvalue when
printing an expr result (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
Author: teemperor
Date: Mon Jul 9 11:57:11 2018
New Revision: 336582
URL: http://llvm.org/viewvc/llvm-project?rev=336582&view=rev
Log:
Don't take the address of an xvalue when printing an expr result
Summary:
If we have an xvalue here, we will always hit the
`err_typecheck_invalid_lvalue_addrof
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM. This looks pretty cut and dry. The evaluator shouldn't try to
take the address of an rvalue.
https://reviews.llvm.org/D48303
___
lldb-co
teemperor updated this revision to Diff 154656.
teemperor edited the summary of this revision.
teemperor added a subscriber: vsk.
teemperor added a comment.
- Removed unnecessary include from the test.
https://reviews.llvm.org/D48303
Files:
packages/Python/lldbsuite/test/expression_command/xv
apolyakov added inline comments.
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py:22
@skipIfDarwin # pexpect is known to be unreliable on Darwin
@skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread
races
def test_
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py:22
@skipIfDarwin # pexpect is known to be unreliable on Darwin
@skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread
races
def test_ll
stella.stamenova added a comment.
(gdb)
-file-exec-and-symbols
"E:\\_work\\4\\b\\LLVMBuild\\tools\\lldb\\lit\\tools\\lldb-mi\\symbol\\Output\\symbol-list-lines.test.tmp"
^done
(gdb)
^done
(gdb)
=library-loaded,id="E:\\_work\\4\\b\\LLVMBuild\\tools\\lldb\\lit\\tools\\lldb-mi\\symb
apolyakov added a comment.
Could you please provide an output of this command on Windows:
`E:\_work\4\b\LLVMBuild\Release\bin\lldb-mi.EXE --synchronous
E:\_work\4\b\LLVMBuild\tools\lldb\lit\tools\lldb-mi\symbol\Output\symbol-list-lines.test.tmp
<
E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\
stella.stamenova added a comment.
symbol-list-lines.test fails on windows. I'm trying to get through the rest of
the failing tests on Windows, so I can add a bot to run the tests and alert on
new failures.
FAIL: lldb :: tools/lldb-mi/symbol/symbol-list
Author: stella.stamenova
Date: Mon Jul 9 10:36:33 2018
New Revision: 336564
URL: http://llvm.org/viewvc/llvm-project?rev=336564&view=rev
Log:
Retrieve a function PDB symbol correctly from nested blocks
Summary:
This patch fixes a problem with retrieving a function symbol by an address in a
nest
apolyakov added inline comments.
Comment at: tools/lldb-mi/MICmdCmdData.cpp:1691
+break;
+ for (uint32_t j = 0, e = cu.GetNumLineEntries(); j < e; ++j) {
+const lldb::SBLineEntry &curLine = cu.GetLineEntryAtIndex(j);
aprantl wrote:
> @claybor
apolyakov updated this revision to Diff 154623.
apolyakov added a comment.
Returned accidentally removed backslashes in `self.expect` pattern, removed
comment from:
`#include // For std::to_string.`
https://reviews.llvm.org/D49062
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/data/Tes
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py:376
self.expect(
-"\^error,msg=\"Command 'data-info-line'\. Error: The LineEntry is
absent or has an unknown format\.\"")
+"\^error,msg=\"C
labath added a comment.
Could you elaborate on how/why is this wrong? E.g. in which situations does it
matter whether we clear the PC list?
https://reviews.llvm.org/D48868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.
24 matches
Mail list logo
