[Lldb-commits] [lldb] r338952 - Fixed header of StringLexer.h

Author: teemperor Date: Fri Aug 3 22:53:07 2018 New Revision: 338952 URL: http://llvm.org/viewvc/llvm-project?rev=338952=rev Log: Fixed header of StringLexer.h Modified: lldb/trunk/include/lldb/Utility/StringLexer.h Modified: lldb/trunk/include/lldb/Utility/StringLexer.h URL:

[Lldb-commits] [lldb] r338949 - Fix a bug in VMRange

Author: lemo Date: Fri Aug 3 19:15:26 2018 New Revision: 338949 URL: http://llvm.org/viewvc/llvm-project?rev=338949=rev Log: Fix a bug in VMRange I noticed a suspicious failure: [ RUN ] VMRange.CollectionContains llvm/src/tools/lldb/unittests/Utility/VMRangeTest.cpp:146: Failure Value of:

[Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL338949: Fix a bug in VMRange (authored by lemo, committed by ). Herald added a subscriber: llvm-commits. Changed prior

Re: [Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

Looks like i was wrong, nevermind! On Fri, Aug 3, 2018 at 6:23 PM Leonard Mosescu via Phabricator via lldb-commits wrote: > lemo added subscribers: bgianfo, labath, penryu, teemperor, zturner. > lemo added a comment. > > Thanks Zach. I can't find llvm::contains() though, any pointers to it? > >

[Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

zturner added a comment. Looks like i was wrong, nevermind! Repository: rLLDB LLDB https://reviews.llvm.org/D50290 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

lemo added subscribers: bgianfo, labath, penryu, teemperor, zturner. lemo added a comment. Thanks Zach. I can't find llvm::contains() though, any pointers to it? Repository: rLLDB LLDB https://reviews.llvm.org/D50290 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

Thanks Zach. I can't find llvm::contains() though, any pointers to it? On Fri, Aug 3, 2018 at 5:58 PM, Zachary Turner via Phabricator via lldb-commits wrote: > zturner added a subscriber: lemo. > zturner added a comment. > > I think we have llvm::contains() which would allow you to make this >

[Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

zturner added a subscriber: lemo. zturner added a comment. I think we have llvm::contains() which would allow you to make this slightly better. Other than that, good find! Repository: rLLDB LLDB https://reviews.llvm.org/D50290 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

I think we have llvm::contains() which would allow you to make this slightly better. Other than that, good find! On Fri, Aug 3, 2018 at 5:49 PM Leonard Mosescu via Phabricator < revi...@reviews.llvm.org> wrote: > lemo created this revision. > lemo added reviewers: zturner, labath, teemperor. >

[Lldb-commits] [PATCH] D49415: Add unit tests for VMRange

lemo added subscribers: teemperor, lemo. lemo added a comment. The new test cases did catch a real bug: [ RUN ] VMRange.CollectionContains llvm/src/tools/lldb/unittests/Utility/VMRangeTest.cpp:146: Failure Value of: VMRange::ContainsRange(collection, VMRange(0x100, 0x104)) Actual: false

Re: [Lldb-commits] [PATCH] D49415: Add unit tests for VMRange

The new test cases did catch a real bug: [ RUN ] VMRange.CollectionContains llvm/src/tools/lldb/unittests/Utility/VMRangeTest.cpp:146: Failure Value of: VMRange::ContainsRange(collection, VMRange(0x100, 0x104)) Actual: false Expected: true class RangeInRangeUnaryPredicate { public:

[Lldb-commits] [PATCH] D50290: Fix a bug in VMRange

lemo created this revision. lemo added reviewers: zturner, labath, teemperor. lemo added a project: LLDB. I noticed a suspicious failure: [ RUN ] VMRange.CollectionContains llvm/src/tools/lldb/unittests/Utility/VMRangeTest.cpp:146: Failure Value of: VMRange::ContainsRange(collection,

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo created this revision. lemo added reviewers: labath, clayborg. lemo added a project: LLDB. Herald added subscribers: JDevlieghere, arichardson, aprantl, emaste. Herald added a reviewer: espindola. This change improves the logging for the lldb.module category to note a few interesting cases:

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

teemperor added a comment. > CompletionRequest - this sounds like it could go next to the command > interpreter Yeah, makes sense. Even though Utility classes then can either not offer completion methods (currently only ArchSpec is doing that) or work around that with a forward decl. But I

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

zturner added a comment. For the Register stuff, for example, I think it could make sense for it to be in a project such as `HAL` (Hardware Abstraction Layer) or something similarly named. Everything that describes properties of specific CPUs could go there, perhaps even including `ArchSpec`.

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

jingham added a comment. First off, I'm fine with Zachary's suggestion that we let the dust settle a bit before we try to organize things better. We'll probably do a better job then. But just to use these cases, for instance, Scalar is the base of how we realize values in the debugger

[Lldb-commits] [lldb] r338923 - Modify lldb_suite.py to enable python debugging

Author: xiaobai Date: Fri Aug 3 14:37:01 2018 New Revision: 338923 URL: http://llvm.org/viewvc/llvm-project?rev=338923=rev Log: Modify lldb_suite.py to enable python debugging Summary: pudb and pdb interfere with the behavior of the inspect module. calling

[Lldb-commits] [PATCH] D50271: [IRMemoryMap] Shrink Allocation by sizeof(addr_t) (NFC)

vsk created this revision. vsk added reviewers: teemperor, lhames. Profiling data show that Allocation::operator= is hot, see: https://teemperor.de/lldb-bench/data/arithmetic.svg Reorder a few fields within Allocation to avoid implicit structure padding and shrink the structure. This should

[Lldb-commits] [PATCH] D50161: Add raw_ostream wrapper to the Stream class

teemperor added a comment. StreamTee is copying it, which is expected to be copyable when we copy CommandObjectResult around. And then I just added the copy-constructor as CommandObjectResult refactoring sound time-expensive. Repository: rL LLVM https://reviews.llvm.org/D50161

[Lldb-commits] [PATCH] D50162: Replace LLDB's LEB128 implementation with the one from LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL338920: Replace LLDBs LEB128 implementation with the one from LLVM (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r338920 - Replace LLDB's LEB128 implementation with the one from LLVM

Author: teemperor Date: Fri Aug 3 13:51:31 2018 New Revision: 338920 URL: http://llvm.org/viewvc/llvm-project?rev=338920=rev Log: Replace LLDB's LEB128 implementation with the one from LLVM Reviewers: davide, labath Reviewed By: labath Subscribers: lldb-commits Differential Revision:

[Lldb-commits] [PATCH] D49963: Preliminary patch to support prompt interpolation

nealsid accepted this revision. nealsid added inline comments. This revision is now accepted and ready to land. Comment at: include/lldb/Host/Editline.h:187 + /// Register a callback to retrieve the prompt. + void SetPromptCallback(PromptCallbackType callback, void *baton); +

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

zturner added a comment. Several months ago when this came up, i hypothesized that Utility would eventually contain a mix of random stuff some of which may not make sense in the long term. But that in the meantime, it’s useful to have some sort of layering abstraction for “has no other

Re: [Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

Several months ago when this came up, i hypothesized that Utility would eventually contain a mix of random stuff some of which may not make sense in the long term. But that in the meantime, it’s useful to have some sort of layering abstraction for “has no other dependencies”. Eventually when this

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

labath added a comment. In https://reviews.llvm.org/D49740#1187799, @jingham wrote: > I worry a little bit about Utility getting kind of incoherent. Some of it is > clearly utility, some is more there because that's where we are putting the > code we're trying to reduce dependencies on so we

[Lldb-commits] [PATCH] D50071: Use rich mangling information in Symtab::InitNameIndexes()

sgraenitz added a comment. I quickly realized, that it needs a bigger change to properly address the aforementioned issues. Here's the major changes. Some documentation is todo. **StringRef to reused buffer** addressed with a split into first parse then get buffer. It seems more natural that

[Lldb-commits] [PATCH] D50071: Use rich mangling information in Symtab::InitNameIndexes()

sgraenitz updated this revision to Diff 159066. sgraenitz added a comment. Polishing https://reviews.llvm.org/D50071 Files: include/lldb/Core/Mangled.h include/lldb/Core/RichManglingInfo.h include/lldb/Symbol/Symtab.h include/lldb/Utility/ConstString.h include/lldb/lldb-forward.h

[Lldb-commits] [PATCH] D50071: Use rich mangling information in Symtab::InitNameIndexes()

sgraenitz updated this revision to Diff 159065. sgraenitz added a comment. Polishing https://reviews.llvm.org/D50071 Files: include/lldb/Core/Mangled.h include/lldb/Core/RichManglingInfo.h include/lldb/Symbol/Symtab.h include/lldb/Utility/ConstString.h include/lldb/lldb-forward.h

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

jingham added a comment. I worry a little bit about Utility getting kind of incoherent. Some of it is clearly utility, some is more there because that's where we are putting the code we're trying to reduce dependencies on so we can share then with lldb-server. RegisterValue doesn't for

[Lldb-commits] [PATCH] D50225: Use a DenseMap for looking up functions by UID in CompileUnit::FindFunctionByUID

vsk added a comment. Thanks for doing this :)! Comment at: source/Symbol/CompileUnit.cpp:111 // TODO: order these by address m_functions.push_back(funcSP); } Is m_functions used to do anything crucial? I see a use in Dump, but it seems like you could

[Lldb-commits] [PATCH] D50161: Add raw_ostream wrapper to the Stream class

This revision was automatically updated to reflect the committed changes. Closed by commit rL338901: Add raw_ostream wrapper to the Stream class (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r338901 - Add raw_ostream wrapper to the Stream class

Author: teemperor Date: Fri Aug 3 09:56:33 2018 New Revision: 338901 URL: http://llvm.org/viewvc/llvm-project?rev=338901=rev Log: Add raw_ostream wrapper to the Stream class Summary: This wrapper will allow us in the future to reuse LLVM methods from within the Stream class. Currently no test

Re: [Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

No objections here On Fri, Aug 3, 2018 at 3:24 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > Does anyone have thoughts on this? (I have one more move like this lined > up (for the Listener/Broadcaster classes), and then I should be done with >

[Lldb-commits] [PATCH] D50071: Use rich mangling information in Symtab::InitNameIndexes()

sgraenitz added inline comments. Comment at: source/Core/RichManglingInfo.cpp:69-80 +const char *RichManglingInfo::GetFunctionBaseName() const { + switch (m_provider) { + case ItaniumPartialDemangler: +if (auto buf = m_IPD->getFunctionBaseName(m_IPD_buf, _IPD_size)) { +

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

labath added a comment. Does anyone have thoughts on this? (I have one more move like this lined up (for the Listener/Broadcaster classes), and then I should be done with these kinds of changes for a while.) https://reviews.llvm.org/D49740 ___

[Lldb-commits] [PATCH] D50071: Use rich mangling information in Symtab::InitNameIndexes()

labath added inline comments. Comment at: include/lldb/Core/RichManglingInfo.h:36 + /// "a::b". + llvm::StringRef GetFunctionDeclContextName() const; + sgraenitz wrote: > I realized that returning `llvm::StringRef` from here may not be the best > idea. To the

[Lldb-commits] [PATCH] D50071: Use rich mangling information in Symtab::InitNameIndexes()

sgraenitz added inline comments. Comment at: include/lldb/Core/RichManglingInfo.h:36 + /// "a::b". + llvm::StringRef GetFunctionDeclContextName() const; + I realized that returning `llvm::StringRef` from here may not be the best idea. To the outside it

[Lldb-commits] [PATCH] D50161: Add raw_ostream wrapper to the Stream class

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good to me. Thanks. Btw, have you looked at how hard would it be to actually fix the places that are copying these streams? https://reviews.llvm.org/D50161

Re: [Lldb-commits] [PATCH] D49750: Add support for ARM and ARM64 breakpad generated minidump files.

I've reverted this to keep the bots green until the issues pointed out by Stella and Raphael are resolved. Based on a quick inspection, it seems that the test issue is that `GetSystemInfo` call that has been added to MinidumpParser::Initialize is failing. I guess that's because the

[Lldb-commits] [lldb] r338828 - Revert "Add support for ARM and ARM64 breakpad generated minidump files"

Author: labath Date: Fri Aug 3 01:47:22 2018 New Revision: 338828 URL: http://llvm.org/viewvc/llvm-project?rev=338828=rev Log: Revert "Add support for ARM and ARM64 breakpad generated minidump files" This reverts commit r338734 (and subsequent fixups in r338772 and r338746), because it breaks

[Lldb-commits] [PATCH] D50162: Replace LLDB's LEB128 implementation with the one from LLVM

teemperor updated this revision to Diff 158930. teemperor added a reviewer: labath. teemperor added a comment. - Fixed compilation errors after changes in parent revision. https://reviews.llvm.org/D50162 Files: source/Utility/Stream.cpp Index: source/Utility/Stream.cpp

[Lldb-commits] [PATCH] D50161: Add raw_ostream wrapper to the Stream class

teemperor updated this revision to Diff 158926. teemperor added a reviewer: labath. teemperor added a comment. - Renamed m_forward_to to m_target. - Added a getter to allow external code to use the raw_ostream API. - Renamed m_forward to m_forwarder. @labath Thanks, fixed the problems you

[Lldb-commits] [PATCH] D49750: Add support for ARM and ARM64 breakpad generated minidump files.

teemperor added a comment. I don't see this mentioned here yet, so: This patch also seems to introduce a few hundred warnings with -Wextended-offsetof (which is enabled by default on the macOS builds):