Author: jmolenda
Date: Thu Sep 6 18:28:48 2018
New Revision: 341623
URL: http://llvm.org/viewvc/llvm-project?rev=341623=rev
Log:
Enable the fp-armv8 disassembler feature when disassembling Cortex-M
code. This will enable disassembly of the optional subset of
neon that some Cortex cores support.
xbolva00 added a comment.
In https://reviews.llvm.org/D51615#1226500, @stella.stamenova wrote:
> In https://reviews.llvm.org/D51615#1226494, @xbolva00 wrote:
>
> > In https://reviews.llvm.org/D51615#1226445, @stella.stamenova wrote:
> >
> > > In https://reviews.llvm.org/D51615#1226396, @xbolva00
stella.stamenova added a comment.
In https://reviews.llvm.org/D51615#1226494, @xbolva00 wrote:
> In https://reviews.llvm.org/D51615#1226445, @stella.stamenova wrote:
>
> > In https://reviews.llvm.org/D51615#1226396, @xbolva00 wrote:
> >
> > > Bot sure how to fix tests since this is somehow hard
xbolva00 added a comment.
In https://reviews.llvm.org/D51615#1226445, @stella.stamenova wrote:
> In https://reviews.llvm.org/D51615#1226396, @xbolva00 wrote:
>
> > Bot sure how to fix tests since this is somehow hard to problematic.
>
>
> I think the fix for this is simply to not make the call
stella.stamenova added a comment.
In https://reviews.llvm.org/D51615#1226396, @xbolva00 wrote:
> Bot sure how to fix tests since this is somehow hard to problematic.
I think the fix for this is simply to not make the call to SetUseColor here. Is
there a reason for the call? It looks like the
Cool. The argument about reverting still stands though (you might
consider following up with logs et simila to make debugging easier).
On Thu, Sep 6, 2018 at 2:10 PM Stella Stamenova via Phabricator
wrote:
>
> stella.stamenova added a comment.
>
> In https://reviews.llvm.org/D51615#1226386,
stella.stamenova added a comment.
In https://reviews.llvm.org/D51615#1226386, @davide wrote:
> You can probably revert it. BTW, is the bot public? I would like to
> understand whether I broke something after I commit.
>
> - Davide
It's not public (yet) because there's one more failure in the
xbolva00 added a comment.
Bot sure how to fix tests since this is somehow hard to problematic.
Repository:
rL LLVM
https://reviews.llvm.org/D51615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
You can probably revert it. BTW, is the bot public? I would like to
understand whether I broke something after I commit.
--
Davide
On Thu, Sep 6, 2018 at 11:21 AM Stella Stamenova via Phabricator via
lldb-commits wrote:
>
> stella.stamenova added a comment.
>
> This change causes one of the LLDB
stella.stamenova added a comment.
This change causes one of the LLDB tests to fail on Windows. More specifically:
FAIL: lldb :: Settings/TestDisableColor.test (42646 of 43956)
TEST 'lldb :: Settings/TestDisableColor.test' FAILED
Yeah, and we might as well refactor this function. I fell for the same
trap as Dávid when I touched this code for the first time. It's just
unexpected that a getter is doing important work... I'll prepare a
patch.
- Raphael
Am Do., 6. Sep. 2018 um 16:05 Uhr schrieb Greg Clayton :
>
> Might be a
clayborg added a comment.
Can we add a test for this?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51730
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Might be a good idea to add a comment in the code for this explaining the
desired side effects?
> On Sep 6, 2018, at 3:24 AM, Raphael Isemann via lldb-commits
> wrote:
>
> Author: teemperor
> Date: Thu Sep 6 03:24:11 2018
> New Revision: 341535
>
> URL:
JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, jingham, clayborg.
JDevlieghere added a project: LLDB.
After landing https://reviews.llvm.org/rL341457, we started seeing a failure on
the swift-lldb bots. The change was correct and pretty straightforward, a
Author: teemperor
Date: Thu Sep 6 03:24:11 2018
New Revision: 341535
URL: http://llvm.org/viewvc/llvm-project?rev=341535=rev
Log:
Reland [ClangUserExpression][NFC] Removed unused code
The GetLanguageForExpr has side effects, so we can't remove this
call without breaking the completion
Author: teemperor
Date: Thu Sep 6 02:42:44 2018
New Revision: 341532
URL: http://llvm.org/viewvc/llvm-project?rev=341532=rev
Log:
Revert "[ClangUserExpression][NFC] Removed unused code"
GetLanguageForExpr has side effects, so this actually breaks
the completion. Should fix TestExprCompletion.
16 matches
Mail list logo