clayborg added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:431
const size_t num_ranges =
-die->GetAttributeAddressRanges(dwarf, this, ranges, false);
+die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc);
if
clayborg added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:298-306
+static uint32_t GetOSOSymbolFlags() {
+ // When a mach-o symbol is encoded, the n_type field is encoded in bits
+ // 23:16, and the n_desc field is encoded in bits
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Nice, thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52376
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Sounds good!
> On Sep 24, 2018, at 10:45 AM, Leonard Mosescu wrote:
>
> Thanks Greg, this is what I had in mind.
>
> I have some ideas which involve this kind of debugger console. We'll likely
> start with a basic version built on top of evaluate `cmd and once we get
> around to building a
aprantl abandoned this revision.
aprantl added a comment.
A
Repository:
rL LLVM
https://reviews.llvm.org/D43647
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342915: [lldb-mi] Fix hanging of target-select-so-path.test
(authored by apolyakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
tatyana-krasnukha accepted this revision.
tatyana-krasnukha added a comment.
This revision is now accepted and ready to land.
A lot of tests are failing with Python 3, at least on CentOS. So, I agree the
problem doesn't block this review.
https://reviews.llvm.org/D52139
tatyana-krasnukha updated this revision to Diff 166719.
tatyana-krasnukha retitled this revision from "[API][Swig] Overloaded functions
for SBTarget" to "[Swig] Merge typemaps with same bodies".
tatyana-krasnukha edited the summary of this revision.
tatyana-krasnukha removed a reviewer: spyffe.
Thanks Greg, this is what I had in mind.
I have some ideas which involve this kind of debugger console. We'll likely
start with a basic version built on top of evaluate `cmd and once we get
around to building a full console I'll ping you.
On Sat, Sep 22, 2018 at 8:50 AM, Greg Clayton wrote:
>
apolyakov updated this revision to Diff 166714.
apolyakov added a comment.
Reduced timer from 120 to 30 seconds.
https://reviews.llvm.org/D52139
Files:
lit/tools/lldb-mi/target/inputs/target-select-so-path.py
Index: lit/tools/lldb-mi/target/inputs/target-select-so-path.py
sgraenitz added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:431
const size_t num_ranges =
-die->GetAttributeAddressRanges(dwarf, this, ranges, false);
+die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc);
clayborg added a comment.
A little background might help here: The lldb_private::Module lock is used to
prevent multiple queries into the DWARF from stomping on each other.
Multi-threaded DWARF parsing was primarily added to speed up indexing and the
only place it is used. Is that not true?
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A little background might help here: The lldb_private::Module lock is used to
prevent multiple queries into the DWARF from stomping on each other.
Multi-threaded DWARF parsing
sgraenitz updated this revision to Diff 166699.
sgraenitz added a comment.
Address Jonas' feedback #2
https://reviews.llvm.org/D52375
Files:
include/lldb/Symbol/Symtab.h
source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
sgraenitz updated this revision to Diff 166698.
sgraenitz added a comment.
Address Jonas' feedback + minor additions
https://reviews.llvm.org/D52375
Files:
include/lldb/Symbol/Symtab.h
source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
teemperor added a comment.
Yeah, explicitly typing python2 is what I did to fix it. Not sure if that
breaks other OSs though (e.g. if a system has no `python2` binary, but only
`python`).
Also, that fix should be its own revision. It's not connected to the idea
behind this revision from what
clayborg added a comment.
So the main questions is: do we need a new section enum called
eSectionTypeDWARFDebugInfoDWO? If so, then this patch changes. I think I would
prefer adding a new enum.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:68
-if
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB342875: Add NativeProcessProtocol unit tests (authored by
labath, committed by ).
Changed prior to commit:
labath added a comment.
I believe you should be able to use `lldb-test` to write this kind of a test. I
am thinking of a sequence like:
yaml2obj %p/Inputs/test.yaml > %t/test.yaml
yaml2obj %p/Inputs/test.o.yaml > %t/test.o.yaml
lldb-test breakpoint %t/test.yaml %s | FileCheck %s
b main
JDevlieghere added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:430
const size_t num_ranges =
-die->GetAttributeAddressRanges(dwarf, this, ranges, false);
+die->GetAttributeAddressRanges(dwarf, this, ranges, true);
if
apolyakov added a comment.
If so, we can try to run the script with python2.x. @teemperor can you try to
modify `target-select-so-path.test` this way:
change `# RUN: python %p/inputs/target-select-so-path.py "%debugserver"
"%lldbmi %t" %s` to
`# RUN: python2 %p/inputs/target-select-so-path.py
JDevlieghere added a comment.
In https://reviews.llvm.org/D48393#1139327, @labath wrote:
> It's even more complicated than that, in case you really have reference
> cycles, you can have multiple threads starting parsing from different points
> in that cycle, and getting deadlocked waiting for
teemperor added subscribers: aprantl, apolyakov.
teemperor added a comment.
> AFAIR, adding an exit(...) to ConnectToRemote won't solve this problem. The
> test will still be failing on Arch.
I was more hoping it would at least turn the deadlock into a fail,
this way I could at least run the
JDevlieghere created this revision.
JDevlieghere added a reviewer: labath.
Herald added a subscriber: mgorny.
JDevlieghere edited the summary of this revision.
This is an attempt to realize Pavel's suggestion from
https://reviews.llvm.org/D48393
In https://reviews.llvm.org/D48393#1139327,
teemperor added a comment.
Posting my mail here for the record:
I was more hoping it would at least turn the deadlock into a fail,
this way I could at least run the test suit.
Anyway, the actual issue is related Python 3: Arch Linux (and probably
some other distributions that "already" upgraded
Author: labath
Date: Mon Sep 24 05:11:04 2018
New Revision: 342875
URL: http://llvm.org/viewvc/llvm-project?rev=342875=rev
Log:
Add NativeProcessProtocol unit tests
Summary:
NativeProcessProtocol is an abstract class, but it still contains a
significant amount of code. Some of that code is
26 matches
Mail list logo
