davide added a comment.
I'll commit this for you, but I might ask if you can try adding a test first?
https://reviews.llvm.org/D50304
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ramana-nvr added a comment.
I do not have the commit permission. Could someone help commit this patch?
https://reviews.llvm.org/D50304
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
vsk added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/target_var/globals.ll:1
+source_filename = "globals.c"
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
davide wrote:
> vsk wrote:
> > Should we check in bitcode
davide added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/target_var/globals.ll:1
+source_filename = "globals.c"
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
vsk wrote:
> Should we check in bitcode instead? That
davide added a comment.
Some basic comments. Haven't looked at the implementation very closely, I'll do
that probably tomorrow. Thanks for working on this!
Comment at: include/lldb/Target/CPPLanguageRuntime.h:59-60
+ lldb::ThreadPlanSP GetStepThroughTrampolinePlan(Thread ,
shafik created this revision.
shafik added reviewers: jingham, davide, aprantl.
Herald added a reviewer: EricWF.
- Adding support to step into the callable wrapped by libc++ std::function
- Adding test to validate that functionality
https://reviews.llvm.org/D52851
Files:
vsk added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/target_var/globals.ll:1
+source_filename = "globals.c"
+target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
Should we check in bitcode instead? That might make it
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB343726: Fix buildbot regression by rL339929: NameError:
global name test_directory is… (authored by jankratochvil,
committed by ).
Changed prior to commit:
Author: jankratochvil
Date: Wed Oct 3 14:42:54 2018
New Revision: 343726
URL: http://llvm.org/viewvc/llvm-project?rev=343726=rev
Log:
Fix buildbot regression by rL339929: NameError: global name 'test_directory' is
not defined
With buildbot slave under test - I get after rL339929:
vsk added inline comments.
Comment at: packages/Python/lldbsuite/test/dosep.py:1693
for core in cores:
dst = core.replace(test_directory, "")[1:]
dst = dst.replace(os.path.sep, "-")
Instead of redefining test_directory, please use
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D50478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
vsk added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:304
+public:
+ CallEdge(const char *mangled_name, lldb::addr_t return_pc);
+
aprantl wrote:
> vsk wrote:
> > vsk wrote:
> > > aprantl wrote:
> > > > Does this also work for C functions?
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
I think this looks fine. Vedant, thoughts?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51874
___
lldb-commits mailing list
Author: shafik
Date: Wed Oct 3 13:52:56 2018
New Revision: 343718
URL: http://llvm.org/viewvc/llvm-project?rev=343718=rev
Log:
Adding skipIf to std::variant libc++ data-formatter test since get is not
available before macOS 10.14
Patch by Shafik Yaghmour
Modified:
aprantl added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:304
+public:
+ CallEdge(const char *mangled_name, lldb::addr_t return_pc);
+
vsk wrote:
> vsk wrote:
> > aprantl wrote:
> > > Does this also work for C functions? If yes, would
vsk added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:304
+public:
+ CallEdge(const char *mangled_name, lldb::addr_t return_pc);
+
aprantl wrote:
> Does this also work for C functions? If yes, would `symbol_name` be a more
> accurate
vsk updated this revision to Diff 168155.
vsk marked an inline comment as done.
vsk added a comment.
- Address feedback from Adrian.
https://reviews.llvm.org/D50478
Files:
lldb/include/lldb/API/SBFrame.h
lldb/include/lldb/Core/FormatEntity.h
lldb/include/lldb/Symbol/Block.h
aprantl added inline comments.
Comment at: source/Interpreter/CommandInterpreter.cpp:2733
+
+ const char *k_space_characters = "\t\n\v\f\r ";
+ size_t first_non_space = line.find_first_not_of(k_space_characters);
sgraenitz wrote:
> sgraenitz wrote:
> > shafik
aprantl added a comment.
This looks pretty good! I have one last question about CallEdge inside.
Comment at: lldb/include/lldb/Symbol/Function.h:304
+public:
+ CallEdge(const char *mangled_name, lldb::addr_t return_pc);
+
Does this also work for C functions?
jingham added a comment.
And more, I just like operations to be explicit and not have overloads like
"settings set property" == "settings clear property".
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52772
___
lldb-commits mailing list
jingham added a comment.
I'm thinking of the scenario where you type:
(lldb) settings set target.run-args
and then decide you didn't want to change the run-args after all. Before this
change hitting return used to be a way to dismiss the settings operation, and
that actually seems a pretty
Author: adrian
Date: Wed Oct 3 09:24:14 2018
New Revision: 343695
URL: http://llvm.org/viewvc/llvm-project?rev=343695=rev
Log:
Skip test with older versions of clang
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/target_var/TestTargetVar.py
Modified:
JDevlieghere added a comment.
Thanks for working on this Stefan, I'm really excited about this feature!
Regarding the code, I don't have comments that weren't already brought up by
the other reviewers.
https://reviews.llvm.org/D52788
___
JDevlieghere added a comment.
In https://reviews.llvm.org/D52772#1252656, @jingham wrote:
> Would it be possible for the exporter to notice empty settings and write
> "settings clear" instead?
I don't think we can if we want to re-use the existing dump infrastructure,
unless there's a way to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343683: Pull FixupBreakpointPCAsNeeded into base class
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52719
Files:
Author: labath
Date: Wed Oct 3 05:29:33 2018
New Revision: 343683
URL: http://llvm.org/viewvc/llvm-project?rev=343683=rev
Log:
Pull FixupBreakpointPCAsNeeded into base class
Summary:
This function existed (with identical code) in both NativeProcessLinux
and NativeProcessNetBSD, and it is likely
grimar added a comment.
In https://reviews.llvm.org/D52689#1253175, @vsk wrote:
> Could you describe how the test exercises DW_FORM_implicit_const support?
> It's not immediately clear to me.
The abbreviation for `foo1` and `foo2` subprograms use it for `DW_AT_decl_file`
and
27 matches
Mail list logo
