[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

2018-10-17 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. That's an interesting code snippet. Thanks for sharing that. The thing that's not clear to me is: are you specifically interested in unwinding from these kinds of functions **without debug info**? Because it sounds to me like the info Zachary provided is enough to

[Lldb-commits] [PATCH] D53357: [Windows] Fix threads comparison on Windows

2018-10-17 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB https://reviews.llvm.org/D53357 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

2018-10-17 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In https://reviews.llvm.org/D53255#1267850, @labath wrote: > It looks like it should be easy to write a test for this by hand-crafting a > minimal .s file and feeding it to lldb-test. Even with such a crafted file (in lldb-repro.tar.xz

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

2018-10-17 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. It looks like it should be easy to write a test for this by hand-crafting a minimal .s file and feeding it to lldb-test. Repository: rL LLVM https://reviews.llvm.org/D53255 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D53375: [PDB] Improve performance of the PDB DIA plugin

2018-10-17 Thread Aleksandr Urakov via Phabricator via lldb-commits
aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, asmith, labath. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. This patch improves performance of `SymbolFilePDB` on huge executables in two ways: - cache names of public symbols

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

2018-10-17 Thread Aleksandr Urakov via Phabricator via lldb-commits
aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, asmith, labath. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds possibility of searching a public symbol with name and type in a symbol file, not only in a symtab.

[Lldb-commits] [PATCH] D53361: [API] Extend the `SBThreadPlan` interface

2018-10-17 Thread Aleksandr Urakov via Phabricator via lldb-commits
aleksandr.urakov created this revision. aleksandr.urakov added reviewers: labath, zturner, jingham. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. This patch extends the `SBThreadPlan` to allow retrieving of thread plans for scripted steps. Repository: rLLDB

[Lldb-commits] [PATCH] D53357: [Windows] Fix threads comparison on Windows

2018-10-17 Thread Aleksandr Urakov via Phabricator via lldb-commits
aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, clayborg. aleksandr.urakov added a project: LLDB. Herald added a subscriber: lldb-commits. This patch makes Windows threads to compare by a thread ID, not by a handle. It's because the same thread can have

[Lldb-commits] [PATCH] D53193: [LLDB] - Add support for DW_RLE_start_end entries (.debug_rnglists)

2018-10-17 Thread George Rimar via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL344674: [LLDB] - Add support for DW_RLE_start_end entries (.debug_rnglists) (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: