[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

zturner added inline comments. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:60 + void Dump(Stream *s) override { *s << "PlaceholderObjectFile\n"; } + uint32_t GetAddressByteSize() const override { return 0; } + uint32_t GetDependentModules(FileSpecList

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

amccarth added a comment. This looks good to me, save for a couple comment nits. Comment at: source/Plugins/SymbolFile/NativePDB/PdbIndex.cpp:155 +// +// TODO: revisit this check since it fires for apparently valid PDBs +// Every apparently valid

[Lldb-commits] [lldb] r348058 - [lit] Add a generic build script with a lit substitution.

Author: zturner Date: Fri Nov 30 16:22:21 2018 New Revision: 348058 URL: http://llvm.org/viewvc/llvm-project?rev=348058=rev Log: [lit] Add a generic build script with a lit substitution. This adds a script called build.py as well as a lit substitution called %build that we can use to invoke it.

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB348058: [lit] Add a generic build script with a lit substitution. (authored by zturner, committed by ). Herald added a

[Lldb-commits] [lldb] r348055 - [windows] Fix two minor bugs on Windows

Author: stella.stamenova Date: Fri Nov 30 16:18:19 2018 New Revision: 348055 URL: http://llvm.org/viewvc/llvm-project?rev=348055=rev Log: [windows] Fix two minor bugs on Windows 1. In ProcessWindows if we fail to allocate memory, we need to return LLDB_INVALID_ADDRESS rather than 0 or nullptr

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

ruiu added a comment. But 2GB is perhaps still too big and I guess a large part of it can be for dead sections. If we fix this, I'd like to fix it in a proper way so that we can completely eliminate debug info for dead sections. rocallahan, can I ask why Rust passes all object files to the

[Lldb-commits] [lldb] r348040 - Add a test to verify that lldb can load a kext binary.

Author: jmolenda Date: Fri Nov 30 13:33:00 2018 New Revision: 348040 URL: http://llvm.org/viewvc/llvm-project?rev=348040=rev Log: Add a test to verify that lldb can load a kext binary. Added: lldb/trunk/packages/Python/lldbsuite/test/macosx/load-kext/

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

lemo created this revision. lemo added reviewers: labath, zturner, amccarth. lemo added a project: LLDB. Herald added subscribers: jfb, abidh, arphaman. A few changes required to enable the use of the native PDB reader when debugging minidumps: 1. Consume PDBs even if the module binary is not

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

JDevlieghere added a comment. In D55038#1314336 , @labath wrote: > In D55038#1314026 , @JDevlieghere > wrote: > > > Test didn't run. Is there a way to REQUIRE either darwin or linux? > > > I think the canonical

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

JDevlieghere updated this revision to Diff 176161. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Make initialize return an error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55038/new/ https://reviews.llvm.org/D55038 Files:

[Lldb-commits] [PATCH] D55114: [CMake] Add LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR for custom dSYM target directory on Darwin

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Looks reasonable, thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55114/new/ https://reviews.llvm.org/D55114

Re: [Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

I reverted it. Thanks. From: Aleksandr Urakov Sent: Friday, November 30, 2018 9:25 AM To: reviews+d53759+public+b214dcdd73261...@reviews.llvm.org Cc: Zachary Turner ; aaron.lee.smith ; Stella Stamenova ; llvm-comm...@lists.llvm.org; pa...@labath.sk; 15dacaoy...@gmail.com; apra...@apple.com;

[Lldb-commits] [lldb] r348010 - Skip TestRequireHWBreakpoints on Windows

Author: jdevlieghere Date: Fri Nov 30 09:31:20 2018 New Revision: 348010 URL: http://llvm.org/viewvc/llvm-project?rev=348010=rev Log: Skip TestRequireHWBreakpoints on Windows The test assumes that HW breakpoints are not implemented by the debug server. Windows doesn't use these and might

[Lldb-commits] [lldb] r348009 - Revert "[PDB] Support PDB-backed expressions evaluation"

Author: stella.stamenova Date: Fri Nov 30 09:29:54 2018 New Revision: 348009 URL: http://llvm.org/viewvc/llvm-project?rev=348009=rev Log: Revert "[PDB] Support PDB-backed expressions evaluation" This reverts commit dec87759523b2f22fcff3325bc2cd543e4cda0e7. This commit caused the tests on

Re: [Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

I'm already OOO today, feel free to revert it. Am Fr., 30. Nov. 2018, 20:15 hat Stella Stamenova via Phabricator < revi...@reviews.llvm.org> geschrieben: > stella.stamenova added a comment. > > It looks like after this change went in, the tests on Windows starting > timing out instead of

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

labath added a comment. I like how you've separated out the conversion function doing the actual conversion. That should make it easy to write unit tests for it (including tests for malformed input). Can you add something like that? I am particularly interested in what will the merging code do

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

stella.stamenova added a comment. It looks like after this change went in, the tests on Windows starting timing out instead of completing. The last run before the change took about 2 minutes and starting with the first run with this change, they're running for 40 minutes before being killed:

Re: [Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

Ah, it looks like my fail. I had an old piece of code, which retrieves an FPO program for the old PDB plugin, and have shared it with Leonid (we are colleagues). Sure, we will move this to the new plugin (and it looks like it's not so difficult). Am Fr., 30. Nov. 2018, 18:39 hat Zachary Turner

[Lldb-commits] [PATCH] D55128: [CMake] Store path to vendor-specific headers in clang-headers target property

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This makes sense to me. I'm don't know if there's a better property but I think this matches the intended use, so I think it is fine. Repository: rC Clang CHANGES SINCE LAST

Re: [Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

It would be great if future work could go towards the native pdb plugin. To be honest, I’m trying very hard to get it to the point that the DIA plugin can be deleted, so large pieces of new functionality that only go to the DIA plugin are, in a way, wasted effort. I’m currently working on getting

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy created this revision. leonid.mashinskiy added reviewers: zturner, asmith, stella.stamenova, aleksandr.urakov. leonid.mashinskiy added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, aprantl, mgorny. This patch makes LLDB able to retrieve proper values

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

labath added a comment. In D55038#1314026 , @JDevlieghere wrote: > Test didn't run. Is there a way to REQUIRE either darwin or linux? I think the canonical way to do that would be to define a new feature in lit, which gets set when the target supports

[Lldb-commits] [PATCH] D55114: [CMake] Add LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR for custom dSYM target directory on Darwin

sgraenitz created this revision. sgraenitz added a reviewer: beanz. Herald added subscribers: aprantl, mgorny. When using `LLVM_EXTERNALIZE_DEBUGINFO` in LLDB, the default dSYM location for the shared library in LLDB.framework is inside the framework bundle. With

[Lldb-commits] [lldb] r347975 - [NativePDB] Fix ast-reconstruction test on x86

Author: aleksandr.urakov Date: Fri Nov 30 01:50:11 2018 New Revision: 347975 URL: http://llvm.org/viewvc/llvm-project?rev=347975=rev Log: [NativePDB] Fix ast-reconstruction test on x86 Summary: This patch fixes ast-reconstruction.cpp test on x86 platform. Patch by: leonid.mashinskiy Reviewers:

[Lldb-commits] [PATCH] D55002: [NativePDB] Fix ast-reconstruction test on x86

This revision was automatically updated to reflect the committed changes. Closed by commit rL347975: [NativePDB] Fix ast-reconstruction test on x86 (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r347974 - [Target] Do not skip a stop on a breakpoint if a plan was completed

Author: aleksandr.urakov Date: Fri Nov 30 01:45:52 2018 New Revision: 347974 URL: http://llvm.org/viewvc/llvm-project?rev=347974=rev Log: [Target] Do not skip a stop on a breakpoint if a plan was completed Summary: This patch fixes the next situation. On Windows clang-cl makes no stub before the

[Lldb-commits] [PATCH] D53761: [Target] Do not skip a stop on a breakpoint if a plan was completed

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB347974: [Target] Do not skip a stop on a breakpoint if a plan was completed (authored by aleksandr.urakov, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D55002: [NativePDB] Fix ast-reconstruction test on x86

leonid.mashinskiy added a comment. Thank you for the review! Please, commit this for me? I have no commit access. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55002/new/ https://reviews.llvm.org/D55002 ___