[Lldb-commits] [lldb] r348332 - gdb-remote: use elaborated type specifier for `Module`

Author: compnerd Date: Tue Dec 4 20:04:14 2018 New Revision: 348332 URL: http://llvm.org/viewvc/llvm-project?rev=348332=rev Log: gdb-remote: use elaborated type specifier for `Module` When building with MSVC, the type `Module` is ambiguous due to both the lldb_private and llvm namespaces being

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

ruiu added a comment. It seems to me that just adding `--start-lib` to his command line can fix the issue, so I'm waiting for Robert's response. If it doesn't work for some reason, we can analyze why it doesn't work and then discuss what we can do for his problem. Repository: rLLD LLVM

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

echristo added a comment. In D54747#1315241 , @ruiu wrote: > But 2GB is perhaps still too big and I guess a large part of it can be for > dead sections. If we fix this, I'd like to fix it in a proper way so that we > can completely eliminate debug info

[Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

Author: zturner Date: Tue Dec 4 15:56:25 2018 New Revision: 348319 URL: http://llvm.org/viewvc/llvm-project?rev=348319=rev Log: [build.py] Disable tests on non-Windows. This won't work until we get the GCC / clang builder implemented. Modified: lldb/trunk/lit/BuildScript/modes.test

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

zturner added inline comments. Comment at: lit/Modules/Breakpad/lit.local.cfg:1 +config.suffixes = ['.test'] This shouldn't be necessary, the top-level `lit.cfg.py` already recognizes `.test` extension. You only need a lit.local.cfg if you're changing

[Lldb-commits] [lldb] r348314 - Fix LLDB build script.

Author: zturner Date: Tue Dec 4 14:46:01 2018 New Revision: 348314 URL: http://llvm.org/viewvc/llvm-project?rev=348314=rev Log: Fix LLDB build script. A local patch was omitted from the original commit. This makes the tests pass. Modified: lldb/trunk/lit/helper/build.py Modified:

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

lemo accepted this revision. lemo added a comment. Looks like a great start Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp:53 + static_assert(sizeof(data) == 20, ""); + if (str.size() < 33 || str.size() > 40) +return UUID(); these

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL348305: [build.py] A few general improvements. (authored by zturner, committed by ). Herald added a subscriber:

[Lldb-commits] [lldb] r348305 - [build.py] A few general improvements.

Author: zturner Date: Tue Dec 4 13:48:27 2018 New Revision: 348305 URL: http://llvm.org/viewvc/llvm-project?rev=348305=rev Log: [build.py] A few general improvements. This makes -mode=compile support multiple inputs (and hence multiple outputs). It also makes the value of -arch for compiling

[Lldb-commits] [lldb] r348300 - Add SBInitializerOptions.cpp.

Author: jmolenda Date: Tue Dec 4 12:34:23 2018 New Revision: 348300 URL: http://llvm.org/viewvc/llvm-project?rev=348300=rev Log: Add SBInitializerOptions.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

Re: [Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

Yeah, that's a good idea. Made the change in r348289. On Tue, Dec 4, 2018 at 2:55 AM Pavel Labath wrote: > On 03/12/2018 21:55, Jonas Devlieghere via lldb-commits wrote: > > That wouldn't work because we try to create the directory which would > > succeeded in the temp dir. I'd have to be

[Lldb-commits] [lldb] r348289 - [Reproducers] Only creaate the bottom-most dir

Author: jdevlieghere Date: Tue Dec 4 10:16:49 2018 New Revision: 348289 URL: http://llvm.org/viewvc/llvm-project?rev=348289=rev Log: [Reproducers] Only creaate the bottom-most dir As Pavel noted on the mailing list we should only create the bottom-most directory if it doesn't exist. This should

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) +

[Lldb-commits] [PATCH] D55240: [FileSystem] Migrate CommandCompletions

This revision was automatically updated to reflect the committed changes. Closed by commit rL348287: [FileSystem] Migrate CommandCompletions (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r348287 - [FileSystem] Migrate CommandCompletions

Author: jdevlieghere Date: Tue Dec 4 09:58:21 2018 New Revision: 348287 URL: http://llvm.org/viewvc/llvm-project?rev=348287=rev Log: [FileSystem] Migrate CommandCompletions Make use of the convenience helpers from FileSystem. Differential revision: https://reviews.llvm.org/D55240 Modified:

[Lldb-commits] [PATCH] D54670: .debug_types: Update of D32167 on top of D51578 (.debug_types section concatenation)

jankratochvil added a comment. @clayborg You have already approved this patchset merged with D51578 in D51578 three weeks ago . I have split it afterwards to: | 1of2 | D51578 | the

[Lldb-commits] [PATCH] D55240: [FileSystem] Migrate CommandCompletions

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: source/Commands/CommandCompletions.cpp:180 + FileSystem fs = FileSystem::Instance(); std::error_code EC; labath wrote: > This should surely be a reference, no?

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

labath added a reviewer: markmentovai. labath marked 3 inline comments as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp:66-84 + if (os == llvm::Triple::Win32) { +// In binary form, the module id should have 20

[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

labath updated this revision to Diff 176615. labath added a comment. - implement the module_id/code_id logic suggested by Mark Mentovai - fix module_id endianness handling to make sure the UUID matches the one we get from the minidump files CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r348261 - Fix lldb-server unit tests for the MonitoringProcessLauncher refactor

Author: labath Date: Tue Dec 4 06:04:27 2018 New Revision: 348261 URL: http://llvm.org/viewvc/llvm-project?rev=348261=rev Log: Fix lldb-server unit tests for the MonitoringProcessLauncher refactor We now need to initialize the filesystem in these tests. Modified:

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

aleksandr.urakov added a comment. Thanks! I've updated DIA PDB tests in D55230 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55230/new/ https://reviews.llvm.org/D55230 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov updated this revision to Diff 176611. aleksandr.urakov added a comment. Update tests due to D55230 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54942/new/ https://reviews.llvm.org/D54942 Files: lit/SymbolFile/PDB/ast-restore.test

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

labath added a comment. In D55122#1318295 , @leonid.mashinskiy wrote: > > Is this true? Is it not possible for a program to depend on a value of a > > register which will be defined later? > > I am not totally sure about this, but all valid fpo programs

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy added a comment. > Is this true? Is it not possible for a program to depend on a value of a > register which will be defined later? I am not totally sure about this, but all valid fpo programs that I've seen in existing pdb support this invariant. So I think that we can

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

leonid.mashinskiy updated this revision to Diff 176597. leonid.mashinskiy added a comment. - add more tests on dependent programs - handle parsing of cyclically dependent programs properly - remove default cases for fully covered enums as mentioned in conding standart CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov added a comment. The test was broken after this commit. It seems that on MacOS X the process of the compiled test application always contains Objective C Runtime, so the part of the test, which assumes that there is no ObjC option enabled, fails. To fix it I've skip this part

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

labath added a comment. Thank you. I like the tests a lot. I think I'll steal the implementation of this when I get around to parsing breakpad unwind instructions. ;) This looks fine to me, but one of the windows folks should take a look at it too. Comment at:

[Lldb-commits] [lldb] r348250 - [Expr] Fix `TestExprOptions` after r348240 on MacOS X

Author: aleksandr.urakov Date: Tue Dec 4 03:08:02 2018 New Revision: 348250 URL: http://llvm.org/viewvc/llvm-project?rev=348250=rev Log: [Expr] Fix `TestExprOptions` after r348240 on MacOS X Summary: r348240 assumes that an expression contains the Objective C option if Objective C Runtime is

Re: [Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

On 03/12/2018 21:55, Jonas Devlieghere via lldb-commits wrote: That wouldn't work because we try to create the directory which would succeeded in the temp dir. I'd have to be something you don't have access to, like the root or some network drive. How about we change the behavior to only

[Lldb-commits] [PATCH] D55240: [FileSystem] Migrate CommandCompletions

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good, modulo the filesystem copy comment. Comment at: source/Commands/CommandCompletions.cpp:180 + FileSystem fs = FileSystem::Instance(); std::error_code EC;

[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

aleksandr.urakov abandoned this revision. aleksandr.urakov added a comment. Abandon due to D55122 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53086/new/ https://reviews.llvm.org/D53086 ___ lldb-commits

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

aleksandr.urakov added a comment. Ok, thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54843/new/ https://reviews.llvm.org/D54843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r348240 - [Expr] Check the language before ignoring Objective C keywords

Author: aleksandr.urakov Date: Tue Dec 4 01:51:29 2018 New Revision: 348240 URL: http://llvm.org/viewvc/llvm-project?rev=348240=rev Log: [Expr] Check the language before ignoring Objective C keywords Summary: This patch adds the check of the language before ignoring names like `id` or `Class`,

[Lldb-commits] [PATCH] D54843: [Expr] Check the language before ignoring Objective C keywords

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL348240: [Expr] Check the language before ignoring Objective C keywords (authored by aleksandr.urakov, committed by ).