[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:577 + + clang::DeclContext *decl_context =

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

Thank you! It seems that your commit have fixed the bug - it haven't been reproduced on `lldb-x64-windows-ninja` since your commit. On Thu, Dec 6, 2018 at 9:45 PM Zachary Turner wrote: > Hopefully fixed in r348511. I went with the approach of concatenating the > executable file name, for two

[Lldb-commits] [lldb] r348561 - Add SBInitializerOptions.h to the Xcode project.

Author: jingham Date: Thu Dec 6 18:28:04 2018 New Revision: 348561 URL: http://llvm.org/viewvc/llvm-project?rev=348561=rev Log: Add SBInitializerOptions.h to the Xcode project. And mark it as a public header so it will get copied into the LLDB.framework. A handful of "api" tests were failing

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB348559: Handle detecting exec for DynamicLoaderMacOS with older debugservers (authored by jingham, committed by ). Changed prior to commit: https://reviews.llvm.org/D55399?vs=177085=177087#toc

[Lldb-commits] [lldb] r348559 - Handle detecting exec for DynamicLoaderMacOS with older debugservers

Author: jingham Date: Thu Dec 6 17:18:40 2018 New Revision: 348559 URL: http://llvm.org/viewvc/llvm-project?rev=348559=rev Log: Handle detecting exec for DynamicLoaderMacOS with older debugservers that don't send reason:exec. Differential Revision: https://reviews.llvm.org/D55399 Modified:

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

jingham marked an inline comment as done. jingham added inline comments. Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:104 +if (image_infos_address != m_maybe_image_infos_address) + did_exec = true; + } jingham

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

jasonmolenda added a comment. I don't feel strongly about it, your choice. But if I misunderstood it this time, I'll likely misunderstand it again in the future. :) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55399/new/ https://reviews.llvm.org/D55399

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

jingham marked an inline comment as done. jingham added inline comments. Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:104 +if (image_infos_address != m_maybe_image_infos_address) + did_exec = true; + }

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

zturner added inline comments. Comment at: include/lldb/API/SBValue.h:310-312 + lldb::SBValue EvaluateExpression(const char *expr) const; + lldb::SBValue EvaluateExpression(const char *expr, + const SBExpressionOptions ) const;

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

jingham added inline comments. Comment at: source/API/SBValue.cpp:1367-1371 + if (log) +log->Printf("SBValue(%p)::EvaluateExpression (expr=\"%s\") => SBValue(%p) " +"(execution result=%d)", +static_cast(value_sp.get()), expr, +

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

jingham added inline comments. Comment at: include/lldb/API/SBValue.h:310-312 + lldb::SBValue EvaluateExpression(const char *expr) const; + lldb::SBValue EvaluateExpression(const char *expr, + const SBExpressionOptions ) const;

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

jasonmolenda accepted this revision. jasonmolenda added a comment. LGTM. Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:104 +if (image_infos_address != m_maybe_image_infos_address) + did_exec = true; + } Do

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Let's try it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55399/new/ https://reviews.llvm.org/D55399 ___

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

jingham marked 2 inline comments as done. jingham added inline comments. Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:83 + m_break_id(LLDB_INVALID_BREAK_ID), m_mutex() + , m_maybe_image_infos_address(LLDB_INVALID_ADDRESS) {}

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

jingham updated this revision to Diff 177085. jingham marked an inline comment as done. jingham added a comment. Added a comment and removed an errant space. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55399/new/ https://reviews.llvm.org/D55399 Files:

[Lldb-commits] [lldb] r348557 - Change the amount of data that Platform::PutFile will try to transfer

Author: jmolenda Date: Thu Dec 6 16:35:26 2018 New Revision: 348557 URL: http://llvm.org/viewvc/llvm-project?rev=348557=rev Log: Change the amount of data that Platform::PutFile will try to transfer in one packet from 1k bytes to 16k bytes. Sending a large file to an iOS device directly

[Lldb-commits] [lldb] r348556 - Host: remove Yield on Windows

Author: compnerd Date: Thu Dec 6 16:31:34 2018 New Revision: 348556 URL: http://llvm.org/viewvc/llvm-project?rev=348556=rev Log: Host: remove Yield on Windows Windows provides a Yield function-like macro that allows a thread to yield the CPU. However, this conflicts with `Yield` in swift.

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

zturner added inline comments. Comment at: include/lldb/API/SBValue.h:310-312 + lldb::SBValue EvaluateExpression(const char *expr) const; + lldb::SBValue EvaluateExpression(const char *expr, + const SBExpressionOptions ) const;

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

aprantl added inline comments. Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:83 + m_break_id(LLDB_INVALID_BREAK_ID), m_mutex() + , m_maybe_image_infos_address(LLDB_INVALID_ADDRESS) {} Why not just write C++11-style `=

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

jingham created this revision. jingham added reviewers: jasonmolenda, aprantl. Herald added subscribers: lldb-commits, abidh. The test "TestExec.py" has been on and off flakey on the GreenDragon MacOS bots for a while now. I'm trying to fix that. It adds a lot of noise to the bots. For

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

shafik added subscribers: stella.stamenova, shafik. shafik added a comment. Hello, This PR broke the green dragon bots, see the following log file: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/13655/consoleFull#-15796076f80f5c9c-2aaa-47fb-b15d-be39b7128d72 I was about to revert it

Re: [Lldb-commits] [lldb] r348544 - [lit] Use the build.py script in the case-insensitive test

Fwiw, I think mode=compile-and-link and compiler=any are both defaults, so those 2 options could be omitted to make this shorter. Not a big deal though On Thu, Dec 6, 2018 at 3:28 PM Stella Stamenova via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: stella.stamenova > Date: Thu Dec

[Lldb-commits] [lldb] r348544 - [lit] Use the build.py script in the case-insensitive test

Author: stella.stamenova Date: Thu Dec 6 15:25:37 2018 New Revision: 348544 URL: http://llvm.org/viewvc/llvm-project?rev=348544=rev Log: [lit] Use the build.py script in the case-insensitive test This makes the test build correctly regardless of whether we use VS or ninja to run the tests

[Lldb-commits] [lldb] r348542 - [pecoff] Use PATH_MAX instead of MAX_PATH

Author: stella.stamenova Date: Thu Dec 6 15:22:46 2018 New Revision: 348542 URL: http://llvm.org/viewvc/llvm-project?rev=348542=rev Log: [pecoff] Use PATH_MAX instead of MAX_PATH PATH_MAX is defined on all platforms while MAX_PATH is Windows-specific Modified:

Re: [Lldb-commits] [lldb] r348527 - [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

Hi Aaron, this is failing to build on macOS systems -- > On Dec 6, 2018, at 1:36 PM, Aaron Smith via lldb-commits > wrote: > > +// At this moment we only have the base name of the DLL. The full path > can > +// only be seen after the dynamic loading. Our best guess is Try to get >

[Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

clayborg added inline comments. Comment at: include/lldb/Symbol/ObjectFile.h:569 + /// Returns the base file address of an object file (also known as the + /// preferred load address or image base address). This is typically the file lemo wrote: > "file

[Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

lemo added inline comments. Comment at: include/lldb/Symbol/ObjectFile.h:569 + /// Returns the base file address of an object file (also known as the + /// preferred load address or image base address). This is typically the file "file address" can mean an

[Lldb-commits] [lldb] r348527 - [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

Author: asmith Date: Thu Dec 6 13:36:39 2018 New Revision: 348527 URL: http://llvm.org/viewvc/llvm-project?rev=348527=rev Log: [pecoff] Implement ObjectFilePECOFF::GetDependedModules() Summary: This parses entries in pecoff import tables for imported DLLs and is intended as the first step to

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

zturner updated this revision to Diff 177039. zturner added a comment. Clang-cl emits `S_LOCAL` symbols while MSVC emits `S_REGREL32` and `S_REGISTER` symbols. So, to get more test coverage, I added an MSVC test as well. Also a little NFC cleanup in the main source file (basically just making

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith updated this revision to Diff 177038. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53094/new/ https://reviews.llvm.org/D53094 Files: lit/Modules/PECOFF/dep-modules.yaml lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/lit.local.cfg

Re: [Lldb-commits] [PATCH] D55383: Implement basic DidAttach for DynamicLoaderWindowsDYLD for use with ds2

On Thu, Dec 6, 2018 at 1:32 PM Davide Italiano via Phabricator wrote: > > davide added subscribers: zturner, labath, davide. > davide added a comment. > > You would recommend getting a post-commit review from @labath or @zturner > *I would. ___

[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

asmith updated this revision to Diff 177036. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53094/new/ https://reviews.llvm.org/D53094 Files: lit/Modules/PECOFF/dep-modules.yaml lit/Modules/PECOFF/export-dllfunc.yaml lit/Modules/PECOFF/lit.local.cfg

[Lldb-commits] [PATCH] D55383: Implement basic DidAttach for DynamicLoaderWindowsDYLD for use with ds2

davide added subscribers: zturner, labath, davide. davide added a comment. You would recommend getting a post-commit review from @labath or @zturner Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55383/new/ https://reviews.llvm.org/D55383

[Lldb-commits] [PATCH] D55383: Implement basic DidAttach for DynamicLoaderWindowsDYLD for use with ds2

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB348526: Implement WindowsDYLD::DidAttach for use with gdb-server attach (authored by lanza, committed by ). Herald

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

zturner created this revision. zturner added reviewers: aleksandr.urakov, amccarth, labath, lemo. Herald added subscribers: hiraditya, aprantl. Previously we would create an `lldb::Function` object for each function parsed, but we would not add these to the clang AST. This is a first step

[Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

clayborg added a comment. Marked as requesting changes in case "GetBaseFileAddress() == GetHeaderAddress().GetFileAddress()" in all cases. If the base file address differs from where the object file header is located, then this change would work. Else we should use GetHeaderAddress() and

[Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. This is already available with: virtual lldb_private::Address ObjectFile::GetHeaderAddress(); It return a lldb_private::Address which is section offset, but nothing stopping

[Lldb-commits] [lldb] r348519 - Fix the Xcode project build for the addition of NativePDB/DWARFLocationExpression.{h, cpp}

Author: jingham Date: Thu Dec 6 11:23:21 2018 New Revision: 348519 URL: http://llvm.org/viewvc/llvm-project?rev=348519=rev Log: Fix the Xcode project build for the addition of NativePDB/DWARFLocationExpression.{h,cpp} Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lit/Modules/MachO/basic-info.yaml:10 +# CHECK: Strata: user +# CHECK: Base VM address: 0x1 + Just so I understand, this

[Lldb-commits] [lldb] r348514 - Fix line endings in build.py

Author: zturner Date: Thu Dec 6 10:45:07 2018 New Revision: 348514 URL: http://llvm.org/viewvc/llvm-project?rev=348514=rev Log: Fix line endings in build.py Modified: lldb/trunk/lit/helper/build.py Modified: lldb/trunk/lit/helper/build.py URL:

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

Hopefully fixed in r348511. I went with the approach of concatenating the executable file name, for two reasons. First, it's easier, since dealing with the tmpfile module and mkstemp and sorts has its own set of complexities and issues. Secondly, because it means the build artifacts will still

[Lldb-commits] [lldb] r348511 - [build.py] Embed the output file name in generated object file names.

Author: zturner Date: Thu Dec 6 10:39:58 2018 New Revision: 348511 URL: http://llvm.org/viewvc/llvm-project?rev=348511=rev Log: [build.py] Embed the output file name in generated object file names. In compile-and-link mode, the user doesn't specify the name of the object files to generate,

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 177003. sgraenitz marked an inline comment as not done. sgraenitz added a comment. LLDB.framework requires an in-tree build CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 Files: CMakeLists.txt

[Lldb-commits] [PATCH] D55361: Move Broadcaster+Listener+Event combo from Core into Utility

teemperor added a comment. LGTM modulo the unrelated clang-format changes. Feel free to commit them separately (even though the `m_event_names` fix looks a bit strange). Comment at: include/lldb/Utility/Broadcaster.h:551 -Broadcaster _broadcaster;///< The

[Lldb-commits] [lldb] r348505 - [PDB] Move some code around. NFC.

Author: zturner Date: Thu Dec 6 09:49:15 2018 New Revision: 348505 URL: http://llvm.org/viewvc/llvm-project?rev=348505=rev Log: [PDB] Move some code around. NFC. Added: lldb/trunk/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 176998. sgraenitz added a comment. Copy Clang headers to LLDB.framework without an intermediate staging directory. This approach seems much simpler and it avoids errors from an ordering issue at configuration time (preventing Clang headers from being

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

stella.stamenova added inline comments. Comment at: CMakeLists.txt:134 --srcRoot=${LLDB_SOURCE_DIR} - --targetDir=${LLDB_PYTHON_TARGET_DIR} - --cfgBldDir=${LLDB_PYTHON_TARGET_DIR} + --targetDir=$ +

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

I am in favor of unique filenames because it will guarantee we avoid any problems like this in the future, but in most cases, as long as the names are unique *in the test suite*, that should be sufficient. So I don’t have any objections to Zachary’s approach of making the filenames unique

[Lldb-commits] [lldb] r348502 - Add another ArchSpec unit test.

Author: adrian Date: Thu Dec 6 09:11:45 2018 New Revision: 348502 URL: http://llvm.org/viewvc/llvm-project?rev=348502=rev Log: Add another ArchSpec unit test. Modified: lldb/trunk/unittests/Utility/ArchSpecTest.cpp Modified: lldb/trunk/unittests/Utility/ArchSpecTest.cpp URL:

[Lldb-commits] [PATCH] D55376: Generate LLDB website/documentation from rst with Sphinx

brucem added a comment. This sounds great to me. Perhaps it'd be nice if we could use Sphinx instead of epydoc in the future? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55376/new/ https://reviews.llvm.org/D55376

[Lldb-commits] [PATCH] D55376: Generate LLDB website/documentation from rst with Sphinx

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: teemperor, arphaman, mgorny. The current LLDB website is written in HTML which is hard to maintain. We have quite a bit of HTML code checked in which can make it hard to differentiate between

[Lldb-commits] [lldb] r348499 - Support skewed stream arrays.

Author: zturner Date: Thu Dec 6 08:55:00 2018 New Revision: 348499 URL: http://llvm.org/viewvc/llvm-project?rev=348499=rev Log: Support skewed stream arrays. VarStreamArray was built on the assumption that it is backed by a StreamRef, and offset 0 of that StreamRef is the first byte of the

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

aleksandr.urakov updated this revision to Diff 176980. aleksandr.urakov added a comment. Thanks for the interest to the feature! I've updated the patch due to the comments. The only problem is that I'm not familiar with Objective C and have no Mac OS to test it, so I haven't written the test

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

Yea that sounds reasonable On Thu, Dec 6, 2018 at 1:07 AM Pavel Labath wrote: > On 06/12/2018 09:25, Aleksandr Urakov via lldb-commits wrote: > > > > I thought about what Stella have said, and it seems that I have found a > > good solution for this. We can use something like `tempfile` > >

Re: [Lldb-commits] [PATCH] D55361: Move Broadcaster+Listener+Event combo from Core into Utility

Lgtm. Btw I noticed StreamBuffer, which might be another easy one On Thu, Dec 6, 2018 at 3:27 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath updated this revision to Diff 176948. > labath added a comment. > > That's a good point, thanks for reminding me. > >

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

sgraenitz updated this revision to Diff 176957. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55332/new/ https://reviews.llvm.org/D55332 Files: CMakeLists.txt scripts/CMakeLists.txt

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

sgraenitz updated this revision to Diff 176956. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55330/new/ https://reviews.llvm.org/D55330 Files: cmake/modules/AddLLDB.cmake

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 176954. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake

[Lldb-commits] [PATCH] D55320: [CMake] Move debugserver options to separate debugserverConfig.cmake

sgraenitz updated this revision to Diff 176950. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55320/new/ https://reviews.llvm.org/D55320 Files: cmake/modules/debugserverConfig.cmake

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 176949. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new/ https://reviews.llvm.org/D55013 Files: cmake/modules/AddLLDB.cmake

[Lldb-commits] [PATCH] D55361: Move Broadcaster+Listener+Event combo from Core into Utility

labath updated this revision to Diff 176948. labath added a comment. That's a good point, thanks for reminding me. Re-clang-formatting the changed lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55361/new/ https://reviews.llvm.org/D55361 Files:

[Lldb-commits] [PATCH] D55361: Move Broadcaster+Listener+Event combo from Core into Utility

brucem added a comment. I recognize that it might be dull, but should you re-sort the various include lists so that the now-in-Utility headers are listed with the other Utility headers? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55361/new/ https://reviews.llvm.org/D55361

[Lldb-commits] [PATCH] D55361: Move Broadcaster+Listener+Event combo from Core into Utility

labath created this revision. labath added reviewers: zturner, jingham, teemperor, clayborg. Herald added a subscriber: mgorny. These are general purpose "utility" classes, whose functionality is not debugger-specific in any way. As such, I believe they belong in the Utility module. This doesn't

[Lldb-commits] [lldb] r348479 - Make scripts/analyzer-project-deps compatible with python3

Author: labath Date: Thu Dec 6 02:27:38 2018 New Revision: 348479 URL: http://llvm.org/viewvc/llvm-project?rev=348479=rev Log: Make scripts/analyzer-project-deps compatible with python3 Modified: lldb/trunk/scripts/analyze-project-deps.py Modified:

[Lldb-commits] [lldb] r348476 - Remove REQUIRES: darwin from a couple of MachO tests

Author: labath Date: Thu Dec 6 01:41:50 2018 New Revision: 348476 URL: http://llvm.org/viewvc/llvm-project?rev=348476=rev Log: Remove REQUIRES: darwin from a couple of MachO tests lldb is able to parse MachO files also on other platforms nowadays. Modified:

[Lldb-commits] [lldb] r348474 - disable toolchain-clang-cl.test on non-windows

Author: labath Date: Thu Dec 6 01:39:09 2018 New Revision: 348474 URL: http://llvm.org/viewvc/llvm-project?rev=348474=rev Log: disable toolchain-clang-cl.test on non-windows The recently added test fail on non-windows platforms. Modified: lldb/trunk/lit/BuildScript/toolchain-clang-cl.test

[Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

labath created this revision. labath added reviewers: clayborg, zturner, lemo. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. Object files generally have a "base" address, which is their preferred address to be loaded into memory (in the sense that if they are

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

On 06/12/2018 09:25, Aleksandr Urakov via lldb-commits wrote: I thought about what Stella have said, and it seems that I have found a good solution for this. We can use something like `tempfile` (https://docs.python.org/3.7/library/tempfile.html) for every internally generated file of the

[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

labath added a comment. In D55142#1320447 , @lemo wrote: > I agree with both comments. The intention is to add some tests but I wanted > to get the review out early to surface concerns, if any. I also needed more > time to investigate a few complex

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

Yes, this solution would solve the current problem. But theoretically the uniqueness may be defined by the directory, where the file is located, not by the name. It looks very unlikely, but who knows... I thought about what Stella have said, and it seems that I have found a good solution for

[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

labath added a comment. Sounds like an interesting feature to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55318/new/ https://reviews.llvm.org/D55318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org