[Lldb-commits] [lldb] r350990 - Add SymbolFileBreakpad.

Author: jmolenda Date: Fri Jan 11 19:17:39 2019 New Revision: 350990 URL: http://llvm.org/viewvc/llvm-project?rev=350990=rev Log: Add SymbolFileBreakpad. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

Hui added a comment. In D56232#1349407 , @labath wrote: > In D56232#1348514 , @zturner wrote: > > > Is that even necessary? If a platform is not remote aware, `IsHost()` will > > always just return `true` by

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

asmith updated this revision to Diff 181377. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56230/new/ https://reviews.llvm.org/D56230 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Index: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp

[Lldb-commits] [lldb] r350978 - [lldbsuite] Skip TestExitDuringStep on Windows

Author: stella.stamenova Date: Fri Jan 11 15:08:35 2019 New Revision: 350978 URL: http://llvm.org/viewvc/llvm-project?rev=350978=rev Log: [lldbsuite] Skip TestExitDuringStep on Windows This test is flaky on Windows and will occasionally hang or fail. Modified:

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

zturner added a comment. In D56230#1354829 , @Hui wrote: > I think the key problem here is to make sure the argument will be treated as > a single argument to the process launcher. > > To be specific to this case only, could we just provide a quote char

[Lldb-commits] [PATCH] D56230: [gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv

Hui added a comment. I think the key problem here is to make sure the argument will be treated as a single argument to the process launcher. To be specific to this case only, could we just provide a quote char to argument log file path and log channels on Windows? The downside is one more #if

[Lldb-commits] [PATCH] D56618: [SymbolFile] Remove the SymbolContext parameter from FindTypes

zturner created this revision. zturner added reviewers: labath, clayborg, davide. This parameter was only ever used with the Module set, and since a SymbolFile is tied to a module, the parameter turns out to be entirely unnecessary. Furthermore, it doesn't make a lot of sense to ask a caller

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: cmake/modules/LLDBStandalone.cmake:9 + find_package(LLVM REQUIRED CONFIG +HINTS "${LLDB_PATH_TO_LLVM_BUILD}" NO_DEFAULT_PATH NO_CMAKE_FIND_ROOT_PATH) + find_package(Clang REQUIRED CONFIG

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

sgraenitz added a comment. Thanks for the initiative! Would be great to have this part cleaned up as well. Comment at: cmake/modules/LLDBStandalone.cmake:9 + find_package(LLVM REQUIRED CONFIG +HINTS "${LLDB_PATH_TO_LLVM_BUILD}" NO_DEFAULT_PATH NO_CMAKE_FIND_ROOT_PATH) +

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

xiaobai updated this revision to Diff 181352. xiaobai added a comment. Removed use of `NO_DEFAULT_PATH` Made LLDB_PATH_TO_{LLVM,CLANG}_BUILD cache variables CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56531/new/ https://reviews.llvm.org/D56531 Files:

[Lldb-commits] [PATCH] D56615: [SymbolFile] Remove the SymbolContext parameter from FindNamespace

zturner created this revision. zturner added reviewers: clayborg, davide, labath. Herald added a subscriber: aprantl. Every callsite was passing an empty SymbolContext, so this parameter had no effect. Inside the DWARF implementation of this function, however, there was one codepath that

[Lldb-commits] [PATCH] D56606: [CMake] Export utility targets to the build/install tree depending on LLVM_BUILD/INSTALL_UTILS

This revision was automatically updated to reflect the committed changes. Closed by commit rL350959: [CMake] Export utility targets to the build/install tree depending on… (authored by stefan.graenitz, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D56606: [CMake] Export utility targets to the build/install tree depending on LLVM_BUILD/INSTALL_UTILS

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56606/new/ https://reviews.llvm.org/D56606 ___ lldb-commits

[Lldb-commits] [PATCH] D56614: [SymbolFile] Change ParseFunctionBlocks(SymbolContext&) to ParseBlocksRecursive(Function&)

zturner created this revision. zturner added reviewers: clayborg, labath, davide. This limits the API surface by providing only the necessary and sufficient information through the parameter list, while also making the expectations of the API self-documenting, since we include the word

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: cmake/modules/LLDBStandalone.cmake:9 + find_package(LLVM REQUIRED CONFIG +HINTS "${LLDB_PATH_TO_LLVM_BUILD}" NO_DEFAULT_PATH NO_CMAKE_FIND_ROOT_PATH) + find_package(Clang REQUIRED CONFIG

[Lldb-commits] [lldb] r350950 - Fix build breaks after the ParseCompileUnit changes.

Author: zturner Date: Fri Jan 11 10:35:58 2019 New Revision: 350950 URL: http://llvm.org/viewvc/llvm-project?rev=350950=rev Log: Fix build breaks after the ParseCompileUnit changes. The addition of SymbolFileBreakpad crossed paths with my change, so this interface needs to be fixed up as well.

[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

sgraenitz abandoned this revision. sgraenitz marked 3 inline comments as done. sgraenitz added a comment. Closing this in favor of a more comprehensive fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56440/new/ https://reviews.llvm.org/D56440

[Lldb-commits] [lldb] r350947 - Attempt to fix PDB tests broken by r350924

Author: labath Date: Fri Jan 11 10:24:17 2019 New Revision: 350947 URL: http://llvm.org/viewvc/llvm-project?rev=350947=rev Log: Attempt to fix PDB tests broken by r350924 The patch added the symbol plugin name to the lldb-test output. Update the tests to account for that. Modified:

[Lldb-commits] [lldb] r350945 - [CMake] Include tests by default also in standalone builds

Author: stefan.graenitz Date: Fri Jan 11 10:11:04 2019 New Revision: 350945 URL: http://llvm.org/viewvc/llvm-project?rev=350945=rev Log: [CMake] Include tests by default also in standalone builds In-tree builds include tests by default. Standalone builds should behave the same. Modified:

[Lldb-commits] [PATCH] D56564: [SymbolFile] Make ParseCompileUnitXXX accept a CompileUnit&.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB350943: [SymbolFile] Make ParseCompileUnitXXX accept a CompileUnit. (authored by zturner, committed by ). Herald added subscribers: teemperor, abidh. Changed prior to commit:

[Lldb-commits] [lldb] r350943 - [SymbolFile] Make ParseCompileUnitXXX accept a CompileUnit&.

Author: zturner Date: Fri Jan 11 10:03:20 2019 New Revision: 350943 URL: http://llvm.org/viewvc/llvm-project?rev=350943=rev Log: [SymbolFile] Make ParseCompileUnitXXX accept a CompileUnit&. Previously all of these functions accepted a SymbolContext&. While a CompileUnit is one member of a

[Lldb-commits] [PATCH] D56609: [CMake] Remove dead code and outdated comments

This revision was automatically updated to reflect the committed changes. Closed by commit rL350937: [CMake] Remove dead code and outdated comments (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r350937 - [CMake] Remove dead code and outdated comments

Author: stefan.graenitz Date: Fri Jan 11 09:51:33 2019 New Revision: 350937 URL: http://llvm.org/viewvc/llvm-project?rev=350937=rev Log: [CMake] Remove dead code and outdated comments Summary: All of these changes are NOPs. Reviewers: stella.stamenova, labath, JDevlieghere Reviewed By:

[Lldb-commits] [PATCH] D56609: [CMake] Remove dead code and outdated comments

sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Simple cleanup parts of the previous reviews D56400 and D56440 Comment at: lit/CMakeLists.txt:21 -endif () -

[Lldb-commits] [PATCH] D56609: [CMake] Remove dead code and outdated comments

sgraenitz created this revision. sgraenitz added reviewers: stella.stamenova, labath, JDevlieghere. Herald added a subscriber: mgorny. All of these changes are NOPs. https://reviews.llvm.org/D56609 Files: CMakeLists.txt cmake/modules/LLDBStandalone.cmake lit/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

sgraenitz abandoned this revision. sgraenitz added a comment. I will split off the "dead code elimination" part and close both reviews in favor of a more comprehensive fix. Comment at: CMakeLists.txt:49 set(LLDB_DEFAULT_TEST_FILECHECK

[Lldb-commits] [PATCH] D56606: [CMake] Export utility targets to the build/install tree depending on LLVM_BUILD/INSTALL_UTILS

sgraenitz created this revision. sgraenitz added reviewers: chapuni, gottesmm, beanz. Herald added a subscriber: mgorny. Allow external projects to import test-related targets like FileCheck, count, not etc. and query binary paths, properties, etc. This would be useful for LLDB, because it

[Lldb-commits] [PATCH] D56602: Move FileAction, ProcessInfo and ProcessLaunchInfo from Target to Host

labath created this revision. labath added reviewers: zturner, clayborg, jingham, davide, teemperor. Herald added subscribers: mgorny, emaste. These classes describe the details of the process we are about to launch, and so they are naturally used by the launching code in the Host module.

[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

labath marked 4 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:775-787 +void DWARFUnit::ComputePathStyle() { + m_path_style = FileSpec::Style::native; + const DWARFDebugInfoEntry *die = GetUnitDIEPtrOnly(); +

[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

labath updated this revision to Diff 181261. labath added a comment. - move the comp_dir resolution logic from SymbolFileDWARF to DWARFUnit - this required the addition on an accessor to the "comp_dir_symlinks" setting, which is used in the full comp_dir resolution - add FileSpec::MakeAbsolute()

[Lldb-commits] [PATCH] D56595: SymbolFileBreakpad: Add line table support

labath created this revision. labath added reviewers: clayborg, zturner, lemo, markmentovai. This patch teaches SymbolFileBreakpad to parse the line information in breakpad files and present it to lldb. The trickiest question here was what kind of "compile units" to present to lldb, as there

[Lldb-commits] [PATCH] D56590: breakpad: Add FUNC records to the symtab

labath created this revision. labath added reviewers: zturner, lemo, clayborg, markmentovai. Herald added a subscriber: aprantl. This patch extends SymbolFileBreakpad::AddSymbols to include the symbols from the FUNC records too. These symbols come from the debug info and have a size associated

[Lldb-commits] [PATCH] D56589: Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()

labath created this revision. labath added reviewers: clayborg, zturner, lemo. Adding a breakpad symbol file to an existing MachO module with "target symbols add" currently works only if one's host platform is a mac. This is because SymbolVendorMacOSX (which is the one responsible for loading

[Lldb-commits] [PATCH] D56173: Introduce SymbolFileBreakpad and use it to fill symtab

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB350924: Introduce SymbolFileBreakpad and use it to fill symtab (authored by labath, committed by ). Herald added a subscriber: abidh. Changed prior to commit:

[Lldb-commits] [lldb] r350924 - Introduce SymbolFileBreakpad and use it to fill symtab

Author: labath Date: Fri Jan 11 03:17:51 2019 New Revision: 350924 URL: http://llvm.org/viewvc/llvm-project?rev=350924=rev Log: Introduce SymbolFileBreakpad and use it to fill symtab Summary: This commit adds the glue code necessary to integrate the SymbolFileBreakpad into the plugin system.

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

grimar planned changes to this revision. grimar added a comment. In D56014#1341129 , @labath wrote: > I guess it should be possible to trigger this from dotest tests via pexpect. > I know we try to avoid it, but given that this is specifically testing >

[Lldb-commits] [PATCH] D56564: [SymbolFile] Make ParseCompileUnitXXX accept a CompileUnit&.

labath accepted this revision. labath added a comment. looks good to me. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:135 + FileSpecList _files) = 0; + virtual size_t ParseTypes(CompileUnit _unit) = 0; + virtual bool

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

mgorny added inline comments. Comment at: cmake/modules/LLDBStandalone.cmake:9 + find_package(LLVM REQUIRED CONFIG +HINTS "${LLDB_PATH_TO_LLVM_BUILD}" NO_DEFAULT_PATH NO_CMAKE_FIND_ROOT_PATH) + find_package(Clang REQUIRED CONFIG labath wrote: > xiaobai

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

labath added inline comments. Comment at: cmake/modules/LLDBStandalone.cmake:9 + find_package(LLVM REQUIRED CONFIG +HINTS "${LLDB_PATH_TO_LLVM_BUILD}" NO_DEFAULT_PATH NO_CMAKE_FIND_ROOT_PATH) + find_package(Clang REQUIRED CONFIG xiaobai wrote: > labath