[Lldb-commits] [lldb] r355766 - Actually implement the TestQueues.py workaround

Author: friss Date: Fri Mar 8 17:34:44 2019 New Revision: 355766 URL: http://llvm.org/viewvc/llvm-project?rev=355766&view=rev Log: Actually implement the TestQueues.py workaround The code commited in r355764 didn't do what I want as I typed GetThreadID instead of GetQueueID. This commit contains

[Lldb-commits] [lldb] r355764 - Try to workaround the TestQueues.py flakyness

Author: friss Date: Fri Mar 8 17:23:47 2019 New Revision: 355764 URL: http://llvm.org/viewvc/llvm-project?rev=355764&view=rev Log: Try to workaround the TestQueues.py flakyness This is not a fix, but if I understand enough of the issue, it should bail out early of the test when in a situation th

Re: [Lldb-commits] [PATCH] D59165: Remove DWARFDIECollection

Yes, it’s not the case here but even it were, just because the Python interface exposes this api doesn’t mean we have to use it internally. Regardless, this particular class is completely private and has no analogue in the SB API On Fri, Mar 8, 2019 at 4:53 PM Adrian Prantl via Phabricator < revi.

[Lldb-commits] [PATCH] D59165: Remove DWARFDIECollection

aprantl added a comment. Whenever I see a GetFooAtIndex() method I expect this to be exposed via the SBAPI, but I assume this isn't the case here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59165/new/ https://reviews.llvm.org/D59165 ___

[Lldb-commits] [PATCH] D59165: Remove DWARFDIECollection

zturner created this revision. zturner added reviewers: clayborg, aprantl. Herald added subscribers: jdoerfert, mgorny. This is a very thin wrapper over a std::vector and does not seem to provide any real value over just using a container directly. https://reviews.llvm.org/D59165 Files:

[Lldb-commits] [PATCH] D59164: [SymbolFileDWARF] Move ElaboratingDIEIterator into implementation file

zturner created this revision. zturner added a reviewer: clayborg. This is not used outside of the private implementation of the class, so hiding in the implementation file is a nice way of simplifying the external interface. https://reviews.llvm.org/D59164 Files: lldb/source/Plugins/Sy

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

This revision was automatically updated to reflect the committed changes. Closed by commit rL355762: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [lldb] r355762 - Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

Author: jdevlieghere Date: Fri Mar 8 16:10:52 2019 New Revision: 355762 URL: http://llvm.org/viewvc/llvm-project?rev=355762&view=rev Log: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands Inspired by Zachary's mail on lldb-dev, this seemed like low hanging fruit. This patch bre

[Lldb-commits] [lldb] r355761 - Add parens to force the order of operations in an expression trying

Author: jmolenda Date: Fri Mar 8 16:04:24 2019 New Revision: 355761 URL: http://llvm.org/viewvc/llvm-project?rev=355761&view=rev Log: Add parens to force the order of operations in an expression trying to do "databuffer + offset" so that we don't overflow the uint64_t's we're using for addresses

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Ahh yea, sorry. Got confused for a second :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59158/new/ https://reviews.llvm.org/D59158 ___

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

JDevlieghere added a comment. In D59158#1423483 , @zturner wrote: > Interesting, I had looked at fixing this one once before but I didn't realize > we had a class named `EvaluateExpressionOptions` that contained just the > right set of information, and i

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

JDevlieghere updated this revision to Diff 189957. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59158/new/ https://reviews.llvm.org/D59158 Files: lldb/include/lldb/Expression/REPL.h lldb/source/Commands/CommandObjectExpression.cpp lldb/source/Expression/REPL.cpp Index: lldb/sourc

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

zturner added a comment. Interesting, I had looked at fixing this one once before but I didn't realize we had a class named `EvaluateExpressionOptions` that contained just the right set of information, and it felt gross to invent a new one just for this purpose (It's a good thing I didn't too,

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

JDevlieghere updated this revision to Diff 189955. JDevlieghere added a comment. format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59158/new/ https://reviews.llvm.org/D59158 Files: lldb/include/lldb/Expression/REPL.h lldb/source/Commands/CommandObjectExpression.cpp lldb/source

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

JDevlieghere added inline comments. Comment at: lldb/source/Expression/REPL.cpp:10 #include "lldb/Expression/REPL.h" +#include "lldb/Commands/CommandObjectExpression.h" #include "lldb/Core/Debugger.h" zturner wrote: > AFAICT, this doesn't really appear to break

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

JDevlieghere updated this revision to Diff 189953. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59158/new/ https://reviews.llvm.org/D59158 Files: lldb/include/lldb/Expression/REPL.h lldb/source/Commands/CommandObjectExpression.cpp lld

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

zturner added a comment. I think maybe part of the problem is that this patch looks like actually 2 things. 1) A move of the include files from `lldb/source/Commands` to `lldb/Include/lldb/Commands`, and 2) The dependency changes. So it makes it hard to see what changes are actually needed fo

[Lldb-commits] [lldb] r355750 - [lldb] [test] Skip broken NetBSD core test

Author: mgorny Date: Fri Mar 8 14:41:14 2019 New Revision: 355750 URL: http://llvm.org/viewvc/llvm-project?rev=355750&view=rev Log: [lldb] [test] Skip broken NetBSD core test Apparently the problem is harder than anticipated. Skip the test for now to fix buildbots. Modified: lldb/trunk/pa

[Lldb-commits] [PATCH] D59159: [third-party] Update pexpect to 4.6.

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. I don't think we should check in the 'test' or 'example' subdirectories. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59159/new/ https://

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Commands/CommandObjectBreakpoint.h:36 - static void VerifyBreakpointOrLocationIDs(Args &args, Target *target, -CommandRe

[Lldb-commits] [lldb] r355747 - [lldb] [test] Do not check libc function names in NetBSD core test

Author: mgorny Date: Fri Mar 8 14:32:35 2019 New Revision: 355747 URL: http://llvm.org/viewvc/llvm-project?rev=355747&view=rev Log: [lldb] [test] Do not check libc function names in NetBSD core test Fix the NetBSD core test not to verify libc function names in backtrace. This obviously requires

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

zturner added inline comments. Comment at: lldb/include/lldb/Commands/CommandObjectBreakpoint.h:36 - static void VerifyBreakpointOrLocationIDs(Args &args, Target *target, -CommandReturnObject &result, I think the cla

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

JDevlieghere created this revision. JDevlieghere added reviewers: zturner, labath, davide. Herald added a project: LLDB. Inspired by Zachary's mail on lldb-dev, this seemed like low hanging fruit. This patch breaks the circular dependency between commands and expression. Repository: rLLDB LLD

[Lldb-commits] [lldb] r355736 - [lldb] [Process] Add proper support for NetBSD core files with threads

Author: mgorny Date: Fri Mar 8 13:10:43 2019 New Revision: 355736 URL: http://llvm.org/viewvc/llvm-project?rev=355736&view=rev Log: [lldb] [Process] Add proper support for NetBSD core files with threads Improve the support for processing NetBSD cores. Fix reading process identifier, thread info

[Lldb-commits] [PATCH] D32149: [lldb] [Process] Add proper support for NetBSD core files with threads

This revision was automatically updated to reflect the committed changes. Closed by commit rL355736: [lldb] [Process] Add proper support for NetBSD core files with threads (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D32149?vs=189658&id=189911#toc Repo

[Lldb-commits] [lldb] r355730 - Remove dependency edges from Host to Target/Core.

Author: zturner Date: Fri Mar 8 12:56:10 2019 New Revision: 355730 URL: http://llvm.org/viewvc/llvm-project?rev=355730&view=rev Log: Remove dependency edges from Host to Target/Core. After recent changes, Host is now dependency-free. Modified: lldb/trunk/source/Host/CMakeLists.txt lldb/

[Lldb-commits] [PATCH] D32149: [lldb] [Process] Add proper support for NetBSD core files with threads

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The code looks good, though I think we should really start figuring out how to write elf core tests without checking in binaries. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32149/n

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added a comment. @jasonliu, you have had a number of patches committed into the project already (D22698 , D22702 , D34649 ). Please go ahead with requesting commit access, a

[Lldb-commits] [lldb] r355711 - [Reproducers] Add missing LLDB_RECORD_DUMMY macros

Author: jdevlieghere Date: Fri Mar 8 11:09:27 2019 New Revision: 355711 URL: http://llvm.org/viewvc/llvm-project?rev=355711&view=rev Log: [Reproducers] Add missing LLDB_RECORD_DUMMY macros Re-ran lldb-inst on the API folder to insert missing LLDB_RECORD_DUMMY macros. Modified: lldb/trunk/in

[Lldb-commits] [lldb] r355710 - [lldb-instr] Support LLDB_RECORD_DUMMY

Author: jdevlieghere Date: Fri Mar 8 10:33:40 2019 New Revision: 355710 URL: http://llvm.org/viewvc/llvm-project?rev=355710&view=rev Log: [lldb-instr] Support LLDB_RECORD_DUMMY Extend lldb-instr to insert LLDB_RECORD_DUMMY macros for currently unsupported signatures (void and function pointers).

[Lldb-commits] [lldb] r355709 - [Reproducers] Add LLDB_RECORD_DUMMY

Author: jdevlieghere Date: Fri Mar 8 09:50:27 2019 New Revision: 355709 URL: http://llvm.org/viewvc/llvm-project?rev=355709&view=rev Log: [Reproducers] Add LLDB_RECORD_DUMMY Add a macro that doesn't actually record anything but still toggles the API boundary. Removing just the register macros fo

[Lldb-commits] [lldb] r355708 - [lldb-vscode] Fix warning

Author: jdevlieghere Date: Fri Mar 8 09:36:54 2019 New Revision: 355708 URL: http://llvm.org/viewvc/llvm-project?rev=355708&view=rev Log: [lldb-vscode] Fix warning I changed the variable to an unsigned to get rid of a signed and unsigned compare without realizing the value could be negative. Thi

[Lldb-commits] [lldb] r355706 - Add more logging to TestQueues.py

Author: friss Date: Fri Mar 8 09:09:13 2019 New Revision: 355706 URL: http://llvm.org/viewvc/llvm-project?rev=355706&view=rev Log: Add more logging to TestQueues.py The last round of logging taught us that when the test fails, lldb is indeed aware of the thread it's failing to associate to a giv

[Lldb-commits] [PATCH] D58930: Add XCOFF triple object format type for AIX

sfertile accepted this revision. sfertile added a comment. LGTM. Comment at: llvm/lib/MC/MCContext.cpp:165 +case MCObjectFileInfo::IsXCOFF: + // TODO: Need to implement class MCSymbolXCOFF. + break; jasonliu wrote: > sfertile wrote: > > jasonliu w

[Lldb-commits] [lldb] r355684 - Make function definition in header inline

Author: d0k Date: Fri Mar 8 02:43:56 2019 New Revision: 355684 URL: http://llvm.org/viewvc/llvm-project?rev=355684&view=rev Log: Make function definition in header inline Otherwise including this header from more than one place will break linking. Modified: lldb/trunk/include/lldb/Utility/R

[Lldb-commits] [PATCH] D59114: [lldb-vscode] Don't hang indefinitely on invalid program

labath added a comment. A test case? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59114/new/ https://reviews.llvm.org/D59114 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma