[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

ruiu added a comment. Overall looking good. Comment at: lld/ELF/MarkLive.cpp:190 + // case we still need to mark the file. + if (S && !IsLSDA && Sec->File) +if (isa(Sec) || isa(Sec)) ruiu wrote: > S is true only when it is an InputSection, so you have

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

ruiu added a comment. Nice. One more thing you might want to try is to add `-O2` to the linker command line option. When that option is given, lld attempts to tail-merge strings in the string table. That's not very effective, but you might be able to shave off 0.2% or something like that.

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

rocallahan added a comment. I am also pleased to report that for my real project , switching from `ld.bfd` to `lld` + this patch reduces the total size of our `dist` built binaries from 2.9GB to 2.0GB. I'm not sure why it's become

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

rocallahan added a comment. Updated results for the rusoto test in https://github.com/rust-lang/rust/issues/56068#issue-382175735. The test changed a bit because I'm using an updated Rust toolchain and `rusoto_core` 0.37.0. | Linker | Size (bytes) | Real time

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

rocallahan updated this revision to Diff 194244. rocallahan added a comment. Addressed all comments AFAIK. I'll post some performance numbers in a moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/ https://reviews.llvm.org/D54747 Files: lld/ELF/Driver.cpp

[Lldb-commits] [lldb] r357963 - Get the run locker before you ask if your thread is valid.

Author: jingham Date: Mon Apr 8 18:33:23 2019 New Revision: 357963 URL: http://llvm.org/viewvc/llvm-project?rev=357963=rev Log: Get the run locker before you ask if your thread is valid. I have occasional crashes coming from SBThread::GetExtendedBacktraceThread. The symptom is that we got

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Overall, I'm ambivalent. The patch description makes a good case for the change. I find the visitor pattern hard to follow (partly because the `visit` and `accept` naming is not

[Lldb-commits] [PATCH] D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357955: Rename Target::GetSharedModule to Target::GetOrCreateModule. (authored by jmolenda, committed by ). Changed

[Lldb-commits] [lldb] r357955 - Rename Target::GetSharedModule to Target::GetOrCreateModule.

Author: jmolenda Date: Mon Apr 8 16:03:02 2019 New Revision: 357955 URL: http://llvm.org/viewvc/llvm-project?rev=357955=rev Log: Rename Target::GetSharedModule to Target::GetOrCreateModule. Add a flag to control whether the ModulesDidLoad notification is called when a module is added. If the

[Lldb-commits] [lldb] r357954 - Experiment with a larger packet timeout.

Author: adrian Date: Mon Apr 8 16:02:11 2019 New Revision: 357954 URL: http://llvm.org/viewvc/llvm-project?rev=357954=rev Log: Experiment with a larger packet timeout. This is a follow-up to r357829 (https://reviews.llvm.org/D60340) to see whether increasing the packet timeout for non-asan

[Lldb-commits] [lldb] r357948 - Fix a stack buffer overflow found by ASAN.

Author: adrian Date: Mon Apr 8 14:58:36 2019 New Revision: 357948 URL: http://llvm.org/viewvc/llvm-project?rev=357948=rev Log: Fix a stack buffer overflow found by ASAN. llvm::StringRef host_and_port is not guaranteed to be null-terminated. Generally, it is not safe at all to convert a

[Lldb-commits] [PATCH] D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

mgorny updated this revision to Diff 194178. mgorny added a comment. Rewritten the test to C++ with inline assembly, and switched to `CHECK-DAG`. Still need to figure out how to filter it for correct platform. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60325/new/

[Lldb-commits] [PATCH] D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

mgorny marked 2 inline comments as done. mgorny added a comment. Thanks. I'll try converting it to C now. Comment at: lldb/lit/Register/x86-mm-xmm-read.test:1 +# REQUIRES: x86 +# RUN: %clang %p/Inputs/x86-mm-xmm-read.s -o %t labath wrote: > Does this mean "the

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

labath updated this revision to Diff 194160. labath added a comment. Fix a bug which meant we weren't replacing the root node correctly (I somehow forgot to run tests before uploading). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60410/new/ https://reviews.llvm.org/D60410 Files:

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

labath added a comment. I find this version easier to follow than the old one, but that could be simply because I didn't write it. :P So if you believe the old one is better, I am happy to just drop this and carry on with the old one. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D60410: PDBFPO: Improvements to the AST visitor

labath created this revision. labath added reviewers: aleksandr.urakov, amccarth. This patch attempts to solve two issues made this code hard to follow for me. The first issue was that a lot of what these visitors do is mutate the AST. The visitor pattern is not particularly good for that

[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

clayborg added a comment. LGTM. Probably should get one more ok Comment at: lib/ObjectYAML/MinidumpYAML.cpp:91 + size_t BlobAllocator::allocateString(StringRef Str) { SmallVector WStr; Might be nice to unique the strings in here? Repository: rL LLVM

[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

labath created this revision. labath added reviewers: amccarth, jhenderson, clayborg, zturner. Herald added a project: LLVM. This patch adds support for yaml (de)serialization of the minidump ModuleList stream. It's a fairly straight forward-application of the existing patterns to the ModuleList

[Lldb-commits] [PATCH] D60400: Remove unneeded #ifdef SWIGs

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60400/new/ https://reviews.llvm.org/D60400 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r357896 - MinidumpParser: parse SystemInfo stream via llvm

Author: labath Date: Mon Apr 8 02:53:03 2019 New Revision: 357896 URL: http://llvm.org/viewvc/llvm-project?rev=357896=rev Log: MinidumpParser: parse SystemInfo stream via llvm I also update the tests for SystemInfo parsing to use the yaml2minidump capabilities in llvm instead of relying on

[Lldb-commits] [lldb] r357895 - PDBFPO: add dyn_cast support

Author: labath Date: Mon Apr 8 02:52:57 2019 New Revision: 357895 URL: http://llvm.org/viewvc/llvm-project?rev=357895=rev Log: PDBFPO: add dyn_cast support This adds the necessary glue so we can use llvm::dyn_cast, instead of doing a manual type-check followed by a cast. NFC. Modified:

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

labath updated this revision to Diff 194108. labath marked 2 inline comments as done. labath added a comment. Remove the fancy parsing of register expressions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60268/new/ https://reviews.llvm.org/D60268 Files:

[Lldb-commits] [PATCH] D60268: Breakpad: Parse Stack CFI records

labath marked 5 inline comments as done. labath added inline comments. Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:393 + llvm::StringRef LHS, RHS; + while (std::tie(Str, Line) = getToken(Line), !Str.empty()) { +if (Str.back() == ':') { // regN

[Lldb-commits] [lldb] r357893 - Fix signed-unsigned comparison warning in Driver.cpp

Author: labath Date: Mon Apr 8 02:17:56 2019 New Revision: 357893 URL: http://llvm.org/viewvc/llvm-project?rev=357893=rev Log: Fix signed-unsigned comparison warning in Driver.cpp Modified: lldb/trunk/tools/driver/Driver.cpp Modified: lldb/trunk/tools/driver/Driver.cpp URL:

[Lldb-commits] [PATCH] D60400: Remove unneeded #ifdef SWIGs

labath created this revision. labath added reviewers: JDevlieghere, clayborg, jingham. Some of these were present in files which should never be read by swig (and we also had one in the interface file, which is only read by swig). They are probably leftovers from the time when we were running

[Lldb-commits] [lldb] r357890 - modify-python-lldb.py: Remove ifdef SWIG-removing code

Author: labath Date: Mon Apr 8 01:43:07 2019 New Revision: 357890 URL: http://llvm.org/viewvc/llvm-project?rev=357890=rev Log: modify-python-lldb.py: Remove ifdef SWIG-removing code There are no patterns like that in the generated swig files (there probably were some back in the days when we

[Lldb-commits] [PATCH] D60180: [CMake] Don't explicitly use LLVM_LIBRARY_DIR in standalone builds

labath added a comment. In D60180#1456263 , @sgraenitz wrote: > > No, everything is being built for android. Cross-compiling lldb-server > > involves cross-compiling llvm libraries, clang libraries, and if you've got > > swift in the picture, swift host

[Lldb-commits] [PATCH] D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

labath added a comment. I really like how you've approached testing this. There's just one thing that bothers me. Using a .s file means it's going to be hard to make this test work on other OSs (and we should be able to test something like this in a cross-OS manner). All elf targets should