[Lldb-commits] [lldb] r358721 - [Python] Simplify the code. NFCI.

Author: davide Date: Thu Apr 18 16:24:54 2019 New Revision: 358721 URL: http://llvm.org/viewvc/llvm-project?rev=358721=rev Log: [Python] Simplify the code. NFCI. Modified: lldb/trunk/examples/python/memory.py lldb/trunk/examples/python/performance.py

[Lldb-commits] [lldb] r358717 - [crashlog] Strip trailing `\n` from check_output return.

Author: davide Date: Thu Apr 18 14:32:36 2019 New Revision: 358717 URL: http://llvm.org/viewvc/llvm-project?rev=358717=rev Log: [crashlog] Strip trailing `\n` from check_output return. Generally having spurious `\n` doesn't matter, but here the returning string is a command which is executed, so

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

amccarth marked an inline comment as done. amccarth added inline comments. Comment at: source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:575 std::string ns = name_components.front()->toString(); -context = m_clang.GetUniqueNamespaceDeclaration(ns.c_str(), context);

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

amccarth added a comment. Sorry for the slow response; I'm still learning about this code. I like where this is going. Comment at: lit/SymbolFile/NativePDB/ast-types.cpp:77 +// FIXME: Should be located in the namespace `A`, in the struct `C<1>`. +A::C<1>::D AC1D; +

[Lldb-commits] [PATCH] D60871: [CodeComplete] Remove obsolete isOutputBinary().

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358696: [CodeComplete] Remove obsolete isOutputBinary(). (authored by sammccall, committed by ). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [lldb] r358696 - [CodeComplete] Remove obsolete isOutputBinary().

Author: sammccall Date: Thu Apr 18 10:35:55 2019 New Revision: 358696 URL: http://llvm.org/viewvc/llvm-project?rev=358696=rev Log: [CodeComplete] Remove obsolete isOutputBinary(). Summary: It's never set to true. Its only effect would be to set stdout to binary mode. Hopefully we have better

[Lldb-commits] [lldb] r358693 - [Docs] Add LLDB bots

Author: jdevlieghere Date: Thu Apr 18 10:31:20 2019 New Revision: 358693 URL: http://llvm.org/viewvc/llvm-project?rev=358693=rev Log: [Docs] Add LLDB bots Added: lldb/trunk/docs/resources/bots.rst Modified: lldb/trunk/docs/index.rst Modified: lldb/trunk/docs/index.rst URL:

[Lldb-commits] [PATCH] D60863: [CMake] Emit LLDB.framework.dSYM to avoid potential name collision with driver's lldb.dSYM

sgraenitz added a comment. This was mostly to illustrate usage of the matching LLVM commit. Unlikely to break something. Post-commit review should be sufficient. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60863/new/ https://reviews.llvm.org/D60863

[Lldb-commits] [PATCH] D60862: [CMake] Allow custom extensions for externalized debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rL358685: [CMake] Allow custom extensions for externalized debug info (authored by stefan.graenitz, committed by ). Changed prior to commit: https://reviews.llvm.org/D60862?vs=195712=195765#toc

[Lldb-commits] [PATCH] D60863: [CMake] Emit LLDB.framework.dSYM to avoid potential name collision with driver's lldb.dSYM

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB358686: [CMake] Emit LLDB.framework.dSYM to avoid potential name collision with… (authored by stefan.graenitz,

[Lldb-commits] [lldb] r358686 - [CMake] Emit LLDB.framework.dSYM to avoid potential name collision with driver's lldb.dSYM

Author: stefan.graenitz Date: Thu Apr 18 09:37:22 2019 New Revision: 358686 URL: http://llvm.org/viewvc/llvm-project?rev=358686=rev Log: [CMake] Emit LLDB.framework.dSYM to avoid potential name collision with driver's lldb.dSYM Summary: Emit framework's dSYM bundle as LLDB.framework.dSYM

[Lldb-commits] [PATCH] D60862: [CMake] Allow custom extensions for externalized debug info

sgraenitz added a comment. Yes, scopes are per directory; macros operate on the caller's scope and functions add one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60862/new/ https://reviews.llvm.org/D60862

[Lldb-commits] [PATCH] D60862: [CMake] Allow custom extensions for externalized debug info

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. Interesting. Cmake scoping rules are still a mystery to me. So when you `set(FOO ...), it's set only for the current scope and in any functions/macros you call in that scope? Then this seems

[Lldb-commits] [PATCH] D60862: [CMake] Allow custom extensions for externalized debug info

sgraenitz added a comment. In D60862#1471755 , @friss wrote: > Actually, thinking more about this, how do you use it? > LLVM_EXTERNALIZE_DEBUGINFO_EXTENSION is a global but this would be different > per target. It can be set in the scope of the

[Lldb-commits] [PATCH] D60862: [CMake] Allow custom extensions for externalized debug info

friss requested changes to this revision. friss added a comment. This revision now requires changes to proceed. Actually, thinking more about this, how do you use it? LLVM_EXTERNALIZE_DEBUGINFO_EXTENSION is a global but this would be different per target. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

labath added inline comments. Comment at: lib/ObjectYAML/MinidumpYAML.cpp:21 +/// methods, while the final minidump file is written by calling the writeTo +/// method. The plan versions of allocation functions take a reference to the +/// data which is to be written (and hence

[Lldb-commits] [PATCH] D60817: [NativePDB] Add anonymous namespaces support

labath added a reviewer: amccarth. labath added a comment. Don't know much about PDBs, but the change seems pretty straight-forward to me. Zach would be the best person to review this, but he's probably busy with other things now. Maybe Adrian could take a look? Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

This revision was automatically updated to reflect the committed changes. labath marked 4 inline comments as done. Closed by commit rL358672: MinidumpYAML: Add support for ModuleList stream (authored by labath, committed by ). Changed prior to commit:

[Lldb-commits] [PATCH] D60862: [CMake] Allow custom extensions for externalized debug info

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60862/new/ https://reviews.llvm.org/D60862 ___

[Lldb-commits] [PATCH] D60829: FuncUnwinders: remove "current_offset" from function arguments

labath added a comment. Sure, that's no problem. Thanks for letting me know. BTW, I have a couple more patches in the general unwinding area (part of the breakpad unwinding thing), but I still need to clean those up before they can be put up for review. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r358660 - [lldb] [test] Mark three more tests flakey/xfail on NetBSD

Author: mgorny Date: Thu Apr 18 05:31:48 2019 New Revision: 358660 URL: http://llvm.org/viewvc/llvm-project?rev=358660=rev Log: [lldb] [test] Mark three more tests flakey/xfail on NetBSD Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py

[Lldb-commits] [PATCH] D60863: [CMake] Emit LLDB.framework.dSYM to avoid potential name collision with driver's lldb.dSYM

sgraenitz created this revision. sgraenitz added reviewers: friss, beanz, bogner. Herald added a subscriber: mgorny. Herald added a project: LLDB. Emit framework's dSYM bundle as LLDB.framework.dSYM instead of LLDB.dSYM, because the latter could conflict with the driver's lldb.dSYM when emitted

[Lldb-commits] [PATCH] D60862: [CMake] Allow custom extensions for externalized debug info

sgraenitz added a comment. Enables https://reviews.llvm.org/D60863 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60862/new/ https://reviews.llvm.org/D60862 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D60862: [CMake] Allow custom extensions for externalized debug info

sgraenitz created this revision. sgraenitz added reviewers: friss, bogner, beanz. Herald added subscribers: aprantl, mgorny. Herald added a project: LLVM. Extra flexibility for emitting debug info to external files (remains Darwin only for now). LLDB needs this functionality to emit a

[Lldb-commits] [PATCH] D60405: MinidumpYAML: Add support for ModuleList stream

jhenderson accepted this revision. jhenderson added inline comments. Comment at: lib/ObjectYAML/MinidumpYAML.cpp:21 +/// methods, while the final minidump file is written by calling the writeTo +/// method. The plan versions of allocation functions take a reference to the +///