[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

lanza added a comment. So the ABI plugin for Windows x64 seems to be necessary for proper unwinding. (Also, proper parsing of xdata and pdata sections might be necessary, too.) I suspect that this could be related to https://bugs.llvm.org/show_bug.cgi?id=32343, but would need to look more into

[Lldb-commits] [lldb] r360971 - [Docs] Fix headings in remote debugging

Author: jdevlieghere Date: Thu May 16 18:38:16 2019 New Revision: 360971 URL: http://llvm.org/viewvc/llvm-project?rev=360971=rev Log: [Docs] Fix headings in remote debugging Add the proper headings instead of using just a bold font. Also add the local ToC. Modified:

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. echristo's comments on the mail thread for this didn't make it to phab. I apologize for repeating more or less everything he said, I had looked on phab before reading email. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/

[Lldb-commits] [lldb] r360967 - [Docs] Remove architectures from feature matrix

Author: jdevlieghere Date: Thu May 16 18:04:37 2019 New Revision: 360967 URL: http://llvm.org/viewvc/llvm-project?rev=360967=rev Log: [Docs] Remove architectures from feature matrix This is outdated, there's a bunch of architectures missing. If we want them to be part of this table they should

[Lldb-commits] [lldb] r360966 - [CommandInterpreter] Accept blanks after `all` or [0-9]+ for bt.

Author: davide Date: Thu May 16 18:03:21 2019 New Revision: 360966 URL: http://llvm.org/viewvc/llvm-project?rev=360966=rev Log: [CommandInterpreter] Accept blanks after `all` or [0-9]+ for bt. Previously "bt all" would've failed as the regex didn't match them. Over the shoulder review by

[Lldb-commits] [lldb] r360964 - [Docs] Unify sidebar padding

Author: jdevlieghere Date: Thu May 16 17:45:05 2019 New Revision: 360964 URL: http://llvm.org/viewvc/llvm-project?rev=360964=rev Log: [Docs] Unify sidebar padding Unify the padding across list items and the list header. Modified: lldb/trunk/docs/_static/lldb.css Modified:

[Lldb-commits] [PATCH] D62012: Make DWARFContext dwo-aware and port debug_info sections over

JDevlieghere added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFContext.cpp:47 +m_data_debug_info); + else +return LoadOrGetSection(m_main_section_list, eSectionTypeDWARFDebugInfo, After the early return we

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

JDevlieghere updated this revision to Diff 199943. JDevlieghere added a comment. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61994/new/ https://reviews.llvm.org/D61994 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

inglorion added a comment. Reverted in r360955. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/ https://reviews.llvm.org/D54747 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

JDevlieghere added inline comments. Comment at: lldb/docs/resources/build.rst:242 -We first need to checkout the source trees into the appropriate locations. Both -Clang and LLDB build as subprojects of LLVM. This means we will be checking out -the source for both Clang and

[Lldb-commits] [lldb] r360956 - Slightly update the macOS part of status.rst to be less out-of-date.

Author: adrian Date: Thu May 16 16:39:08 2019 New Revision: 360956 URL: http://llvm.org/viewvc/llvm-project?rev=360956=rev Log: Slightly update the macOS part of status.rst to be less out-of-date. Modified: lldb/trunk/docs/status/status.rst Modified: lldb/trunk/docs/status/status.rst URL:

Re: [Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

For now I think the compelling argument on revert is: - this breaks currently working thinlto builds whether or not this has uncovered a latent problem in thinlto, the linking strategy used, or something else I think we should revert until we can take a look and decide where the problems are and

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

inglorion added a comment. I also think we should revert this change while we think about the approach. I've been reluctant to do this because I was impressed by how many bytes of output it saves, and I didn't want to lose that just because it doesn't play nice with ThinLTO. However, after

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

jryans created this revision. jryans added a reviewer: JDevlieghere. Herald added a project: LLDB. This removes several older paragraphs in the LLDB build steps for Unix systems which suggested checking out various components via SVN. Since there's a separate page about getting the LLDB source

Re: [Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

Unlikely. I'm in the middle of getting some, but that's still going to be a few months I think. And yes, we should probably just revert for now. I can unless someone beats me to it. Thanks! On Thu, May 16, 2019 at 2:29 PM Nico Weber via Phabricator wrote: > > thakis added a comment. > > This

[Lldb-commits] [lldb] r360945 - [Target] Stop linking against lldbPluginObjCLanguage

Author: xiaobai Date: Thu May 16 15:01:25 2019 New Revision: 360945 URL: http://llvm.org/viewvc/llvm-project?rev=360945=rev Log: [Target] Stop linking against lldbPluginObjCLanguage Modified: lldb/trunk/source/Target/CMakeLists.txt lldb/trunk/source/Target/LanguageRuntime.cpp Modified:

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. This breaking both debug info in thinlto builds and fmodules-debuginfo is probably enough to revert and go back to the drawing board. I suppose we don't have any debug info quality tests that use thinlto? Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

rnk added a comment. There's another use case worth considering here, which is -fmodules-debuginfo. In that situation, a standalone object file is emitted that contains nothing but DWARF .debug_info sections, and the object is fed to the linker. If the linker drops it with --gc-sections, it's

[Lldb-commits] [lldb] r360930 - Factor out switch statement into a helper function (NFC)

Author: adrian Date: Thu May 16 13:03:05 2019 New Revision: 360930 URL: http://llvm.org/viewvc/llvm-project?rev=360930=rev Log: Factor out switch statement into a helper function (NFC) This addresses post-commit review feedback for https://reviews.llvm.org/D62015. Modified:

[Lldb-commits] [PATCH] D62021: Fix LLDB warnings when compiling with Clang 8.0

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62021/new/ https://reviews.llvm.org/D62021

[Lldb-commits] [PATCH] D62015: Make sure GetObjectDescription falls back to the Objective-C runtime.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360929: Make sure GetObjectDescription falls back to the Objective-C runtime. (authored by adrian, committed by ). Changed prior to commit: https://reviews.llvm.org/D62015?vs=199862=199883#toc

[Lldb-commits] [lldb] r360929 - Make sure GetObjectDescription falls back to the Objective-C runtime.

Author: adrian Date: Thu May 16 12:21:31 2019 New Revision: 360929 URL: http://llvm.org/viewvc/llvm-project?rev=360929=rev Log: Make sure GetObjectDescription falls back to the Objective-C runtime. This fixes an unintended regression introduced by https://reviews.llvm.org/D61451 by making sure

[Lldb-commits] [PATCH] D62021: Fix LLDB warnings when compiling with Clang 8.0

aganea created this revision. aganea added reviewers: JDevlieghere, aleksandr.urakov, asmith, mgorny. aganea added a project: LLDB. Herald added subscribers: lldb-commits, abidh, aprantl. Ditto. Please see warnings list: [2660/3259] Building CXX object

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

xiaobai added inline comments. Comment at: lldb/cmake/caches/Apple-lldb-macOS.cmake:18 +set(CMAKE_BUILD_TYPE RelWithDebInfo) +set(LLVM_ENABLE_MODULES ON CACHE BOOL "") xiaobai wrote: > labath wrote: > > sgraenitz wrote: > > > compnerd wrote: > > > > sgraenitz

[Lldb-commits] [PATCH] D62015: Make sure GetObjectDescription falls back to the Objective-C runtime.

aprantl updated this revision to Diff 199859. aprantl added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62015/new/ https://reviews.llvm.org/D62015 Files: lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/Makefile

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

sgraenitz added inline comments. Comment at: lldb/cmake/caches/Apple-lldb-macOS.cmake:18 +set(CMAKE_BUILD_TYPE RelWithDebInfo) +set(LLVM_ENABLE_MODULES ON CACHE BOOL "") compnerd wrote: > sgraenitz wrote: > > Can / Should we add this? Here? > This is fine to add

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

xiaobai added a comment. Seems like an overall improvement to the structure of this code. At the high level, the structure feels easier to understand. In D61994#1504336 , @labath wrote: > I think this is a bit more readable. I've included some

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

sgraenitz added inline comments. Comment at: lldb/cmake/caches/Apple-lldb-macOS.cmake:10 +set(CMAKE_INSTALL_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/install/Developer/usr") +set(LLDB_FRAMEWORK_INSTALL_DIR "${CMAKE_CURRENT_BINARY_DIR}/install/SharedFrameworks" CACHE STRING "") +

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

compnerd added inline comments. Comment at: lldb/cmake/caches/Apple-lldb-macOS.cmake:18 +set(CMAKE_BUILD_TYPE RelWithDebInfo) +set(LLVM_ENABLE_MODULES ON CACHE BOOL "") sgraenitz wrote: > Can / Should we add this? Here? This is fine to add assuming that you are

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

sgraenitz updated this revision to Diff 199853. sgraenitz added a comment. Add back `CACHE STRING ""` for `CMAKE` variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61956/new/ https://reviews.llvm.org/D61956 Files:

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

sgraenitz added a comment. Yet another option: we could install the framework tools to a fake location and copy them to their final destination (overwriting their build-tree pendants) in a manual install step at the very end of the install process. The problem here is, that there may be more

[Lldb-commits] [PATCH] D62015: Make sure GetObjectDescription falls back to the Objective-C runtime.

jasonmolenda added a comment. My one concern is how this will work in a swift-lldb where we have a swift ValueObject, the print description fails, and we fall back to the ObjC print description. That's a change in behavior, right? I imagine worst case is that the objc print description will

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

sgraenitz added a comment. I thought about one more option, but I don't think it's better than the current proposal: instead of deleting the build-tree resources in the very first install step, I could **install the framework manually** at this point and skip its regular install target. We

[Lldb-commits] [PATCH] D62015: Make sure GetObjectDescription falls back to the Objective-C runtime.

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:1112 - bool is_signed; - if (compiler_type.IsIntegerType(is_signed) || - compiler_type.IsPointerType()) { This check was

[Lldb-commits] [PATCH] D62015: Make sure GetObjectDescription falls back to the Objective-C runtime.

aprantl created this revision. aprantl added reviewers: jingham, jasonmolenda. Herald added a project: LLDB. This fixes an unintended regression introduced by https://reviews.llvm.org/D61451 by making sure the Objective-C runtime is also tried when the "correct" language runtime failed to

[Lldb-commits] [lldb] r360916 - [IRExecutionUnit] Remove static_assert

Author: jdevlieghere Date: Thu May 16 09:54:41 2019 New Revision: 360916 URL: http://llvm.org/viewvc/llvm-project?rev=360916=rev Log: [IRExecutionUnit] Remove static_assert This doesn't make sense on platforms other than 64 bit. Modified: lldb/trunk/source/Expression/IRExecutionUnit.cpp

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

labath added a comment. In D61952#1504942 , @sgraenitz wrote: > Actually, why not make the copy operations `PRE_BUILD` actions of the test > suite instead of `POST_BUILD` actions of their executables? Because one might want to run the lldb executable

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

sgraenitz added a comment. Actually, why not make the copy operations `PRE_BUILD` actions of the test suite instead of `POST_BUILD` actions of their executables? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61952/new/

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

sgraenitz added a comment. In D61952#1504346 , @labath wrote: > I'm not very familiar with frameworks and complexities involved in creating > them, but the fact that we need to delete stuff from the build tree in order > to install properly makes me

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

labath accepted this revision. labath added a comment. Adrian is on vacation now, but given that he was just waiting until you resolve my comments (which you have), I think we don't have to wait for him. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/

[Lldb-commits] [PATCH] D61482: [DWARF] Store compile unit IDs in the DIERef class

labath abandoned this revision. labath added a comment. Obsoleted by D61908 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61482/new/ https://reviews.llvm.org/D61482 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D61853: [FuncUnwinders] Use "symbol file" unwind plans for unwinding

labath marked an inline comment as done. labath added inline comments. Comment at: source/Symbol/FuncUnwinders.cpp:61-70 if (UnwindPlanSP plan_sp = GetEHFrameUnwindPlan(target)) return plan_sp; if (UnwindPlanSP plan_sp = GetDebugFrameUnwindPlan(target)) return

[Lldb-commits] [PATCH] D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`

jankratochvil added a comment. In D62011#1504877 , @labath wrote: > Seems like a nice cleanup. Given that code code already assumed that the > DWARFUnit can't be null, I'd just delete the null checks.. I have rechecked it now and 2 of the 3 tests are

[Lldb-commits] [PATCH] D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`

jankratochvil updated this revision to Diff 199838. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62011/new/ https://reviews.llvm.org/D62011 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp

[Lldb-commits] [PATCH] D61885: Minidump: Add support for the MemoryList stream

This revision was automatically updated to reflect the committed changes. Closed by commit rL360908: Minidump: Add support for the MemoryList stream (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D61885?vs=199570=199837#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D61885: Minidump: Add support for the MemoryList stream

labath added a comment. Thanks. This is very straight-forward, so I don't think another set of eyes is needed (though I expect Greg is keeping at least one eye on this). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61885/new/ https://reviews.llvm.org/D61885

[Lldb-commits] [PATCH] D62012: Make DWARFContext dwo-aware and port debug_info sections over

labath created this revision. labath added reviewers: aprantl, clayborg, JDevlieghere. The previous attempt and moving section handling over to DWARFContext (D59611 ) failed because it did not take into account the dwo sections correctly. All DWARFContexts (even

[Lldb-commits] [PATCH] D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`

labath added a comment. Seems like a nice cleanup. Given that code code already assumed that the DWARFUnit can't be null, I'd just delete the null checks.. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62011/new/ https://reviews.llvm.org/D62011

[Lldb-commits] [PATCH] D62008: DWARF: Parse type units from the debug_types section

labath updated this revision to Diff 199831. labath added a comment. - don't bail out if you see the debug_types section - rename a variable in the test to work around the old "Multiple internal symbols found for 'a'" problem CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62008/new/

[Lldb-commits] [PATCH] D62008: DWARF: Parse type units from the debug_types section

jankratochvil added a comment. On Fedora 29 x86_64 I get: FAIL: LLDB :: SymbolFile/DWARF/debug-types-basic.test (123 of 1636) TEST 'LLDB :: SymbolFile/DWARF/debug-types-basic.test' FAILED Script: -- : 'RUN: at line 3';

[Lldb-commits] [PATCH] D62008: DWARF: Parse type units from the debug_types section

labath added a comment. In D62008#1504845 , @jankratochvil wrote: > On Fedora 29 x86_64 I get: > > ... Ah, sorry I forgot to include the part which removes the run-away-screaming-if-you-see-debug_types check. I had that in a separate commit and I

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

labath added a comment. In D61956#1504761 , @sgraenitz wrote: > Instead lldb could have something like `GreenDragon-lldb-base.cmake` that > provides and explains reasonable default settings for a range of > bots/environments. Actual build bot configs in

[Lldb-commits] [PATCH] D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`

jankratochvil marked 3 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:380 +DWARFExpression *frame_base) const { + if (cu == nullptr) return false; Here is a NULL

[Lldb-commits] [PATCH] D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, JDevlieghere. jankratochvil added a project: LLDB. Herald added subscribers: jdoerfert, aprantl. In D61502#1503247 @clayborg suggested that `SymbolFileDWARF

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

sgraenitz added a comment. Thanks for your input. In D61956#1504327 , @labath wrote: > I wouldn't want to over-proliferate these but in general I think this is a > good idea. Agreed, caches for most common configurations only. Also we may not

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

sgraenitz updated this revision to Diff 199817. sgraenitz marked an inline comment as done. sgraenitz added a comment. Rename macOS specific cache file. Add settings and comments. Fix install destinations by appending `Developer` and `SharedFrameworks` respectively. Repository: rG LLVM

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. Ah, yes, sure, it will just be moved on the `lldb-server` side. Thanks again for the clarification! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53753/new/ https://reviews.llvm.org/D53753

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

labath added a comment. In D53753#1504645 , @aleksandr.urakov wrote: > In D53753#1504589 , @labath wrote: > > > When we evaluate an expression, we jit a bunch of opcodes into the inferior > > memory and then have

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. In D53753#1504589 , @labath wrote: > When we evaluate an expression, we jit a bunch of opcodes into the inferior > memory and then have it execute them. For that to work, we need to allocate > some memory in order to

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

labath added a comment. In D53753#1504539 , @aleksandr.urakov wrote: > In D53753#1504361 , @labath wrote: > > > I'm not sure what exactly are the consequences of not using the correct ABI > > definition here. I

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. In D53753#1504361 , @labath wrote: > I'm not sure what exactly are the consequences of not using the correct ABI > definition here. I think the case where the difference may start to become > obvious is if you try to

[Lldb-commits] [PATCH] D61942: DWARFContext: Return empty data extractors instead of null pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360874: DWARFContext: Return empty data extractors instead of null pointers (authored by labath, committed by ). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D61908: DWARF: Add ability to reference debug info coming from multiple sections

This revision was automatically updated to reflect the committed changes. Closed by commit rL360872: DWARF: Add ability to reference debug info coming from multiple sections (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [lldb] r360872 - DWARF: Add ability to reference debug info coming from multiple sections

Author: labath Date: Thu May 16 04:07:58 2019 New Revision: 360872 URL: http://llvm.org/viewvc/llvm-project?rev=360872=rev Log: DWARF: Add ability to reference debug info coming from multiple sections Summary: This patch adds the ability to precisely address debug info in situations when a

[Lldb-commits] [PATCH] D61687: Update Python tests for lldb-server on Windows

labath added a comment. Thanks for explaining. I think this is good to go, sans the merging of the two tests I requested, and the comment fix that @clayborg noticed. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py:208-212 +

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

labath added a comment. In D53753#1504320 , @aleksandr.urakov wrote: > @lanza Hello! AFAIU, these values have nothing to do with the Microsoft x64 > calling convention. They are used by `ABISysV_x86_64`, which specifies ABI > for working with code

[Lldb-commits] [PATCH] D61952: [CMake] Stabilize install process for LLDB.framework

labath added a comment. I'm not very familiar with frameworks and complexities involved in creating them, but the fact that we need to delete stuff from the build tree in order to install properly makes me think that there is something fishy going on. Is there no way to arrange things so that

[Lldb-commits] [lldb] r360868 - Simplify Triple::ppc64{, le} checks with Triple::isPPC64()

Author: maskray Date: Thu May 16 02:07:33 2019 New Revision: 360868 URL: http://llvm.org/viewvc/llvm-project?rev=360868=rev Log: Simplify Triple::ppc64{,le} checks with Triple::isPPC64() While here, update some ppc64le specific check to isPPC64(), if it applies to big-endian as well, in the hope

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

labath added a comment. I think this is a bit more readable. I've included some suggestions which I think could make it even better. Since you're already rewriting this code, this might be a good time to raise a point I wanted to bring up some day. Should we be using `FileSpec` for code like

[Lldb-commits] [lldb] r360865 - Simplify ArchSpec::IsMIPS()

Author: maskray Date: Thu May 16 01:37:32 2019 New Revision: 360865 URL: http://llvm.org/viewvc/llvm-project?rev=360865=rev Log: Simplify ArchSpec::IsMIPS() Modified: lldb/trunk/source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

labath added a comment. I wouldn't want to over-proliferate these, but in general I think this is a good idea. What I would find particularly useful is if we checked in the configurations used by all the bots in here, as that would make it easier to figure out what's going on if one of them

[Lldb-commits] [PATCH] D53753: [Windows] Define generic arguments registers for Windows x64

aleksandr.urakov added a comment. @lanza Hello! AFAIU, these values have nothing to do with the Microsoft x64 calling convention. They are used by `ABISysV_x86_64`, which specifies ABI for working with code injectable into a process being debugged. It requires six arguments to be passed

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

kwk added a comment. I withdraw from my approach and thanks to @teemperor I have found something else to work on. Thank you for this fruitful discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61737/new/ https://reviews.llvm.org/D61737

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2118 +void CommandInterpreter::SourceInitFile(FileSpec file, CommandReturnObject ) { + if

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

JDevlieghere created this revision. JDevlieghere added reviewers: labath, xiaobai, jingham. Herald added a project: LLDB. JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2118 +void