[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.h:63 + return false; // Zero is not a valid stack address +return true; + } kusmour wrote: > compnerd wrote: > > Can we add an additional test

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour marked 16 inline comments as done. kusmour added inline comments. Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1257-1259 + +// We currently only support extracting values with Clang QualTypes. Do we +// care about others?

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 200622. kusmour added a comment. Herald added a subscriber: fedor.sergeev. update a new version based on comment. cleaned some useless comment change to use CHAR_BIT for readability Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r361337 - [Symbol] Remove dead code

Author: xiaobai Date: Tue May 21 17:06:44 2019 New Revision: 361337 URL: http://llvm.org/viewvc/llvm-project?rev=361337=rev Log: [Symbol] Remove dead code Modified: lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp Modified: lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp URL:

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

JDevlieghere updated this revision to Diff 200603. JDevlieghere added a comment. Add comment describing lldb's behavior regarding history files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62216/new/ https://reviews.llvm.org/D62216 Files: lldb/source/Host/common/Editline.cpp

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

jingham added a comment. Then put in a comment saying something like "LLDB ONLY stores history files in .lldb and if you don't like that..." If you are instituting a policy which is not common you should at least document it... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62216/new/

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

JDevlieghere added a comment. In D62216#1511092 , @jingham wrote: > Most other programs write their history files in ~. So we are being a little > odd in offering to put them in ~/.lldb, though I agree that is convenient. > > But if putting files in

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

jingham added a comment. Most other programs write their history files in ~. So we are being a little odd in offering to put them in ~/.lldb, though I agree that is convenient. But if putting files in ~/.lldb ticked somebody off enough that they made a .lldb directory that was read only, your

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

xiaobai added inline comments. Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1257-1259 + +// We currently only support extracting values with Clang QualTypes. Do we +// care about others? I don't see any references to clang in

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp:307-316 +#ifdef LLDB_REMOTE_SHOULD_READ_ALL_REGISTERS_AT_ONCE + // Always fetch the registers at once when the flag has been defined. + bool

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

davide added a comment. What if ~ is not writable either? I think we shouldn't fallback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62216/new/ https://reviews.llvm.org/D62216 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

JDevlieghere added a comment. I figured if we're changing this anyway, we could as well change the behavior. I think it's reasonable to not have history when we cannot create the `.lldb` directory. Before I wiped my directory, I saw several (5?) files in `.lldb` and I'm not convinced we should

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

clayborg added a comment. Using 'g' packets seems fine to me and we might be able to just enable it. We will need to ensure that this doesn't regress stepping times so we will need to get people to try this out on their systems first. Most of our targets expedite enough registers in the stop

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

jingham added a comment. I don't think that's quite right. I think the behavior should be: 1. Try to make a .lldb directory a) If you can, then i) if wchar support ~/.lldb/.lldb-widehistory ii) else ~/.lldb/lldb-history b) else i) if wchar support ~/.lldb-widehistory ii) else ~/.lldb-history

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm updated this revision to Diff 200597. aadsm added a comment. Add missing bits from previous revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62089/new/ https://reviews.llvm.org/D62089 Files: lldb/include/lldb/Host/Socket.h

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm updated this revision to Diff 200594. aadsm added a comment. Fix the mess I created by including parts of the previous diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62089/new/ https://reviews.llvm.org/D62089 Files:

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

guiandrade created this revision. guiandrade added a reviewer: labath. guiandrade added a project: LLDB. Herald added a subscriber: lldb-commits. This change makes it possible to fetch all registers at once from Linux by defining a macro. This is useful for the case when all registers are being

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

compnerd added inline comments. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:1094 + if (arch_type == llvm::Triple::x86_64 && + os_type != llvm::Triple::OSType::Win32) { return ABISP(new ABISysV_x86_64(process_sp)); This really

[Lldb-commits] [PATCH] D62219: [FileSystem] Fix regression in FileSystem::Resolve

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361321: [FileSystem] Fix regression in FileSystem::Resolve (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D62219?vs=200585=200593#toc Repository:

[Lldb-commits] [lldb] r361321 - [FileSystem] Fix regression in FileSystem::Resolve

Author: jdevlieghere Date: Tue May 21 14:56:37 2019 New Revision: 361321 URL: http://llvm.org/viewvc/llvm-project?rev=361321=rev Log: [FileSystem] Fix regression in FileSystem::Resolve When I moved the resolve code from FileSpec to the FileSystem class, I introduced a regression. If you compare

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

JDevlieghere updated this revision to Diff 200592. JDevlieghere added a comment. Jim's feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62216/new/ https://reviews.llvm.org/D62216 Files: lldb/source/Host/common/Editline.cpp Index: lldb/source/Host/common/Editline.cpp

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

clayborg added a comment. In D62211#1510903 , @clayborg wrote: > We really shouldn't have any DWARFDIE references inside > DWARFDebugInfoEntry.h. I noticed there are a lot now which is wrong. I take this back. Many uses are good inside of

[Lldb-commits] [PATCH] D62219: [FileSystem] Fix regression in FileSystem::Resolve

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, also discussed in person. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62219/new/ https://reviews.llvm.org/D62219

[Lldb-commits] [lldb] r361316 - [CommandInterpreter] Fix SkipAppInitFiles setter

Author: jdevlieghere Date: Tue May 21 14:33:06 2019 New Revision: 361316 URL: http://llvm.org/viewvc/llvm-project?rev=361316=rev Log: [CommandInterpreter] Fix SkipAppInitFiles setter The SkipAppInitFiles setter was ignoring its import argument. Modified:

[Lldb-commits] [PATCH] D62219: [FileSystem] Fix regression in FileSystem::Resolve

JDevlieghere created this revision. JDevlieghere added reviewers: davide, jingham. Herald added a project: LLDB. When I moved the resolve code from FileSpec to the FileSystem class, I introduced a regression. If you compare the two implementations, you'll notice that if the path doesn't exist,

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

clayborg added a comment. We really shouldn't have any DWARFDIE references inside DWARFDebugInfoEntry.h. I noticed there are a lot now which is wrong. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62211/new/ https://reviews.llvm.org/D62211

[Lldb-commits] [lldb] r361310 - [Test] Fix conflicting test names.

Author: jdevlieghere Date: Tue May 21 13:55:00 2019 New Revision: 361310 URL: http://llvm.org/viewvc/llvm-project?rev=361310=rev Log: [Test] Fix conflicting test names. Two tests having the same name creates a race condition when moving the trace files. Modified:

[Lldb-commits] [PATCH] D62061: Add AST logging

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM outside of Jonas's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62061/new/ https://reviews.llvm.org/D62061

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. The whole goal of the DWARFDebugInfoEntry::GetName() and DWARFDebugInfoEntry::AppendTypeName() we might be needing to dump the name of a DIE in DWARF that was not parsed yet.

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

JDevlieghere created this revision. JDevlieghere added reviewers: labath, xiaobai, jingham. Herald added a project: LLDB. Rewrite the GetHistoryFilePath implementation without relying on FileSpec in the spirit of our discussion in D61994 . Repository: rLLDB

[Lldb-commits] [PATCH] D62021: Fix LLDB warnings when compiling with Clang 8.0

This revision was automatically updated to reflect the committed changes. aganea marked an inline comment as done. Closed by commit rL361295: Fix LLDB warnings when compiling with Clang 8.0 (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

jankratochvil marked 3 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1073 +bool DWARFDebugInfoEntry::AppendTypeName(const DWARFDIE die, Stream ) { + if (die) { +if

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

jankratochvil updated this revision to Diff 200566. jankratochvil marked an inline comment as done. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62211/new/ https://reviews.llvm.org/D62211 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

aadsm updated this revision to Diff 200562. aadsm added a comment. A-Z order the CMakeLists files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61833/new/ https://reviews.llvm.org/D61833 Files:

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour created this revision. kusmour added reviewers: xiaobai, compnerd. kusmour added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, mgorny. Implement the ABI for WIndows-x86_64 including register info and calling convention. Handled nested struct returned in register

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1073 +bool DWARFDebugInfoEntry::AppendTypeName(const DWARFDIE die, Stream ) { + if (die) { +if (die.GetDIE()->IsNULL()) { How about turning this

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath. jankratochvil added a project: LLDB. Herald added a subscriber: aprantl. In D61502#1503247 @clayborg suggested that `DWARFUnit *`+`dw_offset_t` can be now replaced by

[Lldb-commits] [PATCH] D62168: [DynamicLoader] Make sure we always set the rendezvous breakpoint

eugene accepted this revision. eugene added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62168/new/ https://reviews.llvm.org/D62168

[Lldb-commits] [PATCH] D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`

This revision was automatically updated to reflect the committed changes. Closed by commit rL361277: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *` (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r361277 - Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`

Author: jankratochvil Date: Tue May 21 10:38:56 2019 New Revision: 361277 URL: http://llvm.org/viewvc/llvm-project?rev=361277=rev Log: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *` In D61502#1503247 @clayborg suggested that SymbolFileDWARF *dwarf2Data is really redundant in all

[Lldb-commits] [PATCH] D61853: [FuncUnwinders] Use "symbol file" unwind plans for unwinding

clayborg added inline comments. Comment at: source/Symbol/FuncUnwinders.cpp:63-64 return plan_sp; if (UnwindPlanSP plan_sp = GetDebugFrameUnwindPlan(target)) return plan_sp; if (UnwindPlanSP plan_sp = GetCompactUnwindUnwindPlan(target)) We should

[Lldb-commits] [PATCH] D62178: DWARF: Don't compute address ranges for type units

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with a few small nits, even though I know you just moved the code. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:77 + m_dwarf->GetDebugMapSymfile(); + if

[Lldb-commits] [PATCH] D62061: Add AST logging

JDevlieghere added inline comments. Comment at: lldb/source/Symbol/ClangASTImporter.cpp:968 + from->getDeclKindName(), static_cast(to), + name_string.c_str(), static_cast(from)); + The macro uses llvm's format library, so you can

[Lldb-commits] [PATCH] D59015: [lldb-mi] Include full path in the -data-disassemble response

This revision was automatically updated to reflect the committed changes. Closed by commit rL361255: [lldb-mi] Include full path in the -data-disassemble response (authored by tkrasnukha, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r361255 - [lldb-mi] Include full path in the -data-disassemble response

Author: tkrasnukha Date: Tue May 21 06:22:46 2019 New Revision: 361255 URL: http://llvm.org/viewvc/llvm-project?rev=361255=rev Log: [lldb-mi] Include full path in the -data-disassemble response Differential Revision: https://reviews.llvm.org/D59015 Patch by Anton Kolesov Modified:

[Lldb-commits] [PATCH] D62183: [Windows] Fix race condition between state changes

martin created this revision. martin added a reviewer: zturner. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If the process is resumed before the state is changed to "running" there is a possibility (when single stepping) that the debugger stops and changes the state

[Lldb-commits] [PATCH] D62061: Add AST logging

martong added inline comments. Comment at: lldb/source/Symbol/ClangASTImporter.cpp:956 + Log *log_ast(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_AST)); + if (log_ast) { +std::string name_string; JDevlieghere wrote: > Why not `if (Log*

[Lldb-commits] [PATCH] D62061: Add AST logging

martong updated this revision to Diff 200446. martong marked 4 inline comments as done. martong added a comment. - Change to if(Log *log = ...) - Use LLDB_LOG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62061/new/ https://reviews.llvm.org/D62061

[Lldb-commits] [lldb] r361232 - DWARF: Port debug_addr over to DWARFContext

Author: labath Date: Tue May 21 02:11:11 2019 New Revision: 361232 URL: http://llvm.org/viewvc/llvm-project?rev=361232=rev Log: DWARF: Port debug_addr over to DWARFContext Modified: lldb/trunk/source/Expression/DWARFExpression.cpp

[Lldb-commits] [PATCH] D62178: DWARF: Don't compute address ranges for type units

labath created this revision. labath added reviewers: clayborg, aprantl, JDevlieghere. Herald added a subscriber: jdoerfert. Type units don't describe any code, so they should never be the result of any address lookup queries. Previously, we would compute the address ranges for the type units

[Lldb-commits] [PATCH] D62008: DWARF: Introduce DWARFTypeUnit class

labath marked an inline comment as done. labath added a comment. Thanks. We can always re-add the check if things take longer than expected. Comment at: lit/SymbolFile/DWARF/debug-types-expressions.test:28 +# CHECK-LABEL: print ns::A() +# CHECK: (ns::A) $1 = (i = 147)

[Lldb-commits] [PATCH] D62073: DWARF: Introduce DWARFUnitHeader class

This revision was automatically updated to reflect the committed changes. Closed by commit rL361224: DWARF: Introduce DWARFUnitHeader class (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r361224 - DWARF: Introduce DWARFUnitHeader class

Author: labath Date: Tue May 21 00:22:34 2019 New Revision: 361224 URL: http://llvm.org/viewvc/llvm-project?rev=361224=rev Log: DWARF: Introduce DWARFUnitHeader class Summary: This patch introduces the DWARFUnitHeader class. Its purpose (and its structure, to the extent it was possible to make

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

labath added a comment. It looks like diff now contains the changes from D61833 as well. It would be better to upload just the changes relative to the previous patch in the series, otherwise things get confusing about what is being changed where. It's kind of

[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

labath added inline comments. Comment at: lldb/unittests/Host/CMakeLists.txt:12-13 TaskPoolTest.cpp + SocketTestUtilities.cpp + ConnectionFileDescriptorTest.cpp ) Please sort this list before committing. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D62159: LLGS: support 32-bit on 64-bit hosts

labath added a comment. BTW, there's no fundamental reason why a 64-bit lldb-server has to use instruction emulation for debugging arm32 binaries. Since all arm64 chips support hardware single stepping, we could just teach the arm32 native register context to issue PTRACE_SINGLESTEP commands