[Lldb-commits] [lldb] r361459 - [Reproducer] Pass FileSpec by const-ref. (NFC)

Author: jdevlieghere Date: Wed May 22 22:45:49 2019 New Revision: 361459 URL: http://llvm.org/viewvc/llvm-project?rev=361459=rev Log: [Reproducer] Pass FileSpec by const-ref. (NFC) Fix two functions where we were passing FileSpecs by value, while we could pass by const reference. Modified:

[Lldb-commits] [PATCH] D62284: Replace integer literals which are cast to bool

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: atanasyan, javed.absar. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D62284 Files:

[Lldb-commits] [lldb] r361458 - [Utility] Modernize C-style cats

Author: jdevlieghere Date: Wed May 22 22:12:11 2019 New Revision: 361458 URL: http://llvm.org/viewvc/llvm-project?rev=361458=rev Log: [Utility] Modernize C-style cats Replaces the remaining C-style casts with explicit casts in Utility. The motivation is that they are (1) easier to spot and (2)

Re: [Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

If the remote serial protocol stub includes the GPR register values in the stop packet / jThreadsInfo packet, lldb will pre-seed the thread's RegisterContext with these values. So if the user asks for rax, lldb will already have rax for instance. debugserver doesn't send the vector/floating

Re: [Lldb-commits] [lldb] r361447 - Ack, added DWARFTypeUnit to the wrong target...

> Modified: lldb/trunk/source/Host/common/Editline.cpp > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/Editline.cpp?rev=361447=361446=361447=diff > == > ---

[Lldb-commits] [lldb] r361455 - Remove unused const version of CommandInterpreter::GetCommandHistory.

Author: jingham Date: Wed May 22 18:40:33 2019 New Revision: 361455 URL: http://llvm.org/viewvc/llvm-project?rev=361455=rev Log: Remove unused const version of CommandInterpreter::GetCommandHistory. Modified: lldb/trunk/include/lldb/Interpreter/CommandInterpreter.h Modified:

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

jasonmolenda added a comment. Does your feature print *all* the registers including floating point/vector registers? Or just the main general purpose registers? In debugserver, we expedite the register values for the stopping thread: 1558572448.355979919 < 624> read packet:

[Lldb-commits] [PATCH] D62235: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361451: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE… (authored by omjavaid, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

guiandrade added a comment. Thank you so much for the feedback! In D62221#1511035 , @clayborg wrote: > Using 'g' packets seems fine to me and we might be able to just enable it. We > will need to ensure that this doesn't regress stepping times so we

[Lldb-commits] [lldb] r361451 - [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE extensions

Author: omjavaid Date: Wed May 22 17:46:34 2019 New Revision: 361451 URL: http://llvm.org/viewvc/llvm-project?rev=361451=rev Log: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE extensions This patch updates assembler attributes for AArch64 targets so we can disassemble

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

guiandrade updated this revision to Diff 200846. guiandrade marked an inline comment as done. guiandrade edited the summary of this revision. guiandrade added a comment. Making this revision be responsible only for adding the 'g' packet handler and tests. Also, I'm starting to implement a

Re: [Lldb-commits] [lldb] r361447 - Ack, added DWARFTypeUnit to the wrong target...

I was also eliminating unused const versions of functions in that tree. It wasn't used, so I don't think it matters, but I shouldn't have done it at the same time... Jim > On May 22, 2019, at 5:24 PM, Frédéric Riss wrote: > > > >> On May 22, 2019, at 5:12 PM, Jim Ingham via lldb-commits

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 200844. kusmour added a comment. update nit Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/ https://reviews.llvm.org/D62213 Files: lldb/source/API/SystemInitializerFull.cpp

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour marked an inline comment as done. kusmour added inline comments. Comment at: lldb/source/Plugins/ABI/Windows-x86_64/ABIWindows_x86_64.cpp:1096 + if (arch_type == llvm::Triple::x86_64 +&& os_type == llvm::Triple::OSType::Win32) { +return ABISP(new

[Lldb-commits] [lldb] r361447 - Ack, added DWARFTypeUnit to the wrong target...

Author: jingham Date: Wed May 22 17:12:45 2019 New Revision: 361447 URL: http://llvm.org/viewvc/llvm-project?rev=361447=rev Log: Ack, added DWARFTypeUnit to the wrong target... LLDB -> liblldbcore.a Modified: lldb/trunk/include/lldb/Interpreter/CommandInterpreter.h

[Lldb-commits] [PATCH] D62246: DWARF: Implement DW_AT_signature lookup for type unit support

JDevlieghere added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:261 + dwarf->GetDIEToType()[die.GetDIE()] = type_sp.get(); + clang::DeclContext *decl_ctx = + GetCachedClangDeclContextForDIE(signature_die);

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1073 +bool DWARFDebugInfoEntry::AppendTypeName(const DWARFDIE die, Stream ) { + if (die) { +if (die.GetDIE()->IsNULL()) { jankratochvil wrote: >

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

JDevlieghere added a comment. ^ Feel free to address that in a follow up commit Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62211/new/ https://reviews.llvm.org/D62211 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r361444 - [lldb] Fix use-of-uninitialized-value in Driver

Author: jgorbe Date: Wed May 22 16:37:48 2019 New Revision: 361444 URL: http://llvm.org/viewvc/llvm-project?rev=361444=rev Log: [lldb] Fix use-of-uninitialized-value in Driver The driver passes by reference an uninitialized num_errors variable to RunCommandInterpreter. This should be fine, as

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:1094 + if (arch_type == llvm::Triple::x86_64 && + os_type != llvm::Triple::OSType::Win32) {

[Lldb-commits] [PATCH] D62273: Expression: correct relocation model for Windows

compnerd closed this revision. compnerd added a comment. SVN r361443 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62273/new/ https://reviews.llvm.org/D62273 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r361443 - Expression: correct relocation model for Windows

Author: compnerd Date: Wed May 22 16:23:39 2019 New Revision: 361443 URL: http://llvm.org/viewvc/llvm-project?rev=361443=rev Log: Expression: correct relocation model for Windows The Windows Code Generation model cannot generation code with the PIC relocation model - all code is implicitly

[Lldb-commits] [PATCH] D62273: Expression: correct relocation model for Windows

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I don't know much about this, but the change seems reasonable. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62273/new/

[Lldb-commits] [PATCH] D62273: Expression: correct relocation model for Windows

compnerd created this revision. compnerd added reviewers: aprantl, JDevlieghere, labath, clayborg, xiaobai, davide. Herald added a project: LLDB. The Windows CG model cannot generate code with the PIC relocation model as all code is implicitly PIC. Invert the condition and inline the single

[Lldb-commits] [lldb] r361442 - [Target] Protect Processes' language runtimes map with a mutex

Author: xiaobai Date: Wed May 22 16:01:18 2019 New Revision: 361442 URL: http://llvm.org/viewvc/llvm-project?rev=361442=rev Log: [Target] Protect Processes' language runtimes map with a mutex Summary: From what I understand, it's possible for multiple threads to request a specific language

[Lldb-commits] [lldb] r361440 - Actaully lock accesses to OptionValueFileSpecList objects

Author: friss Date: Wed May 22 14:58:52 2019 New Revision: 361440 URL: http://llvm.org/viewvc/llvm-project?rev=361440=rev Log: Actaully lock accesses to OptionValueFileSpecList objects The patch in r359029 missed a few accessors and mutators. This patch also changes the lock to a recursive one

[Lldb-commits] [lldb] r361420 - Add DWARFTypeUnit to the Xcode project.

Author: jingham Date: Wed May 22 12:05:59 2019 New Revision: 361420 URL: http://llvm.org/viewvc/llvm-project?rev=361420=rev Log: Add DWARFTypeUnit to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

aadsm updated this revision to Diff 200800. aadsm added a comment. Remove unused variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62089/new/ https://reviews.llvm.org/D62089 Files: lldb/include/lldb/Host/Socket.h

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361412: [EditLine] Rewrite GetHistoryFilePath (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D62216?vs=200603=200791#toc Repository: rLLDB LLDB

[Lldb-commits] [lldb] r361412 - [EditLine] Rewrite GetHistoryFilePath

Author: jdevlieghere Date: Wed May 22 10:46:59 2019 New Revision: 361412 URL: http://llvm.org/viewvc/llvm-project?rev=361412=rev Log: [EditLine] Rewrite GetHistoryFilePath Rewrite the GetHistoryFilePath implementation without relying on FileSpec in the spirit of our discussion in D61994. It

[Lldb-commits] [PATCH] D62246: DWARF: Implement DW_AT_signature lookup for type unit support

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just fix the return when we have a DW_AT_signature and this is good to go. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:267 +} +

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

JDevlieghere added a comment. > Also, when we say "no history", we mean "no persistent history", right? I'd > expect one would still be able to use the history of commands typed in the > current session in this scenario... Yup! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62216/new/

[Lldb-commits] [PATCH] D62246: DWARF: Implement DW_AT_signature lookup for type unit support

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:255 TypeList *type_list = dwarf->GetTypeList(); if (type_ptr == NULL) { + Not your code, but it would be easier to follow the logic if we pulled these

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

jankratochvil updated this revision to Diff 200769. jankratochvil added a comment. I have moved it to `DWARFDIE.cpp`. I agree that it is probably all irrelevant after moving to the LLVM `DWARF/` part. I have also removed return type as (1) it was wrong in one case and (2) no existing caller

[Lldb-commits] [PATCH] D61853: [FuncUnwinders] Use "symbol file" unwind plans for unwinding

labath updated this revision to Diff 200737. labath added a comment. - use (reduced) yaml form of the minidump now that yaml2obj supports memory regions - move the symbol file unwind plan to the top of the list. I agree with the reasoning behind this and with the debug_frame>eh_frame (which

[Lldb-commits] [PATCH] D62243: Added a dot at the end of comment

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361383: Added a dot at the end of comment (authored by kwk, committed by ). Herald added a subscriber: abidh.

[Lldb-commits] [lldb] r361383 - Added a dot at the end of comment

Author: kwk Date: Wed May 22 06:23:15 2019 New Revision: 361383 URL: http://llvm.org/viewvc/llvm-project?rev=361383=rev Log: Added a dot at the end of comment Summary: to test SVN commit access with a simple change. Reviewers: jankratochvil Subscribers: mgorny, lldb-commits Tags: #lldb

[Lldb-commits] [lldb] r361373 - DWARF: Add debug_ranges/rnglists tests

Author: labath Date: Wed May 22 04:44:36 2019 New Revision: 361373 URL: http://llvm.org/viewvc/llvm-project?rev=361373=rev Log: DWARF: Add debug_ranges/rnglists tests .debug_ranges parsing is not well tested [citation needed] because this section tends to be only used in optimized code, and we

[Lldb-commits] [PATCH] D62246: DWARF: Implement DW_AT_signature lookup for type unit support

labath created this revision. labath added reviewers: clayborg, JDevlieghere, aprantl. Herald added a subscriber: mgrang. Herald added a reviewer: alexshap. labath added a subscriber: jankratochvil. This patch implements the main feature of type units. When completing a type, if we encounter a

[Lldb-commits] [PATCH] D62243: Added a dot at the end of comment

jankratochvil requested changes to this revision. jankratochvil added a comment. This revision now requires changes to proceed. When committing it, there are two more comments without dot in this file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D62243: Added a dot at the end of comment

kwk created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. kwk added a reviewer: jankratochvil. to test SVN commit access with a simple change. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62243 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D62178: DWARF: Don't compute address ranges for type units

labath updated this revision to Diff 200672. labath added a comment. - rebase and modernize the code as suggested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62178/new/ https://reviews.llvm.org/D62178 Files: lit/SymbolFile/DWARF/debug-types-address-ranges.s

[Lldb-commits] [PATCH] D62061: Add AST logging

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361362: Add AST logging (authored by martong, committed by ). Herald added a subscriber: teemperor. Changed prior to commit: https://reviews.llvm.org/D62061?vs=200666=200670#toc Repository: rLLDB

[Lldb-commits] [PATCH] D62008: DWARF: Introduce DWARFTypeUnit class

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361360: DWARF: Introduce DWARFTypeUnit class (authored by labath, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] r361361 - DWARFDebugInfoEntry: remove unused variable

Author: labath Date: Wed May 22 02:09:44 2019 New Revision: 361361 URL: http://llvm.org/viewvc/llvm-project?rev=361361=rev Log: DWARFDebugInfoEntry: remove unused variable Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp Modified:

[Lldb-commits] [lldb] r361360 - DWARF: Introduce DWARFTypeUnit class

Author: labath Date: Wed May 22 02:09:39 2019 New Revision: 361360 URL: http://llvm.org/viewvc/llvm-project?rev=361360=rev Log: DWARF: Introduce DWARFTypeUnit class Summary: This patch introduces the DWARFTypeUnit class, and teaches lldb to parse type units out of both the debug_types section

[Lldb-commits] [PATCH] D62061: Add AST logging

martong updated this revision to Diff 200666. martong added a comment. - Remove superflous '.c_str()' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62061/new/ https://reviews.llvm.org/D62061 Files: lldb/include/lldb/Utility/Logging.h

[Lldb-commits] [lldb] r361358 - Delete unnecessary copy ctors

Author: maskray Date: Wed May 22 01:38:23 2019 New Revision: 361358 URL: http://llvm.org/viewvc/llvm-project?rev=361358=rev Log: Delete unnecessary copy ctors Modified: lldb/trunk/include/lldb/Core/SearchFilter.h lldb/trunk/include/lldb/Utility/FileSpec.h

[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me. In D62216#1511101 , @JDevlieghere wrote: > In D62216#1511092 , @jingham wrote: > > > Most

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

labath added a subscriber: mgorny. labath added a comment. I think it would be good to split this patch into two: - implementing `g` packet in lldb-server - deciding when lldb sends the `g` packet For the first part, I don't see any reason why lldb-server should *not* support the `g` packet.

[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/unittests/Host/SocketTest.cpp:172-178 + std::unique_ptr socket_a_up; + std::unique_ptr socket_b_up; + if (!IsAddressFamilySupported("127.0.0.1")) { +

[Lldb-commits] [PATCH] D62235: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE extensions

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: kristof.beyls, tschuett, javed.absar. Herald added a project: LLDB. This patch updates assembler attributes for AArch64 targets so we can disassemble newer instructions supported in ISA version 8.5 and

[Lldb-commits] [PATCH] D62211: Simplify `GetName`+`AppendTypeName` by `DWARFDIE`

labath added a comment. Isn't all of this dead code? These functions seem to be only called from `DWARFDebugInfoEntry::Dump`, and I can find no callers of the Dump method. If that's the case, what I'd do is delete all of this stuff, and then if we ever need to dump debug info entries again,

Re: [Lldb-commits] [lldb] r361310 - [Test] Fix conflicting test names.

On 21/05/2019 22:55, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Tue May 21 13:55:00 2019 New Revision: 361310 URL: http://llvm.org/viewvc/llvm-project?rev=361310=rev Log: [Test] Fix conflicting test names. Two tests having the same name creates a race condition when