[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2122 + size_t phdr_num_entries = *maybe_phdr_num_entries; + lldb::addr_t load_base = phdr_addr - sizeof(ELF_EHDR); +

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 203061. kusmour added a comment. Update the `GetReturnValueObjectImpl` using function `CanPassInRegisters` to explicitly check NOTE: There's NO register context info about registers beyond general purpose registers So floating point return type is not

[Lldb-commits] [PATCH] D62887: Update the thread list before setting stop reasons with an OS plugin

jingham created this revision. jingham added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When talking to a gdb-remote server that didn't support the newer thread info packets, we noticed that lldb would hit a breakpoint in target, but then

[Lldb-commits] [lldb] r362570 - Fix -Wsign-compare by explicit cast after r362557

Author: maskray Date: Tue Jun 4 18:49:06 2019 New Revision: 362570 URL: http://llvm.org/viewvc/llvm-project?rev=362570=rev Log: Fix -Wsign-compare by explicit cast after r362557 Modified: lldb/trunk/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp Modified:

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl

jingham added a comment. Pretty much the only actual effect of this patch (besides its changes to the dependency graph) are introducing the possibility for ambiguity here. It seems more logical to do it all as one patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62797/new/

[Lldb-commits] [lldb] r362557 - Call abs to avoid signed/unsigned comparison warning.

Author: jmolenda Date: Tue Jun 4 15:46:20 2019 New Revision: 362557 URL: http://llvm.org/viewvc/llvm-project?rev=362557=rev Log: Call abs to avoid signed/unsigned comparison warning. Modified: lldb/trunk/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp Modified:

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl

xiaobai added a comment. In D62797#1528483 , @jingham wrote: > I have no problem with the change in general. However, you've introduced the > possibility of name collision between convenience type definition in various > languages. So it would be good

[Lldb-commits] [PATCH] D58678: Improve step over performance by not stopping at branches that are function calls and stepping into and them out of each one

lanza added a comment. @clayborg Seems like this still steps into the `call` if the call is the last instruction in the range. `ThreadPlanStepRange::SetNextBranchBreakpoint` checks `if (last_index - pc_index > 1)` before setting the breakpoint. So if `last_index == pc_index` and `pc` points to

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

sgraenitz marked 3 inline comments as done. sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:67 +append_configuration_directories(${LLVM_TOOLS_BINARY_DIR} config_dirs) +find_program(LLVM_TABLEGEN_EXE "llvm-tblgen" ${config_dirs}

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

sgraenitz updated this revision to Diff 203030. sgraenitz added a comment. Add CMAKE_EXECUTABLE_SUFFIX when searching for llvm-tblgen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62879/new/ https://reviews.llvm.org/D62879 Files:

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

stella.stamenova added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:67 +append_configuration_directories(${LLVM_TOOLS_BINARY_DIR} config_dirs) +find_program(LLVM_TABLEGEN_EXE "llvm-tblgen" ${config_dirs} NO_DEFAULT_PATH) endif()

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBStandalone.cmake:67 +append_configuration_directories(${LLVM_TOOLS_BINARY_DIR} config_dirs) +find_program(LLVM_TABLEGEN_EXE "llvm-tblgen" ${config_dirs} NO_DEFAULT_PATH) endif() How

[Lldb-commits] [PATCH] D62878: [CMake] Export CMAKE_CONFIGURATION_TYPES for the LLVM build-tree

sgraenitz added a comment. That will be fine with post-commit review. Will submit tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62878/new/ https://reviews.llvm.org/D62878 ___ lldb-commits

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

stella.stamenova accepted this revision. stella.stamenova added inline comments. This revision is now accepted and ready to land. Comment at: lldb/lit/CMakeLists.txt:13 +# Replace the remaining CMAKE_CFG_INTDIR with ".", assuming the provided +# LLVM build-tree used a

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

sgraenitz marked an inline comment as done. sgraenitz added a comment. After figuring out D62879 that came up on the way, this wasn't too complicated indeed. I put the patch for exporting `LLVM_CONFIGURATION_TYPES` here: D62878

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

sgraenitz updated this revision to Diff 203020. sgraenitz added a comment. Patch the replacement logic also in lit/CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62859/new/ https://reviews.llvm.org/D62859 Files:

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

xiaobai accepted this revision. xiaobai added a comment. Seems fine to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62879/new/ https://reviews.llvm.org/D62879 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

sgraenitz added a comment. IIUC Clang uses the same mechanism. Moving `append_configuration_directories()` to AddLLVM.cmake could help there too. We may consider it for the future once D62859 is through. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

stella.stamenova added inline comments. Comment at: lldb/lit/CMakeLists.txt:13 +# Replace the remaining CMAKE_CFG_INTDIR with ".", assuming the provided +# LLVM build-tree used a single-configuration generator like Ninja. +string(REPLACE ${CMAKE_CFG_INTDIR} "."

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

sgraenitz updated this revision to Diff 203016. sgraenitz added a comment. Chose the replacement for remaining matches of CMAKE_CFG_INTDIR depdending on LLVM_CONFIGURATION_TYPES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62859/new/

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62879/new/ https://reviews.llvm.org/D62879

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, labath, stella.stamenova. Herald added a subscriber: mgorny. Herald added a project: LLDB. If the provided LLVM build-tree used a multi-configuration generator like Xcode, `LLVM_TOOLS_BINARY_DIR` will have a generator-specific

[Lldb-commits] [PATCH] D62878: [CMake] Export CMAKE_CONFIGURATION_TYPES for the LLVM build-tree

sgraenitz created this revision. sgraenitz added reviewers: labath, beanz, mgorny. Herald added a project: LLVM. Useful info for standalone builds of subprojects. If a multi-configuration generator was used for the provided LLVM build-tree, standalone builds should consider actual

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

This revision was automatically updated to reflect the committed changes. Closed by commit rL362544: [Target] Remove Process::GetCPPLanguageRuntime (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [lldb] r362544 - [Target] Remove Process::GetCPPLanguageRuntime

Author: xiaobai Date: Tue Jun 4 13:14:33 2019 New Revision: 362544 URL: http://llvm.org/viewvc/llvm-project?rev=362544=rev Log: [Target] Remove Process::GetCPPLanguageRuntime Summary: I want to remove this method because I think that Process should be language agnostic, or at least, not have

[Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362543: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register (authored by xiaobai, committed by ).

[Lldb-commits] [lldb] r362543 - [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

Author: xiaobai Date: Tue Jun 4 12:29:59 2019 New Revision: 362543 URL: http://llvm.org/viewvc/llvm-project?rev=362543=rev Log: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register Add a function to flatten the nested aggregate type Differential Revision:

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

sgraenitz added a comment. Thanks for your feedback. I should have mentioned that this is pretty much a draft. For now I was happy it works at all. In D62859#1529498 , @stella.stamenova wrote: > I don't think that this would apply very well to Visual

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

labath added a comment. > LLDB_PROVIDED_NINJA_BUILD_TREE=On An even better option would be to get the llvm build to export the fact whether it was built with a multi-config generator or not. Then the user wouldn't have to provide anything, and things would "just work". :) Repository: rG

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

labath marked an inline comment as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:243-251 +// With -fsplit-dwarf-inlining, clang will emit non-empty skeleton compile +// units. We are not able to access these DIE *and* the

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

labath updated this revision to Diff 202986. labath added a comment. - avoid parsing the extra DIEs in the first place CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62852/new/ https://reviews.llvm.org/D62852 Files: lit/SymbolFile/DWARF/split-dwarf-inlining.cpp

[Lldb-commits] [PATCH] D62812: [llvm] [CodeView] Move Triple::ArchType → CPUType mapping from LLDB

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeView.h:147 +return CPUType::ARM64; + default: +return CPUType::X64; compnerd wrote: > This is still wrong. `x86` and `armv7` are

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

stella.stamenova requested changes to this revision. stella.stamenova added a comment. This revision now requires changes to proceed. I don't think that this would apply very well to Visual Studio with the current change because it is likely that if you are using VS to build LLDB, you also used

[Lldb-commits] [lldb] r362510 - [lldb] Fix out-of-bounds read after c3ea7c66fec021867e005ad1b02f3c7e80feaa85

Author: jyknight Date: Tue Jun 4 08:27:19 2019 New Revision: 362510 URL: http://llvm.org/viewvc/llvm-project?rev=362510=rev Log: [lldb] Fix out-of-bounds read after c3ea7c66fec021867e005ad1b02f3c7e80feaa85 "Add support for mid-function epilogues on x86 that end in a non-local jump." Detected by

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, jingham, xiaobai, stella.stamenova. Herald added a subscriber: mgorny. Herald added a project: LLDB. Allow to run the test suite when building LLDB Standalone with Xcode against a provided LLVM build-tree that used a

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:243-251 +// With -fsplit-dwarf-inlining, clang will emit non-empty skeleton compile +// units. We are not able to access these DIE *and* the dwo file +// simultaneously. We also

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

aadsm marked 3 inline comments as done. aadsm added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteLibrariesSvr4Support.py:51-52 + +OFFSET = 0 +LENGTH = 0x + labath wrote: > Why are these all

Re: [Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

On Tue, Jun 4, 2019 at 4:15 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > In D62634#1527575 , @dblaikie > wrote: > > > > 1. We need to figure out whether there's a bug in clang and fix it. + > @dblaikie

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

aadsm marked 2 inline comments as done. aadsm added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2136 +sizeof(phdr_entry), bytes_read); +if (!error.Success()) + return LLDB_INVALID_ADDRESS;

[Lldb-commits] [lldb] r362500 - [CMake] Move and add settings to Apple-lldb-base cache script

Author: stefan.graenitz Date: Tue Jun 4 07:21:48 2019 New Revision: 362500 URL: http://llvm.org/viewvc/llvm-project?rev=362500=rev Log: [CMake] Move and add settings to Apple-lldb-base cache script Modified: lldb/trunk/cmake/caches/Apple-lldb-base.cmake

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:243-251 +// With -fsplit-dwarf-inlining, clang will emit non-empty skeleton compile +// units. We are not able to access these DIE *and* the dwo file +// simultaneously. We also

[Lldb-commits] [PATCH] D62852: Ignore DIEs in the skeleton unit in a DWO scenario

labath created this revision. labath added reviewers: clayborg, JDevlieghere, aprantl. r362103 exposed a bug, where we could read incorrect data if a skeleton unit contained more than the single unit DIE. Clang emits these kinds of units with -fsplit-dwarf-inlining (which is also the default).

[Lldb-commits] [PATCH] D62634: Improve DWARF parsing and accessing by 1% to 2%

labath added a comment. In D62634#1527575 , @dblaikie wrote: > > 1. We need to figure out whether there's a bug in clang and fix it. + > > @dblaikie for help with that > > This is intentional behavior in clang (controllable under the >

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

labath added a comment. In D62755#1527679 , @xiaobai wrote: > > So, what I'd do (and what I have been doing so far, but mainly as a > > passtime effort) was to cut the dependencies way lower that this. Ideally, > > I wouldn't want to include anything

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

labath added a comment. In D62502#1528382 , @aadsm wrote: > @labath > > > Regarding the test, I am wondering whether requiring the /proc/%d/maps and > > the linker rendezvous structure to match isn't too strict of a requirement. > > Dynamic linkers (and

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

labath added subscribers: mgorny, krytarowski. labath added a comment. +@mgorny, @krytarowski in case they know anything interesting about dynamic linkers. NativeProcessProtocol is certainly too generic for this sort of thing, but perhaps it would make sense to put this in a slightly more

[Lldb-commits] [PATCH] D62499: Create a generic handler for Xfer packets

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me now. Thanks for your patience. Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationServerTest.cpp:1-2 +//===--

[Lldb-commits] [PATCH] D62755: [Target] Remove Process::GetCPPLanguageRuntime

labath accepted this revision. labath added inline comments. Comment at: include/lldb/Target/CPPLanguageRuntime.h:47 + static CPPLanguageRuntime *GetCPPLanguageRuntime(Process ) { +return static_cast( +process.GetLanguageRuntime(lldb::eLanguageTypeC_plus_plus));