[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/SymbolFile/DWARF/DIERef.h:30 - DIERef(Section s, llvm::Optional u, dw_offset_t d) - : m_section(s),

[Lldb-commits] [PATCH] D63357: [Process] Remove unused field from HistoryThread

This revision was automatically updated to reflect the committed changes. Closed by commit rL363881: [Process] Remove unused field from HistoryThread (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [lldb] r363881 - [Process] Remove unused field from HistoryThread

Author: xiaobai Date: Wed Jun 19 14:33:44 2019 New Revision: 363881 URL: http://llvm.org/viewvc/llvm-project?rev=363881=rev Log: [Process] Remove unused field from HistoryThread Summary: These fields are unused and have been since their inception, from what I can tell. Reviewers: compnerd,

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

clayborg added a comment. my fix assumes we would have zero sized symbols first in the m_file_addr_to_index map, and the symbols with the same size would be ordered after the ones with zero size. Also, I am assuming when we do: const FileRangeToIndexMap::Entry *entry =

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

clayborg added a comment. So I am fine with symbols having zero size being in the symbol table. I would be fine not changing anything in the sorting and leaving some symbols with zero size, we just need to fix: Symbol *Symtab::FindSymbolAtFileAddress(addr_t file_addr); To ignore zero sized

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

tatyana-krasnukha updated this revision to Diff 205648. tatyana-krasnukha retitled this revision from "Add a worlaround for unsupported cmake feature" to "Use object library if cmake supports it". tatyana-krasnukha added a comment. As I figured out, cmake allows to use $ anywhere since version

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

kusmour updated this revision to Diff 205640. kusmour added a comment. allow SysV_x86_64 ABI to handle unknown OS type this should fix the test `SymbolFile/DWARF/debug_loc.s` Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62213/new/

[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

hintonda added inline comments. Comment at: lldb/trunk/unittests/tools/lldb-mi/utils/CMakeLists.txt:12 + +target_sources(LLDBMiUtilTests PRIVATE $) tatyana-krasnukha wrote: > hintonda wrote: > > Just wanted to let you know that using `$` in anything > > other

[Lldb-commits] [lldb] r363827 - [lldb] [Process/NetBSD] Fix constructor after r363707

Author: mgorny Date: Wed Jun 19 08:49:47 2019 New Revision: 363827 URL: http://llvm.org/viewvc/llvm-project?rev=363827=rev Log: [lldb] [Process/NetBSD] Fix constructor after r363707 Modified: lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp Modified:

[Lldb-commits] [PATCH] D63554: [lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rL363823: [lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64 (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [lldb] r363823 - [lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64

Author: mgorny Date: Wed Jun 19 08:35:01 2019 New Revision: 363823 URL: http://llvm.org/viewvc/llvm-project?rev=363823=rev Log: [lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64 Remove the checks for FPU presence, FXSAVE support and usage from the code for x86_64. Those

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

This revision was automatically updated to reflect the committed changes. Closed by commit rL363821: Specify log level for CMake messages (less stderr) (authored by stefan.graenitz, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[Lldb-commits] [lldb] r363821 - Specify log level for CMake messages (less stderr)

Author: stefan.graenitz Date: Wed Jun 19 08:25:32 2019 New Revision: 363821 URL: http://llvm.org/viewvc/llvm-project?rev=363821=rev Log: Specify log level for CMake messages (less stderr) Summary: Specify message levels in CMake. Prefer STATUS (stdout). As the default message mode (i.e. level)

[Lldb-commits] [PATCH] D63544: Add a worlaround for unsupported cmake feature

hintonda added a comment. I just reviewed all the release notes, and while 3.9 relaxed the usage of TARGET_OBJECTS, cmake doesn't explicitly mention allowing them in `target_link_libraries` until release 3.15. I don't have any of those versions, but it looks like 3.15 is probably the version

[Lldb-commits] [PATCH] D63544: Add a worlaround for unsupported cmake feature

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. Otherwise, LGTM, thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63544/new/ https://reviews.llvm.org/D63544

[Lldb-commits] [PATCH] D63544: Add a worlaround for unsupported cmake feature

hintonda added inline comments. Comment at: tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt:16 +else() + target_sources(LLDBMiUtilTests PRIVATE $) +endif() I'm assuming from your comment, that this is a performance issue. If so, could you add a

[Lldb-commits] [PATCH] D63554: [lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64

mgorny created this revision. mgorny added reviewers: krytarowski, labath, JDevlieghere. Remove the checks for FPU presence, FXSAVE support and usage from the code for x86_64. Those are always true for this architecture, and in fact are hardcoded to true inside NetBSD kernel.

[Lldb-commits] [PATCH] D63544: Add a worlaround for unsupported cmake feature

tatyana-krasnukha added a comment. It will cause some time overhead for linking a library. Linking is already formidable for the project and I'd avoid it when possible. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63544/new/ https://reviews.llvm.org/D63544

[Lldb-commits] [PATCH] D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE [DO NOT MERGE]

mgorny created this revision. mgorny added reviewers: krytarowski, labath, JDevlieghere. Herald added a subscriber: emaste. Provide a (conditional) support for the new PT_GETXSTATE and PT_SETXSTATE ptrace() requests, and use them to implement getting and setting YMM registers. The functions used

[Lldb-commits] [PATCH] D63544: Add a worlaround for unsupported cmake feature

labath added a comment. why not just change `lldb-mi-utils` into a conventional (STATIC) library, at which point it can just be linked in using regular `target_link_libraries`, which has worked since forever? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

tatyana-krasnukha added inline comments. Comment at: lldb/trunk/unittests/tools/lldb-mi/utils/CMakeLists.txt:12 + +target_sources(LLDBMiUtilTests PRIVATE $) hintonda wrote: > Just wanted to let you know that using `$` in anything > other than `add_library` and

[Lldb-commits] [PATCH] D63544: Add a worlaround for unsupported cmake feature

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: hintonda. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, mgorny, ki.stfu. Using $ in anything other than add_library and add_executable was not supported until cmake 3.9. The issue was

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

labath added a comment. The fix seems reasonable to me. There's just one thing I don't get: Why was it necessary to change the iteration order here? IIUC, the real business happens on line 904, where you add the `if (entry[i].base == entry[i+1].base) break;` check. I could be missing something,

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath. jankratochvil added a project: LLDB. Herald added subscribers: teemperor, aprantl. This fixes a failing testcase on Fedora 30 x86_64 (regression Fedora 29->30): PASS: ./bin/lldb

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

jankratochvil added a comment. Even after @labath's rL363772 the testcase `TestGdbRemoteLibrariesSvr4Support` is still FAILing on Fedora 30 x86_64, I will check it more later. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

jankratochvil added a comment. There is a regression on Fedora 30 x86_64: Failing Tests (25): LLDB :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test lldb-Suite :: expression_command/call-function/TestCallStdStringFunction.py lldb-Suite ::

[Lldb-commits] [PATCH] D63467: [Reproducers] Make reproducer relocatable

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/trunk/source/Utility/FileCollector.cpp:137 - const std::string root = m_root.GetPath(); + llvm::StringRef root = m_overlay_root.GetPath(); + Regression

[Lldb-commits] [PATCH] D63428: DWARF: Add "dwo_num" field to the DIERef class

labath updated this revision to Diff 205527. labath added a comment. Remove the cu_offset field from DIERef, bringing the total size back down to "8", as dicussed here, and on D63491 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63428/new/

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

labath added a comment. As I kind of expected, one of these tests was flaky because the names for the vdso pseudo-module were not adding up. When reading from /proc/%pid/maps, we got "[vdso]" (as that's how the kernel likes to call this page), but while reading the linker rendezvous structure,

[Lldb-commits] [lldb] r363772 - Stabilize TestGdbRemoteLibrariesSvr4Support

Author: labath Date: Wed Jun 19 01:41:13 2019 New Revision: 363772 URL: http://llvm.org/viewvc/llvm-project?rev=363772=rev Log: Stabilize TestGdbRemoteLibrariesSvr4Support on some systems this test fails because the two methods it uses to cross-reference the data don't match in the case of the

[Lldb-commits] [lldb] r363770 - Fix a dangling StringRef in FileCollector

Author: labath Date: Wed Jun 19 01:09:56 2019 New Revision: 363770 URL: http://llvm.org/viewvc/llvm-project?rev=363770=rev Log: Fix a dangling StringRef in FileCollector FileSpec::GetPath returns a temporary std::string. Modified: lldb/trunk/source/Utility/FileCollector.cpp Modified:

[Lldb-commits] [PATCH] D63399: DWARF: Make DIERefs always valid

This revision was automatically updated to reflect the committed changes. Closed by commit rL363767: DWARF: Make DIERefs always valid (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r363767 - DWARF: Make DIERefs always valid

Author: labath Date: Wed Jun 19 00:32:39 2019 New Revision: 363767 URL: http://llvm.org/viewvc/llvm-project?rev=363767=rev Log: DWARF: Make DIERefs always valid Summary: This patch makes the DIERef class always valid by default constructor and operator bool. This allows one to express the

Re: [Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

On 19/06/2019 01:05, Jim Ingham wrote: On Jun 7, 2019, at 2:47 AM, Pavel Labath via Phabricator via lldb-commits wrote: labath planned changes to this revision. labath added a comment. It looks like this problem is more widespread than we originally thought (a bunch of other tests are

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

labath added a comment. In D63363#1549500 , @jingham wrote: > In D63363#1545427 , @labath wrote: > > > Although this is technically correct and pretty consistent with our other > > "plugins", I can't help but feel

[Lldb-commits] [PATCH] D63530: [swig] Define attribute(ref) instead of accessing swig internals.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I'm not terribly familiar with this, but it definitely looks like a more idiomatic way to do these things. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63530/new/

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

labath added a comment. In D62213#1549190 , @kusmour wrote: > > Maybe we should make the SysV abi plugin match unknown oss too... > > I'm not sure this is the right thing to do, but this should fix the problem. It would at least preserve status quo. Not