[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D64118#1568656 , @xiaobai wrote: > This patch looks fine to me overall. I'm unsure if LLDB has a guarantee about > which NDK version its compatible

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/dollar-in-variable/main.c:4-5 +int main() { + int $foo = 42; + return 0; //%self.expect("expr $foo", substrs=['(int) $0 = 42']) +}

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

rocallahan added a comment. Sorry for not responding earlier. Phabricator insists on sending me emails about all issues in the system, and I never figured out how to get GMail to show me only emails about Phabricator issues I'm CCed on. > I know little about Rust crates but I worry some

Re: [Lldb-commits] [lldb] r364669 - [GDBRemote] Remove code that flushes GDB remote packets

On Fri, 28 Jun 2019 at 14:14, Jonas Devlieghere via lldb-commits wrote: > > Author: jdevlieghere > Date: Fri Jun 28 11:14:27 2019 > New Revision: 364669 > > URL: http://llvm.org/viewvc/llvm-project?rev=364669=rev > Log: > [GDBRemote] Remove code that flushes GDB remote packets > > The arbitrary

[Lldb-commits] [PATCH] D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL365157: Add assert for bad code path in GetUniqueNamespaceDeclaration (authored by teemperor, committed by ). Herald

[Lldb-commits] [PATCH] D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration

teemperor updated this revision to Diff 208073. teemperor added a comment. - rebase patch to monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57880/new/ https://reviews.llvm.org/D57880 Files: lldb/source/Symbol/ClangASTContext.cpp Index:

[Lldb-commits] [lldb] r365157 - Add assert for 'bad' code path in GetUniqueNamespaceDeclaration

Author: teemperor Date: Thu Jul 4 12:49:31 2019 New Revision: 365157 URL: http://llvm.org/viewvc/llvm-project?rev=365157=rev Log: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration Summary: If we call this function with a non-namespace as a second argument (and a nullptr name), we

[Lldb-commits] [lldb] r365155 - Plugins: permit building on Windows ARM64

Author: compnerd Date: Thu Jul 4 12:26:49 2019 New Revision: 365155 URL: http://llvm.org/viewvc/llvm-project?rev=365155=rev Log: Plugins: permit building on Windows ARM64 Rather than relying on `sizeof(void *)` to determine the architecture, use the `CMAKE_SYSTEM_PROCESSOR` variable. This

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/dollar-in-variable/main.c:4-5 +int main() { + int $foo = 42; + return 0; //%self.expect("expr $foo", substrs=['(int) $0 = 42']) +} davide wrote: > what if you

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

davide requested changes to this revision. davide added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/dollar-in-variable/main.c:4-5 +int main() { + int $foo = 42; + return 0;

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

teemperor added a comment. I realized after revisiting this code that this can't handle Unicode and we probably should just use Clang's Lexer to get the tokens. Still, it would be nice if we can land this in case the Lexer rewrite takes longer than expected. Repository: rLLDB LLDB CHANGES

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to dollar character in variable names.

teemperor created this revision. teemperor added reviewers: jingham, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It's possible to have a dollar character in an identifier with Clang. We use that in LLDB to namespace our own variables, but apparently this