[Lldb-commits] [lldb] r366983 - cli-wrapper-mpxtable.cpp: fix file header

Author: maskray Date: Wed Jul 24 22:15:50 2019 New Revision: 366983 URL: http://llvm.org/viewvc/llvm-project?rev=366983=rev Log: cli-wrapper-mpxtable.cpp: fix file header Modified: lldb/trunk/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp Modified:

[Lldb-commits] [lldb] r366982 - [TableGen] Fix comments/headers referencing clang (NFC)

Author: jdevlieghere Date: Wed Jul 24 21:38:46 2019 New Revision: 366982 URL: http://llvm.org/viewvc/llvm-project?rev=366982=rev Log: [TableGen] Fix comments/headers referencing clang (NFC) Remove references to clang's TableGen implementation. Presumably these files were originally copied over.

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

aadsm updated this revision to Diff 211661. aadsm added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64013/new/ https://reviews.llvm.org/D64013 Files: lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D65207: LLGS: fix tracking execve on linux

jasonmolenda accepted this revision. jasonmolenda added a comment. LGTM. I don't think the use of the posix_spawn API are important for the test case to exercise. If posix_spawn had a problem on darwin systems, lldb/debugserver's process launching would turn it up pretty quick. CHANGES

[Lldb-commits] [lldb] r366975 - [FileCollector] Remove LLDB shim around llvm::FileCollector (NFC)

Author: jdevlieghere Date: Wed Jul 24 18:08:10 2019 New Revision: 366975 URL: http://llvm.org/viewvc/llvm-project?rev=366975=rev Log: [FileCollector] Remove LLDB shim around llvm::FileCollector (NFC) The FileCollector got lifted into LLVM and a shim was introduced in LLDB to keep the old API

[Lldb-commits] [lldb] r366974 - [FileSystem] Fix ambiguous symbol on Windows.

Author: jdevlieghere Date: Wed Jul 24 17:56:31 2019 New Revision: 366974 URL: http://llvm.org/viewvc/llvm-project?rev=366974=rev Log: [FileSystem] Fix ambiguous symbol on Windows. The using declarations make FileCollector ambiguous. Specify that FileSystem takes an lldb_private::FileCollector.

[Lldb-commits] [lldb] r366966 - [FileCollector] Change coding style from LLDB to LLVM (NFC)

Author: jdevlieghere Date: Wed Jul 24 17:17:39 2019 New Revision: 366966 URL: http://llvm.org/viewvc/llvm-project?rev=366966=rev Log: [FileCollector] Change coding style from LLDB to LLVM (NFC) This patch changes the coding style of the FileCollector from the LLDB to the LLVM coding style. Alex

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb created this revision. jfb added a reviewer: chandlerc. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, dexonsmith, jkorous, hiraditya, javed.absar. Herald added projects: clang, LLDB, LLVM. jfb added a comment. This is the main event:

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a comment. This is the main event: https://reviews.llvm.org/D65249#change-IWk6CtRl45h6 The rest is side-show. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249

[Lldb-commits] [PATCH] D65237: [Support] move FileCollector from LLDB to llvm/Support

This revision was automatically updated to reflect the committed changes. Closed by commit rL366956: [Support] move FileCollector from LLDB to llvm/Support (authored by arphaman, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

[Lldb-commits] [PATCH] D64917: Add offsetof support to expression evaluator.

shafik added a comment. Thanks for fixing this one! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64917/new/ https://reviews.llvm.org/D64917 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] r366879 - [lldb] Remove Xcode project legacy

How are we updating the sources in LLDB.framework these days? Using cmake? When making the LLDB.framework, we must fix up the header includes in any header files that are copies over into LLDB.framework from: #include "lldb/API/SB*" to a framework like include: #inclue I am mentioning this

[Lldb-commits] [PATCH] D65171: [LLDB] Find debugserver in Command Line Tools as well

clayborg accepted this revision. clayborg added a comment. Find with me as long as we default to using the installed Xcode, and then check for the command line tools if that fails. Many people keep Xcode up to date, but might not always update the installed command line tools. Repository:

[Lldb-commits] [PATCH] D65207: LLGS: fix tracking execve on linux

clayborg added a comment. Is this not going to be racy on other platforms? Or do all platforms stop at entry point once a program has been exec'ed? I am worried we might miss the breakpoint. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65207/new/ https://reviews.llvm.org/D65207

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

This revision was automatically updated to reflect the committed changes. Closed by commit rL366950: [Symbol] Fix some botched logic in Variable::GetLanguage (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

xiaobai updated this revision to Diff 211607. xiaobai added a comment. Implement suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65165/new/ https://reviews.llvm.org/D65165 Files: source/Symbol/Variable.cpp Index: source/Symbol/Variable.cpp

[Lldb-commits] [lldb] r366950 - [Symbol] Fix some botched logic in Variable::GetLanguage

Author: xiaobai Date: Wed Jul 24 15:12:02 2019 New Revision: 366950 URL: http://llvm.org/viewvc/llvm-project?rev=366950=rev Log: [Symbol] Fix some botched logic in Variable::GetLanguage Summary: I messed up the logic for this. Fixing with some improvements suggested by Pavel. Reviewers: labath,

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

JDevlieghere updated this revision to Diff 211606. JDevlieghere added a comment. Use lowercase variables for locals. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65230/new/ https://reviews.llvm.org/D65230 Files: lldb/cmake/modules/LLDBConfig.cmake Index:

[Lldb-commits] [PATCH] D65237: [Support] move FileCollector from LLDB to llvm/Support

arphaman updated this revision to Diff 211603. arphaman added a comment. Use `private` as suggested by Jan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65237/new/ https://reviews.llvm.org/D65237 Files: lldb/include/lldb/Utility/FileCollector.h lldb/source/Utility/CMakeLists.txt

[Lldb-commits] [PATCH] D65237: [Support] move FileCollector from LLDB to llvm/Support

jkorous added inline comments. Comment at: llvm/include/llvm/Support/FileCollector.h:40 + +protected: + void AddFileImpl(StringRef src_path); TLDR: private? I'm just wondering if we could make the class safer or the correct use more obvious for classes

[Lldb-commits] [PATCH] D65237: [Support] move FileCollector from LLDB to llvm/Support

arphaman updated this revision to Diff 211591. arphaman added a comment. Herald added a subscriber: ormris. Small bug fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65237/new/ https://reviews.llvm.org/D65237 Files:

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

sgraenitz added a comment. Interesting way to get from version to list! :) Cosmetics: It looks like `PYTHON_VERSION_STRING` and `PYTHONLIBS_VERSION_STRING` are global and all others are local variables? Using lowercase names for locals makes it easier to see. As names are case-sensitive, it

[Lldb-commits] [PATCH] D65237: [Support] move FileCollector from LLDB to llvm/Support

arphaman created this revision. arphaman added a reviewer: JDevlieghere. Herald added subscribers: dexonsmith, jkorous, hiraditya, mgorny. Herald added projects: LLDB, LLVM. The file collector class is useful for creating reproducers, not just for LLDB, but for other tools. That's why it should

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with Pavel's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65165/new/ https://reviews.llvm.org/D65165 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D65128: [Logging] Replace Log::Printf with LLDB_LOG macro (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL366936: [Logging] Replace Log::Printf with LLDB_LOG macro (NFC) (authored by JDevlieghere, committed by ). Herald added subscribers: llvm-commits, jrtc27. Herald added a project: LLVM. Changed prior to

[Lldb-commits] [lldb] r366936 - [Logging] Replace Log::Printf with LLDB_LOG macro (NFC)

Modified: lldb/trunk/source/Target/Thread.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Thread.cpp?rev=366936=366935=366936=diff == --- lldb/trunk/source/Target/Thread.cpp (original) +++

[Lldb-commits] [PATCH] D65208: SymbolVendor: Move Symtab construction into the SymbolFile

clayborg added a comment. So the original idea behind the symbol vendor was that if you have more than one binary: stripped installed binary, and unstripped debug info binary with symbols, that the symbol table could be generated by using one or more object files. It would be nice to ensure we

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

JDevlieghere created this revision. JDevlieghere added reviewers: shafik, arphaman, sgraenitz, davide. JDevlieghere added a project: LLDB. Herald added subscribers: dexonsmith, mgorny. Some versions of macOS report a different patch version for the system provided interpreter and libraries.

[Lldb-commits] [lldb] r366932 - [lldb] Configure debugserver_vers.c from CMake

Author: stefan.graenitz Date: Wed Jul 24 10:28:24 2019 New Revision: 366932 URL: http://llvm.org/viewvc/llvm-project?rev=366932=rev Log: [lldb] Configure debugserver_vers.c from CMake Added: lldb/trunk/tools/debugserver/source/debugserver_vers.c.in Modified:

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

jingham added a comment. In D65109#1598695 , @sgraenitz wrote: > > We discussed this and came to an agreement only a few hours before in the > > team meeting > > After all, LLVM is open-source and has a community. Making preemptive > decisions in

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

jingham added a comment. In D65165#1598553 , @labath wrote: > Thanks for responding quickly. LGTM, with one comment.. Don't use checks that assume eLanguageTypeUnknown == 0, that seems really confusing and we don't use that practice anywhere else.

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

JDevlieghere added a comment. In D65185#1599262 , @labath wrote: > .def files can omit fields too: `#define BOOL_PROPERTY(name, global, default, > desc) PROPERTY(name, OptionValue::eTypeBoolean, global, default, nullptr, {}, > desc)`. Some sanity

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

JDevlieghere updated this revision to Diff 211528. JDevlieghere added a comment. Have separate tablegen files for plugins. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65185/new/ https://reviews.llvm.org/D65185 Files: lldb/CMakeLists.txt lldb/include/lldb/Core/CMakeLists.txt

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

labath added a comment. In D65185#1599215 , @JDevlieghere wrote: > In D65185#1598586 , @labath wrote: > > > My dream is to one day be able to define a property by simply declaring a > > variable somewhere (say:

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL366912: [AIX][lit] Dont depend on psutil on AIX (authored by daltenty, committed by ). Changed prior to commit:

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

JDevlieghere added a comment. In D65185#1598586 , @labath wrote: > My dream is to one day be able to define a property by simply declaring a > variable somewhere (say: `Property Foo(ParentProperty, "foo", "description > of foo", DefaultValue);`), and

[Lldb-commits] [PATCH] D65208: SymbolVendor: Move Symtab construction into the SymbolFile

labath created this revision. labath added reviewers: clayborg, JDevlieghere, jingham. Herald added subscribers: MaskRay, arichardson, mgorny, emaste. Herald added a reviewer: espindola. labath added a parent revision: D65135: SymbolVendor: Remove the type list member. Instead of having

[Lldb-commits] [PATCH] D65207: LLGS: fix tracking execve on linux

labath created this revision. labath added reviewers: clayborg, jasonmolenda. Due to a logic error, lldb-server ended up asserting/crashing every time the debugged process attempted an execve(). This fixes the error, and extends TestExec to work on other platforms too. The "extension" consists of

[Lldb-commits] [lldb] r366903 - Fix @skipIfSanitized decorator

Author: labath Date: Wed Jul 24 06:05:56 2019 New Revision: 366903 URL: http://llvm.org/viewvc/llvm-project?rev=366903=rev Log: Fix @skipIfSanitized decorator To run the test the decorator function should return None, not False. Returning anything other than None skips the test. Modified:

[Lldb-commits] [lldb] r366892 - [lldb] Fix build errors from tablegenify platform commit

Author: teemperor Date: Wed Jul 24 05:08:08 2019 New Revision: 366892 URL: http://llvm.org/viewvc/llvm-project?rev=366892=rev Log: [lldb] Fix build errors from tablegenify platform commit Forgot to stage some changes... Modified: lldb/trunk/source/Commands/CommandObjectPlatform.cpp

[Lldb-commits] [lldb] r366891 - [lldb][NFC] Tablegenify platform

Author: teemperor Date: Wed Jul 24 05:05:42 2019 New Revision: 366891 URL: http://llvm.org/viewvc/llvm-project?rev=366891=rev Log: [lldb][NFC] Tablegenify platform Modified: lldb/trunk/source/Commands/CommandObjectPlatform.cpp lldb/trunk/source/Commands/Options.td Modified:

[Lldb-commits] [lldb] r366889 - Revert "Revert "[lldb] [Process/NetBSD] Fix constructor after r363707""

Author: mgorny Date: Wed Jul 24 04:44:43 2019 New Revision: 366889 URL: http://llvm.org/viewvc/llvm-project?rev=366889=rev Log: Revert "Revert "[lldb] [Process/NetBSD] Fix constructor after r363707"" The relevant changes have been reapplied, and broke build again. Modified:

[Lldb-commits] [PATCH] D65109: [LLDB] Remove the Xcode project

sgraenitz added a comment. > We discussed this and came to an agreement only a few hours before in the > team meeting After all, LLVM is open-source and has a community. Making preemptive decisions in internal team meetings sounds concerning. > As far as we know, Greg was the only user of the

[Lldb-commits] [PATCH] D65155: [lldb] Remove Xcode project legacy

This revision was automatically updated to reflect the committed changes. Closed by commit rL366879: [lldb] Remove Xcode project legacy (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r366879 - [lldb] Remove Xcode project legacy

Author: stefan.graenitz Date: Wed Jul 24 02:20:14 2019 New Revision: 366879 URL: http://llvm.org/viewvc/llvm-project?rev=366879=rev Log: [lldb] Remove Xcode project legacy Summary: Since D65109 removed the manually maintained Xcode project, there's a few things we don't need anymore. Anything

[Lldb-commits] [PATCH] D65128: [Logging] Replace Log::Printf with LLDB_LOG macro (NFC)

labath accepted this revision. labath added a comment. I'm fine with this if Jim is. Comment at: lldb/source/Expression/IRExecutionUnit.cpp:601 if (log) { +LLDB_LOGF(log, looks like there are some `if(log)`s still remaining. Maybe the `{}` around the

[Lldb-commits] [PATCH] D65152: Fix issues with inferior stdout coming out of order

labath updated this revision to Diff 211439. labath added a comment. Thanks for the feedback. Updating the patch to avoid calling the flush function twice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65152/new/ https://reviews.llvm.org/D65152 Files: include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

labath added a subscriber: aprantl. labath added a comment. My dream is to one day be able to define a property by simply declaring a variable somewhere (say: `Property Foo(ParentProperty, "foo", "description of foo", DefaultValue);`), and that one could just get/set them via something like

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for responding quickly. LGTM, with one comment.. Comment at: source/Symbol/Variable.cpp:62 if (auto *func = m_owner_scope->CalculateSymbolContextFunction()) { -

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

labath added inline comments. Comment at: source/Core/ValueObjectRegister.cpp:261 + if (auto *exe_module = target->GetExecutableModulePointer()) { +if (auto type_system_or_err = +exe_module->GetTypeSystemForLanguage(eLanguageTypeC)) {

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

labath added a comment. sgtm Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62503/new/ https://reviews.llvm.org/D62503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org