[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

JDevlieghere added a comment. In D65122#1602025 , @xiaobai wrote: > After going through this and modifying this patch, I can't help but wonder if > `llvm::Optional` would be more appropriate. There are plenty of > instances where it's not a hard error

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added a comment. After going through this and modifying this patch, I can't help but wonder if `llvm::Optional` would be more appropriate. There are plenty of instances where it's not a hard error if you can't get a TypeSystem and the appropriate action is probably just to log and move

[Lldb-commits] [lldb] r367079 - [dotest] Remove dead code

Author: jdevlieghere Date: Thu Jul 25 18:58:18 2019 New Revision: 367079 URL: http://llvm.org/viewvc/llvm-project?rev=367079=rev Log: [dotest] Remove dead code Remove some dead code that I ran into when preparing D65311. Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py

[Lldb-commits] [PATCH] D65311: [dotest] Remove multiprocessing

JDevlieghere updated this revision to Diff 211862. JDevlieghere added a comment. Herald added a subscriber: mgorny. Remove more options and external references. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65311/new/ https://reviews.llvm.org/D65311 Files:

[Lldb-commits] [lldb] r367077 - [Tests] Split inferior crashing tests

Author: jdevlieghere Date: Thu Jul 25 18:00:40 2019 New Revision: 367077 URL: http://llvm.org/viewvc/llvm-project?rev=367077=rev Log: [Tests] Split inferior crashing tests We noticed that TestInferiorCrashing.py and TestRecursiveInferior.py are the second and third slowest tests in the test

[Lldb-commits] [PATCH] D65311: [dotest] Remove multiprocessing

JDevlieghere updated this revision to Diff 211861. JDevlieghere added a comment. Add context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65311/new/ https://reviews.llvm.org/D65311 Files: lldb/packages/Python/lldbsuite/test/configuration.py

[Lldb-commits] [PATCH] D65311: [dotest] Remove multiprocessing

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. JDevlieghere updated this revision to Diff 211861. JDevlieghere added a comment. Add context Now that the Xcode project is removed, I want to focus on

[Lldb-commits] [lldb] r367066 - [Docs] Remove reproducers from the project page.

Author: jdevlieghere Date: Thu Jul 25 15:22:43 2019 New Revision: 367066 URL: http://llvm.org/viewvc/llvm-project?rev=367066=rev Log: [Docs] Remove reproducers from the project page. Jim pointed out that this was still open on the website. Modified: lldb/trunk/docs/status/projects.rst

[Lldb-commits] [lldb] r367065 - [Tablegen] Fix issues caused by incorrect escaping.

Author: jdevlieghere Date: Thu Jul 25 15:17:08 2019 New Revision: 367065 URL: http://llvm.org/viewvc/llvm-project?rev=367065=rev Log: [Tablegen] Fix issues caused by incorrect escaping. The printEscapedString would escape newlines by their ASCII values instead of prefixing them with a `\`.

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

clayborg added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1874-1875 -ConstString Name(("PT_LOAD[" + llvm::Twine(LoadID++) + "]").str()); +ConstString Name(llvm::formatv("{0}[{1}]", provider.GetSegmentName(), +

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil marked an inline comment as done. jankratochvil added a comment. In D65271#1600829 , @labath wrote: > Why not unify now? It shouldn't be too hard to at least unify all the > instances in dotest python code to a single place. That would

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil updated this revision to Diff 211825. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65271/new/ https://reviews.llvm.org/D65271 Files: lldb/lit/lit-lldb-init.in lldb/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rL367058: Let tablegen generate property definitions (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r367059 - Mention adding predicates to settings in the projects page.

Author: jingham Date: Thu Jul 25 14:37:57 2019 New Revision: 367059 URL: http://llvm.org/viewvc/llvm-project?rev=367059=rev Log: Mention adding predicates to settings in the projects page. Modified: lldb/trunk/docs/status/projects.rst Modified: lldb/trunk/docs/status/projects.rst URL:

[Lldb-commits] [lldb] r367058 - Let tablegen generate property definitions

Author: jdevlieghere Date: Thu Jul 25 14:36:37 2019 New Revision: 367058 URL: http://llvm.org/viewvc/llvm-project?rev=367058=rev Log: Let tablegen generate property definitions Property definitions are currently defined in a PropertyDefinition array and have a corresponding enum to index in this

[Lldb-commits] [lldb] r367057 - Remove a project that was completed.

Author: jingham Date: Thu Jul 25 14:29:29 2019 New Revision: 367057 URL: http://llvm.org/viewvc/llvm-project?rev=367057=rev Log: Remove a project that was completed. Modified: lldb/trunk/docs/status/projects.rst Modified: lldb/trunk/docs/status/projects.rst URL:

[Lldb-commits] [PATCH] D65171: [LLDB] Find debugserver in Command Line Tools as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL367052: [LLDB] Find debugserver in Command Line Tools as well (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r367054 - [dotest] Set environment variables after potentialy clearing others.

Author: jdevlieghere Date: Thu Jul 25 13:54:41 2019 New Revision: 367054 URL: http://llvm.org/viewvc/llvm-project?rev=367054=rev Log: [dotest] Set environment variables after potentialy clearing others. Dotest contains code to clear DYLD_LIBRARY_PATH for the inferior to not propagate sanitized

[Lldb-commits] [PATCH] D65171: [LLDB] Find debugserver in Command Line Tools as well

aadsm added a comment. @clayborg, yes, I made sure of that, we always first check the Xcode path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65171/new/ https://reviews.llvm.org/D65171 ___

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

JDevlieghere added a comment. @amccarth I think this might explain the issues you were having last week. Without this patch, `find_python_libs_windows` is not setting the expected version variables. As a result, my check was complaining about a mismatch between the Python interpreter that LLVM

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

JDevlieghere updated this revision to Diff 211811. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Export the same variables in `find_python_libs_windows` as `FindPythonInterp` and `FindPythonLibs`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65230/new/

[Lldb-commits] [PATCH] D65289: [lldb] [Process/NetBSD] Report stopped process on SIGSTOP

This revision was automatically updated to reflect the committed changes. Closed by commit rL367047: [lldb] [Process/NetBSD] Report stopped process on SIGSTOP (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r367047 - [lldb] [Process/NetBSD] Report stopped process on SIGSTOP

Author: mgorny Date: Thu Jul 25 13:27:40 2019 New Revision: 367047 URL: http://llvm.org/viewvc/llvm-project?rev=367047=rev Log: [lldb] [Process/NetBSD] Report stopped process on SIGSTOP Mark the process as stopped when SIGSTOP arrives. This is necessary for lldb-server to generate correct

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

friss added a comment. When we hit that merge conflict issue 2 days ago (which mismatched a property and its enum), the first thing that came to my mind was that a tablegen approach would have prevented it. For some reason it seemed more natural to me, and it still does. I might have liked a

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

labath added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:203-204 + if (NOT CMAKE_CROSSCOMPILING) +# Manually split PYTHON_VERSION_STRING because find_python_libs_windows +# doesn't set PYTHON_VERSION_MAJOR or PYTHON_VERSION_MINOR. +

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. I think this is fine. Using `.def` files would be okay too, but I like the sanity checks that Jonas introduced in the LLDBPropertyDefEmitter CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65289: [lldb] [Process/NetBSD] Report stopped process on SIGSTOP

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65289/new/ https://reviews.llvm.org/D65289 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

JDevlieghere updated this revision to Diff 211800. JDevlieghere added a comment. Add sanity check that I mentioned. This actually caught a few properties that didn't have defaults. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65185/new/ https://reviews.llvm.org/D65185 Files:

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jingham added a comment. There isn't an SB API for "settings set" yet. I've put off doing that because the "settings" subsystem is currently unfinished. In the original design you would be specify qualifiers in the setting hierarchy, like: settings set target[arch=x86_64].whatever That

[Lldb-commits] [PATCH] D65128: [Logging] Replace Log::Printf with LLDB_LOG macro (NFC)

jingham added inline comments. Comment at: lldb/source/Expression/IRExecutionUnit.cpp:601 if (log) { +LLDB_LOGF(log, labath wrote: > jingham wrote: > > labath wrote: > > > looks like there are some `if(log)`s still remaining. Maybe the `{}` > > >

[Lldb-commits] [PATCH] D65293: Document the fact that LLDB_LOG uses llvm::format_providers

jingham created this revision. jingham added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a handy and powerful addition to the logging system, but not at all discoverable. This is a trivial patch, but since I don't actually know much about

[Lldb-commits] [PATCH] D65289: [lldb] [Process/NetBSD] Report stopped process on SIGSTOP

mgorny updated this revision to Diff 211789. mgorny added a comment. Herald added a subscriber: dexonsmith. Two more apparent XPASS-es. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65289/new/ https://reviews.llvm.org/D65289 Files:

[Lldb-commits] [PATCH] D65289: [lldb] [Process/NetBSD] Report stopped process on SIGSTOP

mgorny updated this revision to Diff 211787. mgorny added a comment. Herald added a reviewer: jfb. Un-XFAIL some tests fixed by this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65289/new/ https://reviews.llvm.org/D65289 Files:

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade updated this revision to Diff 211781. guiandrade marked an inline comment as done. guiandrade added a comment. Adds a test to make sure the client is using 'g' by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:203-204 + if (NOT CMAKE_CROSSCOMPILING) +# Manually split PYTHON_VERSION_STRING because find_python_libs_windows +# doesn't set

[Lldb-commits] [PATCH] D65289: [lldb] [Process/NetBSD] Report stopped process on SIGSTOP

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Herald added a project: LLDB. Mark the process as stopped when SIGSTOP arrives. This is necessary for lldb-server to generate correct response to 'process interrupt', and therefore to prevent the whole stack crashing when

[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

This revision was automatically updated to reflect the committed changes. Closed by commit rL367020: Correctly use GetLoadedModuleList to take advantage of libraries-svr4 (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

labath added a comment. Why not unify now? It shouldn't be too hard to at least unify all the instances in dotest python code to a single place. That would already cut the number of places that need to be kept synced in half... Comment at:

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil marked 3 inline comments as done. jankratochvil added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoWatchpointSupportInfo.py:24 return "T02thread:1ff0d;thread-pcs:10001bc00;" +

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil updated this revision to Diff 211712. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65271/new/ https://reviews.llvm.org/D65271 Files: lldb/lit/lit-lldb-init.in lldb/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil created this revision. jankratochvil added reviewers: aprantl, labath, clayborg. jankratochvil added a project: LLDB. Herald added subscribers: lldb-commits, abidh. rL357954 did increase `packet-timeout` 1sec -> 5secs. Which is IMO about the

[Lldb-commits] [lldb] r367005 - [lldb][CMake] Fix framework-enabled build detail for Xcode

Author: stefan.graenitz Date: Thu Jul 25 03:47:49 2019 New Revision: 367005 URL: http://llvm.org/viewvc/llvm-project?rev=367005=rev Log: [lldb][CMake] Fix framework-enabled build detail for Xcode If debugserver or any other framework tool gets built first, its post-build copy operation was

[Lldb-commits] [lldb] r367001 - SymbolFile: Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds after D65089/r366791

Author: maskray Date: Thu Jul 25 02:56:45 2019 New Revision: 367001 URL: http://llvm.org/viewvc/llvm-project?rev=367001=rev Log: SymbolFile: Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds after D65089/r366791 Modified: lldb/trunk/source/Symbol/SymbolFile.cpp Modified:

[Lldb-commits] [PATCH] D65266: SymbolVendor: Make SectionAddressesChanged a passthrough

labath created this revision. labath added reviewers: clayborg, jingham, JDevlieghere. This moves the implementation of the function into the SymbolFile class, making it possible to excise the SymbolVendor passthrough functions in follow-up patches. https://reviews.llvm.org/D65266 Files:

[Lldb-commits] [PATCH] D65135: SymbolVendor: Remove the type list member

This revision was automatically updated to reflect the committed changes. Closed by commit rL366994: SymbolVendor: Remove the type list member (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r366994 - SymbolVendor: Remove the type list member

Author: labath Date: Thu Jul 25 01:22:05 2019 New Revision: 366994 URL: http://llvm.org/viewvc/llvm-project?rev=366994=rev Log: SymbolVendor: Remove the type list member Summary: Similarly to the compile unit lists, the list of types can also be managed by the symbol file itself. Since the only

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

labath added a comment. In D65185#1599423 , @JDevlieghere wrote: > In D65185#1599262 , @labath wrote: > > > .def files can omit fields too: `#define BOOL_PROPERTY(name, global, > > default, desc) PROPERTY(name,

[Lldb-commits] [PATCH] D65208: SymbolVendor: Move Symtab construction into the SymbolFile

labath added a comment. In D65208#1599648 , @clayborg wrote: > So the original idea behind the symbol vendor was that if you have more than > one binary: stripped installed binary, and unstripped debug info binary with > symbols, that the symbol table

[Lldb-commits] [PATCH] D65207: LLGS: fix tracking execve on linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL366985: LLGS: fix tracking execve on linux (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r366985 - LLGS: fix tracking execve on linux

Author: labath Date: Wed Jul 24 23:38:33 2019 New Revision: 366985 URL: http://llvm.org/viewvc/llvm-project?rev=366985=rev Log: LLGS: fix tracking execve on linux Summary: Due to a logic error, lldb-server ended up asserting/crashing every time the debugged process attempted an execve(). This

[Lldb-commits] [PATCH] D65207: LLGS: fix tracking execve on linux

labath added a comment. In D65207#1600100 , @clayborg wrote: > Is this not going to be racy on other platforms? Or do all platforms stop at > entry point once a program has been exec'ed? I am worried we might miss the > breakpoint. stopping on exec is

[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

labath added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:203-204 + if (NOT CMAKE_CROSSCOMPILING) +# Manually split PYTHON_VERSION_STRING because find_python_libs_windows +# doesn't set PYTHON_VERSION_MAJOR or PYTHON_VERSION_MINOR. +

[Lldb-commits] [PATCH] D65128: [Logging] Replace Log::Printf with LLDB_LOG macro (NFC)

labath added inline comments. Comment at: lldb/source/Expression/IRExecutionUnit.cpp:601 if (log) { +LLDB_LOGF(log, jingham wrote: > labath wrote: > > looks like there are some `if(log)`s still remaining. Maybe the `{}` around > > the printf confused