[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

hhb updated this revision to Diff 221251. hhb added a comment. Fix symbol linker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67866/new/ https://reviews.llvm.org/D67866 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt

[Lldb-commits] [PATCH] D67896: [LLDB] Add a void* cast when passing object pointers to printf %p

mstorsjo created this revision. mstorsjo added reviewers: hhb, compnerd, amccarth. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This fixes build warnings in MinGW mode. Repository: rLLDB LLDB https://reviews.llvm.org/D67896 Files:

[Lldb-commits] [PATCH] D67895: [LLDB] Avoid a warning about an unused static variable

mstorsjo created this revision. mstorsjo added reviewers: hhb, compnerd, amccarth. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. The variable is unused on windows. Repository: rLLDB LLDB https://reviews.llvm.org/D67895 Files:

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

mstorsjo created this revision. mstorsjo added a reviewer: hhb. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. That change didn't contain any explanation for this bit. There shouldn't be any need for a check for MinGW ifdefs here, as long as the include uses

[Lldb-commits] [PATCH] D67893: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general

mstorsjo created this revision. mstorsjo added reviewers: hhb, compnerd, amccarth. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. These ifdefs contain code that isn't specific to MSVC but useful for any windows target, like MinGW. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

mstorsjo created this revision. mstorsjo added reviewers: jasonmolenda, jingham. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. In these cases, the register number should be calculated from `fpu_d0`, not `fpu_s0`. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. @labath I wrote a patch for the shared_ptr approach. It's simple, but it touches a lot of lines. https://reviews.llvm.org/D67891 Now that I've gone and done it, I kind of like it better that way. If you approve the other patch, I'll update this one

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

mstorsjo added a comment. @hhb - This is the only change left for builds of lldb on mingw to succeed for me (for x86), but I have a whole bunch of more changes lined up that fix warnings and other issues I've found. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67857: [LLDB] Include lldb/Host/windows/windows.h on any windows target

mstorsjo abandoned this revision. mstorsjo added a comment. D67887 was committed with the same change. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67857/new/ https://reviews.llvm.org/D67857

[Lldb-commits] [PATCH] D67887: Use _WIN32 instead of _MSC_VER

mstorsjo added a comment. Just FTR, this was identical to D67857 that I posted a few days ago. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67887/new/ https://reviews.llvm.org/D67887

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 221222. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. updated description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, zturner, jingham, labath. Herald added a project: LLDB. This patch removes File::SetStream() and File::SetDescriptor(), and replaces most direct uses of File with std::shared_ptr. Instead of calling

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny created this revision. mgorny added reviewers: hhb, JDevlieghere, sgraenitz, zturner, beanz, labath. Fix installing Python modules on systems that use /usr/lib for Python while installing other libraries in /usr/lib64. Rewrite CMake logic to query correct directories from Python,